Re: [Kicad-developers] [PATCH v2] Use CMake high-level facility for visibility

2015-12-07 Thread Adam Wolf
I lost the thread, but someone was asking if this works on OS X. It appears to work fine. Adam Wolf On Sun, Sep 6, 2015 at 10:48 AM, Simon Richter wrote: > Hi, > > this is an improved version of the earlier patch, using the visibility > handling in CMake 3.3, and

Re: [Kicad-developers] [PATCH v2] Use CMake high-level facility for visibility

2015-12-07 Thread Wayne Stambaugh
Thanks Adam! I'll commit the patch. On 12/7/2015 2:26 PM, Adam Wolf wrote: > I lost the thread, but someone was asking if this works on OS X. It > appears to work fine. > > Adam Wolf > > On Sun, Sep 6, 2015 at 10:48 AM, Simon Richter

[Kicad-developers] [PATCH v2] Use CMake high-level facility for visibility

2015-09-06 Thread Simon Richter
Hi, this is an improved version of the earlier patch, using the visibility handling in CMake 3.3, and falling back to changing the global CXXFLAGS on previous versions. As CMake 3.3 attempts to be compatible with earlier versions, the new behaviour needs to be explicitly enabled until 3.3