Re: [Kicad-developers] Branches

2018-07-24 Thread Maciej Sumiński
...and also rename it to 5.1-dev (no rc yet). On 07/24/2018 09:47 AM, Jeff Young wrote: > +1 > >> On 24 Jul 2018, at 08:01, Maciej Sumiński wrote: >> >> At the moment the master branch contains all commits from 5.1 and a few >> more. It might be the right moment to drop 5.1 branch. >> >>

Re: [Kicad-developers] Branches

2018-07-24 Thread Maciej Sumiński
At the moment the master branch contains all commits from 5.1 and a few more. It might be the right moment to drop 5.1 branch. Cheers, Orson On 07/20/2018 11:14 AM, Maciej Sumiński wrote: > We already have slightly diverged the branches, I think it shows that it > is hard to maintain two

[Kicad-developers] The version string in the master branch

2018-07-24 Thread Eeli Kaikkonen
The version string which is the visible version information seems to be 6.0 something. It has already caused confusion for those who use nightlies. I hope this will be fixed permanently. Is there any hope to get it changed to something unambiguous, like "post5.0-gitXX"? Eeli Kaikkonen

Re: [Kicad-developers] Adding "Apply" to the 3D viewer display options dialog

2018-07-24 Thread Jeff Young
Hi David, The wxWidgets framework will process OK and Cancel for us (assuming we don’t need anything special). They call TransferDataFromWindow to do the dirty work in the case of an OK. Other Kicad dialogs do have to do something more special, though, and so implement their own processing.

[Kicad-developers] Adding "Apply" to the 3D viewer display options dialog

2018-07-24 Thread David Griffith
I'm at a loss to figure out what to edit to get the display options dialog for the 3D viewer to do the right thing when an "Apply" button is pressed. I got the new button added by way of wxFormBuilder. But looking at 3d-viewer/3d_viewer/dialogs/dialog_3D_view_option.cpp, I can't figure out

Re: [Kicad-developers] Adding "Apply" to the 3D viewer display options dialog

2018-07-24 Thread Maciej Sumiński
Select the Apply button you want to handle, and in the Object Properties panel, Events tab - add an event handler. It will be added to the generated *_BASE class and all you need to do is override it. Cheers, Orson On 07/24/2018 09:10 AM, David Griffith wrote: > > I'm at a loss to figure out

Re: [Kicad-developers] Branches

2018-07-24 Thread Jeff Young
+1 > On 24 Jul 2018, at 08:01, Maciej Sumiński wrote: > > At the moment the master branch contains all commits from 5.1 and a few > more. It might be the right moment to drop 5.1 branch. > > Cheers, > Orson > > On 07/20/2018 11:14 AM, Maciej Sumiński wrote: >> We already have slightly

Re: [Kicad-developers] [PATCH] Aim macOS users at kicad-mac-builder and make building on macOS seem less scary

2018-07-24 Thread Adam Wolf
"make it easier for macOS developers to work on KiCad" is something I am 100% open to feedback on, so please let me know how it goes. I've done some playing around with it and CLion and it seems to work fine, but that was a 15 minute test. On Tue, Jul 24, 2018 at 12:24 PM Andy Peters wrote: > >

Re: [Kicad-developers] Board setup icon

2018-07-24 Thread Jeff Young
Hi John, When you get a chance could you also edit the part_properties_xpm icon to be the op-amp with a gear over it? Oh, and a new icon with the op-amp with a little ’T’ in the bottom right corner would be great. (Both are for the symbol editor. They’re currently just a generic gear and a

Re: [Kicad-developers] The version string in the master branch

2018-07-24 Thread Wayne Stambaugh
On 7/24/2018 11:11 AM, Simon Richter wrote: > Hi, > > On 24.07.2018 09:40, Eeli Kaikkonen wrote: > >> The version string which is the visible version information seems to be >> 6.0 something. It has already caused confusion for those who use >> nightlies. I hope this will be fixed permanently.

Re: [Kicad-developers] The version string in the master branch

2018-07-24 Thread Eeli Kaikkonen
ti 24. heinäk. 2018 klo 22.59 Wayne Stambaugh (stambau...@gmail.com) kirjoitti: > 5.1-dev will confuse the package version > sorting when 5.1.0 is released. Why do development packages (nightly builds or self-compiled) need to be sorted with release builds? The most misleading strings are in

Re: [Kicad-developers] Branches

2018-07-24 Thread Carsten Schoenert
Am 24.07.18 um 15:01 schrieb Maciej Sumiński: > At the moment the master branch contains all commits from 5.1 and a few > more. It might be the right moment to drop 5.1 branch. This depends on the achievements which are desired or wanted in my eyes. The branch 5.1 was created to work on the

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-24 Thread Andrew Lutsenko
Hello, Can someone take a look at my patch please? It's my first so if I didn't submit it correctly please bear with me, I believe I did everything according to developers documentation. It would be great to see this in next release. Patch applies cleanly to both 5.0 branch and master. Regards,

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-24 Thread Adam Wolf
Hi Andrew, Many of the folks on this list may be taking a break after this past weekend's release. Please do not take a few day's silence right now as any sort of sign. :) Adam On Tue, Jul 24, 2018, 10:29 PM Andrew Lutsenko wrote: > Hello, > > Can someone take a look at my patch please? >

Re: [Kicad-developers] [PATCH] qa_geometry tests

2018-07-24 Thread Wayne Stambaugh
John, I didn't forget about your qa test patches. They are on my todo list. I've just been busy with life. I will have some free time over the weekend to test them and get them merged. Cheers, Wayne On 7/24/2018 6:31 AM, John Beard wrote: > I think the first three of these patches are still

Re: [Kicad-developers] The version string in the master branch

2018-07-24 Thread Wayne Stambaugh
If we are fine with 5.1-dev (it is my preference as well), then I'll set the tag to 5.1-dev and update KiCadVersion.cmake before the end of the day. The reason I used 6.0.0-rc1 is that there were complaints that the #.#-dev format was confusing. Let's agree on a tagging scheme and stick with it

Re: [Kicad-developers] [PATCH] qa_geometry tests

2018-07-24 Thread John Beard
I think the first three of these patches are still worth committing now. That will allow "make test" to be used to collect all our (working) tests and give us somewhere to hang new tests so that they can used. We can discuss whether or not we want "make test" to also rebuild the tests separately,

Re: [Kicad-developers] Kicad V4 update chances?

2018-07-24 Thread Adam Wolf
Thanks Wayne! I'll format that machine today, and work on adding it to speed up V5 builds. The chances of getting another working V4 macOS build will be just about zero now anyway :) Adam On Tue, Jul 24, 2018, 12:18 AM Wayne Stambaugh wrote: > As long as I am the project leader the chances

[Kicad-developers] Board setup icon

2018-07-24 Thread John Beard
Hi, Here is a new icon for the board setup toolbar and menu item. The generic gear icon is no clear, as it looks like "Preferences" rather than board setup. PNG included for reference only. Cheers, John From 329eda7c68c0ca56f1d8095342000fdc72868955 Mon Sep 17 00:00:00 2001 From: John Beard

Re: [Kicad-developers] [PATCH] Aim macOS users at kicad-mac-builder and make building on macOS seem less scary

2018-07-24 Thread Adam Wolf
Thanks Wayne! Please apply to both whenever it's convenient. It's a new world for macOS building and packaging for KiCad! Adam On Tue, Jul 24, 2018, 12:04 AM Wayne Stambaugh wrote: > Adam, > > I merged your patch into the development branch. I'm assuming these > changes apply to the 5.0

Re: [Kicad-developers] The version string in the master branch

2018-07-24 Thread Adam Wolf
Hmm. When would it be the right time to change from post5 to pre6? Adam On Tue, Jul 24, 2018, 2:41 AM Eeli Kaikkonen wrote: > The version string which is the visible version information seems to be > 6.0 something. It has already caused confusion for those who use nightlies. > I hope this

Re: [Kicad-developers] Board setup icon

2018-07-24 Thread Jeff Young
I’ve merged your icon, John. Thanks for your contribution! > On 24 Jul 2018, at 12:35, John Beard wrote: > > Hi, > > Here is a new icon for the board setup toolbar and menu item. The > generic gear icon is no clear, as it looks like "Preferences" rather > than board setup. > > PNG included

Re: [Kicad-developers] The version string in the master branch

2018-07-24 Thread Simon Richter
Hi, On 24.07.2018 09:40, Eeli Kaikkonen wrote: > The version string which is the visible version information seems to be > 6.0 something. It has already caused confusion for those who use > nightlies. I hope this will be fixed permanently. Is there any hope to > get it changed to something

[Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-07-24 Thread John Beard
This patch adds a hotkey for adding a corner to a zone or segment. This is an action I have really struggled without a hotkey for! I have used Insert, as: 1) it's available and 2) it's what Inkscape uses (but Inkscape adds the point at the midpoint of the segment, this adds at the cursor). It

[Kicad-developers] Hotkeys in GAL

2018-07-24 Thread John Beard
Hi, I have a few questions about hotkeys in GAL tools: 1) Is there are reason so many GAL tools don't get hotkeys? Very many TOOL_ACTIONS have a hotkey set to '0'. Most others that do have a hotkey have a LegacyHotkey definition. Only a very few have the GAL-style keys (e.g. rotate CW). I

Re: [Kicad-developers] [PATCH] Aim macOS users at kicad-mac-builder and make building on macOS seem less scary

2018-07-24 Thread Andy Peters
On Jul 23, 2018, at 6:18 AM, Adam Wolf wrote: > > Hi folks! > > Attached is a docs patch. Please let me know if it needs any tweaks > or if you have any questions. > <0001-Aim-macOS-users-at-kicad-mac-builder-and-make-buildi.patch> I will try the kicad-mac-builder tonight. -a