Re: [Kicad-developers] Add a cmake option for legacy canvas

2017-02-06 Thread John Beard
Here is an example of the kind of commit that would remove a feature from the legacy canvas: Duplicate Item. This tool doesn't have a lot of code behind it because it mostly piggy-backs on other block operations, so this patch is a fairly good example of the overhead and wiring that can be removed

Re: [Kicad-developers] Add a cmake option for legacy canvas

2017-02-04 Thread Simon Wells
my 2 cents is this is not really a good idea. On 5 February 2017 at 18:47, José Ignacio wrote: > I really like this idea for after 5 is out > > On Sat, Feb 4, 2017 at 11:25 PM, John Beard wrote: >> >> Hi, >> >> I support the general idea of being able to turn off bits of the >> legacy canvas at

Re: [Kicad-developers] Add a cmake option for legacy canvas

2017-02-04 Thread José Ignacio
I really like this idea for after 5 is out On Sat, Feb 4, 2017 at 11:25 PM, John Beard wrote: > Hi, > > I support the general idea of being able to turn off bits of the > legacy canvas at will, in principle. However, I'm not sure how many > people will actually bother to check if stuff behind an

Re: [Kicad-developers] Add a cmake option for legacy canvas

2017-02-04 Thread John Beard
Hi, I support the general idea of being able to turn off bits of the legacy canvas at will, in principle. However, I'm not sure how many people will actually bother to check if stuff behind an #ifdef is getting broken, and legacy stuff is quite vulnerable because of tight binding to large classes

Re: [Kicad-developers] Add a cmake option for legacy canvas

2017-01-31 Thread Chris Pavlina
I think it's worth revisiting this. I know we're not ready to remove legacy yet, but we're getting close. Starting to factor it out into a switchable build option is a good way to make sure the transition is smooth and help find anything that is still missing. Obviously the default build option sho

Re: [Kicad-developers] Add a cmake option for legacy canvas

2016-09-18 Thread Chris Pavlina
On Sun, Sep 18, 2016 at 05:03:33PM -0400, Wayne Stambaugh wrote: > On 9/17/2016 6:59 AM, Simon Wells wrote: > > As legacy canvas in pcbnew is legacy is it worth conditional compiling > > all the code related and only used by legacy canvas based on a cmake > > option aka something like > > > > KICA

Re: [Kicad-developers] Add a cmake option for legacy canvas

2016-09-18 Thread Simon Richter
Hi, On 18.09.2016 23:03, Wayne Stambaugh wrote: > I'm not sure what this would buy the project in terms of usefulness. It allows gradually marking the code as obsolete and testing whether we can safely remove it without creating huge diffs. We can autobuild a variant without legacy from Jenkins

Re: [Kicad-developers] Add a cmake option for legacy canvas

2016-09-18 Thread Wayne Stambaugh
On 9/17/2016 6:59 AM, Simon Wells wrote: > As legacy canvas in pcbnew is legacy is it worth conditional compiling > all the code related and only used by legacy canvas based on a cmake > option aka something like > > KICAD_BUILD_LEGACY_CANVAS with a default of ON, this will allow people > who have

Re: [Kicad-developers] Add a cmake option for legacy canvas

2016-09-17 Thread Nick Østergaard
I am not entirely sure what your intention exactly. The message looks like a commit message rather than a request for comments. Especially because I can not detect any questionmark, but I will assumeit is a question anyways. It guess it requries quite some ifdefs. May I suggest just naming it KIC

[Kicad-developers] Add a cmake option for legacy canvas

2016-09-17 Thread Simon Wells
As legacy canvas in pcbnew is legacy is it worth conditional compiling all the code related and only used by legacy canvas based on a cmake option aka something like KICAD_BUILD_LEGACY_CANVAS with a default of ON, this will allow people who have no use for the legacy canvas as they have a truly fu