Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-28 Thread Morgan
Figured it out and submitted a new KLEE PR to fix a test failure in the Nix sandbox. https://github.com/klee/klee/pull/1385 https://github.com/klee/klee/pull/1471 https://github.com/NixOS/nixpkgs/pull/156413 Thanks for the help. I'll do a subsequent PR to update documentation on

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-23 Thread Morgan
Martin, Thanks, that got me closer. Here's the pull request with some improvements to the KLEE Nix package: https://github.com/NixOS/nixpkgs/pull/156413 I'm currently dealing with an error in the test suite using klee-uclibc. Have any of you seen this? TEST 'KLEE ::

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-17 Thread Nowack, Martin
Hi Morgan, On 17. Jan 2022, at 10:23, Morgan mailto:m...@numin.it>> wrote: In the meantime, I'm having trouble building klee-uclibc. I got past the locale download (had to set UCLIBC_DOWNLOAD_PREGENERATED_LOCALE_DATA=n and copy it over after configure since it builds in the Nix sandbox) but this

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-17 Thread Morgan
Thanks Martin. I'll make this change. In the meantime, I'm having trouble building klee-uclibc. I got past the locale download (had to set UCLIBC_DOWNLOAD_PREGENERATED_LOCALE_DATA=n and copy it over after configure since it builds in the Nix sandbox) but this seems to be happening now.

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-11 Thread Nowack, Martin
Hi Morgan, Just looked at the build instructions: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/science/logic/klee/default.nix#L53 "-DKLEE_RUNTIME_BUILD_TYPE=${buildType}" I would recommend to handle the build type for the `KLEE_RUNTIME_BUILD_TYPE` separate from the

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-08 Thread Morgan
Also, do these build flags look halfway reasonable? Is there anything that users should be able to customize? In Nix, all packages are functions, and we can call the functions with various extra arguments (like debug ? false) in the package.

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-08 Thread Morgan
Somewhat related, I'm having trouble building KLEE on aarch64. Here's the failing part: -- Build files have been written to: /build/source/build cmake: enabled parallel building building build flags: -j4 -l4 SHELL=/nix/store/fbf5n09drbi3bxv9rb9fgf58dm4da4a8-bash-5.1-p12/bin/bash [ 1%] Building

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-08 Thread Morgan
>Is this also the issue you ran into? If yes, maybe you want try the >patches from the PR I linked above. If not and are you having a >different problem, maybe you could try to provide some more details? >Then I will try and see if can help resolve them. This is the problem. No tests discovered.

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-05 Thread Cristian Cadar
Hi all, Indeed, it would be great to update https://klee.github.io/getting-started/ (via a PR at https://github.com/klee/klee.github.io) to mention the Fedora and Nix packages. And thanks to everyone who is maintaining KLEE packages! Best, Cristian On 05/01/2022 10:01, Julian Büning

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-05 Thread Julian Büning
Hi Lukas, nice and thanks for letting me know! I was briefly considering to go the same route, but didn't encounter your fix. But as it turns out, not using gtest_main (which I understand is more or less offered for convenience) has certain other advantages for KLEE (e.g. stack traces;

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-05 Thread Lukas Zaoral
Hi Julian, I've encountered the same problem with lit and latest gtest when I was packaging KLEE for Fedora as I had to use gtest from repos due to Fedora's packaging guidelines. I sent a patch to LLVM to fix this incompatibility at the beginning of last April and it was finally accepted last

Re: [klee-dev] Packaging klee on Nix - gtest broken?

2022-01-05 Thread Julian Büning
Hi Morgan, nice to see your packaging efforts for KLEE! I recently ran into some issues with more recent versions of Google Test when building KLEE (and running unit tests). I just opened a PR that addresses these: https://github.com/klee/klee/pull/1458 Among these issues is one that I

[klee-dev] Packaging klee on Nix - gtest broken?

2022-01-02 Thread Morgan
Hey there, I like Klee and have been trying to package it in nixpkgs so more people can reproducibly use it without resorting to things like setup scripts or Docker. Here are the cmake flags I'm using: