Re: New OFX direct connect problem (BOA)

2016-09-09 Thread Thomas Baumgart 
Jack,

On Thursday 08 September 2016 21:00:19 Jack wrote:

> I've been downloading transactions for my Bank of America credit card
> for months without problems, until a week or two ago, when I started
> getting "The file or folder eftx.bankofamerica.com does not exist."

I just checked that data and get

;; ANSWER SECTION:
eftx.bankofamerica.com. 3600IN  CNAME   eftx.ecglb.bac.com.
eftx.ecglb.bac.com. 30  IN  A   171.161.207.77

which looks OK to me. Something is also responding there and says:



501 Method Not Implemented

Method Not Implemented
help to / not supported.



in case I send some garbage.

The output of 
https://www.ssllabs.com/ssltest/analyze.html?d=eftx.bankofamerica.com also 
looks OK to me.

Can you turn on logging using the ~/ofxlog.txt feature?

Doesn't mapping the account require to login to the bank? So in case you can 
do that, the transmission seems to be working. I am also wondering, which 
error is shown during 'Show error message'.

Strange.

Regards

Thomas



>  On the console, I see
> 
> OfxImporterPlugin::updateAccount
> creating job
> Job finished
> Closing tempfile
> Tempfile closed
> Show error message
> Finishing slotOfxFinished
> 
> which seems to show no response from the bank.  However, I have
> unmapped and successfully remapped the account (KMM OFX).  I have not
> yet tried wireshark to see if any packets are returning.
> 
> Does this ring any bells for anyone?  I've also posted at ofxhome, and
> I suppose I'll have to break down and call BOA - they won't take any
> help calls by email except for statement requests
> 
> Thanks for any suggestions.
> 
> Jack
-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-
Programmers never die: They just GOSUB without RETURN.
-


signature.asc
Description: This is a digitally signed message part.

Re: Review Request 128817: Restructure pages in CSV Importer

2016-09-09 Thread Thomas Baumgart 


> On Sept. 7, 2016, 8:07 vorm., Thomas Baumgart wrote:
> > kmymoney/plugins/csvimport/csvwizard.cpp, line 625
> > 
> >
> > Doesn't that match an empty txt as well?
> 
> Łukasz Wojniłowicz wrote:
> Yes it does and couple of lines above is my recipe for it
> ```c++
> QString txt = ui->tableWidget->item(row, col)->text();
> if (txt.isEmpty())  // nothing to process, so go to next row
>   continue;
> ```

Never mind. I did not see that. Then it's not a problem.


> On Sept. 7, 2016, 8:07 vorm., Thomas Baumgart wrote:
> > kmymoney/plugins/csvimport/csvwizard.cpp, line 622
> > 
> >
> > Don't we know about a lot more currency symbols in the engine 
> > (MyMoneyFile::instance()->currencyList())? The method would be 
> > tradingSymbol(). See KMyMoneyView::loadDefaultCurrencies() for the list of 
> > known currencies. Why do some of them are hard coded here?
> 
> Łukasz Wojniłowicz wrote:
> I use d following code to harvest potential currencies.
> ```c++
>   QList accountList;
>   MyMoneyFile::instance()->accountList(accountList);
> 
>   QList accountTypes;
>   accountTypes << MyMoneyAccount::Checkings <<
>   MyMoneyAccount::Savings <<
>   MyMoneyAccount::Liability <<
>   MyMoneyAccount::Checkings <<
>   MyMoneyAccount::Savings <<
>   MyMoneyAccount::Cash <<
>   MyMoneyAccount::CreditCard <<
>   MyMoneyAccount::Loan <<
>   MyMoneyAccount::Asset <<
>   MyMoneyAccount::Liability;
> 
>   QString filteredCurrencies;
>   QList::ConstIterator account;
>   for (account = accountList.cbegin(); account != accountList.cend(); 
> ++account)
> if (accountTypes.contains((*account).accountType()) && // account 
> must acctually have currency property
> !filteredCurrencies.contains((*account).currencyId())) // 
> currency must not be on the list already
> filteredCurrencies += (*account).currencyId();
> ```
> 
> Łukasz Wojniłowicz wrote:
> Disregard previous response. It should be this.
> ```c++  
>   QList accountList;
>   MyMoneyFile::instance()->accountList(accountList);
> 
>   QList accountTypes;
>   accountTypes << MyMoneyAccount::Checkings <<
>   MyMoneyAccount::Savings <<
>   MyMoneyAccount::Liability <<
>   MyMoneyAccount::Checkings <<
>   MyMoneyAccount::Savings <<
>   MyMoneyAccount::Cash <<
>   MyMoneyAccount::CreditCard <<
>   MyMoneyAccount::Loan <<
>   MyMoneyAccount::Asset <<
>   MyMoneyAccount::Liability;
> 
>   QString filteredCurrencies;
>   QList::ConstIterator account;
>   for (account = accountList.cbegin(); account != accountList.cend(); 
> ++account) {
> if (accountTypes.contains((*account).accountType()) && // account 
> must actually have currency property
> !filteredCurrencies.contains((*account).currencyId(), 
> Qt::CaseInsensitive)) { // currency id must not be on the list already
> filteredCurrencies += (*account).currencyId();
> QString tradingSymbol = 
> MyMoneyFile::instance()->currency((*account).currencyId()).tradingSymbol();
> if (!filteredCurrencies.contains(tradingSymbol, 
> Qt::CaseInsensitive )) // currency trading symbol must not be on the list 
> already
>   filteredCurrencies += tradingSymbol;
> }
>   }
> ```
> I think it's better to remove currency symbols based on what user has in 
> his accounts, than to hunt for over 180 currency symbols/ids from 
> (MyMoneyFile::instance()->currencyList()).

I'd use a QSet to add all trading symbols w/o the hassle of checking 
if it already exists. QSet does not create duplicates. At the end

  QSet symbols;
  
  // do the collection of the symbols over the accounts here
  
  QString filteredCurrencies = QStringList(symbols.values()).join("");
  
Should make the code more readable.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128817/#review98964
---


On Sept. 7, 2016, 8:31 nachm., Łukasz Wojniłowicz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128817/
> ---
> 
> (Updated Sept. 7, 2016, 8:31 nachm.)
> 
> 
> Review request for

Review Request 128874: Free QFileDialog memory

2016-09-09 Thread Łukasz Wojniłowicz 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128874/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

After closing CSV Importer in the middle and then KMyMoney, I get "The program 
has unexpectedly finished".
The problem doesn't occur if CSV Importer goes all way through to the last 
page; then I can go back and close it wherever I want.
If I comment out this line, there is no problem at all.
```c++
  QPointer dialog = new QFileDialog(this, QString(),
 fileInfo.absoluteFilePath(),
 i18n("*.csv *.PRN *.txt | CSV 
Files\n *|All files"));
```
Memory on which dialog pointed wasn't deleted in the method and it obviously 
need to be deleted, but the problem remains. Does anyone know how to prevent 
QtCreator from showing "The program has unexpectedly finished" here?


Diffs
-

  kmymoney/plugins/csvimport/csvwizard.h ecec5b0 
  kmymoney/plugins/csvimport/csvwizard.cpp b576dea 

Diff: https://git.reviewboard.kde.org/r/128874/diff/


Testing
---


Thanks,

Łukasz Wojniłowicz

[kmymoney4] [Bug 357290] unwanted transfer transaction created by ofx

2016-09-09 Thread Swj via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=357290

--- Comment #7 from Swj  ---
This is still occurring in 4.8.  When I do an ofx update on my American Express
credit card account it automatically creates a transfer transaction every month
when the cc bill is paid, which is unwanted because the paying account also
gets its own transactions updated by ofx.  I worked around this by creating a
fake account and setting that as the transfer account.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: New OFX direct connect problem (BOA)

2016-09-09 Thread Jack 

On 2016.09.09 10:24, Thomas Baumgart wrote:

On Thursday 08 September 2016 21:00:19 Jack wrote:

I've been downloading transactions for my Bank of America credit  
card for months without problems, until a week or two ago, when I  
started getting "The file or folder eftx.bankofamerica.com does not  
exist."


I'd like to know exactly where this error comes from, and which file or  
folder it can't find (or perhaps there is a permission problem?


I just checked that data and get

;; ANSWER SECTION:
eftx.bankofamerica.com. 3600IN  CNAME   eftx.ecglb.bac.com.
eftx.ecglb.bac.com. 30  IN  A   171.161.207.77

yes, I see the same.


which looks OK to me. Something is also responding there and says:



501 Method Not Implemented

Method Not Implemented
help to / not supported.



in case I send some garbage.

The output of
https://www.ssllabs.com/ssltest/analyze.html?d=eftx.bankofamerica.com  
also

looks OK to me.

Can you turn on logging using the ~/ofxlog.txt feature?

Sorry, I did and forgot to mention - no response:



response:

Completed

so it doesn't look like anything is coming back.  Doing a traceroute  
shows inconsistent results, but never a reply from the final host,  
although it could be configured to not respond to pings.


Doesn't mapping the account require to login to the bank? So in case  
you can do that, the transmission seems to be working. I am also  
wondering, which error is shown during 'Show error message'.
No error from mapping the account, which I assume does go to the same  
server.  There is just this single popup with the error, but no button  
other than OK.


Strange.
Yes - that's why I was wondering if anyone else has seen this, or if  
anyone else can confirm they are successfully getting BOA credit card  
transactions through ofx direct download.



Regards

Thomas



>  On the console, I see
>
> OfxImporterPlugin::updateAccount
> creating job
> Job finished
> Closing tempfile
> Tempfile closed
> Show error message
> Finishing slotOfxFinished
>
which seems to show no response from the bank.  However, I have  
unmapped and successfully remapped the account (KMM OFX).  I have  
not yet tried wireshark to see if any packets are returning.

>
Does this ring any bells for anyone?  I've also posted at ofxhome,  
and I suppose I'll have to break down and call BOA - they won't take  
any help calls by email except for statement requests

>
> Thanks for any suggestions.

Jack

Review Request 128873: Add configuration dialog for CSV Importer

2016-09-09 Thread Łukasz Wojniłowicz 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128873/
---

Review request for KMymoney.


Repository: kmymoney


Description
---

Although autodetecting features were tested multiple ways, they may
cause troubles on another data sets. Give user the possibility to
disable potential troublemakers.


Diffs
-

  kmymoney/plugins/csvimport/CMakeLists.txt 216c79c 
  kmymoney/plugins/csvimport/kcm_csvimport.h PRE-CREATION 
  kmymoney/plugins/csvimport/kcm_csvimport.cpp PRE-CREATION 
  kmymoney/plugins/csvimport/kcm_kmm_csvimport.desktop PRE-CREATION 
  kmymoney/plugins/csvimport/pluginsettings.kcfg PRE-CREATION 
  kmymoney/plugins/csvimport/pluginsettings.kcfgc PRE-CREATION 
  kmymoney/plugins/csvimport/pluginsettingsdecl.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128873/diff/


Testing
---


File Attachments


configuration dialog
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/09/50f42b98-e239-465b-bf63-21fdd1a42304__Configuration.png


Thanks,

Łukasz Wojniłowicz

Re: New OFX direct connect problem (BOA)

2016-09-09 Thread Jack 

On 2016.09.09 12:39, Jack wrote:

On 2016.09.09 10:24, Thomas Baumgart wrote:

On Thursday 08 September 2016 21:00:19 Jack wrote:

I've been downloading transactions for my Bank of America credit  
card for months without problems, until a week or two ago, when I  
started getting "The file or folder eftx.bankofamerica.com does not  
exist."


I'd like to know exactly where this error comes from, and which file  
or folder it can't find (or perhaps there is a permission problem?


I just checked that data and get

;; ANSWER SECTION:
eftx.bankofamerica.com. 3600IN  CNAME   eftx.ecglb.bac.com.
eftx.ecglb.bac.com. 30  IN  A   171.161.207.77

yes, I see the same.


which looks OK to me. Something is also responding there and says:



501 Method Not Implemented

Method Not Implemented
help to / not supported.



in case I send some garbage.

The output of
https://www.ssllabs.com/ssltest/analyze.html?d=eftx.bankofamerica.com  
also

looks OK to me.

Can you turn on logging using the ~/ofxlog.txt feature?

Sorry, I did and forgot to mention - no response:



response:

Completed

so it doesn't look like anything is coming back.  Doing a traceroute  
shows inconsistent results, but never a reply from the final host,  
although it could be configured to not respond to pings.


Doesn't mapping the account require to login to the bank? So in case  
you can do that, the transmission seems to be working. I am also  
wondering, which error is shown during 'Show error message'.
No error from mapping the account, which I assume does go to the same  
server.  There is just this single popup with the error, but no  
button other than OK.


Strange.
Yes - that's why I was wondering if anyone else has seen this, or if  
anyone else can confirm they are successfully getting BOA credit card  
transactions through ofx direct download.



>  On the console, I see
>
> OfxImporterPlugin::updateAccount
> creating job
> Job finished
> Closing tempfile
> Tempfile closed
> Show error message
> Finishing slotOfxFinished
>
which seems to show no response from the bank.  However, I have  
unmapped and successfully remapped the account (KMM OFX).  I have  
not yet tried wireshark to see if any packets are returning.

>
Does this ring any bells for anyone?  I've also posted at ofxhome,  
and I suppose I'll have to break down and call BOA - they won't  
take any help calls by email except for statement requests

>
Well, wireshark shows the entire transaction in 24 packets.  One of  
them says "Client Hello[Malformed Packet].  Googling leaves me unclear  
if this  might be a wireshark bug (shedding no light on my OFX issue)  
or if there really is something going on such as some sort of SSL level  
mismatch, perhaps due to a recent change at BOA.  (I don't think I've  
updated any SSL or such software lately, but I'll have to dig.)


Jack

Re: Review Request 128873: Add configuration dialog for CSV Importer

2016-09-09 Thread Thomas Baumgart 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128873/#review99041
---



Regarding the initial window size: why should that be a setting for the user? 
We can provide it with the application and simply store whatever the user 
changed it to. This way, we gain more functionality (the user can control the 
size and this setting is automatically kept for the next run) by reducing the 
number of options. See QWidget::saveGeometry() for details. Or simply store the 
width and height as it is done in the ctor/dtor of KSplitTransactionDlg().


kmymoney/plugins/csvimport/CMakeLists.txt (line 59)


Please remove leftover whitespace char(s)


- Thomas Baumgart


On Sept. 9, 2016, 6:01 nachm., Łukasz Wojniłowicz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128873/
> ---
> 
> (Updated Sept. 9, 2016, 6:01 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> ---
> 
> Although autodetecting features were tested multiple ways, they may
> cause troubles on another data sets. Give user the possibility to
> disable potential troublemakers.
> 
> 
> Diffs
> -
> 
>   kmymoney/plugins/csvimport/CMakeLists.txt 216c79c 
>   kmymoney/plugins/csvimport/kcm_csvimport.h PRE-CREATION 
>   kmymoney/plugins/csvimport/kcm_csvimport.cpp PRE-CREATION 
>   kmymoney/plugins/csvimport/kcm_kmm_csvimport.desktop PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettings.kcfg PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettings.kcfgc PRE-CREATION 
>   kmymoney/plugins/csvimport/pluginsettingsdecl.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128873/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> configuration dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/09/50f42b98-e239-465b-bf63-21fdd1a42304__Configuration.png
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>