https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12773
Owen Leonard changed:
What|Removed |Added
Component|Templates |System Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12773
Owen Leonard changed:
What|Removed |Added
Status|In Discussion |ASSIGNED
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34410
Lisette Scheer changed:
What|Removed |Added
CC||lisette.scheer@bywatersolut
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
--- Comment #10 from Matt Blenkinsop ---
(In reply to Jonathan Druart from comment #3)
> Matt, I am wondering if we should not have a flag in the route definition
> instead, we already have is_base, is_navigation_item, is_end_node an
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417
--- Comment #3 from Matt Blenkinsop ---
(In reply to Jonathan Druart from comment #2)
> There are two things I would like to note here:
> 1. It does not feel correct to not invalidate the parameter when the view
> changed. We could e
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
--- Comment #34 from Marcel de Rooy ---
-next unless $hascopyright || $needs_copyright;
+next unless $needs_copyright &&!$hascopyright;
This might need attention still.
--
You are receiving this mail because:
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34363
--- Comment #1 from Owen Leonard ---
I cannot reproduce this issue in 22.11.x. It sounds like there might be a
JavaScript error on the page. Could it be coming from OPACUserJS? Is there an
error in the browser console?
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
Marcel de Rooy changed:
What|Removed |Added
Keywords|Academy |
--
You are receiving thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
--- Comment #33 from Marcel de Rooy ---
1..1
not ok 1 - No files without license problems anymore!
# Failed test 'No files without license problems anymore!'
# at xt/find-license-problems.t line 68.
# got: '1218'
# e
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
--- Comment #32 from Marcel de Rooy ---
Please see follow-up too. Run script with -v to get the sprintf output
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
--- Comment #31 from Marcel de Rooy ---
(In reply to Philip Orr from comment #29)
> Different question though. Some files (for instance
> Koha/AdditionalFields.pm) include the copyright and license statement as
> part of pod documen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
--- Comment #30 from Marcel de Rooy ---
Created attachment 153924
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153924&action=edit
Bug 29324: (QA follow-up) Polishing
Making the verbose output a bit more manageab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
--- Comment #29 from Philip Orr ---
Sounds good. Though that's "only" about 270 files.
Around half of the files are missing both copyright and license statements (ca.
750). The other half are only missing copyright statements.
Diffe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32950
Martin Renvoize changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32896
Martin Renvoize changed:
What|Removed |Added
Assignee|martin.renvoize@ptfs-europe |koha-b...@lists.koha-commu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798
Martin Renvoize changed:
What|Removed |Added
Blocks||32896
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32896
Martin Renvoize changed:
What|Removed |Added
Depends on||31798
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
--- Comment #28 from Marcel de Rooy ---
(In reply to Philip Orr from comment #27)
> 3. You should be getting 1476 fails
Wow
Maybe we should ignore this directory:
File ./installer/data/mysql/db_revs/211200038.pl has wrong copyright
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402
--- Comment #1 from Owen Leonard ---
Created attachment 153923
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153923&action=edit
Bug 34402: Sorting holds on patron account includes articles
This patch adds some co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402
Owen Leonard changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
Patch comple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843
Marcel de Rooy changed:
What|Removed |Added
Attachment #153921|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843
--- Comment #3 from Marcel de Rooy ---
OK Koha/Notice/Util.pm
OK critic
OK forbidden patterns
OK git manipulation
OK pod
OK pod coverage
SKIP spelling
OK tidiness
OK valid
p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843
Marcel de Rooy changed:
What|Removed |Added
Attachment #151725|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
--- Comment #28 from Marcel de Rooy ---
Created attachment 153920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153920&action=edit
Bug 33837: Perl tidy block in Objects.t
WARN t/db_dependent/Koha/Objects.t
W
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402
Owen Leonard changed:
What|Removed |Added
Severity|enhancement |normal
Assignee|ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417
--- Comment #2 from Jonathan Druart ---
There are two things I would like to note here:
1. It does not feel correct to not invalidate the parameter when the view
changed. We could end up with a name from the previous view. It's highl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
--- Comment #27 from Marcel de Rooy ---
prove t/db_dependent/Koha/Pseudonymization.t
All tests successful.
Files=1, Tests=3, 4 wallclock secs ( 0.03 usr 0.00 sys + 3.32 cusr 0.37
csys = 3.72 CPU)
Result: PASS
prove t/db_depende
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
--- Comment #26 from Marcel de Rooy ---
t/db_dependent/Koha/Objects.t
# Subtest: filter_by_last_update
ok 1 - Should raise an exception if no parameter given
ok 2 - filter_by_last_update must return a Koha::Objects-based obje
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
Marcel de Rooy changed:
What|Removed |Added
Attachment #153900|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
Marcel de Rooy changed:
What|Removed |Added
Attachment #151723|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
Marcel de Rooy changed:
What|Removed |Added
Attachment #151722|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
Marcel de Rooy changed:
What|Removed |Added
Attachment #151721|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
Marcel de Rooy changed:
What|Removed |Added
Attachment #151720|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
--- Comment #20 from Marcel de Rooy ---
Funny remember the cardnumber patch?
t/db_dependent/Koha/Patrons.t 27/43
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Duplicate entry '1234
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
--- Comment #19 from Marcel de Rooy ---
Kind of distracted by this code construction in the context:
try {
$count = $patrons->filter_by_last_update(
{ timestamp_column_name => 'updated_on', from => '1970-12-3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417
--- Comment #1 from Jonathan Druart ---
Created attachment 153914
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153914&action=edit
Bug 34417: Allow breadcrumbs to accept dynamic values
This patch is an example of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
Jonathan Druart changed:
What|Removed |Added
Attachment #153905|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
Jonathan Druart changed:
What|Removed |Added
Attachment #153904|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
Jonathan Druart changed:
What|Removed |Added
Attachment #153903|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
Jonathan Druart changed:
What|Removed |Added
Attachment #153902|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
--- Comment #18 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #16)
> New suggestion, tests are passing now. What do you think?
Thanks. Having a look now.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336
Marcel de Rooy changed:
What|Removed |Added
Depends on||34415
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
Marcel de Rooy changed:
What|Removed |Added
Blocks||34336
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
Marcel de Rooy changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
Marcel de Rooy changed:
What|Removed |Added
Summary|t/EdiTransport.t|Remove Test::DBIx::Class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
--- Comment #4 from Marcel de Rooy ---
Created attachment 153909
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153909&action=edit
Bug 34415: (follow-up) Fix count and copy file
Instead of assuming a count of 0, I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
--- Comment #3 from Marcel de Rooy ---
Created attachment 153908
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153908&action=edit
Bug 34415: Perltidy file
Signed-off-by: Marcel de Rooy
--
You are receiving thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
--- Comment #2 from Marcel de Rooy ---
Created attachment 153907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153907&action=edit
Bug 34415: Move to db_dependent
Signed-off-by: Marcel de Rooy
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
--- Comment #1 from Marcel de Rooy ---
Created attachment 153906
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153906&action=edit
Bug 34415: Remove T::D::C from EdiTransport.t
Signed-off-by: Marcel de Rooy
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
Jonathan Druart changed:
What|Removed |Added
Status|NEW |In Discussion
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
--- Comment #5 from Jonathan Druart ---
Created attachment 153905
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153905&action=edit
Bug 34418: DO NOT PUSH - update example
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
--- Comment #4 from Jonathan Druart ---
Created attachment 153904
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153904&action=edit
Bug 34418: Add is_empty flag
--
You are receiving this mail because:
You are wat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983
sandeepj changed:
What|Removed |Added
Attachment #152057|1 |0
is patch|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
--- Comment #3 from Jonathan Druart ---
Matt, I am wondering if we should not have a flag in the route definition
instead, we already have is_base, is_navigation_item, is_end_node and
is_default.
Shouldn't we have another one to fla
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
--- Comment #2 from Jonathan Druart ---
Created attachment 153903
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153903&action=edit
Bug 34418: Allow empty nodes in breadcrumb's elements
Coming from an adaptation o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
--- Comment #1 from Jonathan Druart ---
Created attachment 153902
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153902&action=edit
Bug 34418: DO NOT PUSH - example
Try the other patch with this patch applied.
Go
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169
--- Comment #38 from Jonathan Druart ---
(In reply to Matt Blenkinsop from comment #35)
> The patch above is an example of an implementation for this by passing a
> parameter into the breadcrumbs from a particular component.
>
> Cur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169
Jonathan Druart changed:
What|Removed |Added
Blocks||34418
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418
Bug ID: 34418
Summary: Allow empty nodes in breadcrumb's elements
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Stat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169
Jonathan Druart changed:
What|Removed |Added
Blocks||34417
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417
Bug ID: 34417
Summary: ERM's breadcrumb (Vue) does not display the entity's
name
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909
--- Comment #8 from Owen Leonard ---
(In reply to Caroline Cyr La Rose from comment #5)
> - There is an extra > in the title of this page ( > Currencies >
> Currencies and exchange rates > etc.)
> - There is an extra > in the t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909
--- Comment #7 from Owen Leonard ---
Created attachment 153901
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153901&action=edit
Bug 33909: (follow-up) QA fixes
--
You are receiving this mail because:
You are wat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34416
Bug ID: 34416
Summary: Upgrade error bug
Change sponsored?: ---
Product: Koha
Version: 23.05
Hardware: All
OS: Linux
Status: NEW
Severity: e
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34414
Mason James changed:
What|Removed |Added
CC||m...@kohaaloha.com
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169
--- Comment #37 from Martin Renvoize ---
Isn't it just a case of skipping the 'Add support for FA styles' patch?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
Jonathan Druart changed:
What|Removed |Added
Attachment #153898|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128
Martin Renvoize changed:
What|Removed |Added
Assignee|matt.blenkinsop@ptfs-europe |koha-b...@lists.koha-commu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324
--- Comment #27 from Philip Orr ---
Created attachment 153899
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153899&action=edit
Bug 29324: Change test to look at all .pm or .pl files
This patch changes the test at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
--- Comment #16 from Jonathan Druart ---
New suggestion, tests are passing now. What do you think?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837
--- Comment #15 from Jonathan Druart ---
Created attachment 153898
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153898&action=edit
Bug 33837: Remove datetime parameter
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34414
Jonathan Druart changed:
What|Removed |Added
Attachment #153896|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
Marcel de Rooy changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415
Bug ID: 34415
Summary: t/EdiTransport.t
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34375
Stephen Graham changed:
What|Removed |Added
CC||s.grah...@herts.ac.uk
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34414
--- Comment #3 from Marcel de Rooy ---
QA: NOTE the dependency
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34414
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34414
--- Comment #2 from Marcel de Rooy ---
Created attachment 153896
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153896&action=edit
Bug 34414: Remove DBD::Mock
We never actually used it. See BZ report.
Test plan:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34414
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
101 - 182 of 182 matches
Mail list logo