https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Nick Clemens changed:
What|Removed |Added
CC||and...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #88 from Katrin Fischer ---
Hm, looking at this too, I think it needs a bit of a rewrite. We added the
cancellation reasons since this was first written and the whole cancellation
process is slightly different now (delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Séverine Queune changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #87
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #86 from Chris Cormack ---
I've rebased and tried to fix things Séverine, I don't know how well it works
but if you could test it would be good
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Chris Cormack changed:
What|Removed |Added
Attachment #29668|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Chris Cormack changed:
What|Removed |Added
Attachment #27292|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #85 from Chris Cormack ---
Created attachment 78864
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78864&action=edit
Bug 10869 Followup: Unit tests for DelOrder
[The best would be to add a second sign-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #84 from Chris Cormack ---
Created attachment 78863
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78863&action=edit
Bug 10869: Followup : update the receipt page (parcel.tt)
(Fixed after test by Lyon3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Chris Cormack changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Chris Cormack changed:
What|Removed |Added
Attachment #26692|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #82 from Séverine Queune ---
It would be great if someone could work on this patch again !
The problem is still valid.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #81 from M. Tompsett ---
Comment on attachment 26692
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26692
[PATCH] Bug 10869: Allow the deletion of order line if the record is deleted
Review of attachment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Marjorie Barry-Vila changed:
What|Removed |Added
CC||marjorie.barry-v...@ccs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #80 from mathieu saby ---
(In reply to Paola Rossi from comment #79)
> (In reply to mathieu saby from comment #78)
> > In fact bug 12853 has nothing to do with this one, BUT bug 7162 (passed QA)
> > will have aftereffects,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #79 from Paola Rossi ---
(In reply to mathieu saby from comment #78)
> In fact bug 12853 has nothing to do with this one, BUT bug 7162 (passed QA)
> will have aftereffects, as it rewrites DelOrder.
> So, I'll take a look a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #78 from mathieu saby ---
In fact bug 12853 has nothing to do with this one, BUT bug 7162 (passed QA)
will have aftereffects, as it rewrites DelOrder.
So, I'll take a look again when bug 7162 is pushed
M. Saby
--
You ar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
See Also|http://bugs.koha-community. |
|org/bugzi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #77 from mathieu saby ---
I won't touch it again for the moment
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@l
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #76 from mathieu saby ---
DelOrder sub was modified by Bug 12583 - DelItem takes $dbh in parameter
(commit ba81cdcdb2806e3b60786ed47258a189703ccffb)
"To delete an item, only the itemnumber should be mandatory. The DelItem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Paola Rossi changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #74
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #28516|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #72 from mathieu saby ---
(In reply to Levast from comment #70)
> we can't understand why we should return on the page of reception to delete
> the record already deleted in the basket :
> - go on receipt page
> - in the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Lise changed:
What|Removed |Added
CC||lise.de_baudouin@enc.sorbon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Levast changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment #69
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #68 from mathieu saby ---
Created attachment 28516
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28516&action=edit
[PATCH 2/2] Bug 10869 Followup: Unit tests for DelOrder
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #26693|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #27270|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #66 fro
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #65 from mathieu saby ---
If I understand your comment, it is not a display problem:
Currently, if the record is deleted, the title is currently not given at all in
the table with all orders to receive (in the summary colu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Koha Team Lyon 3 changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #64
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
See Also|http://bugs.koha-community. |
|org/bugzi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #63 from mathieu saby ---
Please note that bug 10758 is linked to this bug (it will display the titles of
deleted records in orders, instead of "Deleted record, can't find title").
There is no dependancy strictly speaking
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #62 from mathieu saby ---
Created attachment 27270
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27270&action=edit
[PATCH 3/3] Followup : update the receipt page (parcel.tt)
Sorry, I forgot to change pa
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Koha Team Lyon 3 changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Blocks|10758 |
--
You are receiving this m
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #60 from mathieu saby ---
I had to make some little changes to the main patch and to the followup, so the
best would be to test again those patch and add new sign-off.
I know Sonia Bouis from Lyon3 was interested with thi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #25003|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #24992|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #57 from M. de Rooy ---
(In reply to mathieu saby from comment #56)
> But it is not the only patch I have written regarding those points. There is
> also:
> - BZ 11224 for adding new UT
> - BZ 10758 for showing bibliograph
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #56 from mathieu saby ---
I don't like BZ 8991 ;-)
BZ 10869 was made to fix a bug reported by Nicole. And for me too it sounds
like a bug, at least at the time I wrote it.
But it is not the only patch I have written rega
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #55 from M. de Rooy ---
(In reply to M. de Rooy from comment #54)
> The questions on order level actually pertain to basket level also. If we
> delete a basket, we do warn the user that he will lose his items. But he
> doe
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #54 from M. de Rooy ---
The questions on order level actually pertain to basket level also. If we
delete a basket, we do warn the user that he will lose his items. But he does
not have a choice between "Delete basket and o
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
--- Comment #53 f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Attachment #25002|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Attachment #25001|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #50 from M. de Rooy ---
Updated the commit message of the second patch too.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Attachment #25000|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #48 from M. de Rooy ---
Follow-up resubmitted to restore patch order. Will still answer previous
comment.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Attachment #24744|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #46 from mathieu saby ---
Marcel, I got a bad result with prove t/db_dependent/Acquisition.t
# Failed test 'DelOrders delete items linked with cancelled order in
aqorders_items table'
# at t/db_dependent/Acquisition.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #24743|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment #44
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #43 from mathieu saby ---
I'm not sure of the origin of the conflict. I prefer to investigate a little
more to avoid a mistake.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
_
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #42 from mathieu saby ---
I'll take a look next week
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #41 from M. de Rooy ---
(In reply to mathieu saby from comment #40)
> OK, I did not understand your point of view. I thought you agreed for
> removing biblionumber param...
Hi Matthieu,
My question about removing the bibli
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #40 from mathieu saby ---
OK, I did not understand your point of view. I thought you agreed for removing
biblionumber param...
I'm going to test your patch asap
Mathieu
--
You are receiving this mail because:
You are w
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #39 from M. de Rooy ---
(In reply to mathieu saby from comment #36)
> I don't understand:
> I wrote it a long time ago, but I seem to remember that the UT added in the
> 2d patch was made to test the function DelOrder as a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Attachment #22300|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Attachment #23839|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
M. de Rooy changed:
What|Removed |Added
Blocks||11617
--
You are receiving thi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #36 from mathieu saby ---
(In reply to M. de Rooy from comment #35)
> (In reply to mathieu saby from comment #34)
> > > I would suggest to combine them, since the followup also includes a unit
> > > test.
> >
> > Are you
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #35 from M. de Rooy ---
(In reply to mathieu saby from comment #34)
> > I would suggest to combine them, since the followup also includes a unit
> > test.
>
> Are you sure it is the best way to proceed? as the 1st patch w
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #34 from mathieu saby ---
(In reply to M. de Rooy from comment #33)
> (In reply to mathieu saby from comment #32)
> > Well, you may be right ;-)
> > I thought it was a good thing to have as less parameters as possible, to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #33 from M. de Rooy ---
(In reply to mathieu saby from comment #32)
> Well, you may be right ;-)
> I thought it was a good thing to have as less parameters as possible, to
> make the code in .pl files more simple. But it w
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #32 from mathieu saby ---
(In reply to M. de Rooy from comment #31)
> Just a *dumb* question: Why remove the biblio parameter and look it up in
> the database if you already had it in the first place?
Well, you may be rig
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #31 from M. de Rooy ---
Just a *dumb* question: Why remove the biblio parameter and look it up in the
database if you already had it in the first place?
--
You are receiving this mail because:
You are watching all bug ch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #22676|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #28 from mathieu saby ---
Of course, UT cannot be tested on a sandbox, but the other aspects of the patch
can.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
__
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #22342|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Patch complexity|Trivial patch |Small patch
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
I'm just a bot changed:
What|Removed |Added
When did the bot|2013-09-24 00:00:00 |2013-10-30
last check th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #25 from mathieu saby ---
I ask for a 2d signoff, as my followup changes a lot of things in DelBiblio.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
__
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #24 from mathieu saby ---
Created attachment 22342
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22342&action=edit
[PATCH 2/2] Bug 10869 Followup : change DelOrder and adds UT
Changes made to DelOrder :
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #23 from mathieu saby ---
In fact, passing the biblionumber to DelBiblio seems useless.
It can be retreived inside the sub, with the ordernumber.
I will rewrite the sub so that it takes only the ordernumber.
Mathieu
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #22104|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
mathieu saby changed:
What|Removed |Added
Attachment #21480|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #20 from mathieu saby ---
Maybe the issue is that some ppl in some libraries send orders before closing
the basket.
I think it should be discourage : closing the basket is needed for calculation
of expected shiping date, s
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #19 from mathieu saby ---
(In reply to Paul Poulain from comment #17)
> QA comments:
> sorry guys, I think there's a regression: I could delete an order that has
> been already recieved. I tried without the patch, and I c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #18 from Paul Poulain ---
Created attachment 22104
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22104&action=edit
Bug 10869 follow-up: indent & term
* removing a few tabs
* fixed a few silly indents
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
Paul Poulain changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869
--- Comment #16 from mathieu saby ---
Could someone QA, so that depending patch (Bug 10758) could be signed on
sandbox once this one is pushed?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
_
1 - 100 of 121 matches
Mail list logo