[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #44 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33029 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33029action=edit Bug 11319: [QA follow-up] Add test message to

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #45 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33030 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33030action=edit Bug 11319: [QA follow-up] Remove a warning from

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #46 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment bug 11319: Generally looks good. The current implementation in master is not error free. This will not resolve all bugs. 5 patches, no koha-qa complaints, added 2

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #29497|0 |1

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #48 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33039 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33039action=edit Bug 11319: Add UT for the fields management Signed-off-by: Kyle M

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #52 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33043 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33043action=edit Bug 11319: [QA follow-up] Add test message to

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #51 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33042 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33042action=edit Bug 11319: Template modifications This patch add template

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #50 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33041 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33041action=edit Bug 11319: Add specific UT for nonexistent field/subfield This

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #49 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33040 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33040action=edit Bug 11319: Add the field management for Koha::SimpleMARC Currently

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #53 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33044 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33044action=edit Bug 11319: [QA follow-up] Remove a warning from

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to M. de Rooy from comment #42) (In reply to Jonathan Druart from comment #41) (In reply to Jonathan Druart from comment #40) Marcel, I submitted a patch on

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #37) I applied 11319, 11413 and 11395 together now. The limitation seems to not be the same anymore. But it is still not

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31343 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31343action=edit Bug 11395: Raise an alert if control field is used If a

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #31343|0

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com --- Marcel, I submitted a patch on bug 11395 comment 39. Could you confirm it's what you expected? -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #40) Marcel, I submitted a patch on bug 11395 comment 39. Could you confirm it's what you expected? It is bug 11395

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #42 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #41) (In reply to Jonathan Druart from comment #40) Marcel, I submitted a patch on bug 11395 comment 39. Could you confirm it's

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #34 from M. de Rooy m.de.r...@rijksmuseum.nl --- Started QA on this one; will have some comments tomorrow. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #32 from M. de Rooy m.de.r...@rijksmuseum.nl --- Planning to QA this after 11319 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #33 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to M. de Rooy from comment #32) Planning to QA this after 11319 Somehow a backspace got in between :) -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #28988|0 |1

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #27 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 29498 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29498action=edit [PASSED QA] Bug 11319: Add UT for the fields management

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #29 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 29500 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29500action=edit [PASSED QA] Bug 11319: Add specific UT for nonexistent

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #28 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 29499 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29499action=edit [PASSED QA] Bug 11319: Add the field management for

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #30 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 29501 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29501action=edit [PASSED QA] Bug 11319: Template modifications This patch add

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #29497|[PASSED QA] Bug 11319: |Bug

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #29498|[PASSED QA] Bug 11319: Add |Bug

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #29499|[PASSED QA] Bug 11319: Add |Bug

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #29501|[PASSED QA] Bug 11319: |Bug

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #29500|[PASSED QA] Bug 11319: Add |Bug

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25751|0

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28989 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28989action=edit Bug 11319: Add UT for the fields management -- You are

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28992 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28992action=edit Bug 11319: Template modifications This patch add template

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28990 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28990action=edit Bug 11319: Add the field management for Koha::SimpleMARC

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- Last patch set fixes silly error introduced by previous rebase (c/p error). -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28991action=edit Bug 11319: Add specific UT for nonexistent field/subfield

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23415|0

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25752 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25752action=edit Bug 11319: Add UT for the fields management -- You are

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25753 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25753action=edit Bug 11319: Add the field management for Koha::SimpleMARC

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25755 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25755action=edit Bug 11319: Template modifications This patch add template

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25754 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25754action=edit Bug 11319: Add specific UT for nonexistent field/subfield

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Fix conflict with bug 11478. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Patch

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 cedric.v...@dracenie.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23419|0

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Fix conflict with bug 11414. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23206|0

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23416 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23416action=edit Bug 11319: Add UT for the fields management -- You are

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23419 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23419action=edit Bug 11319: Template modifications This patch add template

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23418 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23418action=edit Bug 11319: Add specific UT for nonexistent field/subfield

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23417 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23417action=edit Bug 11319: Add the field management for Koha::SimpleMARC

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- As a POC, it looks pretty good to me! The only suggestion I would have would be not keep the export for read_field, and modify that sub to check for a value in the subfield

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Kyle M Hall from comment #3) Kyle, Thank you for your feedback. As a POC, it looks pretty good to me! The only suggestion I would have would be not

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23206 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23206action=edit Bug 11319: POC Marc modification templates improvements

[Koha-bugs] [Bug 11319] Marc modification templates improvements

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW