[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #34 from Mason James m...@kohaaloha.com --- (In reply to Mason James from comment #33) this needs to be added to 3.16.x, as 'ajax-circ' feature (11703) depends on it i'll only attempt to pull QAed patches from this

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Mason James m...@kohaaloha.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to David Cook from comment #31) Comment on attachment 27345 [details] [review] Hello David, Did you see that the belongs_to relations are removed in

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #31 from David Cook dc...@prosentient.com.au --- Comment on attachment 27345 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27345 [PASSED QA] Bug 11518 - Add new method to Koha::Schema::Result::Item that

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #30 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think our ids are named quite differently across tables, so I am not sure if number and id would be enough. Also a little worried that if we change too much about the

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #25 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 31240 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31240action=edit Bug 11518: Follow-up removing biblioitem routines There is no need

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #29544|0 |1

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 31242 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31242action=edit Bug 11518: Follow-up removing biblioitem routines There is no need

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #28 from M. de Rooy m.de.r...@rijksmuseum.nl --- There still is some discussion about it (see IRC): Why do we use $self-biblioitemnumber()-itemtype() ? $self-biblioitem-itemtype would be nicer. My answer would be: Since

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #29 from M. de Rooy m.de.r...@rijksmuseum.nl --- From the DBIx doc: For relationships, belongs_to accessors are made from column names by stripping postfixes other than _id as well, for example just Id, _?ref, _?cd, _?code

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- I really don't understand the complexity of this patch. Why do we want to add extra constraints? In my opinion, the fk constraints exist in DB and we don't want to

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29544 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29544action=edit Bug 11518: WIP - Remove useless constraints previously

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #29544|Bug 11518: WIP - Remove

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords|

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27343 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27343action=edit Bug 11518 [QA Followup] - Make unit tests pass -- You are

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27343|0 |1

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #25510|0 |1

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27346 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27346action=edit [PASSED QA] Bug 11518 [Followup] - Change method name from

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26987|0 |1

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27348 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27348action=edit [PASSED QA] Bug 11518 [QA Followup] - Make unit tests pass

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27345 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27345action=edit [PASSED QA] Bug 11518 - Add new method to

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #24121|0 |1

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27347 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27347action=edit [PASSED QA] Bug 11518 [QA Followup] Signed-off-by: Katrin

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #27344|0 |1

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |In

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- I should note the unit test for this will now fail until we get the database handles for DBI and DBIx::Class tied together somehow. -- You are receiving this mail

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 26983 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26983action=edit Bug 11518 [QA Followup] -- You are receiving this mail because:

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #26983|0 |1

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #26985|0 |1

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #9) I agree, it is too bad to depend on C4::Context but it is the way to get a syspref value. Are you suggesting to get the value

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed: What|Removed |Added Attachment #25448|0

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed: What|Removed |Added Attachment #24143|0

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Blocks||11703

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Just an fyi, I this idea came to me while reading the reports for bug 9448 and bug 11463. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Not bug 9448, I meant bug 9532 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 24121 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24121action=edit Bug 11518 - Add new method to Koha::Schema::Result::Item that will

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- In the future we could even override $item-itype() to return the correct value via system preference. Not sure if this would be a good idea or a bad one. In some cases it

[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 24143 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24143action=edit Bug 11518 [Followup] - Change method name from 'itemtype' to