https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Magnus Enger changed:
What|Removed |Added
Blocks||36536
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Blocks||35231
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #197 from Marcel de Rooy ---
See 35231. OPAC is blocked when logging out.
Did we miss an Auth.pm test here? :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
David Nind changed:
What|Removed |Added
Text to go in the|This enhancement changes|This enhancement changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Caroline Cyr La Rose changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Caroline Cyr La Rose changed:
What|Removed |Added
Blocks||35221
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
David Nind changed:
What|Removed |Added
Text to go in the|This enhancement enables|This enhancement changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Component|Circulation |Patrons
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #193 from Andrii Nugged ---
(In reply to Tomás Cohen Arazi from comment #191)
> Pushed to master for 23.11.
Good! /me taking this to our preprod pilot, and soon to pre-release prod pilot.
So if something pop-ups, we'll
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #192 from Cab Vinton ---
Super-excited for this. Thanks to everyone for all their contributions & work
to get this far!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #191 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||23.11.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #190 from Victor Grousset/tuxayo ---
(In reply to Andrii Nugged from comment #187)
> btw, that atomic update quoting is very inconsistent:
It's just between 1st and 3rd case. The 2nd uses interpolation so needs the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #189 from Victor Grousset/tuxayo ---
Created attachment 157624
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157624=edit
Bug 15504: (QA follow-up): more consistent quotes in atomicupdate
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #188 from Andrii Nugged ---
btw, that atomic update quoting is very inconsistent:
my ($tracklastactivity) = $dbh->selectrow_array(
q|
SELECT value FROM systempreferences WHERE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #187 from Andrii Nugged ---
I did the rebase. But which status we should put for the ticket?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #186 from Andrii Nugged ---
Created attachment 157620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157620=edit
Bug 15504: (QA follow-up) Final changes
[1] Comment in Patron->is_active sharpened.
[2]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #185 from Andrii Nugged ---
Created attachment 157619
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157619=edit
Bug 15504: (QA follow-up) Fix dbrev
Resolve:
ERROR - {UNKNOWN}: DBI Exception:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #184 from Andrii Nugged ---
Created attachment 157618
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157618=edit
Bug 15504: Remove PatronLastActivity preference
This patch removes the older
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #183 from Andrii Nugged ---
Created attachment 157617
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157617=edit
Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons
This patch adds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #182 from Andrii Nugged ---
Created attachment 157616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157616=edit
Bug 15504: (follow-up) Update terminology on cleanborrowers
This patch updates the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #181 from Andrii Nugged ---
Created attachment 157615
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157615=edit
Bug 15504: (QA follow-up) Terminology
This just updates 'Login to OPAC' to 'Login'.. we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #180 from Andrii Nugged ---
Created attachment 157614
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157614=edit
Bug 15504: (follow-up) Rename cache key
I agree, it's better to use borrowernumber for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #179 from Andrii Nugged ---
Created attachment 157613
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157613=edit
Bug 15504: (follow-up) Respect existing TrackLastPatronActivity
This patch updates the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #178 from Andrii Nugged ---
Created attachment 157612
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157612=edit
Bug 15504: (follow-up) Fix is_active test
Bug 33245 introduced a new is_active patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #177 from Andrii Nugged ---
Created attachment 157611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157611=edit
Bug 15504: (follow-up) Tidy 'lastseen' section of unit test
Signed-off-by: Marcel de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #176 from Andrii Nugged ---
Created attachment 157610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157610=edit
Bug 15504: (follow-up) Add Triggers mock to unit tests
Signed-off-by: Marcel de Rooy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #175 from Andrii Nugged ---
Created attachment 157609
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157609=edit
Bug 15504: (follow-up) Use borrowernumber in Koha::Patrons->find
Signed-off-by: Marcel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #174 from Andrii Nugged ---
Created attachment 157608
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157608=edit
Bug 15504: (follow-up) Migrate to one clear method
We were using a series of similarly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #173 from Andrii Nugged ---
Created attachment 157607
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157607=edit
Bug 15504: (follow-up) Unit tests
This patch removes, moves and updates the existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #172 from Andrii Nugged ---
Created attachment 157606
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157606=edit
Bug 15504: Add unit test
prove -v t/db_dependent/Auth.t
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #171 from Andrii Nugged ---
Created attachment 157605
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157605=edit
Bug 15504: Remove update_lastseen method
This patch removes update_lastseen which has
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #170 from Andrii Nugged ---
Created attachment 157604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157604=edit
Bug 15504: Add triggers to instances of track_login_daily
This patch adds a trigger to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #169 from Andrii Nugged ---
Created attachment 157603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157603=edit
Bug 15504: Update track_login_daily to accept triggers
This patch adds triggers to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Andrii Nugged changed:
What|Removed |Added
Attachment #156917|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Andrii Nugged changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Bug 15504 depends on bug 33245, which changed state.
Bug 33245 Summary: Add $patron->is_active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Blocks|35001 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #165 from Marcel de Rooy ---
Note for RM: There are follow-up bugs opened to extend the feature. But imo
this can go in as-is. There is commitment to work further.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #164 from Marcel de Rooy ---
Looks good to me now.
Last commment. Just noticing here. Will open a new bug.
t/db_dependent/Members.t
$dbh->do(q|UPDATE borrowers SET lastseen=NULL|);
Not from this patch set, but this is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #163 from Marcel de Rooy ---
Created attachment 156935
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156935=edit
Bug 15504: (QA follow-up) Final changes
[1] Comment in Patron->is_active sharpened.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156915|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156914|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156913|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156912|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156911|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156910|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156909|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156908|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156907|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156906|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156905|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156904|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156903|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156902|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156901|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156900|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156899|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156898|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #144 from Marcel de Rooy ---
FAIL C4/Auth.pm
FAIL pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
perl -MPod::Coverage=C4::Auth -e1
C4::Auth has a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #143 from Marcel de Rooy ---
We also need 35041 to fix a current failure on Koha/Patron.t. Submitted now.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #142 from Marcel de Rooy ---
Created attachment 156915
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156915=edit
Bug 15504: (QA follow-up) Fix dbrev
Resolve:
ERROR - {UNKNOWN}: DBI Exception:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Status|Patch doesn't apply |BLOCKED
--- Comment #141
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156879|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156870|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156869|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156868|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156867|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156866|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156865|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156864|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156863|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156862|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156861|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156860|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156859|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156858|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156857|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156856|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156855|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #122 from Marcel de Rooy ---
Applying: Bug 15504: (follow-up) Unit tests
error: sha1 information is lacking or useless (t/db_dependent/Koha/Patron.t).
error: could not build fake ancestor
Patch failed at 0001 Bug 15504:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #121
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156875|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #119 from Martin Renvoize ---
I opted to just fold in the removal of TrackLastPatronActivity.. it can be
moved to it's own bug if you prefer.. or squashed a bit.. I kept them as
distict patches for now just to make it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #118 from Martin Renvoize ---
Created attachment 156875
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156875=edit
Bug 15504: Remove PatronLastActivity preference
This patch removes the older
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #117 from Martin Renvoize ---
Created attachment 156870
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156870=edit
Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons
This patch adds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #116 from Martin Renvoize ---
Created attachment 156869
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156869=edit
Bug 15504: (follow-up) Update terminology on cleanborrowers
This patch updates the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #115 from Martin Renvoize ---
Created attachment 156868
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156868=edit
Bug 15504: (QA follow-up) Terminology
This just updates 'Login to OPAC' to 'Login'..
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #114 from Martin Renvoize ---
Created attachment 156867
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156867=edit
Bug 15504: (follow-up) Rename cache key
I agree, it's better to use borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #113 from Martin Renvoize ---
Created attachment 156866
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156866=edit
Bug 15504: (follow-up) Respect existing TrackLastPatronActivity
This patch updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Martin Renvoize changed:
What|Removed |Added
Attachment #156608|0 |1
is obsolete|
1 - 100 of 252 matches
Mail list logo