[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #48 from Tomás Cohen Arazi --- I decided to take another approach as back in 2020 bug 25109 was pushed (for a different script that needed a locking mechanism), and I wasn't aware of the discussion here. Thanks to

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #46 from David Cook --- Comment on attachment 80256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256 Bug 15529: Altered logic for lockfile creation Review of attachment 80256: -->

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #44 from M. Tompsett --- (In reply to Marcel de Rooy from comment #43) > -C4::Letters::SendQueuedMessages( > -{ > -verbose => $verbose, > -username => $username, > -password => $password, > -

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Failed QA -- You are

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #43 from Marcel de Rooy --- -C4::Letters::SendQueuedMessages( -{ -verbose => $verbose, -username => $username, -password => $password, -method => $method, -limit=>

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #42 from Marcel de Rooy --- +my $instancemessagequeuefile = $logdir . "/messagequeue.lock"; +open(FOO, ">> $instancemessagequeuefile") or die "Cannot write to $instancemessagequeuefile: $!"; As Martin already said, the

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #41 from Marcel de Rooy --- (In reply to Alex Buckley from comment #39) > Hi Marcel > > Thanks for testing. Can you please tell me which patch is failing to apply? > > When I test applying on up to date master it is

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #40 from Marcel de Rooy --- +print "$0 is already running. Exiting.\n"; +#Send email to inform administrator another process_message_queue.pl cron was attempted to run whilst previous execution of the file is taking

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #39 from Alex Buckley --- Hi Marcel Thanks for testing. Can you please tell me which patch is failing to apply? When I test applying on up to date master it is applying fine: Apply? [(y)es, (n)o, (i)nteractive] y

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply ---

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #36 from Martin Renvoize --- I never did manage to apply this, but I think it's just a peculiarity with my own git repository. Setting back to Signed Off.. hopefully we can get some more eyes on this again now.. I

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply ---

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #33 from Martin Renvoize --- Hmm.. on second thoughts I think this needs a bit more thought around how it may need to handle the 'type' argument that can be passed to the script.. I can see cases where one would want

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #32 from Martin Renvoize --- Comment on attachment 80256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256 Bug 15529: Altered logic for lockfile creation Review of attachment 80256: -->

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #30 from Alex Buckley --- Created attachment 80256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256=edit Bug 15529: Altered logic for lockfile creation Implemented logic for creating lockfile

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize changed: What|Removed |Added CC||mi...@abunchofthings.net,

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #29 from Martin Renvoize --- See bug 11078 or the current rebuild_zebra.pl script for inspirations perhaps ;) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #27

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What|Removed |Added Attachment #79910|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What|Removed |Added Attachment #79649|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What|Removed |Added Attachment #78918|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #23 from Alex Buckley --- Created attachment 79910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79910=edit Bug 15529: Followup to send without more libraries This uses the letter_code parameter to

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #22 from Alex Buckley --- Hi M. Tompsett I have tested and your patch, in combination with my first two patches, works nicely. I will sign off on your patch, can you please do the same on my two patches. Cheers, Alex

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Attachment #79726|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #21 from M. Tompsett --- Created attachment 79726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79726=edit Bug 15529: Followup to send without more libraries This uses the letter_code parameter to

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What|Removed |Added Attachment #79719|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #19 from M. Tompsett --- Apply ALL the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #18 from M. Tompsett --- Created attachment 79719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79719=edit Bug 15529: Followup to send without more libraries This uses the letter_code parameter to

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #17 from M. Tompsett --- How about this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #14 from Alex Buckley --- Created attachment 79649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79649=edit Bug 15529 - Wrapping email sending up in the verbose flag Thus the cron email telling the

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #13 from M. Tompsett --- Comment on attachment 78918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78918 Bug 15529 - Locking process_message_queue.pl cron whilst it is running Review of attachment

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #11 from Alex Buckley --- Created attachment 78918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78918=edit Bug 15529 - Locking process_message_queue.pl cron whilst it is running This amended patch

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #12 from Alex Buckley --- Rebased against master on 16th of sept 2018. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Attachment #78582|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #10 from Alex Buckley --- Created attachment 78582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78582=edit Bug 15529 - Locking process_message_queue.pl cron whilst it is running This amended patch

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Attachment #78212|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 paxed changed: What|Removed |Added CC||pasi.kalli...@joensuu.fi ---

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #8 from Alex Buckley --- Created attachment 78212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78212=edit Bug 15529 - Lock /var/lock/koha//messagequeue.lock while running process_message_queue.pl

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Attachment #78211|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Attachment #78210|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #7 from Alex Buckley --- Created attachment 78211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78211=edit Bug 15529 - Lock /var/lock/koha//messagequeue.lock while running process_message_queue.pl

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #6 from Alex Buckley --- Created attachment 78210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78210=edit Bug 15529 - Lock /var/lock/koha//messagequeue.lock while running process_message_queue.pl

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added Attachment #78205|0 |1 is obsolete|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #4 from Alex Buckley --- Created attachment 78205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78205=edit Bug 15529 - Using flock to lock new messagequeue.lock lockfile whilst

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Barton Chittenden changed: What|Removed |Added Severity|enhancement

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Liz Rea changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Wendy Sharkey changed: What|Removed |Added CC|