[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #50 from Julian Maurice --- (In reply to Julian Maurice from comment #49) > (In reply to Jacek Ablewicz from comment #48) > > (In reply to Julian Maurice from comment #47) > > > Patches

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #49 from Julian Maurice --- (In reply to Jacek Ablewicz from comment #48) > (In reply to Julian Maurice from comment #47) > > Patches pushed to 3.22.x, will be in 3.22.8 > > Hi Julian, > >

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #48 from Jacek Ablewicz --- (In reply to Julian Maurice from comment #47) > Patches pushed to 3.22.x, will be in 3.22.8 Hi Julian, With Bug 16044 pushed for 3.22.8, some follow-ups of this report

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jacek Ablewicz changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Julian Maurice changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jacek Ablewicz changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jacek Ablewicz changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #46 from Brendan Gallagher --- (In reply to Katrin Fischer from comment #45) > I see 2 sign off lines - one from a QA team member. Should we move this PQA? Last patch pushed (mar 29 - 2016)

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jacek Ablewicz changed: What|Removed |Added Attachment #49568|0 |1

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Attachment #49555|0

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #42 from Jonathan Druart --- I was going to ask Tomas or Jacek, but Jesse is around at this time :) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #41 from Brendan Gallagher --- (In reply to Jonathan Druart from comment #40) > Created attachment 49555 [details] [review] > Bug 16044; Populate the L1 cache when L2 is fetched > > The

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #40 from Jonathan Druart --- Created attachment 49555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49555=edit Bug 16044; Populate the L1 cache when L2 is

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #39 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #19) > BTW, that part of the 1st followup: > > my $get_sub = $self->{ref($self->{$cache}) . "_get"}; >

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Brendan Gallagher changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Tomás Cohen Arazi changed: What|Removed |Added Attachment #49494|0 |1

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Tomás Cohen Arazi changed: What|Removed |Added Attachment #49492|0 |1

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Tomás Cohen Arazi changed: What|Removed |Added Attachment #49493|0 |1

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Tomás Cohen Arazi changed: What|Removed |Added Attachment #49491|0 |1

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Tomás Cohen Arazi changed: What|Removed |Added Attachment #49490|0 |1

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #31 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #24) > (In reply to Jacek Ablewicz from comment #17) > > 1) CGI + memcache - no measurable differences between

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Attachment #49188|0

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Attachment #49187|0

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Attachment #48968|0

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Attachment #49179|0

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Attachment #49186|0

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Attachment #49240|0

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Attachment #49239|0

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Srdjan Jankovic changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #22 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #21) > We'll need to send 'thawed' scalar to memcached somehow packaged (e.g. in [ s/'thawed' scalar/'frozen' scalar/ -- You

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #19 from Jacek Ablewicz --- BTW, that part of the 1st followup: my $get_sub = $self->{ref($self->{$cache}) . "_get"}; -return $get_sub ? $get_sub->($key) : $self->{$cache}->get($key); +

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jesse Weaver changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #12 from Jesse Weaver --- Created attachment 49240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49240=edit Bug 16044: (followup) don't clone cache results for

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #14 from Jonathan Druart --- Jesse, I really like your patches and yes, it's the way to go. But I think they go too far for a first step. We will introduce a significant perfs

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #20 from Jacek Ablewicz --- Some other thoughts, after toying with these patches for a little while. 1) If we want to stay "on the safe side" by default, clone()/dclone() call needs to be

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #23 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #21) > We'll need to send 'frozen' scalar to memcached somehow packaged (e.g. in [ > ]), to be able to distinguish if it was

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #16 from Martin Renvoize --- +1 to the two method approach, seems the safest and most flexible way to do it :-) +1 to splitting out the frameworks followups into their own issue. +1 to

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #11 from Jesse Weaver --- Created attachment 49239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49239=edit Bug 16044: (followup) only clear L1 cache when needed This is

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #25 from Jesse Weaver --- I think that trying to protect cache users from themselves for complex structures is going to come at too high a cost of complexity or performance, based on the

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added Blocks|16088

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jacek Ablewicz changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #15 from Jonathan Druart --- (In reply to Jesse Weaver from comment #13) > Two tiny nitpicks: > > * Why do the commit messages say L2 instead of L1? It's a typo. > * Why

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #17 from Jacek Ablewicz --- I'm also trying to test this, but with kinda weird results so far.. Searching (medium-size dataset, 120k biblios, 300k items, 10-200-2 hits, XSLT processing

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #18 from Jacek Ablewicz --- For some reason, deep copying of MARC frameworks structures with clone() is insanely slow: - clone() from the Clone module: 62 ms !!! - clone() from Clone::Fast: 21 ms

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added See

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #21 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #20) > This may be the problem; get_from_cache() which involves dclone() will be > significantly slower, and Koha::Cache as a

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #10 from Jonathan Druart --- Jacek, I completely agree with your comment, and I think the safe option (deep copy) should be the default behavior. It will avoid regression and

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #9 from Jonathan Druart --- Created attachment 49188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49188=edit Bug 16044: Add an unsafe flag to

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #7 from Jonathan Druart --- Created attachment 49186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49186=edit Bug 16044: Add tests to make sure structures

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #8 from Jonathan Druart --- Created attachment 49187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49187=edit Bug 16044: Add deep cloning To avoid the cache

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #6 from Jonathan Druart --- Created attachment 49179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49179=edit Bug 16044: Make tests from t/Cache.t pass The

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jacek Ablewicz changed: What|Removed |Added Priority|P5 - low|P1

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 --- Comment #5 from Jacek Ablewicz --- To clarify comment #1: I don't think it's a bad idea; on the contrary, I think it's an excellent idea! But I also think that current/initial implementation is, again,

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added Summary|Define a L2