[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Text to go in the|This enhancement adds |This enhancements adds

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Text to go in the||This enhancement adds

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Jonathan Druart changed: What|Removed |Added Keywords|dependency |release-notes-needed --

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Aleisha Amohia changed: What|Removed |Added Severity|normal |enhancement

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.05

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #124 from Jonathan Druart --- For information, the package does not exist in Jessie and Xenial (U16) https://gitlab.com/koha-community/koha-testing-docker/-/pipelines/195722968 -- You are receiving this mail because:

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #123 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #122 from David Cook --- (In reply to Martin Renvoize from comment #121) > Oh.. and this is an awesome enhancement, well-done guys! Cheers. Looking forward to having timestamps in the logs again :D -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #121 from Martin Renvoize --- Oh.. and this is an awesome enhancement, well-done guys! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Martin Renvoize changed: What|Removed |Added Attachment #110109|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Martin Renvoize changed: What|Removed |Added Attachment #110108|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Martin Renvoize changed: What|Removed |Added Attachment #110107|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Martin Renvoize changed: What|Removed |Added Attachment #109055|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Martin Renvoize changed: What|Removed |Added Attachment #109056|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Martin Renvoize changed: What|Removed |Added Attachment #109054|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #113 from David Cook --- (In reply to Arthur Suzuki from comment #112) > Greetings David, > Speaking in the name of BibLibre's Support Team, we're really looking > forward to see this feature integrated into master!

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #112 from Arthur Suzuki --- Greetings David, Speaking in the name of BibLibre's Support Team, we're really looking forward to see this feature integrated into master! I wouldn't mind having some reviews on my patches

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #111 from David Cook --- Cheers, Arthur. You're a legend :D. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #110 from Arthur Suzuki --- Created attachment 110109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110109=edit Bug 16357: Only use Log4perl middleware if appenders defined This patch checks that the

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Arthur Suzuki changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Arthur Suzuki changed: What|Removed |Added Attachment #109067|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #109 from Arthur Suzuki --- Created attachment 110108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110108=edit Bug 16357: (QA follow-up) Add log4perl configs during package upgrade If plack.psgi is

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Attachment #109133|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #106 from David Cook --- (In reply to Joonas Kylmälä from comment #105) > but I don't think we should depend on that using Log4perl in the future > either. I have not found any literature what's the best practice here,

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #105 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #104) > (In reply to Joonas Kylmälä from comment #102) > > David, in the patch I have this tiny nitpick: it misses the Log::Log4perl > > module

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #104 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #102) > David, in the patch I have this tiny nitpick: it misses the Log::Log4perl > module import line, which might cause issues later if

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #103 from David Cook --- (In reply to Joonas Kylmälä from comment #102) > David, in the patch I have this tiny nitpick: it misses the Log::Log4perl > module import line, which might cause issues later if Koha::Logger in

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #101 from David Cook --- Created attachment 109133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109133=edit Bug 16357: Only use Log4perl middleware if appenders defined This patch checks that the

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #100 from David Cook --- Ok actually solved it with the following: 80 if ( Log::Log4perl->get_logger('plack-opac')->has_appenders ){ 81 enable 'Log4perl', category => 'plack-opac'; 82

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #99 from David Cook --- (In reply to David Cook from comment #98) > (Also getting some plugin related errors now in Koha...) Ah, that's just because Docker has consumed all my VM's disk space... -- You are receiving

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #98 from David Cook --- (In reply to David Cook from comment #97) > I suppose we could define an emergency root logger within Koha::Logger... That worked in the event that the Log4perl config wasn't set up... but it

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #97 from David Cook --- If a category doesn't exist in the Log4perl config, Log4perl will just create a new logger that inherits from the root logger. We don't define a root logger, and the root logger by default has no

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #96 from David Cook --- Technically you could peek at $Log::Log4perl::Logger::LOGGERS_BY_NAME, but that's cheating and hacky... -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #95 from David Cook --- Actually, it's a bit of a hack... since we're telling the middleware to use the "plack-opac" category, but then we're checking for the "PLACKOPAC" appender. That relies on the log4perl config

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #94 from David Cook --- Annnd I think that I've solved it. Log::Log4perl::appender_by_name() is the key. Patch to follow... -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #93 from David Cook --- (In reply to David Cook from comment #86) > Based on the documentation from https://metacpan.org/pod/Log::Log4perl, I'd > say "get_logger($category)" would probably do the trick. Wow, that

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #92 from David Cook --- Updated /etc/koha/sites/kohadev/plack.psgi and now the middleware is working... And if I remove the log4perl config, the logs are lost as per Jonathan's earlier comment. -- You are receiving

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #91 from David Cook --- Ah because we now use /etc/koha/sites/kohadev/plack.psgi in koha-testing-docker... -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #90 from David Cook --- (In reply to David Cook from comment #89) > To Test: > 0) apt-get install libplack-middleware-logwarn-perl > 1) Apply all patches > 3) cp debian/templates/plack.psgi /etc/koha/plack.psgi > 4)

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #89 from David Cook --- To Test: 0) apt-get install libplack-middleware-logwarn-perl 1) Apply all patches 3) cp debian/templates/plack.psgi /etc/koha/plack.psgi 4) Temporarily add 'warn "TEST"' to opac-main.pl and

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #88 from David Cook --- The safest thing to do is to add the "Plack::Middleware::LogWarn" dependency, write up a wiki post about how to add timestamps and log separation, and link to the wiki post in the plack.psgi file.

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #87 from David Cook --- I notice that /usr/sbin/koha-plack refers to a possible "/etc/koha/sites/${instancename}/plack.psgi" That adds yet another layer of complexity. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #86 from David Cook --- (In reply to Joonas Kylmälä from comment #85) > To fail more verbosely during plack startup there would need to be a way in > Log4perl to check whether a logger category (e.g. "plack-opac") exists

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #85 from Joonas Kylmälä --- To fail more verbosely during plack startup there would need to be a way in Log4perl to check whether a logger category (e.g. "plack-opac") exists in the log4perl.conf file. I couldn't find

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #84 from Joonas Kylmälä --- Jonathan, I redid the postinst patch given it was not fully done, and switched to calling _init. For further details see the commit messages. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Joonas Kylmälä changed: What|Removed |Added Attachment #109060|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #83 from Joonas Kylmälä --- Created attachment 109068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109068=edit Bug 16357: (QA follow-up) Add log4perl configs during package upgrade If plack.psgi is

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Joonas Kylmälä changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #80 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #78) > (In reply to David Cook from comment #55) > > (In reply to Tomás Cohen Arazi from comment #37) > > > Question: shouldn't we take the oportunity

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #79 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #77) > (In reply to Jonathan Druart from comment #76) > > > Btw, I was thinking we don't need to modify even the log4perl.conf in > > > pre-existing

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #78 from Jonathan Druart --- (In reply to David Cook from comment #55) > (In reply to Tomás Cohen Arazi from comment #37) > > Question: shouldn't we take the oportunity to actually split the logs for > > each interace?

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #77 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #76) > > Btw, I was thinking we don't need to modify even the log4perl.conf in > > pre-existing installations given without the postinst script

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #76 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #74) > (In reply to Jonathan Druart from comment #72) > > In my understanding, following what was done before, we should add the new > > lines during

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #75 from Jonathan Druart --- > And, basically, I don't understand how this work. Can you explain a bit > more? I am confused by the Koha::Logger->get_logger call from .psgi Should not we actually replace

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Przemek Sztuczyński changed: What|Removed |Added CC|p.sztuczyn...@gmail.com | -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #74 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #72) > In my understanding, following what was done before, we should add the new > lines during postinst. > But here we also want to remove the

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #73 from Jonathan Druart --- (In reply to Jonathan Druart from comment #72) > In my understanding, following what was done before, we should add the new > lines during postinst. > But here we also want to remove the

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #72 from Jonathan Druart --- In my understanding, following what was done before, we should add the new lines during postinst. But here we also want to remove the existing "log4perl.logger.plack", right? -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #71 from Jonathan Druart --- Created attachment 109060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109060=edit Bug 16357: Add new lines during for debian postinst -- You are receiving this mail

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #70 from Joonas Kylmälä --- All looks good, also with debian package side of things. Ready for RM to merge. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #68 from Joonas Kylmälä --- Created attachment 109055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109055=edit Bug 16357: Use separate Log4Perl logger for each Plack app This patch creates separate

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #69 from Joonas Kylmälä --- Created attachment 109056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109056=edit Bug 16357: Plack error logs are not time stamped add libplack-middleware-logwarn-perl

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Joonas Kylmälä changed: What|Removed |Added Attachment #77529|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #66 from Mason James --- Created attachment 109053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109053=edit Bug 16357: Plack error logs are not time stamped add libplack-middleware-logwarn-perl

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #65 from Joonas Kylmälä --- (In reply to David Cook from comment #64) > Which patch set did you try? Your comment isn't clear. I tried to apply the patches from Jonathan, and then I thought incorrectly your alternative

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #64 from David Cook --- (In reply to Joonas Kylmälä from comment #63) > even if I apply the patches on top of the Koha version from the day the > patches were submitted I get: > > Applying: Bug 16357: (follow-up) Use

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-08-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #63

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-07-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #62 from David Cook --- (In reply to Jonathan Druart from comment #61) > In my understanding they are an alternative approach. QA will pick one or > the other. Yep, that was my intention when I wrote those [Alternative]

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-07-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #61 from Jonathan Druart --- In my understanding they are an alternative approach. QA will pick one or the other. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-07-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Katrin Fischer changed: What|Removed |Added Keywords||dependency -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Arthur Suzuki changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Arthur Suzuki changed: What|Removed |Added Attachment #106313|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Arthur Suzuki changed: What|Removed |Added Attachment #106141|0 |1 is obsolete|

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #56 from David Cook --- Created attachment 106313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106313=edit Bug 16357: [Alternative] Use separate Log4Perl logger for each Plack app This patch creates

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #55 from David Cook --- (In reply to Tomás Cohen Arazi from comment #37) > Question: shouldn't we take the oportunity to actually split the logs for > each interace? Agreed and achieved. Patch to follow. -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #54 from David Cook --- Forgot that I'd updated my log4perl.conf and plack.psgi in koha-testing-docker and now I have this fix when troubleshooting other issues. Awesome. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #53 from David Cook --- (In reply to Tomás Cohen Arazi from comment #37) > I didn't manage to make this work. Feedback and review from the authors is > needed. > Question: shouldn't we take the oportunity to actually

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Assignee|m...@kohaaloha.com |dc...@prosentient.com.au --

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #52 from David Cook --- Created attachment 106141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106141=edit Bug 16357: [Alternative] Override __WARN__ in Plack to use Log4Perl This patch overrides

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #51 from David Cook --- Ok I have a usable alternative. Patch incoming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #50 from David Cook --- Bug 16357 - Plack error logs are not time stamped 77529 - Bug 16357 - Plack error logs are not time stamped 77530 - Bug 16357 - Plack error logs are not time stamped (follow up) fix typo in

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #49 from David Cook --- It really doesn't look like we have many great options after reading through the following: https://metacpan.org/release/Plack/source/lib/Plack/App/CGIBin.pm

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #48 from David Cook --- Now that I'm using Plack more, this is seriously annoying me. I'll look a bit at a fix. I have some ideas. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #47 from Victor Grousset/tuxayo --- == Workaround == At a sysadmin level, something is doable using the "ts" command. https://www.reddit.com/r/linux/comments/fqiu6b/til_about_vipe/ > ts: timestamp standard input dirty

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #46 from David Cook --- I have some thoughts on this one. Firstly, why are we using Log::Log4perl::Appender::File at all? It doesn't make sense, unless you're going to be logging to custom files independent of your

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #45 from Liz Rea --- The "bad" perms, are the way that they are always created - if you delete the logs and re initialize them they come back that way. :D -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #44 from Liz Rea --- intranet error and opac error tho, those ones are created by apache, not plack. And those are the ones with the bad perms. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #43 from Tomás Cohen Arazi --- Plack logs should be generated by Plack, no Apache at all. And my guess at some point was that starman (or the koha-plack script runnning as root) was to blame for the permissions. -- You

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #42 from Liz Rea --- i forgot to put in the perms that work with this patch: vagrant@kohadevbox:kohadev$ ls -lha total 688K drwxr-xr-x 2 kohadev-koha kohadev-koha 4.0K Aug 30 14:50 . drwxr-xr-x 3 root root

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #41 from Liz Rea --- Ok, I've made this work again, and I followed my previous notes to get there with the addition of one detail by default, the log perms look like this: vagrant@kohadevbox:kohadev$ ls -lah total

[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Danielle Elder changed: What|Removed |Added CC|

  1   2   >