[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Martin Renvoize changed: What|Removed |Added QA

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #32 from Martin Renvoize --- So much as I'm an opponent of Koha::Objects (They still just feel like boilerplate for the point of boilerplate to me), I can't find anything desperately

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #30 from Martin Renvoize --- Created attachment 56652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56652=edit [PASSED QA] Bug 16965: [Follow-up] Adjust

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #29 from Martin Renvoize --- Created attachment 56651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56651=edit [PASSED QA] Bug 16965: search_related returns an

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #31 from Martin Renvoize --- Created attachment 56653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56653=edit [PASSED QA] Bug 16965: Allow Koha::Objects->result_class

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Martin Renvoize changed: What|Removed |Added Attachment #56372|0

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Martin Renvoize changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #27 from Martin Renvoize --- This is probably a conversation for elsewhere.. I'm going to pass qa on these for now to prevent a holdup in the queue and in the knowledge that we can fix

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #26 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #25) > So.. I'm mostly OK with these patches.. but I have a related question: > > What's the history around the continual

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #25 from Martin Renvoize --- So.. I'm mostly OK with these patches.. but I have a related question: What's the history around the continual regeneration of dbic result classes? My

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #24 from Jonathan Druart --- Created attachment 56375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56375=edit Bug 16965: Allow Koha::Objects->result_class

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #23 from Jonathan Druart --- Created attachment 56374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56374=edit Bug 16965: [Follow-up] Adjust get_object_class

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #22 from Jonathan Druart --- Created attachment 56373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56373=edit Bug 16965: search_related returns an

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Jonathan Druart changed: What|Removed |Added Attachment #56238|0

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56010|0 |1

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56009|0 |1

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56011|0 |1

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marc Véron changed: What|Removed |Added Attachment #53777|0 |1 is

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marc Véron changed: What|Removed |Added Attachment #53673|0 |1 is

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marc Véron changed: What|Removed |Added Attachment #53656|0 |1 is

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #14 from Jonathan Druart --- (In reply to Martin Renvoize from comment #13) > To be frank, I think someone needs to go back to basics with me and explain > why/what advantages

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #13 from Martin Renvoize --- To be frank, I think someone needs to go back to basics with me and explain why/what advantages Koha::Objects actually bring us above and beyond DBIx::Class..

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Mason James changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #11 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #10) > (In reply to Jonathan Druart from comment #8) > > Why did you make this change: > > -return

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > Why did you make this change: > -return $object_class->_wrap(@dbic_rows); > +return _wrap(

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #7) > Jonathan: What do you think of the approach in the third patch? I liked the idea to have the mappings

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #7 from Marcel de Rooy --- Jonathan: What do you think of the approach in the third patch? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #6 from Marcel de Rooy --- Created attachment 53777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53777=edit Bug 16965: [Follow-up] Adjust get_object_class In many cases it

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #5 from Jonathan Druart --- Created attachment 53673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53673=edit Bug 16965: search_related returns an

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > (In reply to Marcel de Rooy from comment #2) > > Shouldn't you wrap them like search does ? > > I don't think so: >

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #3 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #2) > Shouldn't you wrap them like search does ? I don't think so: "In list context, ->all() is called

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #1 from Jonathan Druart --- Created attachment 53656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53656=edit Bug 16965: Add Koha::Objects->search_related In

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Jonathan Druart changed: What|Removed |Added Depends on|