[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Katrin Fischer changed: What|Removed |Added Status|Pushed to Stable

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What|Removed |Added Attachment #63310|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What|Removed |Added Attachment #63309|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Bug 17944 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #55 from Jonathan Druart --- Created attachment 63310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63310=edit Bug 17944: QA follow-up - Remove an unused use

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Attachment #63307|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Attachment #63259|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #53 from Jonathan Druart --- Created attachment 63308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63308=edit Bug 17944: QA follow-up - Remove an unused use

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #63220|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #50 from Alex Buckley --- Created attachment 63259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63259=edit Bug 17944 - Removed SQl query from itemtypes.pl and replaced it

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #49 from Jonathan Druart --- Comment on attachment 63220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63220 Bug 17944 - Removed SQl query from itemtypes.pl

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #47 from Alex Buckley --- Created attachment 63220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63220=edit Bug 17944 - Removed SQl query from itemtypes.pl and replaced it

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #63152|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #45 from Jonathan Druart --- Alex, great! The patch is much better :) Indeed the return value of can_be_deleted should be 1 or 0. You can achieve that with: return $nb_items +

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #44 from Alex Buckley --- Hi Jonathan I have implemented the changes you suggested in a single patch for bug 17944. Because I have implemented the following return line (which you

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #43 from Alex Buckley --- Created attachment 63152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63152=edit Bug 17944 - Removed SQl query from itemtypes.pl and replaced it

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #63045|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #42 from Jonathan Druart --- Alex, Some additional remarks (we are aiming the perfect patch, right? :)) 1. The POD of the new method is incorrect, please adapt it. Note that a

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|BLOCKED

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62504|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #41 from Alex Buckley --- Created attachment 63045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63045=edit Bug 17944 - Overridden Koha::Object->delete with

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62505|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62503|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62500|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62502|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #40 from Alex Buckley --- (In reply to Jonathan Druart in comment 39) Hi Jonathan I have squashed all the bugs together locally and I have implemented a delete method in ItemType.pm to

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #39 from Jonathan Druart --- Alex, Please squash all the patches and resubmit, for readability ;) For the check, I think the best would be to override Koha::Object->delete from

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |BLOCKED

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #37 from Alex Buckley --- Created attachment 62505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62505=edit Bug 17944 -Integrated the removal of SQL from itemtypes.pl

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #35 from Alex Buckley --- Created attachment 62503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62503=edit Bug 17944 - Moved the DBIx code into the ItemType.pm file

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #36 from Alex Buckley --- Created attachment 62504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62504=edit Bug 17944 - Updates following second tester feedback Changed

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #34 from Alex Buckley --- Created attachment 62502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62502=edit Bug 17944 - Tidied the DBIx code in itemtypes.pl

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #62501|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #33 from Alex Buckley --- Created attachment 62501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62501=edit Bug 17944 - Tidied the DBIx code in itemtypes.pl

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #32 from Alex Buckley --- Created attachment 62500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62500=edit Bug 17944 - Removed the sql code from Itemtypes.pm Removed the

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #31 from Alex Buckley --- Created attachment 62499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62499=edit Bug 17944 - Moved the sql code from itemtypes.pl into

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #59656|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #59655|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #59657|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #59718|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #59953|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Attachment #59954|0

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #29 from Alex Buckley --- (In reply to Baptiste in comment 28) Ah sorry I see what the issue is I accidentally missed some steps in the test plan for this patch. The ItemTypes.t unit test

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Baptiste changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #26 from Alex Buckley --- Created attachment 59953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59953=edit Bug 17944 - Updates following second tester feedback Changed

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #27 from Alex Buckley --- Created attachment 59954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59954=edit Bug 17944 - Implemented a subtest in the ItemTypes.t file for

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Version|17.05

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #25 from Jonathan Druart --- (In reply to Alex Buckley from comment #22) > (in reply to Jonathan Druart in comment 21) > > 1/ What tests specifically do you want? When a

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #24 from Alex Buckley --- (in reply to Jonathan Druart in comment 21) Please disregard comment 22, I have fixed the strict refs error issue. In the commit I am currently working on I have

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #23 from Alex Buckley --- (in reply to Jonathan Druart in comment 21) 1/ Presumably you mean test plan rather than the output of a qa test? If so the test plan is slightly modified from

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What|Removed |Added Attachment #59715|0 |1

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #19 from Alex Buckley --- Created attachment 59717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59717=edit Bug 17944 - Added additional USE pragma -- You are receiving

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #18 from Alex Buckley --- Created attachment 59716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59716=edit Bug 17955 - removed incorrect function call -- You are

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #17 from M. Tompsett --- Comment on attachment 59715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59715 Bug 17944 - Moved the DBIx code into the ItemType.pm file Review of

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #16 from Alex Buckley --- Created attachment 59715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59715=edit Bug 17944 - Moved the DBIx code into the ItemType.pm file --

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What|Removed |Added Attachment #59564|0 |1

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What|Removed |Added Attachment #59391|0 |1

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What|Removed |Added Attachment #59565|0 |1

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #11 from Alex Buckley --- Created attachment 59565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59565=edit Bug 17944 - Tidied the DBIx code in itemtypes.pl -- You are

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #10 from M. Tompsett --- (In reply to Alex Buckley from comment #9) > So before I attach the new commit just to check would you be happy with this? Yes, and it is prettier. Thank you. :) -- You

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #9 from Alex Buckley --- So before I attach the new commit just to check would you be happy with this? my $schema = Koha::Database->new()->schema(); my $itemtotal =

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #8 from Alex Buckley --- I'll try implementing that now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |In

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #7 from M. Tompsett --- Comment on attachment 59564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59564 Bug 17944 - Removed the sql code from Itemtypes.pm and replaced it with

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #6 from Alex Buckley --- (in reply to comment 4 by M.tompsett) I have tried to implement DBIx in the itemtypes.pl script. To get it working successfully I had to implement two DBIx queries,

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #5 from Alex Buckley --- Created attachment 59564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59564=edit Bug 17944 - Removed the sql code from Itemtypes.pm and replaced

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #4 from M. Tompsett --- Comment on attachment 59391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59391 Bug 17944 - Moved the sql code from itemtypes.pl into Koha/ItemTypes.pm

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #2 from Alex Buckley --- Created attachment 59391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59391=edit Bug 17944 - Moved the sql code from itemtypes.pl into

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What|Removed |Added Summary|Remove the sql code from