[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Katrin Fischer changed: What|Removed |Added CC||sl...@duncanville.com ---

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #39 from Katrin Fischer --- I just tested this on master: * Checked out an item * Placed a hold on it for another user * Tried to renew it using the renewal tab * Got asked to override AllowRenewalOnHoldOverride and

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #38 from Martin Renvoize --- Is still relevant? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #36 from Liz Rea --- Created attachment 87529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87529=edit Bug 18450: (follow up) Fixed forbidden patterns for qa tool Sponsored-by: Catalyst IT

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Liz Rea changed: What|Removed |Added Attachment #87337|0 |1 is obsolete|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #34 from Hayley Mapley --- Created attachment 87338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87338=edit Bug 18450: (follow up) Fixed forbidden patterns for qa tool Sponsored-by: Catalyst IT --

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley changed: What|Removed |Added Attachment #86590|0 |1 is obsolete|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #32 from Hayley Mapley --- (In reply to Martin Renvoize from comment #31) > Did this get fixed somewhere else already.. looks like both patches are > applied but I can't seen any reference to them in the git logs. This

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |hayleymap...@catalyst.net.n

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #30 from Hayley Mapley --- Created attachment 86591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86591=edit Bug 18450: Mades changes for QA test tool and old code missed -- You are receiving this

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley changed: What|Removed |Added Attachment #86588|0 |1 is obsolete|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #28 from Hayley Mapley --- Created attachment 86589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86589=edit Bug 18450: Mades changes for QA test tool and old code missed -- You are receiving this

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley changed: What|Removed |Added Attachment #72835|0 |1 is obsolete|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #26 from Hayley Mapley --- Created attachment 86587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86587=edit Bug 18450: Mades changes for QA test tool and old code missed -- You are receiving this

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Niamh changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Nick Clemens changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #25 from Nick Clemens --- The second patch here confuses me - the if/elsif seem to generate the same button for either condition set? In the case of: NextAvailable hold on record with another

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 sandbo...@biblibre.com changed: What|Removed |Added Attachment #64402|0

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #24 from sandbo...@biblibre.com --- Created attachment 72836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72836=edit Bug 18450 - Followup - Implemented a conditional checking

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #23 from sandbo...@biblibre.com --- Created attachment 72835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72835=edit Bug 18450 - Implemented check in renew.tt for block and

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 sandbo...@biblibre.com changed: What|Removed |Added Attachment #69489|0

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 sandbo...@biblibre.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #21 from Alex Buckley --- Created attachment 69489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69489=edit Bug 18450 - Followup - Implemented a conditional checking if

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Attachment #69476|0

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #20 from Alex Buckley --- Created attachment 69476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69476=edit Bug 18450 - Followup - Implemented a conditional checking if

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Attachment #69475|0

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #19 from Alex Buckley --- Created attachment 69475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69475=edit Bug 18450 - Followup - Implemented 'IF A OR B OR C {stuff}" for

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Nick Clemens changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Lee Jamison changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Lee Jamison changed: What|Removed |Added Attachment #63764|0 |1

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #16 from Alex Buckley --- Hi Jonathan I have done what you asked in comment 14. Were you happy with the if statement logic in the renew.tt file being this: IF A AND B: Do the stuffs

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #15 from Alex Buckley --- Created attachment 63764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63764=edit Bug 18450 - Implemented check in renew.tt for block and renewal

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Attachment #63377|0

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Attachment #63293|0

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #12 from Alex Buckley --- Created attachment 63377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63377=edit Bug 18450 - Implemented check if either AllowRenewLimitOverride

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Attachment #63292|0

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #11 from Jonathan Druart --- If I do not misread the second patch, we have: IF NOT A AND B: Do stuff ELSIF A AND NOT B: Do the same stuff If that the case, we can simplify

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What|Removed |Added Attachment #63226|0 |1

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What|Removed |Added Attachment #62447|0 |1

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Attachment #62811|0

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #7 from Alex Buckley --- Created attachment 63226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63226=edit Bug 18450 - Implemented check if either AllowRenewLimitOverride

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #6 from Josef Moravec --- Comment on attachment 62811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62811 Bug 18450 - Implemented check if either AllowRenewLimitOverride or

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #5 from Alex Buckley --- Created attachment 62811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62811=edit Bug 18450 - Implemented check if either AllowRenewLimitOverride

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #4 from Christopher Brannon --- Test needs to be updated to include all combinations of these two settings. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Christopher Brannon changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Marc Véron changed: What|Removed |Added Attachment #62339|0 |1 is

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #1 from Alex Buckley --- Created attachment 62339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62339=edit Bug 18450 - Implemented a check to determine if the 'Override

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Lisette changed: What|Removed |Added CC|