https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Katrin Fischer changed:
What|Removed |Added
Resolution|---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #79 from Jonathan Druart
---
(In reply to Barton Chittenden from comment #77)
> (In reply to Jonathan Druart from comment #76)
> > (In reply to Katrin Fischer from comment #75)
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #78 from Katrin Fischer ---
(In reply to Barton Chittenden from comment #77)
> (In reply to Jonathan Druart from comment #76)
> > (In reply to Katrin Fischer from comment #75)
> > > Hm, but that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #77 from Barton Chittenden ---
(In reply to Jonathan Druart from comment #76)
> (In reply to Katrin Fischer from comment #75)
> > Hm, but that would mean that you can't check-in the book and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #76 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #75)
> Hm, but that would mean that you can't check-in the book and it remains on
> the patron account...?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #75 from Katrin Fischer ---
Hm, but that would mean that you can't check-in the book and it remains on the
patron account...?
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #74 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #73)
> But if we keep the transaction, we keep the renumbering...
No, we just prevent datalost. If the move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #73 from Katrin Fischer ---
But if we keep the transaction, we keep the renumbering...
I'd really feel better if we could figure out what happens in reports like
18963 and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
jmbroust changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #72 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #71)
> At this point, I am wondering if we shouldn't go as far as reverting bug
> 18242 and push massively
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #71 from Katrin Fischer ---
At this moment, I don't feel confident in this patch set to be the right fix.
- We will keep the state of constant renumbering. Once a MySQL restart has
caused the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #70 from Katrin Fischer ---
Created attachment 65134
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65134=edit
Screenshot of failed checkins
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #69 from Katrin Fischer ---
The race condition with the lock worries me. It happened pretty consistently
and often in my testing yesterday checking in with the checkboxes from the
patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #68 from Katrin Fischer ---
Rewriting the issue_ids seems like a dangerous thing - it fixes the problem,
but it only works because we are not heavily relying on it yet. I'd prefer to
keep it to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #67 from Jonathan Druart
---
I am not sure I will be able to provide something better before your next
release.
What you describe in 1) is the note I let on the last patch:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #66 from Katrin Fischer ---
I've tested the patches for 16.11.x, but I think this is still pretty
problematic:
1) Unable to check-in more than one problematic issue at once
- Check out some
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #65 from Jonathan Druart
---
(In reply to Barton Chittenden from comment #10)
> I suspect that the right thing to do might be to use the mysql --init-file
> option to run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #64 from Katrin Fischer ---
Thx a lot, I will try to test ASAP. If someone wants to help and test against
16.11.x too, that would be much appreciated. Hope we can fix this for good.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #63 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #61)
> I have massive problems making this work with 16.11.x - starting with the
> Return.t tests. And now
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
David Kuhn changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #62 from Katrin Fischer ---
Also: unable to check in.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #61 from Katrin Fischer ---
I have massive problems making this work with 16.11.x - starting with the
Return.t tests. And now an error in Circulation.pm. I think I am missing
dependencies for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Fridolin SOMERS changed:
What|Removed |Added
Status|Pushed to Master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Fridolin SOMERS changed:
What|Removed |Added
Patch complexity|---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #58 from Jonathan Druart
---
(In reply to DEVINIM from comment #55)
> (In reply to Marcel de Rooy from comment #54)
> > (In reply to DEVINIM from comment #53)
> > >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #57 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #56)
> Created attachment 64495 [details] [review]
> Bug 18651: Do no LOCK/UNLOCK the table
Pushed to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Attachment #64490|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Attachment #64455|1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #56 from Jonathan Druart
---
Created attachment 64495
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64495=edit
Bug 18651: Do no LOCK/UNLOCK the table
We
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
DEVINIM changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #54 from Marcel de Rooy ---
(In reply to DEVINIM from comment #53)
> Created attachment 64490 [details] [review]
> Bug 18651: [QA Follow-up] Fix the MAX(issue_id) calculation
>
> Found this by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
DEVINIM changed:
What|Removed |Added
Attachment #64455|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #52 from Jonathan Druart
---
Last patch pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #51 from Jonathan Druart
---
Created attachment 64489
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64489=edit
Bug 18651: Fix tests if no circ rule exist
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #50 from Jonathan Druart
---
The following test is failing on Jenkins:
# Subtest: Handle ids duplication
1..4
ok 1 - No account lines should exist on old issue_id
not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #47 from Marcel de Rooy ---
Created attachment 64454
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64454=edit
Bug 18651: [QA Follow-up] Remove unused variable
Variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Attachment #64399|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #48 from Marcel de Rooy ---
Created attachment 64455
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64455=edit
Bug 18651: [QA Follow-up] Fix the MAX(issue_id) calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Attachment #64397|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Attachment #64398|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Attachment #64396|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Attachment #64395|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Attachment #64394|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #39 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #38)
> Will have another look today
QA: Resuming here now
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #38 from Marcel de Rooy ---
Will have another look today
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Severity|critical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #36 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #29)
> Generally looks good. But still some things:
>
> Patch 4 seems to be just for debugging purposes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #35 from Jonathan Druart
---
Created attachment 64399
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64399=edit
Bug 18651: Limit the life span of the LOCK
We
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #32 from Jonathan Druart
---
Created attachment 64396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64396=edit
Bug 18651: Update accountlines.issue_id is the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #33 from Jonathan Druart
---
Created attachment 64397
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64397=edit
Bug 18651: Copy the row before modify the id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #34 from Jonathan Druart
---
Created attachment 64398
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64398=edit
Bug 18651: Use a READ and WRITE LOCK
For more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #31 from Jonathan Druart
---
Created attachment 64395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64395=edit
Bug 18651: Do not charge if the checkin failed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Attachment #64352|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #28 from Marcel de Rooy ---
QA: Looking here now
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Chris Cormack changed:
What|Removed |Added
Attachment #63706|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Chris Cormack changed:
What|Removed |Added
Attachment #63637|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Chris Cormack changed:
What|Removed |Added
Attachment #63659|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Chris Cormack changed:
What|Removed |Added
Attachment #63636|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Chris Cormack changed:
What|Removed |Added
Attachment #63635|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Chris Cormack changed:
What|Removed |Added
Attachment #63634|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #21 from Jonathan Druart
---
(In reply to Dilan Johnpullé from comment #20)
> Is there a test plan for this?
No, there is no test plan to follow-up step-by-step. You will need
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marcel de Rooy changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
di...@calyx.net.au changed:
What|Removed |Added
CC||di...@calyx.net.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Severity|major
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #18 from Jonathan Druart
---
Created attachment 63706
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63706=edit
Bug 18651: Use a READ and WRITE LOCK
For more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #17 from Jonathan Druart
---
I have messed up the example. I reattached the patch amending the commit
message.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Attachment #63654|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #15 from Kyle M Hall ---
Comment on attachment 63654
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63654
Bug 18651: Copy the row before modify the id
Review of attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Barton Chittenden changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #14 from Kyle M Hall ---
I like the solution. Correct me if I'm wrong, but we still aren't correcting
the auto_increment value for issue_id. This effectively *does* create a race
condition if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #13 from Jonathan Druart
---
Created attachment 63654
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63654=edit
Bug 18651: Copy the row before modify the id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Kyle M Hall changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Colin Campbell changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Mason James changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Barton Chittenden changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Tomás Cohen Arazi changed:
What|Removed |Added
Version|unspecified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #9 from Kyle M Hall ---
Created attachment 63637
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63637=edit
DEBUG patches: I'd like feedback
Check what the debug statement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #8 from Kyle M Hall ---
Created attachment 63636
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63636=edit
Bug 18651: Update accountlines.issue_id is the issue_id has been
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #7 from Kyle M Hall ---
Created attachment 63635
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63635=edit
Bug 18651: Do not charge if the checkin failed
2. If the move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Kyle M Hall changed:
What|Removed |Added
Attachment #63633|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Kyle M Hall changed:
What|Removed |Added
Attachment #63629|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Nick Clemens changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #4 from Jonathan Druart
---
Created attachment 63632
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63632=edit
DEBUG patches: I'd like feedback
Check what the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #1 from Jonathan Druart
---
Created attachment 63629
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63629=edit
Bug 18651: Update issue_id in AddReturn
1.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #3 from Jonathan Druart
---
Created attachment 63631
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63631=edit
Bug 18651: Update accountlines.issue_id is the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651
--- Comment #2 from Jonathan Druart
---
Created attachment 63630
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63630=edit
Bug 18651: Do not charge if the checkin failed
100 matches
Mail list logo