[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #38 from Marcel de Rooy --- is_waiting_or_transit ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #37 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #17) > is_found is also a bit confusing, because this also includes transit items. Yes, confirming it again.

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #36 from Marcel de Rooy --- This is a quick fix, the other point mentioned in earlier comments should go on a new enhancement. Why not add it to 18.05 still, Joubu ? -- You are receiving this

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #35 from Marcel de Rooy --- Created attachment 75395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75395=edit Bug 18856: (QA follow-up) Rename method to avoid confusion

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What|Removed |Added Attachment #70424|0

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #33 from Hugh Rundle --- If I am understanding correctly what the patch does (removes the cancel button from allocated holds), then yes, it qualifies as a quick fix. -- You are receiving this

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #32 from Jonathan Druart --- What's wrong with the patches, could they be considered ok as a quick fix? -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #31 from Hugh Rundle --- +1 on a quick fix, current behaviour is baffling to patrons. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #30 from Katrin Fischer --- We have another library complaining about this :( I think at the moment, we just need a quick fix that doesn't appear broken to the patron. -- You are receiving

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #29 from Katrin Fischer --- I agree with Hugh and Liz that we might want to rethink the policy of not allowing patrons to cancel waiting holds, but think the fix might need a bit more thought.

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #28 from Hugh Rundle --- I like Liz's suggested way of dealing with it. On the topic of alerts, there is a related problem in that the holds cancellation alert is quite confusing anyway,

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Liz Rea changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Hugh Rundle changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Juan Romay Sieira changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Margaret changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #23 from Barton Chittenden --- (In reply to Marcel de Rooy from comment #21) > (In reply to Jonathan Druart from comment #16) > > Yes Barton you are right, that's why I added a comment to the

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #22 from Katrin Fischer --- You are absolutely right, Marcel. Tired brain. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #21 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > Yes Barton you are right, that's why I added a comment to the POD of the > method to tell it only applies for the

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #20 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #17) > is_found is also a bit confusing, because this also includes transit items. > found = F in the reserves table is for

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #19 from Kyle M Hall --- Created attachment 70425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70425=edit Bug 18856 [QA Followup] - Rename method to avoid confusion

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added Attachment #70398|0 |1

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Axelle Aix-Marseille Université changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #17 from Katrin Fischer --- is_found is also a bit confusing, because this also includes transit items. found = F in the reserves table is for waiting. So you might not think about the transit

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #16 from Jonathan Druart --- Yes Barton you are right, that's why I added a comment to the POD of the method to tell it only applies for the OPAC. Maybe rename the method to

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart changed: What|Removed |Added Attachment #70398|1

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #15 from Barton Chittenden --- (In reply to Jonathan Druart from comment #14) > Kyle, Katrin and Marcel, could you take a look at this l > ast patch? > It sounds better to me to keep the

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart changed: What|Removed |Added Attachment #70398|0

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer changed: What|Removed |Added Attachment #69077|0

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer changed: What|Removed |Added Attachment #70294|0

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #12 from Katrin Fischer --- Created attachment 70399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70399=edit Bug 18856: (follow-up) Catch missed instance of is_cancelable

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #11 from Katrin Fischer --- Created attachment 70398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70398=edit Bug 18856: Don't show cancel option for waiting holds in OPAC

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #9 from Kyle M Hall --- Created attachment 70294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70294=edit Bug 18856 [QA Followup] - Catch missed instance of is_cancelable

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jessie Zairo changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What|Removed |Added Version|16.11

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What|Removed |Added Attachment #67520|0

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added Attachment #67480|0 |1

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #3 from Kyle M Hall --- Created attachment 67480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67480=edit Bug 18856 - Cancel Waiting Hold in OPAC does not give useful

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #2 from Katrin Fischer --- I did some digging and it looks like there should be no button when the hold is waiting or in transfer already. (see bug 12876) -- You are receiving this mail

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Barton Chittenden changed: What|Removed |Added CC|