https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Bug 19489 depends on bug 22006, which changed state.
Bug 22006 Summary: Koha::Account::Line->item should return undef if no item
linked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22006
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Nick Clemens changed:
What|Removed |Added
Attachment #83299|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #26 from Jonathan Druart
---
I have updated the commit message, re-added the test plan and submitted a
follow-up to cover the non-existing issue case.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Jonathan Druart changed:
What|Removed |Added
Assignee|je...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Jonathan Druart changed:
What|Removed |Added
Attachment #83109|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #25 from Jonathan Druart
---
Created attachment 83301
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83301=edit
Bug 19489: Cover non-existent issue
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #24 from Jonathan Druart
---
Created attachment 83300
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83300=edit
Bug 19489: Development for fines and Fees Module - Detailed Description of
charges in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Attachment #83276|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Attachment #83110|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #20 from Jonathan Druart
---
Created attachment 83242
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83242=edit
Bug 19489: Simplify the code a bit
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Jonathan Druart changed:
What|Removed |Added
Depends on||22006
--- Comment #19
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #18 from Devinim ---
(In reply to Jonathan Druart from comment #16)
> 2. As well, the html filter is not needed when already KohaDates filtered.
>
> 3. in printinvoice.pl
>
> +$accountline->{'item'} =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #17 from Devinim ---
(In reply to Jonathan Druart from comment #15)
> due_date must be displayed with the as_due_date flag, not with_hours:
>
> [% your_due_date | $KohaDates as_due_date => 1 %]
Hi Jonathan,
In order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #16 from Jonathan Druart
---
2. As well, the html filter is not needed when already KohaDates filtered.
3. in printinvoice.pl
+$accountline->{'item'} = $accountline->{itemnumber} ?
$accountline_object->item : "" ;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Nick Clemens changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Nick Clemens changed:
What|Removed |Added
Attachment #82614|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #14 from Nick Clemens ---
Created attachment 83110
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83110=edit
Bug 19489: Development for fines and Fees Module
Signed-off-by: Nick Clemens
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Attachment #82615|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #11 from Devinim ---
(In reply to Owen Leonard from comment #9)
> This seems to be working, but the test doesn't pass:
>
> t/db_dependent/Koha/Account/Lines.t .. 1/5
> # Failed test 'No tests run for subtest "item()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #10 from Devinim ---
Hi Owen,
It is most probably another patch made it this since we've tested before
sending patches and unit tests.
Our developers is looking once again, will change it soon.
Thanks a lot.
Devinim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Blocks||21879
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #8 from Devinim ---
Created attachment 82615
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82615=edit
Bug 19489: Development for fines and Fees Module
Test plan:
1) Apply this patch
2) Choose a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Attachment #82520|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Attachment #82519|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Attachment #81991|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Attachment #81956|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #3 from Devinim ---
Created attachment 81989
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81989=edit
(Object method) Development for fines and Fees Module - Detailed Description of
charges in Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #2 from Nick Clemens ---
Comment on attachment 81956
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81956
Bug 19489 - Development for fines and Fees Module - Detailed Description of
charges in Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Sally Healey changed:
What|Removed |Added
CC||sally.healey@cheshireshared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Devinim changed:
What|Removed |Added
Status|NEW |Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
--- Comment #1 from Devinim ---
Created attachment 81956
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81956=edit
Bug 19489 - Development for fines and Fees Module - Detailed Description of
charges in Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Indranil Das Gupta changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489
Indranil Das Gupta changed:
What|Removed |Added
CC||indr...@l2c2.co.in
--
39 matches
Mail list logo
