https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #288 from Christopher Brannon ---
So let me ask this.
Instead of trying to overhaul the existing deletion tables, would it be easier
to try to insert an option between - as a starting point?
So, instead of doing away
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Katie Bliss changed:
What|Removed |Added
CC||kebl...@dmpl.org
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Emily Lamancusa changed:
What|Removed |Added
Blocks|10758 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Marcel de Rooy changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Cab Vinton changed:
What|Removed |Added
CC||bibli...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #286 from Victor Grousset/tuxayo ---
The problem is not to test the concept of delete flagging. The patches on this
ticket well demonstrated that.
Even without that already done, not sure that was ever a question. The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #285 from Christopher Brannon ---
No, but if you want to start small, and at least do a proof of concept, you
might try out the delete flagging technique on something that doesn't have a
delete table, then if that goes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #284 from Katrin Fischer ---
(In reply to Christopher Brannon from comment #283)
> (In reply to Marcel de Rooy from comment #282)
> > When reviving this one, it might be wise to do it one by one table instead?
>
> If
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #283 from Christopher Brannon ---
(In reply to Marcel de Rooy from comment #282)
> When reviving this one, it might be wise to do it one by one table instead?
If doing it table by table would help move it along, I would
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #282 from Marcel de Rooy ---
When reviving this one, it might be wise to do it one by one table instead?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Dave changed:
What|Removed |Added
CC||ddagh...@mckinneytexas.org
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #281 from Katrin Fischer ---
Securing funding is one part, but the other part is to come to a decision as
community about these change and ensure that there will be enough
time/committment to see it through, if it's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #280 from Christopher Brannon ---
(In reply to Victor Grousset/tuxayo from comment #279)
> > Is this at a place for testing, or does more work need to be done?
>
> Testing became impossible after a few weeks after the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #279 from Victor Grousset/tuxayo ---
> Is this at a place for testing, or does more work need to be done?
Testing became impossible after a few weeks after the last code update long
ago.
It needs a really big work to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Emily Lamancusa changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Barbara Johnson changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Christopher Brannon changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #278 from Christopher Brannon ---
Is this at a place for testing, or does more work need to be done? If there
are funding issues, please let us know what funds are needed.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #277 from Rhonda Kuiper ---
Adding my support for this enhancement. Hope we can get it moving again.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
mathieu saby changed:
What|Removed |Added
CC||mathsaby...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Michaela Sieber changed:
What|Removed |Added
CC||michaela.sie...@kit.edu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Rebecca Coert changed:
What|Removed |Added
CC||rco...@arlingtonva.us
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
koha-US bug tracker changed:
What|Removed |Added
CC||bugzi...@koha-us.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #276 from Christopher Brannon ---
(In reply to Victor Grousset/tuxayo from comment #275)
> If I recall correctly testing was most of what this patch needed.
> To check if stuff was broken in many parts of Koha.
> At the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #275 from Victor Grousset/tuxayo ---
If I recall correctly testing was most of what this patch needed.
To check if stuff was broken in many parts of Koha.
At the time, it was possible to test it (except crons) using the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #274 from Christopher Brannon ---
What would it mean to have many people focus on it? Previously you asked for
more eyes and feedback. I'm not setup to get into the development side of
things, but if there is anything
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #273 from Jonathan Druart ---
The best hope is to find people to focus on it at the same time. Having someone
to rebase it is not enough, I have rebased it and adjusted it dozens of times
already.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #272 from Victor Grousset/tuxayo ---
At this point the best hope would be for a few user libraries to pool funding
together and contract a support company to revive this.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
AspenCat Team changed:
What|Removed |Added
CC||aspencatt...@clicweb.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Michael Adamyk changed:
What|Removed |Added
CC||mada...@ckls.org
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Christopher Brannon changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Charles Kelley changed:
What|Removed |Added
CC||cmkelley...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Emmi Takkinen changed:
What|Removed |Added
CC||emmi.takki...@koha-suomi.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Martin Renvoize changed:
What|Removed |Added
Blocks|11983 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
rkui...@roundrocktexas.gov changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Andrew Fuerste-Henry changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Jonathan Druart changed:
What|Removed |Added
Assignee|jonathan.dru...@bugs.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #267 from Jonathan Druart
---
Remote branch has been rebased against master, few tweaks made:
* new commit "Bug 20271: Fix - is_current is nullable"
* Only 1 "DBIC changes" commit and a separate "Declare is_current as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #266 from David Cook ---
(In reply to Jonathan Druart from comment #264)
> (In reply to Nick Clemens from comment #261)
> > Maybe it is too late to ask this question: Rather than joining items and
> > deleteditems, can
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Margaret changed:
What|Removed |Added
CC||margaret@bywatersolutions.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #265 from Jonathan Druart
---
New commits are:
Bug 20271: Prevent cover image to be attached to a deleted record
Bug 20271: Prevent biblio to be modified in batch
Bug 20271: Prevent marked as deleted items to be added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #264 from Jonathan Druart
---
(In reply to Nick Clemens from comment #260)
> (In reply to Jonathan Druart from comment #259)
> > Patches have been rebased against master.
>
> Looking here:
> 1 - Foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #263 from Jonathan Druart
---
(In reply to Nick Clemens from comment #260)
> (In reply to Jonathan Druart from comment #259)
> > Patches have been rebased against master.
>
> Looking here:
> 1 - Foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Tomáš Wünsch changed:
What|Removed |Added
CC||frak...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #262 from David Cook ---
(In reply to Nick Clemens from comment #261)
> Maybe it is too late to ask this question: Rather than joining items and
> deleteditems, can we join them into a new table and provide views for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #261
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #260 from Nick Clemens ---
(In reply to Jonathan Druart from comment #259)
> Patches have been rebased against master.
Looking here:
1 - Foreign key constraints on items table 'ON DELETE' updates are affected
here - for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #259 from Jonathan Druart
---
Patches have been rebased against master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Jonathan Druart changed:
What|Removed |Added
Blocks|26080 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #258 from Jonathan Druart
---
(In reply to Victor Grousset/tuxayo from comment #256)
> Bug found: OPAC results lists deleted items
>
> - delete items from a record
> - do a search that returns the record among other
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #257 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #255)
> Should be fixed now by "Bug 20271: Handle items marked as deleted in the
> circ module"
Confirmed :)
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #256 from Victor Grousset/tuxayo ---
Bug found: OPAC results lists deleted items
- delete items from a record
- do a search that returns the record among other ones
- in the results you should see «Items available for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #255 from Jonathan Druart
---
(In reply to Victor Grousset/tuxayo from comment #253)
> Bug found: it's possible to check out a deleted item.
> - find a record
> - copy the barcode of an item
> - delete it
> - check it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #254 from Victor Grousset/tuxayo ---
(In reply to Katrin Fischer from comment #252)
> (In reply to Victor Grousset/tuxayo from comment #251)
> > Does anyone know something worth to test with UNIMARC?
>
> Not UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #253 from Victor Grousset/tuxayo ---
Bug found: it's possible to check out a deleted item.
- find a record
- copy the barcode of an item
- delete it
- check it out
- it works :o
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #252 from Katrin Fischer ---
(In reply to Victor Grousset/tuxayo from comment #251)
> Does anyone know something worth to test with UNIMARC?
Not UNIMARC specific, but did you see:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #251 from Victor Grousset/tuxayo ---
Does anyone know something worth to test with UNIMARC?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #250 from Victor Grousset/tuxayo ---
For what it's worth. Nothing suspicious found after rereading the whole diff.
Also, deleted an item when using ES and restored it manually via the DB.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #249 from Victor Grousset/tuxayo ---
Potentially incorrect remaining occurrences of the old tables:
misc/cronjobs/cleanup_database.pl
> (from tables deleteditems, deletedbiblioitems, deletedbiblio_metadata and
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Jonathan Druart changed:
What|Removed |Added
Blocks||26080
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #248 from Jonathan Druart
---
All Koha gitlab projects have this problem (because of the size). I will deal
with that in the next couple of months. The remote branch is up-to-date however
;)
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #247 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #246)
> (In reply to Marcel de Rooy from comment #245)
> > fatal: repository 'https://gitlab.com/joubu/Koha/commits/bug_20271/' not
> > found
> > ??
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #246 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #245)
> fatal: repository 'https://gitlab.com/joubu/Koha/commits/bug_20271/' not
> found
> ??
When do you get this error?
% git remote add joubu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #245 from Marcel de Rooy ---
fatal: repository 'https://gitlab.com/joubu/Koha/commits/bug_20271/' not found
??
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #244 from Jonathan Druart
---
(In reply to Victor Grousset/tuxayo from comment #242)
> From what I understand cleanup_database.pl (and maybe other things) still
> rely on the original table names, so with the patchset,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #243 from Jonathan Druart
---
The failure from t/db_dependent/Items.t should be fixed by bug 25964.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #242 from Victor Grousset/tuxayo ---
From what I understand cleanup_database.pl (and maybe other things) still rely
on the original table names, so with the patchset, the views.
It would be in a follow up to use the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #241 from Victor Grousset/tuxayo ---
with koha-testing-docker (images up to date, including DB and ES)
Debian 9 with MariaDB 10.1
Debian 10 with MariaDB 10.3 (and ES 6 in case that matters)
prove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #240 from Martin Renvoize ---
Tomas and I have been discussing the possibilities to rename the tables here so
we can reuse the current table names for the views and thus nicely sidestep the
reports challenges.
I didn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #239 from Victor Grousset/tuxayo ---
> is there a way to disable the output
Found. The declarations of the views can be found with `git grep
"ResultSource::View"`
Beside from me removing them now to check for other
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #238 from Victor Grousset/tuxayo ---
When running the tests, is there a way to disable the output of «running
"CREATE VIEW "items_legacy"» ?
There are more than 100 of those outputs when running the tests.
I commented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #237 from Victor Grousset/tuxayo ---
Reran the tests (branch joubu/Koha/commits/bug_20271), the issues of comment
219 are gone.
New failing test:
kohadev-koha@50ed3ff6e267:/kohadevbox/koha$ prove t/db_dependent/Items.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Jonathan Druart changed:
What|Removed |Added
Blocks||25921
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #236 from Jonathan Druart
---
Thanks Martin, I've cherry-picked your 2 QA follow-ups and added your stamp on
the whole stack!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #235 from Martin Renvoize ---
I've added a couple of additional followups with fixes to minor issues I
found.. generally it's looking great, performs well and I've not found any
regressions.
I'm not 100% sure about the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #233 from Martin Renvoize ---
My turn, thanks for leading the way Tomas.. I'm taking over and giving it my
once over.. :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #234 from Jonathan Druart
---
Remote branch updated. Tomas's signed-off-by lines have been added.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #232 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #231)
> Tomas, I cherry-picked 2 of your patches and added a commit to fix the
> atomic update process bug you reported me (pm)
I tested your
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #231 from Jonathan Druart
---
Tomas, I cherry-picked 2 of your patches and added a commit to fix the atomic
update process bug you reported me (pm)
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #230 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #229)
> I don't think items is an exception, and so I don't think biblio should have
> another naming.
>
> For instance (as noted in comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #229 from Jonathan Druart
---
I don't think items is an exception, and so I don't think biblio should have
another naming.
For instance (as noted in comment 198):
"""As we are going to face this situation for some
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #228 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #227)
> (In reply to Tomás Cohen Arazi from comment #226)
> > (In reply to Jonathan Druart from comment #225)
> > > Tomas, with your patches we now
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #227 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #226)
> (In reply to Jonathan Druart from comment #225)
> > Tomas, with your patches we now have:
> > biblio.deleted_on, biblio.deleted
> > and
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #226 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #225)
> Tomas, with your patches we now have:
> biblio.deleted_on, biblio.deleted
> and
> items.deleted_on, items.is_current
> I think it's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #225 from Jonathan Druart
---
Tomas, with your patches we now have:
biblio.deleted_on, biblio.deleted
and
items.deleted_on, items.is_current
I think it's confusing.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #222 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #220)
> Ok, I tested all I could find and added a couple follow-ups for the API
> (tests and spec).
Hi Tomas, can you explain a bit more so people
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #221 from Tomás Cohen Arazi ---
My SO branch with the follow-up commits:
https://gitlab.com/thekesolutions/Koha/-/commits/qa_20271
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Alexander Borkowski changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Jonathan Druart changed:
What|Removed |Added
Severity|major |enhancement
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Jonathan Druart changed:
What|Removed |Added
Patch complexity|Medium patch|Large patch
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #218 from Jonathan Druart
---
I rebased the remote branch against master and added the view for backward
compatibility.
biblio_legacy
items_legacy
biblioitems_legacy
biblio_metadata_legacy
deletedbiblio
1 - 100 of 240 matches
Mail list logo
