[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #46 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #45 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #43) > Signed-off-by: Katrin Fischer Thanks ! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Katrin Fischer changed: What|Removed |Added Attachment #107419|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Katrin Fischer changed: What|Removed |Added Attachment #107418|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Katrin Fischer changed: What|Removed |Added Attachment #107417|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #44 from Katrin Fischer --- Nice clean patch. Something similar would be really nice for the item search results. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #40 from Jonathan Druart --- Thanks Marcel, the patches look great now! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #38 from Marcel de Rooy --- Created attachment 107418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107418=edit Bug 20469: Remove effective parameter Test plan: Run test Koha/Item.t again

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #107413|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #107412|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Blocks||20472 Referenced Bugs:

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #36 from Jonathan Druart --- I'd remove the effective param, I don't see a case where we would not need it, effective_itemtype will always return the correct value (depending on the pref) -- You are receiving this

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #107235|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #35 from Marcel de Rooy --- Created attachment 107413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107413=edit Bug 20469: Add item status to staff article request form The template checks if an item

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #33 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #32) > Would not it be better to introduce Koha::Item->itemtype that would return a > Koha::ItemType object? Yes, good idea. -- You are receiving

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #32 from Jonathan Druart --- Would not it be better to introduce Koha::Item->itemtype that would return a Koha::ItemType object? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #30 from Marcel de Rooy --- Created attachment 107236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107236=edit Bug 20469: Add test for ItemTypes plugin Test plan: Run the test. Signed-off-by:

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #77184|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added Depends on|11983 |

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #27 from Marcel de Rooy --- This got stuck two years ago on a discussion on another report that did not get further either. And now what? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Bug 20469 depends on bug 20468, which changed state. Bug 20468 Summary: Multiselect on staff article requests form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 What|Removed

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #26 from Martin Renvoize --- https://wiki.koha-community.org/wiki/Koha_Objects#Subclassing_Koha::Object_and_Object_.22factories.22 for guidance around the sort of thing I'm thinking. -- You are receiving this mail

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #25 from Martin Renvoize --- This feels like it doesn't fit in either Koha::Items or Koha::Holds to me and rather, as per my suggestion in bug 11983 comment 8

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #24 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #23) > (In reply to Jonathan Druart from comment #22) > > The "correct" way to do it (regarding the discussion on bug 11983) would be: > > > >

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Depends on||11983 Referenced Bugs:

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #23 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #22) > The "correct" way to do it (regarding the discussion on bug 11983) would be: > > $patron->holds->filter_by_in_transit->filter_by_waiting >

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #77184|1 |0 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #21 from Marcel de Rooy --- Other candidates for a future change? C4/Items.pm:WHERE (found = 'W' OR found = 'T') C4/Members.pm:my $waiting_holds = $patron->holds->search({ found => 'W' });

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #20 from Marcel de Rooy --- Core change is now: +sub has_waiting_or_transit_hold { +my ( $self ) = @_; +my $rs = $self->_result->reserves; +return Koha::Holds->_new_from_dbic($rs)->waiting_or_transit->count;

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #19 from Marcel de Rooy --- Created attachment 77224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77224=edit Bug 20469: (follow-up) Make translation of status possible As Mark noticed, adding a span

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #17 from Marcel de Rooy --- Created attachment 77222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77222=edit Bug 20469: (follow-up) Add Koha::Holds->waiting_or_transit Adding this variant next to

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #77184|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Keywords|NeedsMoreQA | -- You are receiving

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #16

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #15 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > Why do you return an empty string instead of "0"? > IMO we should return ->count, and use the DBIC rs. > > I will provide a patch and you will

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added Keywords||NeedsMoreQA --- Comment

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added Attachment #76630|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #13 from Jonathan Druart --- Created attachment 77186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77186=edit Bug 20469: Use DBIC rs and return ->count -- You are receiving this mail because: You

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #12 from Jonathan Druart --- Created attachment 77185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77185=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #9 from Owen Leonard --- Created attachment 76631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76631=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a span

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Owen Leonard changed: What|Removed |Added Attachment #76627|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #73282|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #73388|0 |1 is obsolete|

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #5 from Marcel de Rooy --- Created attachment 73388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73388=edit Bug 20469: (Follow-up) Make translation of status possible As

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #4 from Marcel de Rooy --- (In reply to M. Tompsett from comment #3) > Comment on attachment 73282 [details] [review] > Bug 20469: Add item status to staff article request form > > Review of

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #3 from M. Tompsett --- Comment on attachment 73282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73282 Bug 20469: Add item status to staff article request form Review of

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Attachment #73281|0

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #1 from Marcel de Rooy --- Created attachment 73281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73281=edit Bug 20469: Add item status to staff article request form -- You

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Depends on|