[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86407|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86408|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #21 from Martin Renvoize --- Created attachment 86408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86408=edit Bug 22483: Restore svc/members/search This script used to pass 'undef' to haspermission,

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #20 from Martin Renvoize --- Created attachment 86407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86407=edit Bug 22483: Restore exact behaviour of undef Passing undef (or nothing) as $flagsrequired

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Pierre-Marc Thibault changed: What|Removed |Added CC|pierre-marc.thibault@inlibr |

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #19 from Jonathan Druart --- (In reply to Martin Renvoize from comment #0) > This functionality was in use in two places. /svc/members/search and > /Koha/REST/V1/Auth.pm. About /svc/members/search: at first glance I

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #18 from Jonathan Druart --- 2087 return 1 unless defined($flagsrequired); # This is horrifying but restores behaviour prior to bug 22031 Are you sure about that? I do not see any situations where is returned 1

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Pierre-Marc Thibault changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86394|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86392|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86395|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86390|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86391|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86393|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #12 from Kyle M Hall --- Created attachment 86394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86394=edit Bug 22483: (follow-up) Fix wrong tests higlighted by bug Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #13 from Kyle M Hall --- Created attachment 86395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86395=edit Bug 22483: Restore undef behaviour Turns out that we rely heavily on the side effect that

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #11 from Kyle M Hall --- Created attachment 86393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86393=edit Bug 22483: (QA follow-up) Tweaking call to haspermission This patch tweaks the logic to

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #10 from Kyle M Hall --- Created attachment 86392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86392=edit Bug 22483: (QA follow-up) Corrections to logic in check_cookie_auth check_cookie_auth needs

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #9 from Kyle M Hall --- Created attachment 86391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86391=edit Bug 22483: (follow-up) Improve POD as requested in bug 22031 Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Kyle M Hall changed: What|Removed |Added Attachment #86379|0 |1 is obsolete|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #7 from Martin Renvoize --- Created attachment 86389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86389=edit Bug 22483: Restore undef behaviour Turns out that we rely heavily on the side effect that

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 86388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86388=edit Bug 22483: (follow-up) Fix wrong tests higlighted by bug Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #5 from Martin Renvoize --- Created attachment 86386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86386=edit Bug 22483: (QA follow-up) Tweaking call to haspermission This patch tweaks the logic to

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #4

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #3 from Martin Renvoize --- Created attachment 86385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86385=edit Bug 22483: (QA follow-up) Corrections to logic in check_cookie_auth check_cookie_auth

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #2 from Martin Renvoize --- Created attachment 86380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86380=edit Bug 22483: (follow-up) Improve POD as requested in bug 22031 Signed-off-by: Martin

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #1 from Martin Renvoize --- Created attachment 86379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86379=edit Bug 22483: Explicitly ban 'undef' as a valid $flagsrequired Before bug 22031 the

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added Depends on||22031 Referenced Bugs:

[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added Severity|enhancement |major -- You are