[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #77 from Martin Renvoize --- Created attachment 94001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94001=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #78 from Martin Renvoize --- Created attachment 94002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94002=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE --

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #74 from Martin Renvoize --- Created attachment 93998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93998=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #75 from Martin Renvoize --- Created attachment 93999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93999=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #73 from Martin Renvoize --- Created attachment 93997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93997=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #72 from Martin Renvoize --- Created attachment 93996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93996=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #71 from Martin Renvoize --- Created attachment 93995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93995=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #69 from Martin Renvoize --- Created attachment 93993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93993=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #70 from Martin Renvoize --- Created attachment 93994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93994=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #67 from Martin Renvoize --- Created attachment 93991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93991=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #66 from Martin Renvoize --- Created attachment 93990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93990=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE -- You

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #68 from Martin Renvoize --- Created attachment 93992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93992=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #65 from Martin Renvoize --- Created attachment 93989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93989=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93978|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93979|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93977|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93976|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93972|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93975|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93974|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93973|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93968|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93970|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93969|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93967|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93966|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93965|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93963|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93964|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93962|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93961|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93960|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #64 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #61) > This is a quite fundamental one: > > UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL > WHERE accounttype IN (SELECT

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #63 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #59) > FAIL Koha/Account/DebitType.pm >OK critic >OK forbidden patterns >OK git manipulation >OK pod >OK

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #62 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #58) > Moving authorized values to new table: > SUBSTR(authorised_value, 1, 64) > This may be a source of trouble, at least theoretically. Why not

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA -- You are

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #61 from Marcel de Rooy --- This is a quite fundamental one: UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types) Hmm. I do not really

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #60 from Martin Renvoize --- Thanks for taking a look Marcel, I'll get onto the feedback today... all of it seems sane to me so far. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #59 from Marcel de Rooy --- FAIL Koha/Account/DebitType.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling FAIL valid

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #58 from Marcel de Rooy --- Moving authorized values to new table: SUBSTR(authorised_value, 1, 64) This may be a source of trouble, at least theoretically. Why not switch from the 64 to 80 chars? `accounttype`

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #57 from Marcel de Rooy --- NAME ac_debit_types_branches Names for databases, tables, columns, and indexes can be up to 64 characters long. Alias names can be up to 256 characters long. Why not

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #56 from Marcel de Rooy --- INSERT IGNORE INTO account_debit_types ( code, default_amount, description, can_be_added_manually, is_system

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Depends on||23321 Referenced Bugs:

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Blocks||23354 Referenced Bugs:

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Depends on|23354 | Referenced Bugs:

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #53 from Martin Renvoize --- Created attachment 93978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93978=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE -- You are receiving this mail

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #54 from Martin Renvoize --- Created attachment 93979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93979=edit Bug 23049: (follow-up) Fix manual debits via add_debit Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #52 from Martin Renvoize --- Created attachment 93977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93977=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #51 from Martin Renvoize --- Created attachment 93976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93976=edit Bug 23049: 'N' -> 'NEW_CARD' Signed-off-by: Séverine QUEUNE -- You are receiving this

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #49 from Martin Renvoize --- Created attachment 93974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93974=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE --

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #50 from Martin Renvoize --- Created attachment 93975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93975=edit Bug 23049: Capitalise type passed to add_debit for overdue Signed-off-by: Séverine

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #47 from Martin Renvoize --- Created attachment 93972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93972=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #48 from Martin Renvoize --- Created attachment 93973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93973=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #46 from Martin Renvoize --- Created attachment 93970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93970=edit Bug 23049: Capitalise type passed to add_debit for account Signed-off-by: Séverine

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #44 from Martin Renvoize --- Created attachment 93968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93968=edit Bug 23049: Capitalise 'rent' calls to add_debit This works towards making type codes

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #45 from Martin Renvoize --- Created attachment 93969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93969=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #43 from Martin Renvoize --- Created attachment 93967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93967=edit Bug 23049: Update 'Res' to 'RESERVE' for consistency This patch updates all cases where

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #42 from Martin Renvoize --- Created attachment 93966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93966=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #40 from Martin Renvoize --- Created attachment 93964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93964=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #41 from Martin Renvoize --- Created attachment 93965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93965=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #39 from Martin Renvoize --- Created attachment 93963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93963=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #38 from Martin Renvoize --- Created attachment 93962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93962=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #37 from Martin Renvoize --- Created attachment 93961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93961=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE -- You

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93579|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #36 from Martin Renvoize --- Created attachment 93960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93960=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93577|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93578|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93576|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93575|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93574|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93573|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93572|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93571|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93569|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93570|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93568|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93567|0 |1 is obsolete|

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #35

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #34 from sandbo...@biblibre.com --- Created attachment 93579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93579=edit Bug 23049: (follow-up) Remove MANUAL_INV from AV Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #33 from sandbo...@biblibre.com --- Created attachment 93578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93578=edit Bug 23049: (follow-up) Impliment feedback Signed-off-by: Séverine QUEUNE --

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #32 from sandbo...@biblibre.com --- Created attachment 93577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93577=edit Bug 23049: Use a filtered table instead of two tables Test Plan * Apply this

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #30 from sandbo...@biblibre.com --- Created attachment 93575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93575=edit Bug 23049: Split system and local types Test plan 1) Apply patches up to this

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #31 from sandbo...@biblibre.com --- Created attachment 93576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93576=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #29 from sandbo...@biblibre.com --- Created attachment 93574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93574=edit Bug 23049: Update existing accounttype values Signed-off-by: Séverine QUEUNE --

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #26 from sandbo...@biblibre.com --- Created attachment 93571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93571=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #25 from sandbo...@biblibre.com --- Created attachment 93570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93570=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #27 from sandbo...@biblibre.com --- Created attachment 93572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93572=edit Bug 23049: Update maninvoice to reference debit types Signed-off-by: Séverine

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #28 from sandbo...@biblibre.com --- Created attachment 93573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93573=edit Bug 23049: Use debit_type in staff client views Signed-off-by: Séverine QUEUNE

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93529|0 |1 is

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #23 from sandbo...@biblibre.com --- Created attachment 93568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93568=edit Bug 23049: Add branch limitations tables Signed-off-by: Séverine QUEUNE -- You

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #24 from sandbo...@biblibre.com --- Created attachment 93569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93569=edit Bug 23049: Update DBIC Classes for branch limitations Signed-off-by: Séverine

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #22 from sandbo...@biblibre.com --- Created attachment 93567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93567=edit Bug 23049: Add debit_type * Add account_debit_types table * Add

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93565|0 |1 is

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93564|0 |1 is

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93523|0 |1 is

[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93521|0 |1 is

<    1   2   3   4   >