[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #79 from Jonathan Druart --- The last 2 patches were pushed to master (19.11) but not attached here and so missed for 19.05.x They fix bug 25665. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #78 from Jonathan Druart --- Created attachment 107457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107457=edit Bug 23382: (RM follow-up) Ensure tests pass on Wednesdays Koha::Calendar assumes we

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #77 from Jonathan Druart --- Created attachment 107456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107456=edit Bug 23382: (RM follow-up) Revert "hours_between should match..." This reverts commit

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added CC||ke...@bywatersolutions.com

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Lucas Gass changed: What|Removed |Added Version(s)|19.11.00|19.11.00, 19.05.07

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #74 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Keywords|rel_19_11_candidate | -- You are receiving

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94766|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94765|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94764|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94763|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94762|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94758|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94756|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94761|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94759|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94760|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94757|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #62 from Martin Renvoize --- Thanks dude :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94755|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94743|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94731|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94728|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94726|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94729|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94727|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94723|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94730|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94724|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94725|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #50 from Jonathan Druart --- Created attachment 94755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94755=edit Bug 23382: Use floating time zone to prevent tests to fail because of DST Today Friday

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #49 from Martin Renvoize --- Created attachment 94743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94743=edit Bug 23382: (follow-up) Ensure closed day is inside charge window We're testing with an

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94289|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94288|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94287|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94285|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94284|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94286|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94283|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94282|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #94281|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #39 from Martin Renvoize --- As for testing the truncate dates patch.. I would suggest reading the tests added within this patchset to confirm you agree that they make sense (from a datetime math perspective) then

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #38 from Martin Renvoize --- Comment on attachment 94284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94284 Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued Review of attachment 94284: -->

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate --

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #36 from Martin Renvoize --- Created attachment 94289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94289=edit Bug 23382: hours_between should match the logic of days_between The loops for

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #35 from Martin Renvoize --- Created attachment 94288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94288=edit Bug 23382: Truncate dates to minutes for comparison. It's somewhat of a mess in

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #93412|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #34 from Martin Renvoize --- Created attachment 94287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94287=edit Bug 23382: (follow-up) Further improve test coverage -- You are receiving this mail

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #93408|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #93411|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #93410|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #93409|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #93407|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #27 from Martin Renvoize --- It is indeed scary.. I'm working on it today but I think I've just had a breakthrough.. just trying to write a bunch more tests to prove my theory -- You are receiving this mail because:

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #25

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #22 from Martin Renvoize --- Created attachment 93411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93411=edit Bug 23382: (follow-up) Clarify variable names This patch updates the variable name

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #23 from Martin Renvoize --- Created attachment 93412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93412=edit Bug 23382: (follow-up) Ensure tests pass on Wednesdays -- You are receiving this mail

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92273|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92275|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92274|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92276|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Severity|major |critical -- You are

[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Summary|Issuing rules failing in|Issuing rules failing