https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Andrew Isherwood changed:
What|Removed |Added
CC|bugzi...@warmlight.co.uk|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Agustín Moyano changed:
What|Removed |Added
Blocks|20936 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #29 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Agustín Moyano changed:
What|Removed |Added
Blocks||25328
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #28 from Jonathan Druart
---
I still think we are doing messy stuff with the timezone. I may be wrong (don't
have the situation clear in mind right now) be I feel like the whole timezone
handling should be removed from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Jonathan Druart changed:
What|Removed |Added
Attachment #101910|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #27 from Jonathan Druart
---
Created attachment 104026
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104026=edit
Bug 24980: (follow-up) return '' when date is null
Signed-off-by: Jonathan Druart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #25 from Jonathan Druart
---
So basically this first patch is for (maybe) later, and should not block other
bug reports?
And second patch should be moved somewhere else.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #24 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #23)
> (In reply to Jonathan Druart from comment #22)
> > (In reply to Agustín Moyano from comment #20)
> > > (In reply to Jonathan Druart from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #22 from Jonathan Druart
---
(In reply to Agustín Moyano from comment #20)
> (In reply to Jonathan Druart from comment #18)
> > How do I test the timezone handling in real life? ie. without using the
> > console.
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #21 from Agustín Moyano ---
(In reply to Martin Renvoize from comment #19)
> I initially liked that final patch.. but do we believe it's correct
> consistency wise given that dt_from_string (which we're using in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #20 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #18)
> How do I test the timezone handling in real life? ie. without using the
> console.
Actually there is no place (even bug 20936) that brings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #19 from Martin Renvoize ---
I initially liked that final patch.. but do we believe it's correct consistency
wise given that dt_from_string (which we're using in KohaDates which with
function is emulating) will return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #18 from Jonathan Druart
---
How do I test the timezone handling in real life? ie. without using the
console.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Agustín Moyano changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #17 from Agustín Moyano ---
Created attachment 102157
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102157=edit
Bug 24980: (follow-up) return '' when date is null
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #16 from Jonathan Druart
---
Yes, that was for bug 20936!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #15 from Agustín Moyano ---
(In reply to Agustín Moyano from comment #13)
> Hi Jonathan,
>
> (In reply to Jonathan Druart from comment #11)
> > 0. Dates look great now! :)
> >
> > 1. Why not having current holds in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #14 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #12)
> 7. Should not deal with that in js-date-format.inc?
> (data&&$date(data))||'';
ok, it can be done
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #13 from Agustín Moyano ---
Hi Jonathan,
(In reply to Jonathan Druart from comment #11)
> 0. Dates look great now! :)
>
> 1. Why not having current holds in the table (behavior intranet-side,
> members/holdshistory.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #12 from Jonathan Druart
---
7. Should not deal with that in js-date-format.inc?
(data&&$date(data))||'';
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What|Removed |Added
Blocks|24765 |24999
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What|Removed |Added
Blocks||24765
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #10 from Martin Renvoize ---
OK.. so my understanding of why we need to support timezone in this js function
at all is that we are effectively replacing the native toLocalDateString().
That function, in my
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #9 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #8)
> When should we deal with tz when displaying dates?
>
> What are the different possibilities offered by js-date-format.inc?
Hi Jonathan, with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #7 from Agustín Moyano ---
(In reply to Agustín Moyano from comment #4)
> 4. In your browser go to koha main page, open a console and type
> $date('2020-03-25', {tz:
>'UTC'})
Don't know why it added an enter.. in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #5 from Agustín Moyano ---
(In reply to Martin Renvoize from comment #2)
> How does that look to you?
Great, it was just what I was looking for.. it just lacked the actual execution
of creationData function.. too much
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #4 from Agustín Moyano ---
Created attachment 101910
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101910=edit
Bug 24980: (RM follow-up) Only add timezone if passed a date-time
This patch prevents a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Agustín Moyano changed:
What|Removed |Added
Attachment #101794|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What|Removed |Added
Severity|enhancement |major
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What|Removed |Added
Assignee|oleon...@myacpl.org |agustinmoy...@theke.io
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #1 from Martin Renvoize ---
Created attachment 101794
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101794=edit
Bug 24980: (RM follow-up) Only add timezone if passed a date-time
This patch prevents a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #2 from Martin Renvoize ---
How does that look to you?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
42 matches
Mail list logo
