[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Blocks||28139 Referenced Bugs:

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Nick Clemens changed: What|Removed |Added Blocks||28136 Referenced Bugs:

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Blocks|27936 | Referenced Bugs:

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Jonathan Druart changed: What|Removed |Added Blocks||27936 Referenced Bugs:

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #55 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05, please rebase for backport. Thanks! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.04

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #53 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #52 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #51) > Btw, there quite nice refactoring opportunity around that if-else block that > had the warnings, thinking of doing a follow-up patch series to

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #51 from Joonas Kylmälä --- Btw, there quite nice refactoring opportunity around that if-else block that had the warnings, thinking of doing a follow-up patch series to tidy that up even more and also the now unnecessary

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #50 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #48) > Can you have a look at the output of t/db_dependent/Reserves.t please? > There are tons of warnings: > Use of uninitialized value in string

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #49 from Joonas Kylmälä --- Created attachment 117674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117674=edit Bug 25690: (follow-up) Supress warning about unitialized string This fixes the warning:

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #48 from Jonathan Druart --- Thanks for you answer, Joonas. Can you have a look at the output of t/db_dependent/Reserves.t please? There are tons of warnings: Use of uninitialized value in string eq at

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #47 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #46) > (In reply to Jonathan Druart from comment #44) > > -if ( $res->{'itemnumber'} && $res->{'itemnumber'} == > > $itemnumber &&

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #46 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #44) > -if ( $res->{'itemnumber'} && $res->{'itemnumber'} == > $itemnumber && $res->{'priority'} == 0) { > > Why did you remove that

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #45 from Jonathan Druart --- I am a bit tired right now to deep into the whole changes, but basically the line you removed was making sure we returned there for item-level holds, but @reserves can contain biblio-level

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #43 from Kyle M Hall --- Created attachment 117525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117525=edit Bug 25690: (follow-up) Correct grammar in warning messages This makes the meaning of the

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #42 from Kyle M Hall --- Created attachment 117524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117524=edit Bug 25690: (QA follow-up) PROCESSED -> PROCESSING for consistency PROCESSED gave the

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #41 from Kyle M Hall --- Created attachment 117523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117523=edit Bug 25690: Add SIP2 tests for checking out with holds This should cover whether checking

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #40 from Kyle M Hall --- Created attachment 117522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117522=edit Bug 25690: Make CanBookBeIssued return In Processing state as needing confirmation This

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #39 from Kyle M Hall --- Created attachment 117521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117521=edit Bug 25690: Remove duplicated logic in SIP2 checkouts Because AllowItemsOnHoldCheckoutSIP

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #38 from Kyle M Hall --- Created attachment 117520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117520=edit Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred Items

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Kyle M Hall changed: What|Removed |Added Attachment #117507|0 |1 is obsolete|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #36 from Joonas Kylmälä --- Kyle, btw, you had set the bug to "Doesn't apply status". For me it applied but I noticed: > Using index info to reconstruct a base tree... > M C4/SIP/ILS/Transaction/Checkout.pm >

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #34 from Joonas Kylmälä --- Created attachment 117513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117513=edit Bug 25690: (follow-up) Correct grammar in warning messages This makes the meaning of

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #33 from Joonas Kylmälä --- Created attachment 117512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117512=edit Bug 25690: (QA follow-up) PROCESSED -> PROCESSING for consistency PROCESSED gave the

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #32 from Joonas Kylmälä --- Created attachment 117511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117511=edit Bug 25690: Add SIP2 tests for checking out with holds This should cover whether

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #31 from Joonas Kylmälä --- Created attachment 117510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117510=edit Bug 25690: Make CanBookBeIssued return In Processing state as needing confirmation This

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #30 from Joonas Kylmälä --- Created attachment 117509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117509=edit Bug 25690: Remove duplicated logic in SIP2 checkouts Because

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #29 from Joonas Kylmälä --- Created attachment 117508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117508=edit Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred Items

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Attachment #117062|0 |1 is obsolete|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #27 from Joonas Kylmälä --- (In reply to Kyle M Hall from comment #25) > Comment on attachment 117064 [details] [review] > Bug 25690: Remove duplicated logic in SIP2 checkouts > > Review of attachment 117064 [details]

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #26 from Kyle M Hall --- Comment on attachment 117374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117374 Bug 25690: (follow-up) Correct grammar in warning messages Review of attachment 117374: -->

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #25 from Kyle M Hall --- Comment on attachment 117064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117064 Bug 25690: Remove duplicated logic in SIP2 checkouts Review of attachment 117064: -->

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #24 from Joonas Kylmälä --- Attached trivial follow-up to address the grammar issues raised in comment 14. To me it looks like we cannot get the destination branch info to the transfer warning without refactoring the

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #23 from Joonas Kylmälä --- Created attachment 117374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117374=edit Bug 25690: (follow-up) Correct grammar in warning messages This makes the meaning of

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #22 from Martin Renvoize --- Above = comment 14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #20 from Martin Renvoize --- Created attachment 117067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117067=edit Bug 25690: (QA follow-up) PROCESSED -> PROCESSING for consistency PROCESSED gave the

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Martin Renvoize changed: What|Removed |Added Attachment #117004|0 |1 is obsolete|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Martin Renvoize changed: What|Removed |Added Attachment #117003|0 |1 is obsolete|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Martin Renvoize changed: What|Removed |Added Attachment #117002|0 |1 is obsolete|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Martin Renvoize changed: What|Removed |Added Attachment #117001|0 |1 is obsolete|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Martin Renvoize changed: What|Removed |Added Attachment #117000|0 |1 is obsolete|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #14 from Martin Renvoize --- Comment on attachment 117000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117000 Bug 25690: Remove double usage of 'Reserved' return value Review of attachment 117000:

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Text to go in the||- Proper warning messages

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #13 from Joonas Kylmälä --- The patch series is now ready for Sign-off. The actual bug reported here is fixed in the patch "Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred" but the

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #12 from Joonas Kylmälä --- Created attachment 117004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117004=edit Bug 25690: Add SIP2 tests for checking out with holds This should cover whether

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #11 from Joonas Kylmälä --- Created attachment 117003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117003=edit Bug 25690: Make CanBookBeIssued return In Processing state as needing confirmation This

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #10 from Joonas Kylmälä --- Created attachment 117002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117002=edit Bug 25690: Remove duplicated logic in SIP2 checkouts Because

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #9 from Joonas Kylmälä --- Created attachment 117001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117001=edit Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred Items

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Attachment #116948|0 |1 is obsolete|

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #7 from Joonas Kylmälä --- I have done some rudimentary testing to those attached patches that fix this issue and a bit more. I will move the status to Needs Sign-Off when I'm as certain as I possibly can that there is

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #6 from Joonas Kylmälä --- Created attachment 116951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116951=edit Bug 25690: Make CanBookBeIssued return In Processing state as needing confirmation This

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #5 from Joonas Kylmälä --- Created attachment 116950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116950=edit Bug 25690: Remove duplicated logic in SIP2 checkouts Because AllowItemsOnHoldCheckoutSIP

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #4 from Joonas Kylmälä --- Created attachment 116949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116949=edit Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred Items

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #3 from Joonas Kylmälä --- Created attachment 116948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116948=edit Bug 25690: Remove double usage of 'Reserved' return value The patch "Bug 19116: Hold not

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Version|20.05 |master -- You are

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2021-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Assignee|nug...@gmail.com|joonas.kylm...@helsinki.fi

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Andrew Nugged changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |nug...@gmail.com

[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2020-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Katrin Fischer changed: What|Removed |Added Summary|SIP allows to check out an |SIP should not allow to