https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #48 from Katrin Fischer ---
I haven't heard any good argument for tokens yet tbh. I think they would just
obscure the templates and make them harder for people to work with. Koha is a
huge application by now, that has a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #46 from Jonathan Druart ---
I don't think it is a discussion for 21.11.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #43 from Katrin Fischer ---
I feel like this might be better as "in discussion", but it should really be
discussed.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Julian Maurice changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Julian Maurice changed:
What|Removed |Added
Attachment #109948|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Julian Maurice changed:
What|Removed |Added
Attachment #109947|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #40 from David Cook ---
But I reiterate... this is basically a philosophical discussion at this point.
I'm not planning to do any work on Java style token-based translations, and
Julian is doing work on the t() style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #39 from David Cook ---
(In reply to Katrin Fischer from comment #37)
> I really don't see the advantage of this. To me it adds an extra step with
> no visible win.
Here are some random examples from DSpace and Koha.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #38 from David Cook ---
(In reply to Katrin Fischer from comment #35)
> Not always, but I think in this case it applies. Forcing people to invent
> tons of variables will not make things more readable, but much likely
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #37 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #36)
> (In reply to Katrin Fischer from comment #35)
> > (In reply to David Cook from comment #32)
> > > (In reply to Katrin Fischer from comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #36 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #35)
> (In reply to David Cook from comment #32)
> > (In reply to Katrin Fischer from comment #29)
> > > Have to still read discussion, but I also
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #35 from Katrin Fischer ---
(In reply to David Cook from comment #32)
> (In reply to Katrin Fischer from comment #29)
> > Have to still read discussion, but I also am in favor of keeping stuff
> > readable in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #34 from David Cook ---
I reiterate though that I'm not an expert on this and I'm happy to defer to
others.
I'm just saying that the current proposal looks complex and difficult to use.
Since the OPAC is much smaller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #33 from David Cook ---
(In reply to Martin Renvoize from comment #28)
> Just for documentation, we had a good discussion around this on IRC this
> morning with a few options to think about.. discussion is around 8.13:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #32 from David Cook ---
(In reply to Katrin Fischer from comment #29)
> Have to still read discussion, but I also am in favor of keeping stuff
> readable in templates to some extent. Using only variables in templates and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #31 from David Cook ---
(In reply to Julian Maurice from comment #27)
> If we can't expect developers to use 8 functions, what can we expect from
> them ?
We can expect developers to follow consistent simple rules.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #30 from David Cook ---
(In reply to Julian Maurice from comment #27)
> I really don't see how what you're describing is a better solution than what
> we already have. This is looking worse actually. Correct me if I'm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #29 from Katrin Fischer ---
Have to still read discussion, but I also am in favor of keeping stuff readable
in templates to some extent. Using only variables in templates and having to
look them up in a Perl script adds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #27 from Julian Maurice ---
(In reply to David Cook from comment #22)
> Drupal is an old project as well, and that example looks worrying. Based on
> https://en.wikipedia.org/wiki/Drupal#Themes, it looks like that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #26 from David Cook ---
However, I defer to those people who actually *do* the translation work. I am
not pretending that I know what is best.
These are just ideas I have encountered in my other non-Koha projects, and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #25 from David Cook ---
Regarding the Java method, look at "Fetch the Text from the ResourceBundle" at
https://docs.oracle.com/javase/tutorial/i18n/intro/steps.html.
In my mind, we'd fetch the relevant translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #24 from David Cook ---
(In reply to David Cook from comment #22)
> (In reply to Owen Leonard from comment #21)
> > If you're referring to the question of syntax, other projects I've seen do
> > something similar. For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #23 from David Cook ---
(In reply to Jonathan Druart from comment #19)
> (In reply to David Cook from comment #18)
> > Overall, I'll do whatever other people decide needs to be done, but I just
> > worry that we're
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #22 from David Cook ---
(In reply to Owen Leonard from comment #21)
> If you're referring to the question of syntax, other projects I've seen do
> something similar. For instance in Drupal:
>
>
>
> Translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #21 from Owen Leonard ---
(In reply to David Cook from comment #18)
> when other projects have already sorted out internationalization
> more gracefully.
If you're referring to the question of syntax, other projects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #20 from Jonathan Druart
---
Julian, I'd like to know if we need this one or not, for 21.05.
Could you send an email to koha-devel with a pro/con list and detail what is
done here? Then a vote at a dev meeting will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #18 from David Cook ---
(In reply to Owen Leonard from comment #17)
> (In reply to David Cook from comment #13)
> > This does not look developer friendly...
>
> We've been saying this kind of thing would not be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #17 from Owen Leonard ---
(In reply to David Cook from comment #13)
> This does not look developer friendly...
We've been saying this kind of thing would not be developer-friendly for years,
and it's time to get over
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #16 from Katrin Fischer ---
I think for that prominent spot on the start page it would be good to put in
the little more work. And syntax can be learned :)
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #15 from David Cook ---
(In reply to Katrin Fischer from comment #14)
> We can also translate using singular/plural forms now - just missing an
> example right now, but there is documentation on the wiki:
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #14 from Katrin Fischer ---
> Then you're just needing to translate "Checkouts" rather than singular and
> plural forms.
We can also translate using singular/plural forms now - just missing an example
right now, but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #12 from Julian Maurice ---
(In reply to Katrin Fischer from comment #11)
> Hi Julian, I wonder if we should postpone this to next release now maybe,
> but I hope we can get some more active discussion. What do you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #11 from Katrin Fischer ---
Hi Julian, I wonder if we should postpone this to next release now maybe, but I
hope we can get some more active discussion. What do you think?
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #10 from Julian Maurice ---
(In reply to Katrin Fischer from comment #9)
> This appears to work well, but it doesn't really make the templates easier
> to read...
>
> - class="user_checkouts_count count_label">[%
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #9 from Katrin Fischer ---
This appears to work well, but it doesn't really make the templates easier to
read...
- [% checkouts | html %]
checkout(s)
Turns into:
+[% count =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #8 from Owen Leonard ---
Created attachment 109948
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109948=edit
Bug 26392: Fix opac news display issue when there is no author
Signed-off-by: Owen Leonard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Owen Leonard changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Owen Leonard changed:
What|Removed |Added
Attachment #109943|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #5 from Julian Maurice ---
Created attachment 109944
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109944=edit
Bug 26392: Fix opac news display issue when there is no author
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Julian Maurice changed:
What|Removed |Added
Attachment #109666|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #2 from Julian Maurice ---
Test plan:
1. Apply patch
2. cd misc/translator && ./translate update fr-FR
3. Open and translate misc/translator/po/fr-FR-messages.po (don't forget plural
forms)
4. cd misc/translator &&
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #1 from Julian Maurice ---
Created attachment 109666
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109666=edit
Bug 26392: Wrap all translatable strings in opac-main.tt
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
54 matches
Mail list logo
