https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Caroline Cyr La Rose changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Text to go in the||This patch adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Katrin Fischer changed:
What|Removed |Added
CC||glask...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Katrin Fischer changed:
What|Removed |Added
Keywords||release-notes-needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #79 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #78 from Tomás Cohen Arazi ---
Created attachment 140502
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140502=edit
Bug 27981: (QA follow-up) GetMarcBiblio was removed from codebase
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #77 from Andrew Nugged ---
Future development note, but this is not in the scope of the CURRENT TICKET:
Our librarians also noted that there's a 003 field which might also be
auto-filled with some hardcoded value for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #76 from Andrew Nugged ---
This bugfix code (including my last patch) was already used in our productions
for more than a month as a hotfix, and works well.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #75 from Andrew Nugged ---
Did QA & Rebased to the latest master.
Also added 1 final patch (small polishing step) to use true/false everywhere to
unify JS because,
KohaBackend.GetRecord( id, remove_control_num,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #74 from Andrew Nugged ---
Created attachment 140097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140097=edit
Bug 27981: (QA follow-up) Unify JavaScript to false/true from 0/1/""
Make
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #73 from Andrew Nugged ---
Created attachment 140096
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140096=edit
Bug 27981: (follow-up) Fix tests
Signed-off-by: Andrew Nugged
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #72 from Andrew Nugged ---
Created attachment 140095
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140095=edit
Bug 27981: (follow-up) Correct variable
Signed-off-by: Andrew Nugged
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #71 from Andrew Nugged ---
Created attachment 140094
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140094=edit
Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #70 from Andrew Nugged ---
Created attachment 140093
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140093=edit
Bug 27981: Add option to automatically set 001 to the biblionumber
This patch adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Andrew Nugged changed:
What|Removed |Added
Attachment #134536|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Andrew Nugged changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Andrew Nugged changed:
What|Removed |Added
CC||nug...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Katrin Fischer changed:
What|Removed |Added
Blocks||28685
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Katrin Fischer changed:
What|Removed |Added
CC||ha...@orex.es
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #67 from Nick Clemens ---
Created attachment 136022
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136022=edit
Bug 27981: (follow-up) Fix tests
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #66
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #65 from Katrin Fischer ---
Thx Nick for adding the sign-off lines :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #64 from Nick Clemens ---
Created attachment 134539
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134539=edit
Bug 27981: (follow-up) Correct variable
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #132036|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #132035|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #132034|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Thomas Klausner changed:
What|Removed |Added
CC||d...@plix.at
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #59 from Nick Clemens ---
Created attachment 132036
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132036=edit
Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #58 from Nick Clemens ---
Created attachment 132035
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132035=edit
Bug 27981: Add option to automatically set 001 to the biblionumber
This patch adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #128223|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #56 from Nick Clemens ---
Created attachment 128225
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128225=edit
Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #55 from Nick Clemens ---
Created attachment 128224
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128224=edit
Bug 27981: Add option to automatically set 001 to the biblionumber
This patch adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #124279|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #53 from Katrin Fischer ---
Is the sequence of the attached patch files correct? (QA follow-up on top)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #52 from Marcel de Rooy ---
I think this needs to be Needs Signoff.
If someone signs off on the last patch, I probably could do the QA again ;)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #51 from Nick Clemens ---
(In reply to David Cook from comment #46)
> Thanks for working on this, Nick. This is a feature I've long wanted in Koha.
>
> I've just taken a quick peek at the code, so just going to ask for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #50 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #45)
> (In reply to Marcel de Rooy from comment #42)
> > Commit promises:
> > The option "biblionumber" will set field 001 to the biblionumber when you
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #49 from Nick Clemens ---
Created attachment 124281
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124281=edit
Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #48 from Nick Clemens ---
Created attachment 124280
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124280=edit
Bug 27981: Add option to automatically set 001 to the biblionumber
This patch adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #122674|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #46 from David Cook ---
Thanks for working on this, Nick. This is a feature I've long wanted in Koha.
I've just taken a quick peek at the code, so just going to ask for some
clarification.
At a glance, it looks like a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #45 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #42)
> Commit promises:
> The option "biblionumber" will set field 001 to the biblionumber when you
> create a new record or edit an existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Attachment #122672|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Attachment #122356|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #42 from Marcel de Rooy ---
Commit promises:
The option "biblionumber" will set field 001 to the biblionumber when you
create a new record or edit an existing record
Create works, modify does not.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #41 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #40)
> (In reply to Marcel de Rooy from comment #38)
> > Nick: There is also another point still. If we update 001, we should update
> > the orgcode too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #40 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #38)
> Nick: There is also another point still. If we update 001, we should update
> the orgcode too in 003.
> See also bug 28491 for authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #122344|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #38 from Marcel de Rooy ---
Nick: There is also another point still. If we update 001, we should update the
orgcode too in 003.
See also bug 28491 for authority counterpart.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #37 from Jonathan Druart ---
Yes, that's definitely hacky and it will complicate the move when we will
replace svc/bib with a REST API call.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #36 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #34)
> (In reply to Nick Clemens from comment #32)
> > I get the extra warning if i run the test before the DB update, but all is
> > good after
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #34 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #32)
> I get the extra warning if i run the test before the DB update, but all is
> good after
Still have it.
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #33 from Marcel de Rooy ---
Created attachment 122356
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122356=edit
Bug 27981: (QA follow-up) Adjust atomic update
[1] Insert ignore.
[2] Remove references
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #32 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #30)
> Please cleanup your patches!
> Please amend the first patch where you delete the buggy lines too ;)
Patches squashed, back to NSO
(In reply to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #119704|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #30
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #29 from Marcel de Rooy ---
# Subtest: AddBiblio
1..5
not ok 1 - expected warnings when adding too long LCCN
# Failed test 'expected warnings when adding too long LCCN'
# at t/db_dependent/Biblio.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |BLOCKED
--- Comment #28
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #27 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #25)
> Hi Hakam, should this be switched to signed off?
>
> I notice you only reattached the last patch. Usually we will add sign-off
> lines to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #26 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #25)
> Hi Hakam, should this be switched to signed off?
>
> I notice you only reattached the last patch. Usually we will add sign-off
> lines to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #25 from Katrin Fischer ---
Hi Hakam, should this be switched to signed off?
I notice you only reattached the last patch. Usually we will add sign-off lines
to all patches and then reattach them all with them. If you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Hakam Almotlak changed:
What|Removed |Added
Attachment #122280|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #23 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #18)
> The problem with leaving a number might be when you are cloning records with
> Edit as new. When you do not modify that 001, it is probably wrong.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #22 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #20)
> +}elsif($record->field('001')->data() eq 'biblionumber'){
>
> How and when will the 001 ever be string biblionumber ?
Either I was
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #21 from Nick Clemens ---
Created attachment 122280
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122280=edit
Bug 27981: (follow-up) Handle duplciation and remove debug
There were some additional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #20 from Marcel de Rooy ---
+}elsif($record->field('001')->data() eq 'biblionumber'){
How and when will the 001 ever be string biblionumber ?
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #19 from Marcel de Rooy ---
This still needs more attention, I am afraid?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #18 from Marcel de Rooy ---
The problem with leaving a number might be when you are cloning records with
Edit as new. When you do not modify that 001, it is probably wrong.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #16
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #15
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #14
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #13 from Marcel de Rooy ---
Note that the Biblio.t test already fails without this patch..
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #12 from Marcel de Rooy ---
Processing additional checks
* Signed-off-by line 'Signed-off-by: Salman Ali '
seems invalid
This email adress does not work, Salman ;)
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #11 from Marcel de Rooy ---
FAIL members/memberentry.pl
OK critic
FAIL forbidden patterns
forbidden pattern: Data::Dumper::Dumper (line 112)
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Salman Ali changed:
What|Removed |Added
CC||salman@inlibro.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Salman Ali changed:
What|Removed |Added
Attachment #119717|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Frank Hansen changed:
What|Removed |Added
Attachment #119705|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Frank Hansen changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #118513|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Attachment #118461|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Frank Hansen changed:
What|Removed |Added
CC||frank.han...@ub.lu.se
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #5 from Nick Clemens ---
I don't recreate this, can you test against master too?
I don't see how these changes would case these failures
(In reply to Marcel de Rooy from comment #3)
> # Failed test 'AddBiblio'
> #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
--- Comment #4 from Nick Clemens ---
Created attachment 118513
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118513=edit
Bug 27981: (follow-up) Set pref off for existing tests
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
1 - 100 of 104 matches
Mail list logo
