https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Pushed to oldstable |Pushed to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Victor Grousset/tuxayo changed:
What|Removed |Added
Version(s)|21.11.00,21.05.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #118 from Martin Renvoize ---
Any chance of having this for 20.11 now that 29284 is in master and 21.11 and
21.05?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Nick Clemens changed:
What|Removed |Added
Blocks||29418
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #117 from Fridolin Somers ---
Yep, I was waiting for Bug 29284.
Will be in 20.11.12 release.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #116 from Martin Renvoize ---
Can we get a backport for this for 20.11 pretty please?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Blocks||29284
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Kyle M Hall changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #114 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #113 from Martin Renvoize ---
(In reply to Andrew Nugged from comment #112)
> :huggs:
>
> yeah, right, Petro, look, we should next time add follow-up (thanks Martin!)
No worries; if there's a mistake to be made like
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #112 from Andrew Nugged ---
:huggs:
yeah, right, Petro, look, we should next time add follow-up (thanks Martin!)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #124566|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #124565|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #124564|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #124563|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #124562|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #124561|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #124560|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #103 from Martin Renvoize ---
For future reference, once a bug has gone through SO and QA please respond to
change requests as follow-ups... that way it's easy for a reviewer to see that
the requested change has been
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #102 from Peter Vashchuk ---
(In reply to Jonathan Druart from comment #91)
> Questions and suggestions:
> 1. Could we use named capture in the regexs?
> 2. What means XI?
> 3. Why do we need the 'e' modifier in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #101 from Peter Vashchuk ---
Created attachment 124566
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124566=edit
Bug 28316: (QA follow-up) Make clean_search_term public
With all the work that's gone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #100 from Peter Vashchuk ---
Created attachment 124565
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124565=edit
Bug 28316: escape ES ranges if QueryAutoTruncate is enabled
if QueryAutoTruncate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #99 from Peter Vashchuk ---
Created attachment 124564
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124564=edit
Bug 28316: avoid messing up regexes in the search queries
This patch ensures that the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #98 from Peter Vashchuk ---
Created attachment 124563
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124563=edit
Bug 28316: escape exclamation signs in the query
Currently having exclamation sign at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #97 from Peter Vashchuk ---
Created attachment 124562
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124562=edit
Bug 28316: escape brackets in the search query
This patch screens square and curly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #96 from Peter Vashchuk ---
Created attachment 124561
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124561=edit
Bug 28316: screen unquoted semicolons and all followup colons
Currently searches like:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Peter Vashchuk changed:
What|Removed |Added
Attachment #124372|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Peter Vashchuk changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Blocks|11175 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
mathieu saby changed:
What|Removed |Added
CC||mathsaby...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #94 from Jonathan Druart ---
(In reply to Andrew Nugged from comment #92)
> 1: yes, naming can be added
>
> 2: this is a "placeholder" which:
Yes, I got that, and L for Left and R for Right. But then XI for... what? :)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #93 from Andrew Nugged ---
> This is for temporary hiding out current brackets from "next RegExs"
I agree that this is not the best solution: with 0.00..1% probability that some
books can have in the name "~~LC1~~" and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Andrew Nugged changed:
What|Removed |Added
Status|Passed QA |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Blocks||11175
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Blocks||26314
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
CC||ha...@orex.es
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #88 from Martin Renvoize ---
Created attachment 124378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124378=edit
Bug 28316: (QA follow-up) Make clean_search_term public
With all the work that's gone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #123606|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #123605|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #123604|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #123603|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #123602|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Martin Renvoize changed:
What|Removed |Added
Attachment #123601|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Andreas Jonsson changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #81 from Andrew Nugged ---
Why this fuzziness and the extra job was done by us? We wanted to limit syntax
errors from ES and make it easier for librarians to copy-paste just book names
and have results,
but NOT TO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #80 from Andrew Nugged ---
So, the patch adds more order with "QueryRegexEscapeOptions" than before,
same with "QueryAutoTruncate", and keeps ranges working as well.
Yet it l+ng read above :), for a strong coffee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #79 from Andrew Nugged ---
(In reply to Victor Grousset/tuxayo from comment #41)
> > 4) additionally perform a search using range,
Vicor, this seems working now,
By the way, it should find normally this with and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #78 from Andrew Nugged ---
And the exclamation mark:
==
this used to be the "negate" command for words in queries, ONLY when '!'
sticking
to the beginning of the word, so patch fuzziness added:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #77 from Andrew Nugged ---
Tricks with colons:
==
colons in Koha expected to separate search field and search value,
so "title:good" should search word "good" only in "titles",
but if you will use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #76 from Andrew Nugged ---
Ranges in ES language
=
let's disable QueryAutoTruncate for not adding those asterisks,
and QueryRegexEscapeOptions doesn't matter here unless we will add
regular
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #75 from Andrew Nugged ---
QueryRegexEscapeOptions
=
Now let's turn "QueryAutoTruncate" off and check with QueryRegexEscapeOptions:
It's all about RegEx in ES queries,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #74 from Andrew Nugged ---
QueryAutoTruncate case:
=
This is a feature that BLINDLY adds to alphanumeric-ended words asterisk
in the end before tossing that phrase to ES as a search query.
So,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #73 from Andrew Nugged ---
First, if you create" crazy request like (exactly this to the search field):
The reserved characters are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ /
it's impossible to do such
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #72 from Andrew Nugged ---
Now regarding the current ticket - why it's appeared:
There already was some "prevention from dies (exceptions) in ES language" to
make requests "just regular characters" instead of special
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #71 from Andrew Nugged ---
Generally about these complications and some mess with ES search:
we don't have at all ES query language parser and transmitting requests
directly to ES and getting its "parse_exception"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #70 from Victor Grousset/tuxayo ---
(In reply to Andrew Nugged from comment #61)
> Victor, please can you again give-this-a-go?
> i.e. Re-Sign-off this ticket again according to that so we now might have
> proper "error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #69 from Victor Grousset/tuxayo ---
(In reply to Peter Vashchuk from comment #58)
> I think search query like that should never work as it will always cause ES
> syntax error, ElasticSearch is a mini-language after all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Alex Buckley changed:
What|Removed |Added
CC||alexbuck...@catalyst.net.nz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #67 from Alex Buckley ---
Created attachment 123606
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123606=edit
Bug 28316: escape ES ranges if QueryAutoTruncate is enabled
if QueryAutoTruncate enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #66 from Alex Buckley ---
Created attachment 123605
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123605=edit
Bug 28316: avoid messing up regexes in the search queries
This patch ensures that the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #65 from Alex Buckley ---
Created attachment 123604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123604=edit
Bug 28316: escape exclamation signs in the query
Currently having exclamation sign at the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #64 from Alex Buckley ---
Created attachment 123603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123603=edit
Bug 28316: escape brackets in the search query
This patch screens square and curly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #63 from Alex Buckley ---
Created attachment 123602
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123602=edit
Bug 28316: screen unquoted semicolons and all followup colons
Currently searches like:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Alex Buckley changed:
What|Removed |Added
Attachment #122801|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Alex Buckley changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #61 from Andrew Nugged ---
(In reply to Victor Grousset/tuxayo from comment #51)
Victor, please can you again give-this-a-go?
i.e. Re-Sign-off this ticket again according to that so we now might have
proper "error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #60 from Peter Vashchuk ---
Victor, please check this ticket:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736
it will make sense why search queries like this one "+ - = && || > < ! ( ) { }
[ ] ^ " ~ * ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
e.betemps changed:
What|Removed |Added
CC||e.bete...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Peter Vashchuk changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Alex Arnaud changed:
What|Removed |Added
Blocks||28484
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Eric Phetteplace changed:
What|Removed |Added
CC||ephettepl...@cca.edu
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #59 from Peter Vashchuk ---
Pushed the patches with fixed descriptions and removed some unnecessary
newlines that were left there.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #58 from Peter Vashchuk ---
(In reply to Victor Grousset/tuxayo from comment #51)
> With QueryAutoTruncate=only if *
> For a search of the following and a record named the following:
> The reserved characters are: + - =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #57 from Peter Vashchuk ---
Created attachment 122806
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122806=edit
Bug 28316: escape ES ranges if QueryAutoTruncate is enabled
if QueryAutoTruncate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #56 from Peter Vashchuk ---
Created attachment 122805
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122805=edit
Bug 28316: avoid messing up regexes in the search queries
This patch ensures that the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #55 from Peter Vashchuk ---
Created attachment 122804
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122804=edit
Bug 28316: escape exclamation signs in the query
Currently having exclamation sign at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #54 from Peter Vashchuk ---
Created attachment 122803
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122803=edit
Bug 28316: escape brackets in the search query
This patch screens square and curly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #53 from Peter Vashchuk ---
Created attachment 122802
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122802=edit
Bug 28316: screen unquoted semicolons and all followup colons
Currently searches like:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Peter Vashchuk changed:
What|Removed |Added
Attachment #122201|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Peter Vashchuk changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Jason Boyer changed:
What|Removed |Added
CC||jbo...@equinoxoli.org
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #51 from Victor Grousset/tuxayo ---
I forgot I tested this in the past.
What should be expected to be different from comment 11 results?
- Should I still have to quote stuff (the cases of comment 8)
- Should some stuff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Andrew Nugged changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #49 from Victor Grousset/tuxayo ---
The test plan yielded good results :)
Patches were reordered to make it easier to check the tests (they indeed fail
when the implementation is missing)
Do these commits need a test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #48 from Victor Grousset/tuxayo ---
Created attachment 122206
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122206=edit
Bug 28316: avoid messing up regexes in the search queries
This patch ensures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #122106|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #122105|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #122104|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #122103|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #122108|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #42 from Victor Grousset/tuxayo ---
errata: «date-of-publication:[1950 TO 2020]»
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #41 from Victor Grousset/tuxayo ---
> 4) additionally perform a search using range,
for example: "[1999 TO 2020]", ensure that it works correctly too.
What values should be in the record for the search to yield it?
It
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #40 from Peter Vashchuk ---
Created attachment 122108
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122108=edit
Bug 28316: add tests
--
You are receiving this mail because:
You are watching all bug
1 - 100 of 127 matches
Mail list logo
