https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Blou changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #27 from Jonathan Druart ---
(In reply to Blou from comment #26)
> I did that (comment 21). Moved everything to Bug 28411, seemed more
> appropriate. There are no patch left in this bug.
>
> Good point about the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #26 from Blou ---
I did that (comment 21). Moved everything to Bug 28411, seemed more
appropriate. There are no patch left in this bug.
Good point about the plugins, didn't think of that.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #25 from Jonathan Druart ---
Philippe, please move your patch to its own bug, and link it to this one.
So that we can discuss on this approach specifically on this bug and it does
not get lost here.
I would suggest to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #24 from David Cook ---
(In reply to Jonathan Druart from comment #22)
> Why do you want to remove C4::Context from updatedatabase? What would be the
> gain?
While I don't directly accuse C4::Context in bug 34088, it is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #23 from Blou ---
We were talking about moving all calls to preference().
updatedatabase.pl has had problems in the past when the code calls DB objects
of the new version that do not correspond to the database that is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #22 from Jonathan Druart ---
(In reply to Blou from comment #21)
> Did a quick check. There are a lot of them.
>
> One question: installer/data/mysql/updatedatabase.pl calls
> C4::Context->preference, which is now
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #21 from Blou ---
Did a quick check. There are a lot of them.
One question: installer/data/mysql/updatedatabase.pl calls
C4::Context->preference, which is now an object call behind the scene. I know
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #20 from Jonathan Druart ---
(In reply to Blou from comment #15)
> (In reply to Jonathan Druart from comment #14)
> > We are loosing the logaction calls.
>
> Very good point.
>
> This needs to be preserved, one way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #19 from Blou ---
moved my patches to Bug 28411, more appropriate as pointed out.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Blou changed:
What|Removed |Added
Attachment #157953|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Blou changed:
What|Removed |Added
Attachment #157945|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #18 from Blou ---
prove t/db_dependent/sysprefs.t fails the cache test.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Blou changed:
What|Removed |Added
Attachment #157952|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Blou changed:
What|Removed |Added
Attachment #157946|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #15 from Blou ---
(In reply to Jonathan Druart from comment #14)
> We are loosing the logaction calls.
Very good point.
This needs to be preserved, one way or another. It's unfortunate the call to
"preference" being
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #14 from Jonathan Druart ---
We are loosing the logaction calls.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #13 from Blou ---
Created attachment 157946
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157946=edit
Bug 28410: remove Koha::Config::Syspref(s) from C4::Context
Use straigth SQL queries to access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Blou changed:
What|Removed |Added
Attachment #157875|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #11 from Blou ---
> So bug 28410 isn't the right place to put patches. You'll want to raise
> separate tickets and then link them using "Depends on".
Yeah, I figured that, but I was really putting them here for your
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #10 from David Cook ---
(In reply to Blou from comment #9)
> I followed on David's comment and tried a few lazy loading. Some have a
> good impact (like ZOOM), but others like the TimeZone have no impact because
> it's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #9 from Blou ---
I followed on David's comment and tried a few lazy loading. Some have a good
impact (like ZOOM), but others like the TimeZone have no impact because it's
included in some other module in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #8 from Blou ---
Created attachment 157875
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157875=edit
Bug 28410: Use lazy loading to reduce memory footprint of C4/Context.pm
This simply removes some
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #7 from David Cook ---
(In reply to Blou from comment #4)
> I know I might sound blasphemous, but to me C4::Context should not carry
> this bagage, even at the cost of the nice OO design.
We could also use lazy loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #6 from David Cook ---
(In reply to Blou from comment #4)
> A few old-school SELECT in
> C4::Context, and you reduce all your scripts memory footprints by a lot.
That's the strategy I use in bug 27267 and it is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #5 from David Cook ---
(In reply to Blou from comment #4)
> Maybe I'm naive, but it seems rather simple to reduce 40M of RES out of most
> Koha scripts.
I think it's easier said than done. Sounds like a fair number of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #4 from Blou ---
I know I might sound blasphemous, but to me C4::Context should not carry this
bagage, even at the cost of the nice OO design.
I want the context. I think this includes the config file and the sysprefs,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
--- Comment #3 from Blou ---
Ok, I digged in v23
BackgroundJobs
|
v
BackgroundJob (Net::Stomp : 5M)
| |
| v
| Koha::Object (Mojo::JSON : 16M)
v
C4::Context (DateTime::TimeZone : 7M)
| (ZOOM : 8M)
v
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Blou changed:
What|Removed |Added
CC||philippe.blo...@inlibro.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
David Cook changed:
What|Removed |Added
Depends on||34477
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
David Cook changed:
What|Removed |Added
Depends on||27267
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Katrin Fischer changed:
What|Removed |Added
Summary|Reduce memory footprint |[Omnibus] Reduce memory
32 matches
Mail list logo
