[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #46 from Caroline Cyr La Rose --- (In reply to Katrin Fischer from comment #44) > I am not sure about the proposed patches here as what they actually do and > what is advertised in the bug title doesn't match up. > > 1)

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #45 from Katrin Fischer --- I accidentally pushed this to main, but will revert, I think easier and less confusing to push a clean patch later. Please let me know if I can help - I have done quite a bit of XSLT work. --

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #44

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Martin Renvoize changed: What|Removed |Added Attachment #165347|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Martin Renvoize changed: What|Removed |Added Attachment #165346|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Attachment #165335|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Attachment #165236|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #38 from David Nind --- (In reply to Matthias Le Gac from comment #37) > I fixed the problem when "online resources" is not displayed. There is no > longer an extra space between fields. > > As for the second problem,

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Roman Dolny changed: What|Removed |Added CC||roman.do...@jezuici.pl --

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #37 from Matthias Le Gac --- I fixed the problem when "online resources" is not displayed. There is no longer an extra space between fields. As for the second problem, it's not related to this bz because the difference

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #36 from Matthias Le Gac --- Created attachment 165335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165335=edit Bug 36111: fixed extra space -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #35

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Roman Dolny changed: What|Removed |Added Attachment #164476|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Roman Dolny changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #33 from Matthias Le Gac --- (In reply to Victor Grousset/tuxayo from comment #32) > Do you confirm the commit/patch "Bug 36111: removes display of fields 856y3z > if not 856u" isn't needed anymore? > > Asking in case

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #32 from Victor Grousset/tuxayo --- Do you confirm the commit/patch "Bug 36111: removes display of fields 856y3z if not 856u" isn't needed anymore? Asking in case there was a confusion about removing the duplicate test

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #31 from Matthias Le Gac --- When I had made my modifications in the first commit, I had indented the code, which generated a lot of differences with the code and didn't make it easy to understand where I had really made

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164429|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #28 from Matthias Le Gac --- (In reply to Victor Grousset/tuxayo from comment #24) I put the last test plan in the first commit and removed the test plan in the second commit. -- You are receiving this mail because:

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164429|1 |0 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164275|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164276|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164429|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164275|1 |0 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164275|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #25 from Victor Grousset/tuxayo --- @Owen when you signed-off, did you use the full test plan that is in the second commit? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #24 from Victor Grousset/tuxayo --- (In reply to Matthias Le Gac from comment #21) > I put the test plan in the commit message I missed that there was again the 1st mistake: so indeed the patch on comment 18 didn't have

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #23 from Owen Leonard --- Created attachment 164276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164276=edit Bug 36111: removes display of fields 856y3z if not 856u Test plan: 1. Add 856$h to MARC

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Owen Leonard changed: What|Removed |Added Attachment #162406|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #21 from Matthias Le Gac --- I put the test plan in the commit message It's better now? -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164029|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #19 from Victor Grousset/tuxayo --- Thanks for the additional steps :) The back to need signoff now is clear, there is additional behavior to test. Remaining is the issue of the 1st patch having the old test plan. So

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #163876|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #17 from Matthias Le Gac --- Ok I understand I will change the plan test to test the fix -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #16 from Victor Grousset/tuxayo --- Hi :) The second patch now duplicates the test plan of the 1st patch. That will cause confusion. About the switch back to Needs Signoff: are the steps to test the additional changes

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #15 from Matthias Le Gac --- Created attachment 163876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163876=edit Bug 36111: removes display of fields 856 if not 856 Test plan: 1. Add 856$h to MARC

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #14 from Victor Grousset/tuxayo --- No need, David did it when signing off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #13 from Matthias Le Gac --- (In reply to Victor Grousset/tuxayo from comment #12) > > For some reason, when I signed off the patch the test plan was not > > included. I have amended the patch to include a description

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Text to go in the|This fixes the display of |This fixes the display of

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Text to go in the|This fixes the display of |This fixes the display of

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |matthias.le-...@inlibro.com

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Attachment #162405|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Attachment #162322|0 |1 is obsolete|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Esther Melander changed: What|Removed |Added CC|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added CC|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #7 from Matthias Le Gac --- Created attachment 162322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162322=edit Bug 36111: 856$h should not appear as a link in detailed record Test Plan : 1. Add

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #6 from Heather --- That's a great use of the field, Caroline--thank you for mentioning it! (And that the frameworks aren't updated for existing installations--alerts me to some changes I might want to make!) I could

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #5 from Caroline Cyr La Rose --- (In reply to Heather from comment #3) > I would completely hide this subfield in my OPAC *and* staff client, frankly! I'm using this field for a migration where all the links have to be

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #4 from Caroline Cyr La Rose --- (In reply to Heather from comment #3) > (The label for the field should also be changed from "Processor of request" > to "Non-functioning URI" to conform to the MARC21 standard. IMO.)

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #3 from Heather --- I was able to replicate this and IMO it's bad--very, very bad! I even had "Is a URL:" in the Framework unchecked, and a clickable "Click here to access online" was still displayed. I would

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Caroline Cyr La Rose changed: What|Removed |Added CC|

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #2 from Caroline Cyr La Rose --- I also tried only filling out 856$s (file size) and the link appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #1 from Caroline Cyr La Rose --- Info about 856 https://www.loc.gov/marc/bibliographic/bd856.html 856$h Non-functioning Uniform Resource Identifier Uniform Resource Identifier (URI), which is no longer functional, for