https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #15 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Tomás Cohen Arazi from comment #13)
> > (In reply to Jonathan Druart from comment #11)
> > > 2. So far we have decided to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #14 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #13)
> (In reply to Jonathan Druart from comment #11)
> > 2. So far we have decided to provide what is implemented/used. With this we
> > will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #13 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #11)
> It could work to reduce the number of lines in the -api-client.js.
>
> Two points however:
> 1. The endpoint need to be configurable.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #12 from Paul Derscheid ---
I have implemented something similar before. In this case we can't have
simplicity and flexibility. The more flexible the api-client-base is, the more
complex it will become.
I think we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #11 from Jonathan Druart ---
It could work to reduce the number of lines in the -api-client.js.
Two points however:
1. The endpoint need to be configurable. 'this._baseURL + "/" + id' is too
simple and does not work for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
0xfun changed:
What|Removed |Added
CC||m...@paulderscheid.xyz
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #164201|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #8 from Tomás Cohen Arazi ---
Sorry for the delay y'all. I didn't manage to make this work. But I think it
highlights the idea of what I tried to propose.
api-client-base.js could be implemented as an http-client.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #7 from Tomás Cohen Arazi ---
Created attachment 164201
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164201=edit
Bug 36369: Introduce an APIClientBase class
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #6 from Paul Derscheid ---
If you want to validate input before passing it to api clients, please use zod
or something similar.
That makes it very declarative and easy to maintain.
Here's a list of options compared by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #5 from Kyle M Hall ---
(In reply to Tomás Cohen Arazi from comment #4)
> (In reply to Kyle M Hall from comment #2)
> > Is there any reason not to build the javascript version of our OpenAPI spec
> > and use that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #4 from Tomás Cohen Arazi ---
(In reply to Kyle M Hall from comment #2)
> Is there any reason not to build the javascript version of our OpenAPI spec
> and use that internally?
You mean for validating outgoing requests?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #3 from Tomás Cohen Arazi ---
(In reply to Pedro Amorim from comment #1)
> I think this makes sense.
> Tomas are you able to provide a PoC we can use as a starting point to look
> at / discuss?
Yes, it is my plan for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #2 from Kyle M Hall ---
Is there any reason not to build the javascript version of our OpenAPI spec and
use that internally?
--
You are receiving this mail because:
You are watching all bug changes.
You are the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #1 from Pedro Amorim ---
I think this makes sense.
Tomas are you able to provide a PoC we can use as a starting point to look at /
discuss?
--
You are receiving this mail because:
You are watching all bug changes.
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
Tomás Cohen Arazi changed:
What|Removed |Added
CC|
17 matches
Mail list logo
