http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Jonathan Druart changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Sally Healey changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #92 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #91)
> Comment on attachment 42609 [details] [review]
> Bug-6810: Send membership expiry reminder notices.
>
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #91 from Jonathan Druart
---
Comment on attachment 42609
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42609
Bug-6810: Send membership expiry reminder notices.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Tomás Cohen Arazi changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Mike changed:
What|Removed |Added
CC||blac...@gmail.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #89 from Marcel de Rooy ---
Created attachment 42700
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42700=edit
Bug 6810: [QA Follow-up] Exit cronjob if pref not set
As per
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit Gupta changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marcel de Rooy changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marcel de Rooy changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marcel de Rooy changed:
What|Removed |Added
Attachment #41916|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marcel de Rooy changed:
What|Removed |Added
Attachment #40665|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marcel de Rooy changed:
What|Removed |Added
Attachment #40700|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #85 from Marcel de Rooy ---
Created attachment 42612
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42612=edit
Bug 6810: [QA Follow-up] Move test file to db_dependent
Note that
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marcel de Rooy changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #83 from Marcel de Rooy ---
Created attachment 42610
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42610=edit
Bug 6810 - Add new systempreference (MembershipExpiryDaysNotice)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #86 from Marcel de Rooy ---
Created attachment 42613
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42613=edit
Bug 6810: [QA Follow-up] Some minor tidying up of cron script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #82 from Marcel de Rooy ---
Created attachment 42609
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42609=edit
Bug-6810: Send membership expiry reminder notices.
A new crontab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|Medium patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #88 from Marcel de Rooy ---
And for the record: We should still add this new cron job to the example file
and somewhere commented in a cron file for the packages..
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #80 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 41916
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41916action=edit
Bug 6810 - Fix QA failures
- remove DateTime-now()
- use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Alex Arnaud alex.arn...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Alex Arnaud alex.arn...@biblibre.com changed:
What|Removed |Added
Attachment #40766|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #78 from Jonathan Druart jonathan.dru...@biblibre.com ---
FAIL C4/Members.pm
OK critic
FAIL forbidden patterns
forbidden pattern: trailing space char (line 1493)
OK pod
OK
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Attachment #40701|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Attachment #40685|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #77 from Amit amitddng...@gmail.com ---
Created attachment 40701
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40701action=edit
Bug 6810: Squashed Fixes QA failures
Bug 6810 - Fix QA failures -- Squashed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #59 from Amit amitddng...@gmail.com ---
Created attachment 40641
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40641action=edit
Bug 6810 - Fix QA failures
Bug 6810 - Fix QA failures
- remove
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #60 from Amit amitddng...@gmail.com ---
Created attachment 40642
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40642action=edit
Bug 6810 - Fix QA failures
MembershipExpiryDaysNotice system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #61 from Amit amitddng...@gmail.com ---
Created attachment 40643
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40643action=edit
Bug 6810 - Fix QA failures
Change letter code from MEMEXP to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Attachment #40641|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #63 from Amit amitddng...@gmail.com ---
Created attachment 40645
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40645action=edit
Bug 6810 - Fix QA failures
MembershipExpiryDaysNotice system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #64 from Amit amitddng...@gmail.com ---
Created attachment 40646
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40646action=edit
Bug 6810 - Fix QA failures
Change letter code from MEMEXP to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Attachment #40121|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #32683|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #40120|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #40644|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Mirko Tietgen mi...@abunchofthings.net changed:
What|Removed |Added
CC|mi...@abunchofthings.net|
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #69 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 40667
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40667
Bug 6810: Squashed Amit Gupta's patches
Review of attachment 40667:
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Attachment #40666|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #71 from Amit amitddng...@gmail.com ---
Created attachment 40686
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40686action=edit
Bug 6810 - Fix QA failures
--
You are receiving this mail because:
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #74 from Amit amitddng...@gmail.com ---
Created attachment 40689
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40689action=edit
Bug 6810 - Fix QA failures
MembershipExpiryDaysNotice system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #75 from Amit amitddng...@gmail.com ---
Created attachment 40690
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40690action=edit
Bug-6810-Add-sample-notices
Review comments implemented
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
CC|mtomp...@hotmail.com|
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #72 from Amit amitddng...@gmail.com ---
Created attachment 40687
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40687action=edit
Bug 6810 - Fix QA failures
--
You are receiving this mail because:
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #73 from Amit amitddng...@gmail.com ---
Created attachment 40688
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40688action=edit
Bug 6810 - Fix QA failures
- remove DateTime-now()
- use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #56 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Mirko Tietgen from comment #55)
I agree with Katrin. I don't think the assumption that the librarian is
an/the IT person is necessarily correct for small
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Mirko Tietgen mi...@abunchofthings.net changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #57 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Katrin Fischer from comment #54)
I am not a fan of the override idea. I think either/or. I think otherwise
it's just confusing things unnecessarily.
This is a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #53 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Katrin Fischer from comment #52)
A command line option is a disavantage for package installations with
multiple instances, but also for small libraries. If it's a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #54 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am not a fan of the override idea. I think either/or. I think otherwise it's
just confusing things unnecessarily. This is a new feature, so we don't need to
retain old
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #51 from Fridolin SOMERS fridolin.som...@biblibre.com ---
A syspref again :(
We could give the period as argument of script.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #52 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
A command line option is a disavantage for package installations with multiple
instances, but also for small libraries. If it's a pref, any librarian can
change it, but
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Alex Arnaud alex.arn...@biblibre.com changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Indranil Das Gupta indr...@gmail.com changed:
What|Removed |Added
Attachment #40179|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Indranil Das Gupta indr...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #49 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40179
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40179action=edit
[Followup-up] Bug 6810 - Fix QA failures:
- use Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
QA Contact|alex.arn...@biblibre.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #48 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 40122
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40122
Bug 6810 - Fix QA failures
Review of attachment 40122:
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Indranil Das Gupta indr...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Indranil Das Gupta indr...@gmail.com changed:
What|Removed |Added
Attachment #40091|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Indranil Das Gupta indr...@gmail.com changed:
What|Removed |Added
Attachment #40100|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Indranil Das Gupta indr...@gmail.com changed:
What|Removed |Added
Attachment #40090|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Alex Arnaud alex.arn...@biblibre.com changed:
What|Removed |Added
QA Contact|koha-b...@lists.koha-commun
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #44 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40100
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40100action=edit
[follow-up] Bug 6810 - Fix QA failures
- Use KohaDates to convert
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Alex Arnaud alex.arn...@biblibre.com changed:
What|Removed |Added
Assignee|amitddng...@gmail.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #42 from Alex Arnaud alex.arn...@biblibre.com ---
Rebased the patches and replaced those which add sample notices and those which
add syspref (using now atomic update).
For the next step i will fix M. Tompsett QA comments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #41 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40091
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40091action=edit
Bug 6810 - Add sample notices
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Alex++ :)
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Alex Arnaud alex.arn...@biblibre.com changed:
What|Removed |Added
Attachment #32692|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Status|Patch doesn't apply |ASSIGNED
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #39 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 32692
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32692
Bug 6810 [Revised] Add new systempreference and sample notice (Membership
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Status|Needs Signoff |Patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Status|ASSIGNED|Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #37 from M. Tompsett mtomp...@hotmail.com ---
Patch does not apply.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #38 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 32683
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32683
[SIGNED-OFF] Bug-6810: Send membership expiry reminder notices.
Review of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marc Véron ve...@veron.ch changed:
What|Removed |Added
CC||ve...@veron.ch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Nick Clemens n...@quecheelibrary.org changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Status|ASSIGNED|Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #30 from Owen Leonard oleon...@myacpl.org ---
Created attachment 33954
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33954action=edit
Bug 6810 [Sample notices follow-up] Send membership expiry reminder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #31 from Owen Leonard oleon...@myacpl.org ---
- Can you please add the new sample notice to the non-English web-installers
as well?
I have added a patch for this because my library would really like to have this
feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #32 from Amit amitddng...@gmail.com ---
Hi Owen,
I have written some test cases will share by this monday.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
CC||indr...@gmail.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Amit amitddng...@gmail.com changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Attachment #21870|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Attachment #22459|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Attachment #32684|0 |1
1 - 100 of 134 matches
Mail list logo