http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Alex Arnaud alex.arn...@biblibre.com changed:
What|Removed |Added
Blocks||7710
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Alex Arnaud alex.arn...@biblibre.com changed:
What|Removed |Added
Blocks|7710|
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Tomás Cohen Arazi tomasco...@gmail.com changed:
What|Removed |Added
Blocks||10949
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Tomás Cohen Arazi tomasco...@gmail.com changed:
What|Removed |Added
Blocks||10247
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Attachment #18465|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #42 from Galen Charlton gmcha...@gmail.com ---
Created attachment 19895
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19895action=edit
Bug 9394: (follow-up) modernize test cases
- wrap in a transaction
-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #45 from Galen Charlton gmcha...@gmail.com ---
Created attachment 19898
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19898action=edit
Bug 9394: (follow-up) fix query column alias
A change-and-replace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #47 from Galen Charlton gmcha...@gmail.com ---
This is about ready to go. I've attached the patches along with several
follows; setting status to signed-off for a final QA pass, particularly of the
follow-ups.
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #19893|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #19894|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #19895|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #19896|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #19897|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #19898|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #19899|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|Passed QA |Pushed to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #39 from Galen Charlton gmcha...@gmail.com ---
Update during testing; I discover that the ability to cancel holds from the
patron summary (i.e., members/moremember.pl) was broken. A follow-up along the
lines of Jonathan's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #36 from Galen Charlton gmcha...@gmail.com ---
I've started reviewing this. One thing that jumped out -- the QA follow-up
(re?)introduces a change in the behavior of AlterPriority that should get a
test case. I'll deal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #37 from Kyle M Hall kyle.m.h...@gmail.com ---
(In reply to comment #36)
I've started reviewing this. One thing that jumped out -- the QA follow-up
(re?)introduces a change in the behavior of AlterPriority that should
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #38 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #37)
Good catch! I'm re-evaluating it right now and I don't think it's going to
affect anything. Koha does not expose canceled reserves iirc, so a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Needs Signoff |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #18492|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #31)
(In reply to comment #29)
Created attachment 18466 [details] [review] [review]
Bug 9394: QA Followup
* C4::Reserves::GetReserveId
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #18466|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #18318|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18466
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18466action=edit
Bug 9394: QA Followup
* C4::Reserves::_FixPriority
- The
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #31 from Maxime Pelletier pelletiermax...@gmail.com ---
(In reply to comment #29)
Created attachment 18466 [details] [review]
Bug 9394: QA Followup
* C4::Reserves::GetReserveId
This subroutine did not have a unit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
cedric.v...@dracenie.com changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Maxime Pelletier pelletiermax...@gmail.com changed:
What|Removed |Added
Attachment #17447|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Maxime Pelletier pelletiermax...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Maxime Pelletier pelletiermax...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18216
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18216action=edit
Bug 9394 - Use reserve_id where possible - Followup
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #23 from Kyle M Hall kyle.m.h...@gmail.com ---
Followup adds the lines from 7710 that needed to be in this patch set instead.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #21 from Kyle M Hall kyle.m.h...@gmail.com ---
That looks good to me!
Kyle, is there anything else I need to touch to test this?
No koha-qa errors :-)
--
You are receiving this mail because:
You are watching all bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #16676|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall kyle.m.h...@gmail.com changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks||5696
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle, this is a bit confusing - it seems 7710 depends on 9394 and vice
versa?
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Fridolyn SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Patch doesn't apply |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #15733|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
cedric.v...@dracenie.com changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Please don't limit testing to running the test suite, but also check the test
plan in comment 3 and beyond. This is quite a big change.
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #14863|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #15730|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Do you mean the sample data that comes pre-packaged with an install? No. I
used some local sample data.
Yes, that's what I meant. However, all you really need to do is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Holds.t is db dependent and requires the use of the default sample data ( or at
least a branch with the branchcode CPL ).
Did you run the test on a system using the sample
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #9 from David Cook dc...@prosentient.com.au ---
(In reply to comment #8)
Holds.t is db dependent and requires the use of the default sample data ( or
at least a branch with the branchcode CPL ).
Did you run the test on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
David Cook dc...@prosentient.com.au changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
David Cook dc...@prosentient.com.au changed:
What|Removed |Added
Status|Needs Signoff |Failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com ---
For changes of this scope there really needs to be a unit test that will check
for regressions.
--
You are receiving this mail because:
You are watching all bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #14601|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #14860|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14601
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14601action=edit
Bug 9394 - Use reserve_id where possible
This patch switches from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|NEW |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Depends on||7710
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Depends on|7710|
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Blocks||7710
69 matches
Mail list logo
