[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Pongtawat  changed:

   What|Removed |Added

 CC||pongta...@punsarn.asia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17143] New: Popup Notification for decreaseloanhighholds preference

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Bug ID: 17143
   Summary: Popup Notification for decreaseloanhighholds
preference
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If you have an item that meets the holds requirement by the
decreaseloanhighholds preference, but doesn’t get a decrease in the actual
checkout period; you still get a popup notification that the high demand
feature is being used and the loan period will be decreased. The notification
shouldn't populate if the decreased loan period matches or is higher than the
original loan period.  The current behavior in the system looks at the the
number of holds and doesn't take the loan periods with an equal value into
consideration when enforcing the preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16371] Quote of the Day (QOTD) - Display in different interfaces

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14642] Add logging of hold modifications

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #28 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Tomas, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14642] Add logging of hold modifications

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
  Attachment #53466|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #7 from Nick Clemens  ---
Yes it does

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #19 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14844] Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted.

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Olli!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17103] Google API Loader jsapi called over http

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Indranil!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|16942   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942
[Bug 16942] Confirm hold results in ugly error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA
 Blocks|14695   |

--- Comment #10 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Jonathan Druart from comment #4)
> > Kyle, the following test should fail without this patch:
> >   is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly'
> > );
> > 
> > Could you please adapt it?
> 
> The test still passes.

They unit tests fail for me without the initial patch applied.

prove t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Letters/TemplateToolkit.t .. 1/14 DBD::mysql::st execute failed:
You have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near 'BIBLIONUMBER '557' AND
`ARRAY(0x8818f68)` BORROWERNUMBER '140' ) AND `ARRAY(0x88' at line 1 [for
Statement "SELECT `me`.`reserve_id`, `me`.`borrowernumber`, `me`.`reservedate`,
`me`.`biblionumber`, `me`.`branchcode`, `me`.`notificationdate`,
`me`.`reminderdate`, `me`.`cancellationdate`, `me`.`reservenotes`,
`me`.`priority`, `me`.`found`, `me`.`timestamp`, `me`.`itemnumber`,
`me`.`waitingdate`, `me`.`expirationdate`, `me`.`lowestPriority`,
`me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype` FROM `reserves` `me`
WHERE ( ( ( `ARRAY(0x8818f68)` BIBLIONUMBER ? AND `ARRAY(0x8818f68)`
BORROWERNUMBER ? ) AND `ARRAY(0x8818f68)` RESERVE_ID ? ) )" with ParamValues:
0='557', 1='140', 2='114'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1832.
DBD::mysql::st execute failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near 'BIBLIONUMBER '557' AND `ARRAY(0x8818f68)` BORROWERNUMBER '140' ) AND
`ARRAY(0x88' at line 1 [for Statement "SELECT `me`.`reserve_id`,
`me`.`borrowernumber`, `me`.`reservedate`, `me`.`biblionumber`,
`me`.`branchcode`, `me`.`notificationdate`, `me`.`reminderdate`,
`me`.`cancellationdate`, `me`.`reservenotes`, `me`.`priority`, `me`.`found`,
`me`.`timestamp`, `me`.`itemnumber`, `me`.`waitingdate`, `me`.`expirationdate`,
`me`.`lowestPriority`, `me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype`
FROM `reserves` `me` WHERE ( ( ( `ARRAY(0x8818f68)` BIBLIONUMBER ? AND
`ARRAY(0x8818f68)` BORROWERNUMBER ? ) AND `ARRAY(0x8818f68)` RESERVE_ID ? ) )"
with ParamValues: 0='557', 1='140', 2='114'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
# Looks like your test exited with 255 just after 8.
t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
Failed 6/14 subtests

Test Summary Report
---
t/db_dependent/Letters/TemplateToolkit.t (Wstat: 65280 Tests: 8 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 14 tests but ran 8.
Files=1, Tests=8,  3 wallclock secs ( 0.02 usr  0.01 sys +  1.74 cusr  0.18
csys =  1.95 CPU)
Result: FAIL


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695
[Bug 14695] Add ability to place multiple item holds on a given record per
patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #172 from Kyle M Hall  ---
Created attachment 54559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54559=edit
Bug 14695 [QA Followup] - Tell librarian if item doesn't allow or forces item
level holds in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #166 from Kyle M Hall  ---
Created attachment 54553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54553=edit
Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout

Signed-off-by: Nick Clemens 

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #171 from Kyle M Hall  ---
Created attachment 54558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54558=edit
Bug 14695 [QA Followup] - Disable "Holds to place (count)" unless "Hold next
available item" is checked

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #169 from Kyle M Hall  ---
Created attachment 54556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54556=edit
Bug 14695 [QA Followup] - Fix method names 'type' to '_type'

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #167 from Kyle M Hall  ---
Created attachment 54554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54554=edit
Bug 14695 - Warn librarian if max_holds_per_record is reached

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #165 from Kyle M Hall  ---
Created attachment 54552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54552=edit
Bug 14695 [QA Followup] - Make existing unit tests pass

* Removes tests no longer needed
* Updates rules to work with existing tests
* Fixes code issues revealed by unit tests

Signed-off-by: Nick Clemens 

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #168 from Kyle M Hall  ---
Created attachment 54555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54555=edit
Bug 14695 - Don't use holds_to_place_count when checking an item.

This fix the following bug:
If you select 2 in "Holds to place (count)" and finally
check an item, so you get 2 holds for the same item.

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #170 from Kyle M Hall  ---
Created attachment 54557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54557=edit
Bug 14695: Fix typo in template

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #162 from Kyle M Hall  ---
Created attachment 54549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54549=edit
Bug 14695 - Tidy C4::Reserves::CanItemBeReserved

Signed-off-by: Nick Clemens 

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #164 from Kyle M Hall  ---
Created attachment 54551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54551=edit
Bug 14695 [QA Followup] - Filling one hold fills all of them

Signed-off-by: Nick Clemens 

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #51277|0   |1
is obsolete||
  Attachment #51278|0   |1
is obsolete||
  Attachment #51279|0   |1
is obsolete||
  Attachment #51280|0   |1
is obsolete||
  Attachment #51281|0   |1
is obsolete||
  Attachment #51282|0   |1
is obsolete||
  Attachment #51283|0   |1
is obsolete||
  Attachment #51284|0   |1
is obsolete||
  Attachment #51285|0   |1
is obsolete||
  Attachment #51286|0   |1
is obsolete||
  Attachment #51287|0   |1
is obsolete||
  Attachment #51288|0   |1
is obsolete||
  Attachment #51289|0   |1
is obsolete||
  Attachment #52457|0   |1
is obsolete||

--- Comment #159 from Kyle M Hall  ---
Created attachment 54546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54546=edit
Bug 14695 - Update database

Signed-off-by: Nick Clemens 

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #161 from Kyle M Hall  ---
Created attachment 54548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54548=edit
Bug 14695 - Add new circulation rule

Signed-off-by: Nick Clemens 

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #163 from Kyle M Hall  ---
Created attachment 54550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54550=edit
Bug 14695 - Add ability to place multiple item holds on a given record per
patron

Signed-off-by: Nick Clemens 

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

--- Comment #160 from Kyle M Hall  ---
Created attachment 54547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54547=edit
Bug 14695 - Update DB Schema file

Signed-off-by: Nick Clemens 

Signed-off-by: Jason M. Burds 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16942] Confirm hold results in ugly error

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||14695


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695
[Bug 14695] Add ability to place multiple item holds on a given record per
patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||16942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942
[Bug 16942] Confirm hold results in ugly error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14668] Show serial enumeration in the patron's opac checkout summary

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668

Aliki Pavlidou  changed:

   What|Removed |Added

 CC||pavlidoual...@gmail.com

--- Comment #11 from Aliki Pavlidou  ---
Hello everybody!


1. THE CHECKOUT TAB, INTRANET

First things first there was no "h" subfield at the editing page of an item.

The "h" subfield for items.enumchron is in "MARC21 Holding field (952)".
The matching "v" subfield is in UNIMARC Holding field (995), which was showing
at the editing page.
So I tested it by adding the values "volume 42" in the following subfield "v -
Note sur le N° de périodique". 
In this perspective everything worked just fine and the enumchron was
concatenated with the title, and the barcode.


2. A PATRON'S RELATIVE, INTRANET + OPAC

The enumchron was in the "Relatives' checkouts" tab, of the guarantor's
checkout page.


P.S.: Please let me know if there is something I should do to check it with the
"h" subfield.

Best regards
Aliki

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17142] Don' t show library group selection in advanced search if groups are not defined

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jacek Ablewicz  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17142] Don' t show library group selection in advanced search if groups are not defined

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jacek Ablewicz  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17142] Don' t show library group selection in advanced search if groups are not defined

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

--- Comment #1 from Jacek Ablewicz  ---
Created attachment 54545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54545=edit
Bug 17142 - Don't show library group selection in advanced search if groups are
not defined

Even if library groups/search domains are not defined in the system,
(empty) select for "Groups of libraries" under "Location and
availability" section in OPAC advanced search is still visible; it
shouldn't. Side effect of Bug 15295 - 'searchdomainloop' variable
in the template is now an object, it needs a different kind of statement
(.count) for checking if it's empty or not.

To test:

1) apply patch
2) when there are no groups of libraries defined in Administration ->
Libraries and Groups, "Groups of libraries" selection should be
no longer visible in OPAC adavanced search page
3) add library group or two: "Groups of libraries" selection should
reappear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17142] New: Don' t show library group selection in advanced search if groups are not defined

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Bug ID: 17142
   Summary: Don't show library group selection in advanced search
if groups are not defined
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: a...@biblos.pk.edu.pl
QA Contact: testo...@bugs.koha-community.org

Even if library groups/search domains are not defined in the system, (empty)
select for "Groups of libraries" under "Location and availability" section in
OPAC advanced search is still visible; it shouldn't. Side effect of Bug 15295 -
'searchdomainloop' variable in the template is now an object, it needs a
different kind of statement (.count) to check if it's empty or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17142] Don' t show library group selection in advanced search if groups are not defined

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142

Jacek Ablewicz  changed:

   What|Removed |Added

 Depends on||15295


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295
[Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295

Jacek Ablewicz  changed:

   What|Removed |Added

 Blocks||17142


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142
[Bug 17142] Don't show library group selection in advanced search if groups are
not defined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get logdir

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Colin Campbell  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com
 Status|NEW |Needs Signoff

--- Comment #1 from Colin Campbell  ---
Created attachment 54544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54544=edit
Proposed patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17141] Incorrect method called in edi_cron to get logdir

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Colin Campbell  changed:

   What|Removed |Added

Summary|Incorrect method called in  |Incorrect method called in
   |edit_cron to get logdir |edi_cron to get logdir

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17141] New: Incorrect method called in edit_cron to get logdir

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141

Bug ID: 17141
   Summary: Incorrect method called in edit_cron to get logdir
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

Should call the config method to retrieve the logdir otherwise an error is
generated at runtime

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14535] Late orders doensn't show orders with price = 0

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535

--- Comment #2 from Katrin Fischer  ---
Just had another library reporting this as a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account:: pay internally for recordpayment

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895

Lari Taskula  changed:

   What|Removed |Added

  Attachment #53883|0   |1
is obsolete||

--- Comment #18 from Lari Taskula  ---
Created attachment 54543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54543=edit
Bug 15895 - Add Koha::Account module, use Koha::Account::pay internally for
recordpayment

This is the first patch in a series to unify all payment functions into
a single method.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
3) Test fine payment via the "Pay amount" button

Signed-off-by: Owen Leonard 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Lari Taskula  changed:

   What|Removed |Added

 Depends on||15741


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741
[Bug 15741] Incorrect rounding in total fines calculations
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741

Lari Taskula  changed:

   What|Removed |Added

 Blocks||17140


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140
[Bug 17140] Incorrect rounding in total fines calculations, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #1 from Lari Taskula  ---
Created attachment 54542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54542=edit
Bug 17140: Test to cover more rounding issues in fines calculations

To test:
1. Run t/db_dependent/Members.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] New: Incorrect rounding in total fines calculations, part 2

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Bug ID: 17140
   Summary: Incorrect rounding in total fines calculations, part 2
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: la...@student.uef.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Bug 15741 fixes some rounding issues but not all, for example trying to paying
a fine of 1.14 still does not work (also 1.39).

To replicate bug:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Go to Pay fines tab
7. Click "Pay selected" and confirm
8. Observe error message "You must pay a value less than or equal to 1.14."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #25 from M. Tompsett  ---
The addbiblio.tt conflict is easy enough to resolve, though you need to look
into fontawesome classes instead of icon-ok.

The C4/Biblio.pm conflict is harder to resolve, as the logic which is ripped
out and replaced with a function has changed. This means the logic in the new
function needed to be rechecked.

Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #8 from M. Tompsett  ---
Rebased. Kitten saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett  changed:

   What|Removed |Added

  Attachment #54540|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 54541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54541=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
 in jessie is just fine and should be added to the community
 repo if wheezy will be supported for the coming release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685

M. Tompsett  changed:

   What|Removed |Added

  Attachment #52902|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 54540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54540=edit
Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp

File::Slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
 in jessie is just fine and should be added to the community
 repo if wheezy will be supported for the coming release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17139] Translation process should not pick class value inside span tags

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17139

--- Comment #1 from Marc Véron  ---
...but we have:




Inside abbr tag, "Used For" should be translatable (is picked by translation
process).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

M. Tompsett  changed:

   What|Removed |Added

  Attachment #51228|0   |1
is obsolete||

--- Comment #9 from M. Tompsett  ---
Created attachment 54539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54539=edit
Bug 16258 Add a syspref to govern EDIFACT functionality

Adds an "Edifact" systempreference to govern whether edifact processing
is enabled. In most places this is hidden if the current
vendor does not appear in the edi vendors table. This preference
hides the admin screens which define this and a couple of links.

Also fixes an anomaly whereby the basketgroup screen was not
making the same check on whether edi ordering should be enabled as
the basket screen. Both now use the same logic.

Rebase by mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17139] New: Translation process should not pick class value inside span tags

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17139

Bug ID: 17139
   Summary: Translation process should not pick class value inside
span tags
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Example:

koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
line 14:
 

BT is picked for translation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor search template

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

--- Comment #13 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor search template

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

--- Comment #12 from Julian Maurice  ---
Created attachment 54538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54538=edit
[3.22.x] Bug 16450 - Remove the use of "onclick" from guarantor search template

This patch updates the guarantor search template so that event
definition is done in the script rather than in an onclick attribute.

This patch also increases the size of the popup window to help prevent
the need for horizontal scrolling and adds Bootstrap style to the
"select" button.

To test, apply the patch and clear your browser cache if necessary.

- Go to Patrons and add a patron with a "child" category type.
- In the "Guarantor information" section, click the "Set to patron"
  button.
- In the pop-up window, search for a patron.
- Click the "Select" button next to a patron.
- The window should close, and the patron you selected should now appear
  as the guarantor. The guarantor's address information should be added
  to the "Main address" section.

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13736] Enable EDS Plugin Patch

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736

--- Comment #5 from M. Tompsett  ---
Comment on attachment 42894
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42894
EDS Plugin Patches Code checks to see if  setting EDSEnabled is ON and
integrates the EDS Plugin to the Opac

Review of attachment 42894:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=13736=42894)
-

I'm pretty sure something jquery/ajax-y could be written to get the plugin to
accomplish the same thing. I too, like Katrin in comment #4, have some
misgivings about this implementation.

::: C4/Auth.pm
@@ +471,4 @@
>  AuthorisedValueImages => 
> C4::Context->preference("AuthorisedValueImages"),
>  BranchesLoop  => 
> GetBranchesLoop($opac_name),
>  BranchCategoriesLoop  => GetBranchCategories( 
> 'searchdomain', 1, $opac_name ),
> + EDSEnabled=> 
> C4::Context->preference("EDSEnabled"),

Never needed.
Access [% Koha.Preference('EDSEnabled') %] in template files.

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
@@ +48,4 @@
>  function _(s) { return s } // dummy function for gettext
>  
>  
> +[% IF ( EDSEnabled ) %] src="/plugin/Koha/Plugin/EDS/js/EDSScript.js">[% END %]

Including a plugin javascript link should be possible in the OPACUserJS system
preference. Make sure to carefully add/remove as needed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13914] The holds statistics report returns random data

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

Sophie MEYNIEUX  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |sophie.meyni...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor search template

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

--- Comment #11 from Christopher Brannon  ---
(In reply to Julian Maurice from comment #10)
> (In reply to Owen Leonard from comment #7)
> > I think this patch will fix Bug 16756 (a 3.22.x bug), but is it problematic
> > that it depends on Bug 16386?
> 
> This patch seems not to be really dependent on bug 16386 (except that it was
> written on top of it).
> I'll try to write a patch for 3.22.x

That is awesome.  Thank you.  :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16450] Remove the use of "onclick" from guarantor search template

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #10 from Julian Maurice  ---
(In reply to Owen Leonard from comment #7)
> I think this patch will fix Bug 16756 (a 3.22.x bug), but is it problematic
> that it depends on Bug 16386?

This patch seems not to be really dependent on bug 16386 (except that it was
written on top of it).
I'll try to write a patch for 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372

Julian Maurice  changed:

   What|Removed |Added

 Depends on||16058
 CC||julian.maur...@biblibre.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058
[Bug 16058] Add a button to delete an individual news item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16058] Add a button to delete an individual news item

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058

Julian Maurice  changed:

   What|Removed |Added

 Blocks||16372


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372
[Bug 16372] Replace the use of "onclick" for deletion confirmation in some
templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

--- Comment #1 from Jacek Ablewicz  ---
Dunno how to resolve this problem properly

- reintroduce due date to the issue record <-> fine record matching in
UpdateFine()
- unlink fine record from the issue record on renewal (set issue_id to NULL in
fine record)
- set fine type to 'F' on renewal, and ignore records of such type in the
matching code in UpdateFine()

or maybe some combination of the above? I think this problem can happen only
when there is at least 1 renewal of due item involved (any kind of renewal),
but I'm not entirely sure. All that legacy fine calculation code works in truly
mysterious ways.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14251] style discharge letter

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

--- Comment #7 from Katrin Fischer  ---
Not totally sure - we haven't played much with the discharge notices so far.

We have added a few line breaks so far, but no more formatting I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #26 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #16 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17062] debian/control.in update: change maintainer & add libhtml-parser-perl

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #6 from Frédéric Demians  ---
See 17063 for 16.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17068] empty list item in opac-reserves.tt

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17044] Wrong destination for 'api' directory

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16809] Silence CGI param warnings from C4::Biblio:: TransformHtmlToMarc

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Silence authority warnings  |Silence CGI param warnings
   |C4::Biblio::TransformHtmlTo |from
   |Marc|C4::Biblio::TransformHtmlTo
   ||Marc
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15164] Allow editing of the invoice number after initial saving

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

--- Comment #3 from Kyle M Hall  ---
Created attachment 54537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54537=edit
Bug 15164 - Allow editing of the invoice number after initial saving

When you notice a typo in your invoice number after finishing with the
receiving process, the only way to correct it right now is in the
database - or by undoing all the steps and starting over.

It would be nice if the invoice number could be edited.

Test Plan:
1) Apply this patch
2) Browse to acqui/invoice.pl for an invoice
3) Note the new "Invoice number" field contains the existing invoice
4) Alter the invoice number
5) Save the invoice
6) Note the invoice number has been updated
7) Edit the invoice again
8) Attempt to save the invoice with an empty invoice number field
9) Note that you cannot save the invoice without having an invoice number

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15164] Allow editing of the invoice number after initial saving

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #11 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16727] Upload tool needs better warning

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971

--- Comment #9 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14251] style discharge letter

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

Sophie MEYNIEUX  changed:

   What|Removed |Added

 CC||sophie.meyni...@biblibre.co
   ||m

--- Comment #6 from Sophie MEYNIEUX  ---
Katrin, are you sure CSS is used ?
I see the code uses PDF::FromHTML to produce the pd file or the documentation
says "it is not designed to utilise CSS."
(http://search.cpan.org/~audreyt/PDF-FromHTML-0.31/lib/PDF/FromHTML.pm)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16809] Silence authority warnings C4::Biblio::TransformHtmlToMarc

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16809] Silence authority warnings C4::Biblio::TransformHtmlToMarc

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

--- Comment #5 from Marcel de Rooy  ---
Created attachment 54536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54536=edit
Bug 16809: Follow-up for scalarizing biblionumber

Still resolves another multi_param warning.

Test plan:
Look at your logs before and after this patch when saving a biblio
record (you may have to start plack again).
If your biblionumber is mapped to 999c, you should no longer have a warn
about line 2563 (disclaimer: line numbers are subject to change).

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16809] Silence authority warnings C4::Biblio::TransformHtmlToMarc

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #52832|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 54535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54535=edit
Bug 16809: Silence authority warnings C4::Biblio::TransformHtmlToMarc

Most of the floodiness is caused by accessing the cgi parameters
in a context which is hard to determine. By purposefully saving
the value to a scalar variable and using the variable, the issue
disappears, and it will likely be a tiny tad faster as variable
access is faster than multiple function calls.

TEST PLAN
-
 1) Back up your intranet error log
-- for example:
   cp ~/koha-dev/var/log/koha-error-log ~/koha-error-log.backup
 2) Blank your intranet error log
-- for example:
   echo > ~/koha-dev/var/log/koha-error-log
 3) Log into your staff client
 4) Click 'Authorities'
 5) Click 'New from Z39.50'
 5) Type 'Seuss' into 'Name (any):' and press enter
 6) Click 'Import' beside the first link
 7) Click 'Save'
 8) Check your koha-error-log
-- floody!
 9) Apply patch
10) repeat steps 2-8
-- blank!
11) restore your intranet error log
   -- for example:
  mv ~/koha-error-log.backup ~/koha-dev/var/log/koha-error-log
12) run koha qa test tools

Signed-off-by: Marcel de Rooy 
Tested with addbiblio.pl. I would have preferred the scalar option in terms
of simpler code, but this works too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15164] Allow editing of the invoice number after initial saving

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

Julian Maurice  changed:

   What|Removed |Added

 Blocks||16868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868
[Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Depends on||16155


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155
[Bug 16155] Composite keys in TestBuilder and more
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16818] CAS redirect broken under Plack

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #16 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16988] Suspending a hold with AutoResumeSuspendedHolds disabled results in error

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741

Lari Taskula  changed:

   What|Removed |Added

 CC||la...@student.uef.fi

--- Comment #12 from Lari Taskula  ---
This bug still appears in master at "Pay amount" and "Pay selected" for payment
of 1.14, but not with 64.60.

To replicate:
1. Go to patron's fines tab, make sure there are no outstanding payments.
2. Via "Create manual invoice" tab, create one fine of 1.14
3. Go to Pay fines tab
4. Click "Pay amount" and confirm.
5. Observe error message "You must pay a value less than or equal to 1.14."
6. Go to Pay fines tab
7. Click "Pay selected" and confirm
8. Observe error message "You must pay a value less than or equal to 1.14."

However, via individual row's "Pay" button it seems to work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15397] Pay selected does not works as expected

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #14 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #23 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17037] 952 Field/Record Items not being accessed

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17037

--- Comment #3 from Matthew K  ---
Hi,

We finally managed to get the item information to display again. I'd overloaded
the archive by importing too many records; Just required a clean out. Is there
a way to expand the archive space?

However, the search results won't update any additions or deletions of records
(they definitely exist/have been deleted - can be located through items
issued). I've speculated that it may have something to do with Zebra and may
require a manual index, but when we were trying this with the initial problem,
the koha-conf.xml file apparently didn't exist (though I don't know if this is
still the case). Any additional suggestions would be appreciated.

Also, with regards to updating. Would an update to a later version cause any
data loss with regards to currently issued items? What precautions can I take
to avoid this?

Apologies if any of these questions are irrelevant or novice. I'm still very
new to the software.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #10 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16947] Can not modify patron messaging preferences

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #7 from Julian Maurice  ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #10 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list.

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #9 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17125] opac-basket: DataTables warning: table id= itemst - Cannot reinitialise DataTable.

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17125

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17125] opac-basket: DataTables warning: table id= itemst - Cannot reinitialise DataTable.

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17125

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #4 from Marcel de Rooy  ---
Horrible: A duplicated PROCESS jsinclude line in opac-bottom.inc was the
culprit. Somehow created in a rebase.
Closing this report now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >