[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 --- Comment #18 from Julian Maurice --- (In reply to Tomás Cohen Arazi from comment #17) > I think we should tie api id and keys to patrons to take advantage of the > current permission system. And introduce the use of scopes at a later stage. > > Julian: can you do it? i.e. pick the code you once wrote for having patrons > create api keys on the staff interface? I think it's not needed if you only want to tie an API client with a patron. We could add a xxx in $KOHA_CONF, and act as if that user was authenticated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #32 from Benjamin Rokseth --- (In reply to Ere Maijala from comment #31) > I'm working on it now. > > > Looks like there may be a typo in the atomic update. I got the following > error: > > updatedatabase.pl: DBD::mysql::db do failed: Can't DROP FOREIGN KEY > `deletedbiblio_metadata_fk_1`; check that it exists [for Statement "ALTER > TABLE deletedbiblio_metadata DROP FOREIGN KEY deletedbiblio_metadata_fk_1"] > at (eval 1389) line 8. > > Looking at the old kohastructure.sql I believe it should have tried to drop > 'deletedrecord_metadata_fk_1'. hmm, sad to say, but no, it's not a typo but db design issues. this commit seems to have added to the confusion: https://github.com/Koha-Community/Koha/commit/739e2e0c5dc26502e195e2cc4c687ababdcaf381 (Bug 17196) and following Bug 18284 you can see that most agree on deleted* tables being a bad idea in the first place. Problem is, kohastructure.sql and updatedatabase.pl is not in sync and libraries having migrated from 16.05 and before would need to delete this foreign key. And this patch is most important for them anyways. I suppose we could add a delete foreign key for both and ignore errors rather than die in the final version -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #12 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #11) > > Just make your changes as a follow-up patch (separate) next time. :) > > Got it, two patches wouldn't have looked clean in the history but if two > patches are an issue then the maintainer could just squash them. Why would they not have looked clean? It's how we roll :) The general rule is that once a patch has been signed off, you shoud not change the signed patches but add changes as seprate patches. This way the sign-offer and QA can verify the changes and the history is clear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #33 from Ere Maijala --- Oh, that's a nasty one. But do you even have to drop the constraints to delete the table? I think it's enough to drop the table and all the constraints there would be dropped too, no? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #13 from Victor Grousset/tuxayo --- > Why would they not have looked clean? It would be like 2/3 of the work in one patch and 1/3 in the other. > It's how we roll :) > The general rule is that once a patch has been signed off, you shoud not > change the signed patches but add changes as seprate patches. This way the > sign-offer and QA can verify the changes and the history is clear. Thanks for the clarification, it's simpler like that :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #34 from Ere Maijala --- Created attachment 73597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73597&action=edit Bug 20271 - Use a single pass in the OAI-PMH provider -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #35 from Ere Maijala --- Changes for the OAI-PMH provider have been attached. I'm really happy to make it so much more simple. Please feel free to rebase or whatever is necessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #72089|0 |1 is obsolete|| --- Comment #30 from Ere Maijala --- Created attachment 73598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73598&action=edit Bug 14716: URI-encode URLs in xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14176 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #31 from Ere Maijala --- Rebased. The last patch alone should apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added Summary|opac-detail.pl -- Series|opac-detail.pl -- Series |link fails when series |link fails when series |title ends with semicolon |title ends with semicolon |preceded by space. |preceded by space -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #36 from Benjamin Rokseth --- (In reply to Benjamin Rokseth from comment #32) > (In reply to Ere Maijala from comment #31) > > I'm working on it now. > > > > > > Looks like there may be a typo in the atomic update. I got the following > > error: > > > > updatedatabase.pl: DBD::mysql::db do failed: Can't DROP FOREIGN KEY > > `deletedbiblio_metadata_fk_1`; check that it exists [for Statement "ALTER > > TABLE deletedbiblio_metadata DROP FOREIGN KEY deletedbiblio_metadata_fk_1"] > > at (eval 1389) line 8. > > > > Looking at the old kohastructure.sql I believe it should have tried to drop > > 'deletedrecord_metadata_fk_1'. > > hmm, sad to say, but no, it's not a typo but db design issues. > this commit seems to have added to the confusion: > https://github.com/Koha-Community/Koha/commit/ > 739e2e0c5dc26502e195e2cc4c687ababdcaf381 (Bug 17196) > > and following Bug 18284 you can see that most agree on deleted* tables being > a bad idea in the first place. > > Problem is, kohastructure.sql and updatedatabase.pl is not in sync and > libraries having migrated from 16.05 and before would need to delete this > foreign key. And this patch is most important for them anyways. > > I suppose we could add a delete foreign key for both and ignore errors > rather than die in the final version fail to remember, but probably I put it there because otherwise it complained, perhaps due to the "rename table". the idea was that any leftovers from conflicts should be moved to temporary tables (prepended with _) so that one could check and delete them at convenience I will remove the dies in the atomicupdate and see if it works for us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added Attachment #44174|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added Attachment #45743|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #37 from Francesco Rivetti --- (In reply to Benjamin Rokseth from comment #36) > fail to remember, but probably I put it there because otherwise it > complained, perhaps due to the "rename table". the idea was that any > leftovers from conflicts should be moved to temporary tables (prepended with > _) so that one could check and delete them at convenience We had to drop the constraint to avoid the delete on cascade. When we clean up the deletedbiblio andt able, we don't want to drop any items which were left behind because not properly merged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #38 from Ere Maijala --- Ok, fair enough. I think Benjamin's proposal of dropping both without die'ing makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #204 from Julian Maurice --- test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 paxed changed: What|Removed |Added CC||pasi.kalli...@joensuu.fi --- Comment #17 from paxed --- The manual should first try to be in the currently used UI language, and then whatever other fallbacks there are (with "en" as the last, hardcoded one) or if fallbacks aren't feasible, the non-existing-manual page on koha-community could show something like "The manual does not exist for the language $foo. You can read the [manual in english], or [translate the manual]", with links to the actual manual in english and to the wiki article on how to start translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15003] Help should be a wiki, not translatable via po-files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15003 paxed changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19817 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19817] Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 paxed changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15003 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 paxed changed: What|Removed |Added CC||pasi.kalli...@joensuu.fi --- Comment #32 from paxed --- Comment on attachment 73598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73598 Bug 14716: URI-encode URLs in xsl templates. Ere, shouldn't this: + be + -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add index from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #9 from Alex Arnaud --- (In reply to Jonathan Druart from comment #8) > 1. What's the point of the JS function valid_line? > I think you should double-check it, it does not do what you expect it to do. > > 2. You are reusing code to duplicate a new mapping but for something else. > You should rename the variables to avoid confusion then. > For instance "search_fields" is not an index name I wanted to reuse the code as much as possible. It is not a problem for to add a js fonction dedicated to duplicate search fields only. > > 3. Bug report's title is wrong, we are not adding/removing indices Right! > > 4. I did not implement that part on the original patch because it's hard to > keep an interface consistent. > For instance: > - create a new search field > => You cannot create a new mapping, you have to save first > - create a new search field, save > => You can delete it. So it you create a mapping using it, you can still > delete it. If you save => kaboom > => If you have a search field already mapped and delete the mapping, you > cannot delete the search field. I see 2 solutions: 1) JS code for validating data when saving and warn the user if there is something inconsistent. May be quite tricky... 2) Submit the form on clicking the "+add" button. There is a disavantage: page is reloaded between each adding. Not confortable for adding many search fields or mapping -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325
Josef Moravec changed:
What|Removed |Added
Attachment #73516|0 |1
is obsolete||
--- Comment #6 from Josef Moravec ---
Created attachment 73599
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73599&action=edit
Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets
purge_zero_balance_fees is used in cleanup_database.pl to determine which fees
can be cleaned up.
It uses a simple SQL query to determine which rows in accountlines need to be
removed:
463 my $sth = $dbh->prepare(
464 q{
465 DELETE FROM accountlines
466 WHERE date < date_sub(curdate(), INTERVAL ? DAY)
467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL );
468 }
The function comes with the following warning:
451 B Because fines and payments are not linked in accountlines, it
is
452 possible for a fine to be deleted without the accompanying payment,
453 or vise versa. This won't affect the account balance, but might be
454 confusing to staff.
This was a reasonable solution prior to the addition of account_offsets in
17.11. The problem now is that rows in accountlines which are linked as credits
in accountlines will *always* have amountoutstanding marked as 0. These are
linked to debits via account_offsets. purge_zero_balance_fees will delete
credits and leave rows in account_offsets which link to deleted credits.
Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may
have all of their credits removed without warning.
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
Signed-off-by: Katrin Fischer
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune changed: What|Removed |Added Attachment #73493|0 |1 is obsolete|| --- Comment #9 from Séverine Queune --- Created attachment 73601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73601&action=edit Bug 18316 - Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune changed: What|Removed |Added Attachment #73492|0 |1 is obsolete|| --- Comment #8 from Séverine Queune --- Created attachment 73600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73600&action=edit Bug 18316 - Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #33 from Ere Maijala --- Paxed, yes, indeed. Thanks, I'll fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||josef.mora...@gmail.com --- Comment #6 from Josef Moravec --- Could you rebase please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578
Kyle M Hall changed:
What|Removed |Added
Attachment #73596|0 |1
is obsolete||
--- Comment #17 from Kyle M Hall ---
Created attachment 73602
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73602&action=edit
Bug 19578: Remove MARC punctuation in notices (TT syntax)
Jenkins fails (run 287) on a test in t/db_dependent/Letters/TemplateToolkit.t:
With the historical syntax:
# Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been
canceled for the following reason:
With the TT syntax:
# Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has been
canceled for the following reason:
The last character of the biblio's title has been removed because it's a
punctuation character.
It comes from: C4::Letters::_parseletter
893 $val =~ s/\p{P}$// if $val && $table=~/biblio/;
The same replacement is done for patron's attributes too.
Test plan:
- Confirm that the new tests pass. That should be enough to confirm this change
make sense.
Test plan (manual):
- Create a biblio with a title ending with a punctuation (like
"with_punctuation_"), or any other fields of biblio/biblioitem
- Generate a notice which will display this field (CHECKIN for instance)
Use the historical syntax and the TT syntax, both should display the title
without the punctuation character at the end
CHECKIN historical:
The following items have been checked in:
<>
CHECKIN TT syntax:
The following items have been checked in:
[% biblio.title %]
Signed-off-by: Katrin Fischer
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325
Kyle M Hall changed:
What|Removed |Added
Attachment #73599|0 |1
is obsolete||
--- Comment #7 from Kyle M Hall ---
Created attachment 73603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73603&action=edit
Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets
purge_zero_balance_fees is used in cleanup_database.pl to determine which fees
can be cleaned up.
It uses a simple SQL query to determine which rows in accountlines need to be
removed:
463 my $sth = $dbh->prepare(
464 q{
465 DELETE FROM accountlines
466 WHERE date < date_sub(curdate(), INTERVAL ? DAY)
467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL );
468 }
The function comes with the following warning:
451 B Because fines and payments are not linked in accountlines, it
is
452 possible for a fine to be deleted without the accompanying payment,
453 or vise versa. This won't affect the account balance, but might be
454 confusing to staff.
This was a reasonable solution prior to the addition of account_offsets in
17.11. The problem now is that rows in accountlines which are linked as credits
in accountlines will *always* have amountoutstanding marked as 0. These are
linked to debits via account_offsets. purge_zero_balance_fees will delete
credits and leave rows in account_offsets which link to deleted credits.
Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may
have all of their credits removed without warning.
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
Signed-off-by: Katrin Fischer
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #27 from Fridolin SOMERS --- Ah ok its missing a patch for DBIX class files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #46 from Josef Moravec --- (In reply to Katrin Fischer from comment #45) > > > > Let [1,2,3,4] be the framework structure > > Let [1,4,2] be the saved record > > > > Currently we load on the framework structure order, giving us > > 1, 2, 3 (empty), 4 > > This does not respect the saved record order. But if we load according do > > the saved record order, where should the empty tag (3) go? Should we place > > it before the saved record's fields or after? Or do some weird half-sorted > > behavior? > > > > before : [3 (empty), 1, 4, 2] > > after : [1, 4, 2, 3 (empty)] > > weird : [1, 3 (empty), 4, 2] > > I'd put the empty ones at the bottom of the list, in alphabetic sequence. +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #28 from Fridolin SOMERS --- Created attachment 73604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73604&action=edit Bug 18818: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #20 from Kyle M Hall --- (In reply to M. Tompsett from comment #19) > Created attachment 73595 [details] [review] > Bug 19066: Follow up to reduce C4::Context references Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #73598|0 |1 is obsolete|| --- Comment #34 from Ere Maijala --- Created attachment 73605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73605&action=edit Bug 14716: URI-encode URLs in xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14176 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. 4. Also try the attached test records and make sure their links work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #12 from Kyle M Hall --- (In reply to Katrin Fischer from comment #11) > I've tested it and I think it's still a little confusing. > > Right now it is: total of holds / holds on on order items > > Which can lead to the 1 / 0 that Jonathan pointed out. Maybe it would make > more sense to switch the values? Or just show the total number of holds = > record level + item level on on order items? I like the idea of switching the values around. I'll get a followup done asap! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Assignee|kyle.m.h...@gmail.com |ere.maij...@helsinki.fi --- Comment #35 from Ere Maijala --- The bug Paxed noted has been fixed and the patch has been extended to cover all xsl files where I found search links (something with "q=") including UNIMARC and NORMARC. I did my best to test them too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #13 from Kyle M Hall --- Created attachment 73606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73606&action=edit Bug 19812 [QA Followup] - Swap sides for total and item holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20515] New: "ILL Request" menu options displayed when user has no ILL permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Bug ID: 20515 Summary: "ILL Request" menu options displayed when user has no ILL permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com When the Interlibrary Loans module is enabled the menu option "ILL Requests" is added to the main intranet screen and the "More" dropdown menu. These options are displayed regardless of whether the logged in user has any permissions on this module. They should only be displayed if the user has permissions to work with ILL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #14 from Kyle M Hall --- Created attachment 73607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73607&action=edit Bug 19812 [QA Followup] - If 0 holds show '0' not '0 / 0' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #15 from Kyle M Hall --- Created attachment 73608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73608&action=edit Bug 19812 [QA Followup] - Remove unnecessary line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Josef Moravec changed: What|Removed |Added Attachment #73505|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 73609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73609&action=edit Bug 19267: Rancor - Warn before leaving page if record modified To test: 1 - Open the advanced editor 2 - Make some changes to a record 3 - Click on 'Patrons' or leave the page in some way 4 - Note there is no warning and changes are not saved 5 - Apply patch 6 - Open the advanced editor 7 - Make some changes 8 - Leave the page 9 - Note you get a warning of unsaved changes and can stay on the page Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20115] Languages appear in a different order in the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20115] Languages appear in a different order in the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Josef Moravec changed: What|Removed |Added Attachment #73027|0 |1 is obsolete|| Attachment #73028|0 |1 is obsolete|| Attachment #73029|0 |1 is obsolete|| Attachment #73030|0 |1 is obsolete|| Attachment #73433|0 |1 is obsolete|| --- Comment #17 from Josef Moravec --- Created attachment 73610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73610&action=edit Bug 20115: Set the languages order with the pref values To avoid the languages to be ordered randomly, it is better to stick on a default order. Let's suppose that the order in the pref is correct. Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20115] Languages appear in a different order in the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #18 from Josef Moravec --- Created attachment 73611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73611&action=edit Bug 20115: Make the prefs sortable If we depend on the order, we should make it sortable. I let the customization to someone else (we would need an icon to tell the user it's sortable). Something does not work here: If fr-FR and fr-CA is installed, but only 1 is ticked, it will be considered as last. I do not think it's a blocker as it does not make really make sense to have it installed but not used (the interface is also weird, there is a dropdown list with only 1 entry) Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20115] Languages appear in a different order in the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #19 from Josef Moravec --- Created attachment 73612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73612&action=edit Bug 20115: Trigger "modified" when sort is changed Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20115] Languages appear in a different order in the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #21 from Josef Moravec --- Created attachment 73614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73614&action=edit Bug 20115: Add information about this feature in the pref descriptions I guess a native English speaker will have a better wording :) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20115] Languages appear in a different order in the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #20 from Josef Moravec --- Created attachment 73613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73613&action=edit Bug 20115: Remove sort on rfc4646_subtag in OPAC templates Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #8 from Josef Moravec ---
Comment on attachment 71097
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71097
Bug 20116: Prepare the ground
Review of attachment 71097:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20116&attachment=71097)
-
::: C4/Languages.pm
@@ +132,3 @@
> $htdocs = C4::Context->config('opachtdocs');
> +push @languages, _get_intranet_opac_dirs( $htdocs );
> +
should be _get_opac_language_dirs
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #35 from Kyle M Hall --- (In reply to Katrin Fischer from comment #34) > I was thinking on the wiki page :) Sounds good! Here it is: https://wiki.koha-community.org/wiki/Time_Zone_Configuration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515
--- Comment #1 from Andrew Isherwood ---
Created attachment 73615
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73615&action=edit
Bug 20515 - "ILL Request" menu options displayed when user has no ILL
This patch adds the following additional conditions to the display of
both the ILL Requests drop down "More" menu option and the "ILL Requests"
option on the intranet front page:
Before:
[% IF Koha.Preference('ILLModule') %]
After:
[% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian)
%]
This prevents the options being displayed to users who have no
permissions to work with ILL.
Test plan:
View both the intranet front page and "More" dropdown while logged in as
a user without ILL permissions, ensure the options do not display. Then
do the same with a user with ILL permissions, ensure the options do
display.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What|Removed |Added Blocks||20515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize changed: What|Removed |Added Depends on||7317 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20516] New: Show patron's library in pending discharges table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Bug ID: 20516 Summary: Show patron's library in pending discharges table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20516] Show patron's library in pending discharges table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 --- Comment #1 from Julian Maurice --- Created attachment 73616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73616&action=edit Bug 20516: Show patron's library in pending discharges table Test plan: 1. Enable syspref useDischarge 2. Login to OPAC and ask for a discharge (tab on the left) 3. Login to intranet, you should see a message about pending discharges, and a link. Click on the link. 4. Confirm that there is a 'Library' column in the table that is displaying the patron's library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20516] Show patron's library in pending discharges table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #62 from Fridolin SOMERS --- Created attachment 73617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73617&action=edit Bug 8962: Changes to CCL.properties, bib1 for authorities, and templates This patch adds a new index Anywhere in ccl.properties in bib1 for authorities, and add "any word" option in intranet search for using this index. Default OPAC and intranet search in still using CCL "Any" index. Testing plan : In a Marc21 GRS-1 Koha : 1/ make some biblio searches without selecting any index (Koha will use "any" index) and note the results. Ex : search "fre", "eng", "book", "history", "history book" 2/ apply the 3 patches 3/ copy the 4 new record.abs files (Marc21 auth, Marc21 bib, Unimarc auth, Unimarc bib) from your sources to the directory used by Zebra configuration in your Koha instance 4/ launch rebuild_zebra.pl -b -r -x -v 5/ check that a new choice "Any word (all indexes)" is visible in advanced search. 6/ make the same searches as 1/ : you should see less results (detailed test plan in patchs 2 and 3) 7/ in Staff interface adavanced search, select "Any word (all indexes)" and make the same searches as 1/ : you should see the same results (maybe with a slight differences, because more notes fields are indexed in Marc21) In a UNIMARC GRS-1 Koha : same test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include transacting library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Josef Moravec --- Kyle, I still found some issues with this: 1. reported by QA tools, not sure how to fix this..., : FAIL Koha/Old/Checkout.pm FAIL valid merging failed on 'Koha::Checkout' ] Koha::Old::Checkout, current merge results [ Inconsistent hierarchy during C3 merge of class 'Koha::Old::Checkout': 2. This still remains: FAIL Koha/Checkout.pm FAILpod in file Koha/Checkout.pm Unknown command 'head' *** ERROR: FAIL pod coverage POD is missing for 'library' you should use =head3 I think 3. The code added to Koha/Schema/Result/OldIssue.pm should be after schema loader mark 4. Also, when you make Koha::Checkout base for Koha::Old::Checkout, you should also define relations 'borrower' and 'item' in Koha::Schema::OldIssue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Attachment #70127|0 |1 is obsolete|| --- Comment #63 from Fridolin SOMERS --- Created attachment 73618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73618&action=edit Bug 8962: Restore Any index behavior and add Anywhere index The "Any" index/register should contains all the data contained in all the other indexes/registers (e.g. Title, Author, Subject, etc). The "Anywhere" index/register should contain the entire record including fields/subfields that aren't indexed anywhere else. In GRS1 indexing the Any index was indeed only on fields defined as indexed. This has changed in DOM where all data in MARC is indexed with Any. This generates a lot of results when no index is defined in search. This patch changes the DOM xsl config generation to add Any to each indexed data and add Anywhere to keep a way of searching on all data. Test plan : - Add a data on a field that is not indexed : for example "toto" in 998$z - Add same data as the title of another record - Index the records - Search on toto without index (uses Any) => you get the 2 records - Search on toto with title index => you get the record with "toto" as title - Apply patch - Update DOM xsl config files - Reindex - Search on toto without index (uses Any) => you get the record with "toto" as title - Search on toto with title index => you get the record with "toto" as title - Search on toto with Anywhere index => you get the 2 records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #64 from Fridolin SOMERS --- (In reply to Charles Farmer from comment #61) > Unless I'm mistaken, this patch doesn't apply anymore: > > > CONFLICT (content): Merge conflict in > > koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc Indeed. Easy rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20517] New: Use the "sort bin" field in SIP2 Checkin Response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Bug ID: 20517 Summary: Use the "sort bin" field in SIP2 Checkin Response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com The SIP2 Checkin Response (10) can have a "variable-length optional field" for "sort bin", labelled "CL". In the description of the SIP2 protocol, this field is described as follows: "sort bin - CL - variable-length field. This field should contain a bin number that indicates how the items should be sorted. The maximum practical number of sort bins for a patron using 3M SelfCheck system is probably only 3 or 4, but many digits are allowed to accommodate some sort of fantastic sorting device using a hierarchical bin numbering scheme." I have a customer who wants to use this field to display messages on the screen of self service machines that tell users to put items in a separate bin based on itemtype, location etc. The idea is to add a syspref that can contain something like this: itemtype:ILL:1 location:CLOSEDSTACKS:2 - The first field is an item field. - The second field is a value to look for in the given item field - The third field is the value given to the CL field in the SIP2 Checkin Response if the value in the second field matches the item on hand. It should also be possible to set the CL field for items that need to be transferred after they have been returned, that is for items that are returned at another library than the homebranch. This will probably be another syspref. If the returned item needs to be transferred to the homebranch, CL is set to the value of the syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #35 from Josef Moravec --- Why did you added the cleaning of the code in C4/SIP/ILS.pm? It looks OK, but I think it's not related to this report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What|Removed |Added Attachment #71097|0 |1 is obsolete|| Attachment #73521|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 73619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73619&action=edit Bug 20116: Prepare the ground Just refactoring to make the next patch more readable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #10 from Jonathan Druart --- Created attachment 73620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73620&action=edit Bug 20116: Cache language list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #11 from Jonathan Druart
---
(In reply to Josef Moravec from comment #8)
> Comment on attachment 71097 [details] [review]
> Bug 20116: Prepare the ground
>
> Review of attachment 71097 [details] [review]:
> -
>
> ::: C4/Languages.pm
> @@ +132,3 @@
> > $htdocs = C4::Context->config('opachtdocs');
> > +push @languages, _get_intranet_opac_dirs( $htdocs );
> > +
>
> should be _get_opac_language_dirs
Erk, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 Jonathan Druart changed: What|Removed |Added Attachment #69970|0 |1 is obsolete|| Attachment #69971|0 |1 is obsolete|| Attachment #69972|0 |1 is obsolete|| Attachment #69973|0 |1 is obsolete|| Attachment #69974|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 73621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73621&action=edit Bug 19855: Remove getalert from moremember.pl This is not used later and seems unused since: commit b38997925f603dc9784c25d3db3501644c19e068 Date: Wed Oct 26 09:11:02 2005 + big commit, still breaking things... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 --- Comment #8 from Jonathan Druart --- Created attachment 73622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73622&action=edit Bug 19855: Remove getalert from opac-user.pl This is not used later and seems unused since: commit e61173aa8eb23c111a707eba2cfbd2003df709bf Date: Sun May 21 02:29:09 2006 + syncing dev-week and HEAD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 --- Comment #9 from Jonathan Druart --- Created attachment 73623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73623&action=edit Bug 19855: Remove C4::Letters::findrelatedto This subroutine is called only once. It only concat firstname and surname for subscribers. It can be easily replaced with Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 --- Comment #10 from Jonathan Druart --- Created attachment 73624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73624&action=edit Bug 19855: Remove $type from the alerts It looks like this feature has never been finished. It has been developed with more flexibility in mind, but only 'issue' is used for this parameter. Apparently it could have been 'virtual', for virtual shelves. Let remove this parameter and clean the code a bit. TODO: Remove the DB column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 --- Comment #11 from Jonathan Druart --- Created attachment 73625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73625&action=edit Bug 19855: Move getalert, addalert and delalert to Koha::Subscription This patch removes 3 subroutines from C4::Letters: - getalert - addalert - delalert And add 3 methods to Koha::Subscription: - subscribers - add_subscriber - remove_subscriber It makes the code cleaner for future cleanup. TODO - we should remove alert.alertid and alert.type, and rename alert.externalid with alert.subscriptionid That way alert will be renamed borrowers_subscriptions (or similar) and will become a simple join table between borrowers and subscriptions. We will need to deal with FK that could not be satisfied. Let's do that after this patch is pushed. Test plan: Subscribe and unsubscribe to email notifications sent when a new issues is available. Make sure everything works as before and you receive the emails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520
--- Comment #10 from Josef Moravec ---
Comment on attachment 72240
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72240
Bug 15520: Add permission to restrict circ rules editing to own library
Review of attachment 72240:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15520&attachment=72240)
-
::: admin/smart-rules.pl
@@ +63,5 @@
> +
> +my $uid = Koha::Patrons->find( $loggedinuser )->userid;
> +my $restricted_to_own_library = $uid && haspermission( $uid, { parameters =>
> 'manage_circ_rules_restricted' }, { no_inherit => 1 } );
> +$template->param( restricted_to_own_library => $restricted_to_own_library );
> +$branch = C4::Context::mybranch() if $restricted_to_own_library;
This is not the logged in user's home library, it is the library where the user
is logged in now - so when user change library, he/she could change another's
library rules!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What|Removed |Added Summary|Elasticsearch - Ability to |Elasticsearch - Ability to |add index from UI |add search fields from UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What|Removed |Added Attachment #73476|0 |1 is obsolete|| --- Comment #10 from Alex Arnaud --- Created attachment 73626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73626&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #11 from Alex Arnaud --- Created attachment 73627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73627&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - you create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (don't save) - check that you can delete this search field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9474] filter overdues with fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Marjorie Barry-Vila changed: What|Removed |Added CC|marjorie.barry-vila@collect | |o.ca| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9474] filter overdues with fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Andrew Isherwood changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Kyle M Hall changed: What|Removed |Added Attachment #72282|0 |1 is obsolete|| --- Comment #36 from Kyle M Hall --- Created attachment 73628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73628&action=edit Bug 18786: Remove use of Koha::Patron::Images -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18786] Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #37 from Kyle M Hall --- (In reply to Josef Moravec from comment #35) > Why did you added the cleaning of the code in C4/SIP/ILS.pm? > > It looks OK, but I think it's not related to this report. No idea how the snuck in. This new version of the followup should have that fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What|Removed |Added Attachment #73627|0 |1 is obsolete|| --- Comment #12 from Alex Arnaud --- Created attachment 73629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73629&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authoroties), don't save, - check that you can delete this search field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #48 from Jonathan Druart --- Created attachment 73631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73631&action=edit Bug 19936: Add the Koha::Patron->has_valid_userid method Reuse how C4::Members::Check_Userid works and adapt it to write Koha::Patron->check_userid Adapt the tests to use this new method. The tests still pass, we can adapt the different callers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #49 from Jonathan Druart --- Created attachment 73632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73632&action=edit Bug 19936: Replace Check_userid - Update the occurrences We previously prove that the method and the subroutine were equivalent, we know update the controller calls. Test plan: - Add and update a patron with different variations of userid (automatically generated or not) - Import patrons with and without userid, as well as with existing userid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #50 from Jonathan Druart --- Created attachment 73633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73633&action=edit Bug 19936: Remove the subroutine Check_Userid It is no longer in user, we can remove it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Jonathan Druart changed: What|Removed |Added Attachment #72141|0 |1 is obsolete|| Attachment #72142|0 |1 is obsolete|| Attachment #72143|0 |1 is obsolete|| Attachment #72144|0 |1 is obsolete|| Attachment #72145|0 |1 is obsolete|| Attachment #72146|0 |1 is obsolete|| Attachment #72147|0 |1 is obsolete|| Attachment #72148|0 |1 is obsolete|| Attachment #72149|0 |1 is obsolete|| Attachment #72150|0 |1 is obsolete|| Attachment #72151|0 |1 is obsolete|| Attachment #72152|0 |1 is obsolete|| --- Comment #47 from Jonathan Druart --- Created attachment 73630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73630&action=edit Bug 19936: Replace Check_userid - just move the tests This patch moves the tests related to Check_userid out of Members.t The tests must pass with only this patch applied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
