[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 Jonathan Druart changed: What|Removed |Added Version|17.05 |master Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED Severity|normal |major Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #72061|0 |1 is obsolete|| --- Comment #72 from Charles Farmer --- Created attachment 77718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77718=edit Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21203] ILS-DI - GetRecords crashes on non-existent records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21203] ILS-DI - GetRecords crashes on non-existent records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 --- Comment #1 from Jonathan Druart --- Created attachment 77688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77688=edit Bug 21203: ILS-DI - Make GetRecords handle non-existent records Caused by commit cb336e633bf7e0cb25051a8ed8157af8486a58d7 Bug 18255: Koha::Biblio - Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem Can't call method "biblioitem" on an undefined value at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 212 Test plan: - Enable ilsdi - hit /cgi-bin/koha/ilsdi.pl?service=GetRecords=X With X an existing biblionumber and a non existing one Both requests must succeed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard changed: What|Removed |Added Attachment #76523|0 |1 is obsolete|| --- Comment #15 from Owen Leonard --- Created attachment 77690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77690=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard changed: What|Removed |Added Attachment #74715|0 |1 is obsolete|| --- Comment #14 from Owen Leonard --- Created attachment 77689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77689=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] New: C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205
Bug ID: 21205
Summary: C4::Acquisition - Remove GetOrderFromItemnumber
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.dru...@bugs.koha-community.org
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
This is done to ease the move of C4::Items (bug 18252) to Koha::Items
my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber});
will become
my @itemnumbers = $order_object->items->get_column('itemnumbers');
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20690] Update two-column templates with Bootstrap grid: Acquisitions part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21164] Fix alignment on new basket form in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21164 Pierre-Luc Lapointe changed: What|Removed |Added CC||pierre-luc.lapointe@inLibro ||.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Maryse Simard changed: What|Removed |Added Attachment #77603|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 77714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77714=edit Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What|Removed |Added Blocks||21168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 [Bug 21168] Error on circ/returns.pl after deleting checked-in item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 Jonathan Druart changed: What|Removed |Added Depends on||18276 --- Comment #2 from Jonathan Druart --- Caused by: commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Maryse Simard changed: What|Removed |Added Attachment #77545|0 |1 is obsolete|| --- Comment #5 from Maryse Simard --- Created attachment 77716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77716=edit Bug 19991: use Modern::Perl in OPAC perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; errors/400.pl errors/401.pl errors/402.pl errors/403.pl errors/404.pl errors/500.pl opac-account-pay-paypal-return.pl opac-alert-subscribe.pl opac-authorities-home.pl opac-authoritiesdetail.pl opac-browser.pl opac-ics.pl opac-image.pl opac-imageviewer.pl opac-messaging.pl opac-modrequest-suspend.pl opac-modrequest.pl opac-mymessages.pl opac-overdrive-search.pl opac-passwd.pl opac-patron-image.pl opac-privacy.pl opac-ratings-ajax.pl opac-ratings.pl opac-readingrecord.pl opac-renew.pl opac-sendshelf.pl opac-serial-issues.pl opac-showreviews.pl opac-suggestions.pl opac-tags_subject.pl opac-topissues.pl opac-user.pl sco/help.pl sco/printslip.pl sco/sco-patron-image.pl svc/overdrive_proxy svc/suggestion unapi Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #77718|0 |1 is obsolete|| --- Comment #76 from Charles Farmer --- Created attachment 77721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77721=edit Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #77719|0 |1 is obsolete|| --- Comment #77 from Charles Farmer --- Created attachment 77722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77722=edit Bug 11297 - Add atomicupdate patch and modify kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #77720|0 |1 is obsolete|| --- Comment #78 from Charles Farmer --- Created attachment 77723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77723=edit Bug 11297 - Modify Z3950server schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Katrin Fischer changed: What|Removed |Added Summary|Difference in Koha module |Make module names on |names for notices linked to |letters overview page |Holds/Reserves |translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 --- Comment #2 from Katrin Fischer --- Created attachment 77724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77724=edit Bug 19500: Make module names on letters overview page translatable While the module pull down on adding and editing a letter is written out and fully translatable, the overview page showed the internal 'module code'. Patch also renames the "Members" module into the "Patrons" module to match Koha's terminology. To test: - Before applying the patch: - Add or edit a notice, look at the pull down for module - Go back to the overview page - Verify the module names don't match - Apply the patch: - Check again, pull downs should now match - Verify that Members is now Patrons everywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21164] Fix alignment on new basket form in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21164 Pierre-Luc Lapointe changed: What|Removed |Added Attachment #77496|0 |1 is obsolete|| --- Comment #2 from Pierre-Luc Lapointe --- Created attachment 77712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77712=edit Bug 21164: Fix alignment on new basket form in acquisitions This patch removes some unnecessary ""'s from the template for creating a new basket in acquisitions. This fixes the alignment on the form fields. To test, apply the patch and go to Acquisitions -> Vendor -> New basket. All the form fields should be correctly left-aligned with each other. Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 --- Comment #1 from Jonathan Druart --- Created attachment 77715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77715=edit Bug 21168: Handle deleted checked-in items on checking in circ/returns.pl generates a server error when attempting to checkin an item while the list of previously-returned items contains an item that has been deleted. Error text: Can't call method "biblio" on an undefined value at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 606. Test plan: - checkout two items - checkin item1 - on a separate tab, delete item1 - on the original tab (which still shows item1 in the list of Checked-In Items), attempt to check in item2 => No error appears -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21185] Incorrect title tag on tags review page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21185 Maryse Simard changed: What|Removed |Added Attachment #77588|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 77711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77711=edit Bug 21185: Incorrect title tag on tags review page This patch corrects the title tag on the tags review page. To test, apply the patch and go to Tools -> Tags. The page title (probably shown in the browser tab) should start with "Koha ->" instead of "Home ->". Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21185] Incorrect title tag on tags review page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21185 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 --- Comment #2 from Jonathan Druart --- Created attachment 77717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77717=edit Bug 21208: Fix housebound deliverer/chooser names When creating a housebound visit, the names of the chooser and deliverer are the same as the housebound patron (even though the housebound patron does not have chooser and deliverer roles). It has been caused by: commit 5f80977875ff124d411f2cd89de4a944fa9c27af Bug 18403: Use patron-title.inc when hidepatronname is used patron-title.inc now starts looking for a variable named "patron", which exists in members/housebound. A better fix could be to renamed this "patron" variable tested by patron-title.inc, but at first glance it's the only place this issue exists. Test plan: 1- Make sure HouseboundModule is enabled in system preferences 2- Go to a patron file (Patron A) 3- Edit this patron's housebound roles to Chooser 4- Go to another patron file (Patron B) 5- Edit this patron's housebound roles to Deliverer 6- Go to a third patron's file (Patron C) 7- Go to the Housebound tab 8- Fill out the housebound profile for Patron c 9- Click on "Add a new delivery" 10- Fill out day and time 11- Check the Chooser drop down 12- Check the Deliverer drop down 13- Save the delivery 14- Notice the Chooser and Deliverer names are correct 15- Click on the name of the Chooser, it goes to Patron A's file 16- Go back and click on the name of the Deliverer, it goes to Patron B's file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21034] Re-indent circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Owen Leonard changed: What|Removed |Added Attachment #76656|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 77710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77710=edit Bug 21034: Re-indent circulation.tt This patch reindents the template for the checkout page, circulation.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the checkout page under various circumstances: - No card number submitted - Name submitted (patron search results) - Card number submitted - Restricted patron - Patron with circulation messages - On-site checkouts - Check all tabs: checkouts, relatives' checkouts holds, article requests, restrictions, clubs HTML validation before and after the patch should return the same results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] New: Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Bug ID: 21208 Summary: Housebound deliverer/chooser have wrong name when creating a visit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When creating a housebound visit, the names of the chooser and deliverer are the same as the housebound patron (even though the housebound patron does not have chooser and deliverer roles). To reproduce : 1- Make sure HouseboundModule is enabled in system preferences 2- Go to a patron file (Patron A) 3- Edit this patron's housebound roles to Chooser 4- Go to another patron file (Patron B) 5- Edit this patron's housebound roles to Deliverer 6- Go to a third patron's file (Patron C) 7- Go to the Housebound tab 8- Fill out the housebound profile for Patron c 9- Click on "Add a new delivery" 10- Fill out day and time 11- Check the Chooser drop down, notice the only choice is Patron C and not Patron A, choose Patron C anyway 12- Check the Deliverer drop down, notice the only choice is Patron C and not Patron B, choose Patron C anyway 13- Save the delivery 14- Notice the Chooser and Deliverer are both Patron C 15- Click on the name of the Chooser, it goes to Patron A's file 16- Go back and click on the name of the Deliverer, it goes to Patron B's file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Caroline Cyr La Rose --- Names are displaying fine now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Maryse Simard changed: What|Removed |Added Attachment #77706|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 77713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77713=edit Bug 19390: Make jQuery selector more specific, so OPAC view link can open in new tab The OPAC view link in the staff result list already had a target="_blank", but it didn't work, because of the JavaScript for the result list browser in staff. The JavaSript code was looking for the links to the detail page in staff and this also selected the link to the detail page in OPAC. By changing detail.pl to \detail.pl opac-detail.pl will no longer be selected. To test: - Search in the staff interface - Click "OPAC view" links in staff result lists - Click "OPAC view' links in detai page - Verify both now open in a new tab - Click other links and test that navigation (previous, next, return to results) works as expected - Inside the staff client, you should see something like searchid=scs_1533922927978 added to the URLs Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Jonathan Druart changed: What|Removed |Added Depends on||18403 --- Comment #1 from Jonathan Druart --- Caused by: commit 5f80977875ff124d411f2cd89de4a944fa9c27af Bug 18403: Use patron-title.inc when hidepatronname is used Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What|Removed |Added Blocks||21208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18609] Make attachment of MARC records for list/cart email optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18609 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 2172 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2172] Cart attaches an iso2709 file, which confuses 99% of patrons.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2172 --- Comment #4 from Katrin Fischer --- *** Bug 18609 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Katrin Fischer changed: What|Removed |Added Attachment #77660|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 77680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77680=edit Bug 20898: Replace OPAC detail's results browser with non-JavaScript version This patch moves generation of the OPAC detail page's results browser from JavaScript to the template. This makes the template easier to understand and easier to debug. It also makes it possible for the widget to be completely non-dependent on JavaScript. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Enable the OpacBrowseResults system preference and perform a search in the OPAC which will return multiple results. - Click on any title in the first page of search results. - On the bibliographic detail page there should be a "Browse results" link in the right-hand sidebar just as before. - Test that the "Previous," "Back to results," and "Next" links work correctly. - Click the "Browse results" link. A list of the first 20 search results should appear. An arrow should indicate the title you're viewing. - Click any title in the results browser. The page should correctly load that record. - Clicking the numbered links at the top of the results browser should do the same. Signed-off-by: Cab Vinton Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Blocks||21201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Jonathan Druart changed: What|Removed |Added Depends on||21184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Jonathan Druart changed: What|Removed |Added Blocks||18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What|Removed |Added Depends on||21201 --- Comment #8 from Jonathan Druart --- Bug 21201 - C4::Items - Remove GetItemnumbersForBiblio Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] New: C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201
Bug ID: 21201
Summary: C4::Items - Remove GetItemnumbersForBiblio
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.dru...@bugs.koha-community.org
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
my $itemnumbers = GetItemnumbersForBiblio($biblionumber);
will become
my $itemnumbers = [ Koha::Items->search({ biblionumber =>
$biblionumber})->get_column("itemnumber") ];
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 --- Comment #2 from Jonathan Druart --- Created attachment 77686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77686=edit Bug 21201: Remove GetItemnumbersForBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201
--- Comment #1 from Jonathan Druart
---
Created attachment 77685
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77685=edit
Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls
Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with
my @itemnumbers = Koha::Items->search({ biblionumber =>
$biblionumber})->get_column("itemnumber")
Test plan:
- Use the GetAvailability service of ILS-DI
- Try to place a hold on an item that is available and another one
- Use the batch record deletion tool to remove record with and without items.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 Jonathan Druart changed: What|Removed |Added Blocks||18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21202] New: C4::Items - Remove GetItemsByBiblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 Bug ID: 21202 Summary: C4::Items - Remove GetItemsByBiblioitemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org my $items = GetItemsByBiblioitemnumber($biblioitemnumber); will become my $items = $biblio->items->unblessed; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What|Removed |Added Depends on||21202 --- Comment #9 from Jonathan Druart --- Bug 21202 - C4::Items - Remove GetItemsByBiblioitemnumber Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21204] New: Move C4::Acquisition code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 Bug ID: 21204 Summary: Move C4::Acquisition code to the Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What|Removed |Added Depends on||21206 --- Comment #10 from Jonathan Druart --- Bug 21206 - C4::Items - Remove GetItem Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Blocks||18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #5 from Jonathan Druart --- This is ready for testing, no test plan provided. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #4 from Jonathan Druart --- The whole dependency tree has been pushed to https://gitlab.com/joubu/Koha/commits/bug_21206 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #44 from Kyle M Hall --- Created attachment 77682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77682=edit Bug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass limit to template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall changed: What|Removed |Added Attachment #77648|0 |1 is obsolete|| --- Comment #43 from Kyle M Hall --- Created attachment 77681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77681=edit Bug 15524: (QA follow-up) Respect ReservesControlBranch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21201] C4::Items - Remove GetItemnumbersForBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21201 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #7 from Katrin Fischer --- +1 for asking the mailing list, the current behaviour causes a bit of confusion here and there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
Jonathan Druart changed:
What|Removed |Added
Attachment #77586|0 |1
is obsolete||
--- Comment #3 from Jonathan Druart
---
Created attachment 77687
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77687=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 Jonathan Druart changed: What|Removed |Added Blocks||15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What|Removed |Added Depends on||21204 --- Comment #22 from Jonathan Druart --- Bug 21204 - Move C4::Acquisition code to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 [Bug 21204] Move C4::Acquisition code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What|Removed |Added Depends on||21207 --- Comment #23 from Jonathan Druart --- Bug 21207 - C4::Overdues::GetItems is not used Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 [Bug 21207] C4::Overdues::GetItems is not used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Jonathan Druart changed: What|Removed |Added Blocks||15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 Jonathan Druart changed: What|Removed |Added Depends on||21184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 Jonathan Druart changed: What|Removed |Added Depends on|21184 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Blocks||21204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 [Bug 21204] Move C4::Acquisition code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #5 from Owen Leonard --- Created attachment 77684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77684=edit Bug 21174: (alternate) Sysprefs to enable the opening of OPAC cart in one click This is an alternate patch which would replace the proposed changes to masthead.inc, opac-bottom.inc, opac-basket.tt, and basket.js. This patch slightly changes the markup in masthead.inc so that the Cart link doesn't try to interpret it as a dropdown trigger, and switches out the ID attribute so that it triggers the right action from basket.js. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart changed: What|Removed |Added Depends on||15184 --- Comment #1 from Jonathan Druart --- Koha::Acquisition::Order->items comes from bug 15184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 [Bug 15184] Ability to duplicate existing order lines to a given basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart changed: What|Removed |Added Blocks||21205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Owen Leonard changed: What|Removed |Added Attachment #77191|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 77704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77704=edit Bug 15287: Use font-awesome on the OPAC This patch replaces Bootstrap's glyphicons with Font Awesome icons. To test, apply the patch and clear your browser cache and regenerate the OPAC CSS from the LESS file if necessary. Check these icons and confirm they look correct: - Cart and Lists icons in the OPAC header - User icon in the header when the browser window is narrow - Languages menu when multiple languages are installed and the OpacLangSelectorMode system preference is "top" or "both top and footer." - Set the SuspendHoldsOpac system preference to "allow" and log in to the OPAC as a user who has one or more holds. - Check the appearance of the "suspend" and "resume" buttons both in the table of holds and at the bottom. - With one or more clubs defined, log in to the OPAC and check the "Clubs" tab on the user summary page. The "Enroll" and "Cancel enrollment" buttons should look correct. - On the "your messaging" tab in the OPAC, the "Digests only" information icon should look correct. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #35 from Owen Leonard --- Created attachment 77696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77696=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #37 from Owen Leonard --- I've rebased these patches and moved the changes in staff-global.css to staff-global.scss. Staff client CSS will have to be recompiled for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] New: C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Bug ID: 21206 Summary: C4::Items - Remove GetItem Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Let's use Koha::Items! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3935] Schedule tasks periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi, the main problem is bug 1993, that needs to be resolved first. Please understand that this will need funding and/or resources in order to move forward. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 Jonathan Druart changed: What|Removed |Added Depends on||21205 --- Comment #1 from Jonathan Druart --- Bug 21205 - C4::Acquisition - Remove GetOrderFromItemnumber Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart changed: What|Removed |Added Blocks||21204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 [Bug 21204] Move C4::Acquisition code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 --- Comment #1 from Jonathan Druart --- Created attachment 77702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77702=edit Bug 21207: Remove unused RM C4::Overdues::GetItems sub Test plan: git grep GetItems | grep -v GetItemsInCollection | grep -v GetItemsForInventory | grep -v GetItemsInfo | grep -v GetItemsLocationInfo | grep -v GetItemsAvailable | grep -v GetItemsByBiblioitemnumber should not return any occurrences of code in perl scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard changed: What|Removed |Added Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 --- Comment #1 from Katrin Fischer --- Created attachment 77706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77706=edit Bug 19390: Make jQuery selector more specific, so OPAC view link can open in new tab The OPAC view link in the staff result list already had a target="_blank", but it didn't work, because of the JavaScript for the result list browser in staff. The JavaSript code was looking for the links to the detail page in staff and this also selected the link to the detail page in OPAC. By changing detail.pl to \detail.pl opac-detail.pl will no longer be selected. To test: - Search in the staff interface - Click "OPAC view" links in staff result lists - Click "OPAC view' links in detai page - Verify both now open in a new tab - Click other links and test that navigation (previous, next, return to results) works as expected - Inside the staff client, you should see something like searchid=scs_1533922927978 added to the URLs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #88 from Katrin Fischer --- Giving this a go, any help/more eyes much appreaciated! 1) Questions 1.1) >This will allow to configure the way the simple search is weighted: >it will search in all fields for which a weight has been indicated. >If no weight was indicated it will search in all fields. (In addition, >this allows excluding some search fields from the simple search!) >From comments#13+ I tihnk this is no longer the case and it will be always searched on all fields + boosting the weighted fields. Can you confirm? 1.2) Should the patches on this bug tested in combination with other patches from dependent bugs? A more detailed test plan would help me a lot. 1.3) Could we deliver this with a basic default weighting? 2) QA tools and unit tests 2.1) FAIL t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid You tried to plan twice 2.2) When I remove the doubled up line, the test still fails: t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report --- t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. Files=1, Tests=0, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.23 cusr 0.05 csys = 0.30 CPU) Result: FAIL kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ vi t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. 1/3 # No tests run! # Failed test 'No tests run for subtest "build_query with weighted fields tests"' # at t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 167. Can't locate object method "new" via package "t::lib::TestBuilder" (perhaps you forgot to load "t::lib::TestBuilder"?) at t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 127. # Looks like your test exited with 255 just after 3. t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/3 subtests 2.3) * Commit title does not start with 'Bug X: ' - dfe2ab9 2.4) Other tests fail too: t/db_dependent/Koha/SearchField.t .. 1/15 # Failed test 'Title weight is 25.' # at t/db_dependent/Koha/SearchField.t line 196. # got: '25.00' # expected: '25' # Failed test 'Subject weight is 15.' # at t/db_dependent/Koha/SearchField.t line 198. # got: '15.00' # expected: '15' # Failed test 'Author weight is 5.' # at t/db_dependent/Koha/SearchField.t line 200. # got: '5.00' # expected: '5' # Looks like you failed 3 tests of 15. t/db_dependent/Koha/SearchField.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/15 subtests 3) Code Review 3.1) Please use AFTER/BEFORE to make sure the column ends always in the correct spot. +$dbh->do( "ALTER TABLE `search_field` ADD COLUMN `weight` decimal(5,2) DEFAULT NULL" ); 3.2) Can you explain this line? 4) Further tests Adding, deleting and editing weights works. Waiting for follow-up and more info before I continue! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Jonathan Druart changed: What|Removed |Added Blocks||21203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 [Bug 21203] ILS-DI - GetRecords crashes on non-existent records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21203] New: ILS-DI - GetRecords crashes on non-existent records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 Bug ID: 21203 Summary: ILS-DI - GetRecords crashes on non-existent records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Web services Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 18255 Caused by commit cb336e633bf7e0cb25051a8ed8157af8486a58d7 Bug 18255: Koha::Biblio - Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem Can't call method "biblioitem" on an undefined value at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart changed: What|Removed |Added Depends on||21202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard changed: What|Removed |Added Attachment #76524|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 Jonathan Druart changed: What|Removed |Added Blocks||21205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #33 from Owen Leonard --- Created attachment 77694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77694=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #36 from Owen Leonard --- Created attachment 77697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77697=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205
--- Comment #2 from Jonathan Druart
---
Created attachment 77698
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77698=edit
Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls
This is done to ease the move of C4::Items (bug 18252) to Koha::Items
my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber});
will become
my @itemnumbers = $order_object->items->get_column('itemnumbers');
Test plan:
- Create an order with several items
- Receive some items
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #34 from Owen Leonard --- Created attachment 77695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77695=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
