[Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #77582|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 --- Comment #4 from Alex Buckley --- Created attachment 81048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81048=edit Bug 21584: Wrong offset type for Lost Item Bug 2696 introduced account_offset_type.inc but 'Lost Item Return' doesn't match what is added on the database. Moreover, bug 20978 added references to this wrong value too in Koha::Account This patch performs a trivial fix for this. Signed-off-by: Tomas Cohen Arazi Patch matches what was outlined in test plan, also passes qa test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #80676|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21636] Error browsing the search results of Authorities in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21636 Andreas Roussos changed: What|Removed |Added CC||arouss1...@gmail.com --- Comment #1 from Andreas Roussos --- Hello Pablo, this looks like a duplicate of Bug 21405? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21642] New: create patron card template in koha generate error not assign template id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21642 Bug ID: 21642 Summary: create patron card template in koha generate error not assign template id Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: it.offi...@ppsu.ac.in QA Contact: testo...@bugs.koha-community.org create patron card template in koha generate error not assign template id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21476] Incorrect filter prevents HTML5 media from playing in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 --- Comment #5 from Alex Buckley --- I tested both patches and they both work nicely. But if we are aiming to make the OPAC code the same as the intranet code (as Jonathan recommended in comment #2) then the second patch does that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21476] Incorrect filter prevents HTML5 media from playing in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 --- Comment #4 from Alex Buckley --- Created attachment 81047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81047=edit Bug 21476: [alternate] Incorrect filter prevents HTML5 media from playing in the OPAC This patch makes a correction to a template filter to prevent incorrectly-encoded HTML in media source links which were preventing media from embedding correctly in the OPAC. To test, apply the patch and enable the HTML5MediaEnabled and HTML5MediaYouTube system preferences. - Edit a record to include links to videos in 856$u. For example: - https://www.youtube.com/watch?v=grTwH6Evdfc - https://archive.org/download/POPEYEMeetsSindbadTheSailor1936/POPEYE%20meets%20Sindbad%20The%20Sailor%20%281936%29.ogv View the record in the OPAC and confirm that the videos display in the "Play media" tab and that they play correctly. Tested and works as described, also matches the intranet code. Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21476] Incorrect filter prevents HTML5 media from playing in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #81013|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #80 from Alex Buckley --- Sorry the patches could not apply, can you please rebase Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17656 - Keep irregularities during subscription renewals Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/css/staff-global.css M koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Auto-merging C4/Serials.pm Failed to merge in the changes. Patch failed at 0001 Bug 17656 - Keep irregularities during subscription renewals The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17656---Keep-irregularities-during-subscriptio-4ETfMG.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21641] Software error when checking out an item with a charge associated with it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21641 Alex Buckley changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21641] Software error when checking out an item with a charge associated with it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21641 --- Comment #1 from Alex Buckley --- Created attachment 81046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81046=edit Bug 21641: Added C4::Accounts to getnextacctno() call Test plan: 1. Fetch and checkout the master branch 2. Checkout an item with a rental charge associated with it to a user and notice an error is thrown 3. Apply patch 4. Restart memcached and plack 5. Repeat steps 1 and 2 and notice the checkout happens successfully Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21641] New: Software error when checking out an item with a charge associated with it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21641 Bug ID: 21641 Summary: Software error when checking out an item with a charge associated with it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When you try to check out an item with a charge associated with it the following error is thrown as the C4::Circulation->AddIssuingCharge() is executed: Undefined subroutine ::Circulation::getnextacctno called at /home/vagrant/kohaclone/C4/Circulation.pm line 3194 The getnextacctno function is in C4::Accounts. This module is in a use pragma at the top of C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #15 from Alex Buckley --- Apologies that should be 'Hi Michal' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #14 from Alex Buckley --- Hi Michael Thanks for testing. Can you please try testing now using the test plan in the patch I have just attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #13 from Alex Buckley --- Created attachment 81045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81045=edit Bug 20844: Revert hold when setting an item to lost If an item is marked as 'Lost' then this patch introduces the following new functionality: 1. Check if there is a bib-level or item-level hold on the item with the status of 'W' (waiting). This is an allocated hold which is not yet checked out to the requesting patron. 1.a. If the hold was originally a bib-level reserve (reserves.originalholdtype='B') then do the following: * Revert the waiting status of the reserve * Set the reserves.itemnumber=NULL so the hold is reset to a bib-level hold 1.b. If the hold was originally (and still is) a item-level hold (reserves.originalholdtype='I') then display a alert dialog box on the additem.pl interface asking the librarian to select one of two options: * Cancel the hold - This deletes the hold altogether * Retain the hold - This does not change the hold. Therefore the requester will still have a hold on a lost item NOTE: Previously an allocated bib-level hold was identical to a item-level hold in the database. As the first available item on the bib record had been allocated to the requester and so an itemnumber had been set in the record in the reserves table. However this patch introduces a atomicupdate which adds the new column 'originalholdtype' to the reserves table. This allows us to track if the reserve was originally a bib level hold and treat it differently when the allocated item is being marked as 'Lost' Test plan: 1. Place a bib-level hold on a biblio 2. Check out an item from the biblio to a different patron 3. Query the reserves db table for biblio you placed the bib-level hold and notice it has no 'itemnumber' or 'status' value 4. Return the item and confirm the hold in the modal box that is loaded 5. Query the reserves db table and notice the itemnumber field is now filled with the returned item's itemnumber and the status is 'W' 6. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 7. Notice the waiting item-level hold still exists after the item is marked as 'lost' 8. Repeat steps 1-7 but this time place an item-level hold on an item in step 1 and then check that same item out in step 2. Notice in the repeated step 7 that the hold remains after marking the item as 'Lost' 9. Apply patch and run ./updatedatabase.pl from the koha-shell in the installer/data/mysql/ directory 9. Repeat steps 1-6 placing an bib-level hold and then query the database and notice the bib-level hold which was changed to an allocated waiting item-level hold when the item was returned and the hold confirmed is now reverted to a bib-level hold again. This is controlled by the LostBibLevelHoldsRevert syspref. If this syspref is not enabled then the allocated item-level (originally bib-level hold) will remain after the item is marked as lost. 10. Repeat 1-6 but this time place an item-level hold on the item. Notice when you mark the item as 'Lost' a yellow warning box is displayed asking if you want to 'Retain hold' or 'Cancel hold'. Select 'Retain hold' and notice the item-level hold remains now the item is marked as lost. 11. Repeat step 10 but choose 'Cancel hold' option and notice the hold is deleted now. 12. Now enable the new 'LostItemCancelOutstandingTransfers' syspref. This will now cancel any outstanding transfers on the item when it is marked as lost. 13. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 14. Now mark that item as 'Lost' and now notice the transfer is cancelled 15. Go into koha-shell from the Koha home dir: sudo koha-shell 16. Run the RevertWaitingStatus.t test file: prove t/db_dependent/Holds/RevertWaitingStatus.t Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Attachment #80891|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Attachment #80760|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Attachment #80890|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #1 from Nick Clemens --- Created attachment 81044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81044=edit Bug 21639: Add phone transports to new and existing installs To test: 1 - Confirm if you do or do not have 'phone' transports defined in the message_transports table 2 - Apply patch 3 - Run updatedatabase 4 - If you didn't have them you should now 5 - Run updatedatabase again, confirm it doesn't error 6 - sudo koha-mysql kohadev 7 - DELETE from message_transports WHERE message_transport_type = 'phone' 8 - Run updatedatabase again 9 - Confirm the message transports table is restored 10 - Drop your DB (or reset_all in kohadevbox) 11 - Ensure the table is fully populated including phone notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 --- Comment #1 from Nick Clemens --- Created attachment 81043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81043=edit Bug 21640: Enable output to STDOUT for Itiva outbound script To test: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output 10 - Apply patch 11 - repeat 12 - Hold info is output to command line -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21640] New: Itivia outbound script doesn't print to STDOUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640
Bug ID: 21640
Summary: Itivia outbound script doesn't print to STDOUT
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Command-line Utilities
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz
This line doesn't seem to work:
open( $OUT, '>', "" ) || die("Couldn't duplicate STDOUT: $!");
To recreate:
1 - Enable the TalkingTechItivaPhoneNotification
2 - Copy 'HOLD' notice 'email' transport to the phone section
3 - Enable EnhancedMessagingPreferences
4 - Find a patron and enable 'phone' for the 'Hold filled' notice
Note: You might not be able to do this straightaway, bug 21639
If the phone box has a '-' and not a checkbox:
sudo koha-mysql kohadev
INSERT INTO message_transports
(message_attribute_id,message_transport_type,is_digest,letter_module,letter_code)
VALUES (4,'phone',0,'reserves','HOLD');
5 - Place a hold for the patron
6 - Check it in and confirm the hold to set it waiting
7 - sudo koha-shell kohadev
8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE
-w 0 -v
9 - Note the Output says it will be on STDOUT, but nothing is output
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] New: Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Bug ID: 21639 Summary: Phone notice transports do not exist for new installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org SELECT * FROM message_transports; there are no phone transports Enable TalkingTechItivaPhoneNotification and EnhancedMessagingPreferences Open a patron Note you can see phone as an option, but not check it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #25 from David Cook --- I figure one way or another we need to have a solid solution for background processing of tasks. I'm running into a related issue with someone trying to do batch_record_modification.pl with a large number of records, but there are a million other use cases that require it. We've been talking about this issue for years, and I'm wondering if this is something where plugins might be useful. Tomas suggested an approach to me at Kohacon where Koha has a default built-in functionality, but then lets you use plugins to override that built-in functionality. Maybe we could make the hooks a "developer feature"? So the hook is only run in "developer mode", but that lets many developers write their own plugins to try and find something that works? And maybe the best plugin gets adopted by Koha to replace the default functionality, which I'm sure we all agree is not good enough right now. I wrote my own job server using POE::Component::JobQueue for #10662 and it works pretty well, but I'm sure it could be better. But I'd be happy to contribute a plugin for people to try out. I can't guarantee it would be the best solution, but it would be "a" solution. (With 10662, the job server runs as a standalone daemon process, and Koha, whether CGI or PSGI, connects to the daemon using a UNIX socket and uses JSON messages for talking about jobs.) There are lots of other options out there. I think Minion might be a good one since it's within the Mojolicious family. I was thinking of using it, but I think I didn't as it wasn't interactive enough for my purposes, but... I figure we should try out some things rather than just be in discussion forever? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21638] New: Allow reporting of holds cancelled by cancel_expired_holds.pl and ExpireReservesMaxPickUpDelay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21638 Bug ID: 21638 Summary: Allow reporting of holds cancelled by cancel_expired_holds.pl and ExpireReservesMaxPickUpDelay Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When ExpireReservesMaxPickUpDelay is set to Allow, waiting holds are automatically cancelled by cancel_expired_holds.pl. But, generally, libraries still need to physically remove those items from their hold shelf and check them in to guarantee there are not pending holds or transfers to be triggered. A report to identify these items is imperfect and cannot definitively distinguish a hold cancelled by the cron from a hold cancelled by an employee. Bug 14134 established behavior that displays holds which *will* be cancelled by the next run of the cron on the "holds over" tab in Holds Awaiting Pickup, but doesn't allow staff to see which holds have already been cancelled. It'd be great if the cron could email a list of cancelled holds. Additionally, reporting would be improved by the introduction of a new value in old_reserves.found for items cancelled by the cron (maybe E for expired). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21180] Allow Talking Tech outbound script to limit based on patron home library branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21180 Nick Clemens changed: What|Removed |Added Attachment #77581|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 81042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81042=edit Bug 21180: Allow Talking Tech outbound script to limit based on patron home library branchcode A library system has requested the ability to limit which patrons are sent to Itivia for phone notices. Test Plan: 1) Enable phone notices for two patrons with overdues 2) Run the misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl with the new --patron-branchcode option 3) Note only the patron whose homebranch you specified is in the output file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Cormack changed: What|Removed |Added Attachment #80556|0 |1 is obsolete|| --- Comment #53 from Chris Cormack --- Created attachment 81041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81041=edit Bug 15836: Fix display input in any situations Fix when switching an existing rule to RegEx Signed-off-by: Christian Stelzenmüller Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Cormack changed: What|Removed |Added Attachment #80554|0 |1 is obsolete|| --- Comment #51 from Chris Cormack --- Created attachment 81039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81039=edit Bug 15836: Add missing svc script Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Cormack changed: What|Removed |Added Attachment #80553|0 |1 is obsolete|| --- Comment #50 from Chris Cormack --- Created attachment 81038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81038=edit Bug 15836: Add tests Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Cormack changed: What|Removed |Added Attachment #80552|0 |1 is obsolete|| --- Comment #49 from Chris Cormack --- Created attachment 81037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81037=edit Bug 15836: Mark C4::ClassSource subs DEPRECATED These subs are no longer used from scripts and should be removed. It should be done on a separate bug report given that additional work is needed Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836
Chris Cormack changed:
What|Removed |Added
Attachment #80551|0 |1
is obsolete||
--- Comment #48 from Chris Cormack ---
Created attachment 81036
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81036=edit
Bug 15836: Add the ability to defined custom methods to split call number in
labels
Currently the call number splitting seems to be mostly implemented for
DDC and LC classifications.
Those are both not very common in some countries.
A lot of libraries use their own custom classification schemes so the call
number
plitting is something that should be individually configurable.
This enhancement adds the ability to define custom splitting rules based
on regular expressions.
How does it work so far?
From C4/Labels/Label.pm there are 3 differents splitting methods defined,
depending on items.cn_source.
if cn_source is "lcc' or 'nlm' we split using Library::CallNumber::LC
if cn_source is 'ddc' we split using a in-house method
Finally there is a fallback method to split on space
And nothing else is done for other cn_source
The idea of this patch is to mimick what was done for the "filing rules" and
add
the ability to define "splitting rules" that will be used by the
"Classification sources".
A classification source will then have:
* a filing rule used to sort items by callnumbers
* a splitting rule used to print labels
To acchieve this goal this enhancement will do the following
modifications at DB level:
* New table class_split_rules
* New column class_sources.class_split_rule
Test plan:
* Execute the update database entry to create the new table and
column.
I. UI Changes
a) Create/modify/delete a filing rule
b) Create/modify/delete a splitting rule
c) Create/modify/delete a classification source
=> A filing rule or splitting rule cannot be removed if used by a
classification source
II. Splitting rule using regular expressions
a) Create a splitting rule using the "Splitting routine" "RegEx"
b) Define several regular expressions, they will be applied one after
the other in the same order you define them.
Something like:
s/\s/\n/g # Break on spaces
s/(\s?=)/\n=/g# Break on = (unless it's done already)
s/^(J|K)\n/$1 / # Remove the first break if callnumber starts with J or K
c) You can test the regular expressions using filling the textarea with
a list of callnumbers. Then click "Test" and confirm the callnumbers are
split how you expected.
d) Finally create a new classification source that will use this new
splitting rule.
III. Print the label!
a) Create a layout. It should have the "Split call numbers" checkbox
ticked, and display itemcallnumber
b) Use this layout to export labels, use items with different
classification source ('lcc', 'ddc', but also the new one you have
create)
=> The callnumbers should have been split according to the regex you
defined earlier!
Notes:
* The update database entry fill the class_sources.class_split_rule
with the value of class_sources.class_sort_rule
If default rules exist it will not work, we should add a note in the
release notes (would be enough?)
* C4::ClassSplitRoutine::* should be moved to Koha::ClassSplitRule,
but it sounded better to keep the same pattern as ClassSortRoutines
* Should not we use a LONGTEXT for class_split_rules.split_regex instead
of VARCHAR(255)?
* class_sources.sql should be filled for other languages before pushed
to master!
IMPORTANT NOTES: The regular expressions are stored as it, and eval is
used to evaluate it (perlcritic raises a warning about it (Expression
form of "eval"). It can lead to serious security issues (execution of
arbitrary code on the server), especially if the modifier 'e' is used.
We could then remedy the situation with one of these following points:
- Assume that this DB data is safe (We can add a new permission?)
- Assume that the data is not safe and deal with possible attack
Cons: how be sure we are exhaustive? Making sure it matches ^s///[^e/]*$
would be enough?
- Use Template Toolkit syntax instead (Really safer?)
[% callnumber.replace('\s', '\n').replace ... %]
- Cut the regex parts: find, replace, modifiers
like we already do for Marc modification template. Cons: we are going to
have escape problems, the "find" and "replace" parts should not be
handle the same way (think "\n", "\\n", "\1", "\s", etc.)
I did not manage to implement this one easily.
Signed-off-by: Christian Stelzenmüller
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git :
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Cormack changed: What|Removed |Added Attachment #80548|0 |1 is obsolete|| --- Comment #45 from Chris Cormack --- Created attachment 81033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81033=edit Bug 15836: DB changes Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Cormack changed: What|Removed |Added Attachment #80550|0 |1 is obsolete|| --- Comment #47 from Chris Cormack --- Created attachment 81035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81035=edit Bug 15836: UI changes The script admin/classsources.pl has been adjusted to follow usual patterns used in other Koha scripts. $op can be add_source, add_source_validate, etc. Deletion steps have been removed (there is a JS confirmation box) to simplify both script and template. Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Cormack changed: What|Removed |Added Attachment #80549|0 |1 is obsolete|| --- Comment #46 from Chris Cormack --- Created attachment 81034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81034=edit Bug 15836: DBIC Schema change Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21637] New: Capitalization: EasyAnalyticalRecords syspref option "Don't Display" should be "Don't display"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21637 Bug ID: 21637 Summary: Capitalization: EasyAnalyticalRecords syspref option "Don't Display" should be "Don't display" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In Administration > Global System Preferences, go in Cataloging > Interface. The options for EasyAnalyticalRecords are Don't Display and Display. "Don't Display" should be "Don't display". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #74 from Pierre-Marc Thibault --- All the old patches have been merged to make tests easier. The new patch is rebased and solves the last problems mentioned. The tab char is gone, the style attributes too and the inputs order is now correct. It seems there is no problem with the alert message, it will be to confirme with other tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #73 from Pierre-Marc Thibault --- Created attachment 81032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81032=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #103 from Julian Maurice ---
(In reply to Jonathan Druart from comment #101)
> So, from what I understand the third form (for 0) will be not supported,
> unless we change the Plural-Forms (are we really supposed to change that?).
I don't think we are supposed to.
The simple solution would be to always use the {count} so we would have "0
exemplaire" and "1 exemplaire".
Or we could handle this in the code:
[% IF count %]
[% tnx('{count} item', '{count} items', count, { count = count }) %]
[% ELSE %]
[% t('Not a single item!') %]
[% END %]
I think there is no best solution here and both can be used.
Sometimes we want to display a different message when there are 0 "things", and
sometimes not.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74268|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74267|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74269|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74272|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74270|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #102 from Jonathan Druart --- Code review: 1. Not important but the Koha.po file provided for the tests are not taken into account. Maybe it could be better to generate the .mo from the tests? 2. No tests provided for misc/translator/LangInstaller.pm - I would not consider it as blocker as it is the current state. 3. The content from the .inc files are added to the .po because they contain TT blocks on several lines. Maybe we should have a list of files to skip and copy as it (?) 4. What is done in Koha::I18N::init is weird, but I trust you if you think everythink is needed. However: pod Locale::Messages, nl_putenv: "The sole purpose of this function is to work around some ideosyncrasies in the environment processing of Windows systems. If you want to portably set or unset environment variables, use this function instead of directly manipulating %ENV." So maybe we should use ENV, it will make the line clear about what it does, and 'git grep $ENV' will work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21636] New: Error browsing the search results of Authorities in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21636 Bug ID: 21636 Summary: Error browsing the search results of Authorities in Staff Client Change sponsored?: --- Product: Koha Version: 18.05 Hardware: HP OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: pablojoneslo...@yahoo.com QA Contact: testo...@bugs.koha-community.org Created attachment 81031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81031=edit Error Example pagination When I consult the results of a search in: Home> Authorities> Authority search results (../cgi-bin/koha/authorities/authorities-home.pl?marclist=mainmainentry_or=and=contains=ECONOMIA=20=intranet=do_search=HeadingAsc=1), the paging buttons do not work correctly. The first page displays the results of 1 to 20, but the second page shows the results of 2 to 21 instead of 21 to 35. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #101 from Jonathan Druart
---
It works better instead.
Just noting:
== es-ES - nplurals=2; plural=(n != 1); ==
msgid "{count} item"
msgid_plural "{count} items"
msgstr[0] "Uno ejemplar"
msgstr[1] "{count} ejemplares"
will output:
1: Uno ejemplar
2: 2 ejemplares
but also:
0: 0 ejemplares
== fr-FR - nplurals=2; plural=(n > 1); ==
msgid "{count} item"
msgid_plural "{count} items"
msgstr[0] "Un exemplaire"
msgstr[1] "{count} exemplaires"
will output:
1: Un examplaire
2: 2 exemplaires
but also:
0: Un exemplaire
So, from what I understand the third form (for 0) will be not supported, unless
we change the Plural-Forms (are we really supposed to change that?).
With:
"Plural-Forms: nplurals=3; plural=(n==0 ? 0 : n==1 ? 1 : 2);\n"
#: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:1
#: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:2
#, perl-brace-format
msgid "{count} item"
msgid_plural "{count} items"
msgstr[0] "Pas d'exemplaire"
msgstr[1] "Un exemplaire"
msgstr[2] "{count} exemplaires"
I get what I expected:
1: Un exemplaire
2: 2 exemplaires
0: Pas d'exemplaire
(I have moved the tnx call outside before the SEARCH_RESULT.items_count)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #100 from Julian Maurice --- (In reply to Jonathan Druart from comment #99) > > - According to > > https://localization-guide.readthedocs.io/en/latest/l10n/pluralforms.html > > Spanish has 2 "plural forms" (one of which is the singular form), so > > msgstr[0] should contain the singular form and msgstr[1] the plural form. > > Did you try if these changes will behave correctly in pootle? > i.e. Does the pootle's interface will let translators filled these forms > according to the language, etc.? I haven't tried but the documentation says that pootle support this feature http://docs.translatehouse.org/projects/translate-toolkit/en/latest/formats/po.html#po and it's a basic feature of gettext/PO files. I would be very surprised if Pootle doesn't handle it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #99 from Jonathan Druart --- (In reply to Julian Maurice from comment #98) > Hi Jonathan, and thanks for testing. > > There are several problems here: > - You must not modify msgid_plural in the PO file, it's a string identifier > just like msgid. Erk! ok retesting! > - According to > https://localization-guide.readthedocs.io/en/latest/l10n/pluralforms.html > Spanish has 2 "plural forms" (one of which is the singular form), so > msgstr[0] should contain the singular form and msgstr[1] the plural form. Did you try if these changes will behave correctly in pootle? i.e. Does the pootle's interface will let translators filled these forms according to the language, etc.? > - Locale::Messages does export setlocale but only since version 1.24. It > should be ok since Ubuntu xenial/16.04 and Debian stretch/stable. Which > version of this package are you using ? 1.23 I guess it will not hurt to have it, right? > - bug 21156 is not needed here. Please don't apply it. ok! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #98 from Julian Maurice --- Hi Jonathan, and thanks for testing. There are several problems here: - You must not modify msgid_plural in the PO file, it's a string identifier just like msgid. - According to https://localization-guide.readthedocs.io/en/latest/l10n/pluralforms.html Spanish has 2 "plural forms" (one of which is the singular form), so msgstr[0] should contain the singular form and msgstr[1] the plural form. - Locale::Messages does export setlocale but only since version 1.24. It should be ok since Ubuntu xenial/16.04 and Debian stretch/stable. Which version of this package are you using ? - bug 21156 is not needed here. Please don't apply it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #173 from David Gustafsson --- I agree It might benefit from documentation, it should (or even can) not be moved outside though, since I think there are some closures within. It is also a specific and private helper-method, thus belongs inside the method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Attachment #74273|0 |1 is obsolete|| --- Comment #72 from Pierre-Marc Thibault --- Comment on attachment 74273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74273 Bug 8643: (follow-up) Move input field up below mandatory This patch is set at obsolete since it contains no usable code and duplicated code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #97 from Jonathan Druart --- Also I should note that I had to amend the code, the tests were failing # Failed test 'use Koha::I18N;' # at t/Koha/I18N.t line 10. # Tried to use 'Koha::I18N'. # Error: "setlocale" is not exported by the Locale::Messages module I did, in Koha/I18N.pm -use Locale::Messages qw(:locale_h nl_putenv setlocale LC_MESSAGES); +use Locale::Messages qw(:locale_h nl_putenv LC_MESSAGES); +use POSIX qw (setlocale); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #96 from Jonathan Druart
---
Sorry but I still do not manage to make it works.
Naive test, following the test plan:
0/ do not apply the patch
1/ perl translate update es-ES && perl translate install es-ES
2/ git commit -a -m"init po's" # to see the diff later
3/ yes|git bz apply 21156
4/ perl translate update es-ES
5/ Edit misc/translator/po/es-ES-messages.po
6/
#: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:1
#, perl-brace-format
msgid "{count} item"
msgid_plural "XXX {count} ejemplares XXX"
msgstr[0] "No ejemplar"
msgstr[1] "Solo uno ejemplar"
4/ perl translate install es-ES
5/ I see:
English version: https://snag.gy/91kXtN.jpg
Spanish version: https://snag.gy/HD7OQN.jpg
I have added
msgstr[2] "XXX {count} ejemplares XXX"
But it does not change the result.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18593] Suggestions aren't updated when one biblio is merged with another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19739] Add default ES configuration to koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20067] Wrong display of authorised value for items.materials on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11936] Consistent log message for item insert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20383] Hide link to plugin management if plugins are not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20383 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20372] Correct toolbar markup on some pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20376] "Select all" button no longer selects disabled checkboxes in Batch Record Deletion Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20054] Remove attribute "text/css" for the style tags used in the OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20430] Z39.50 button display depends on wrong server count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20430 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20474] Passwordrecovery.t should mock Mail::Sendmail::sendmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20474 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19953] Add column for invoice in acquisition details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589 Bug 13589 depends on bug 12812, which changed state. Bug 12812 Summary: Longoverdue.pl --mark-returned doesn't return items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18709] koha-foreach should use koha-shell, internally
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18709 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19568] Wrong html filter used in opac-opensearch.tt url
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19568 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Bug 20286 depends on bug 19568, which changed state. Bug 19568 Summary: Wrong html filter used in opac-opensearch.tt url https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19568 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20311] get_age tests can fail on February 28th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20311 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20301] Allow translating "View" in manage MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20301 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20302] Allow translating Delete button in Patron batch mod tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20302 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20141] Untranslatable string in Transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20141 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20296] Untranslatable "All" in patrons table filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20296 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20295] Allow translating link title in ILL module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20295 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20290] Fix capitalization: Routing List
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20290 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20142] Allow translating offline circ message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20142 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20147] Allow translating prompt in label edit batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20147 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Jonathan Druart changed: What|Removed |Added Severity|major |critical --- Comment #19 from Jonathan Druart --- Upgrading severity as it impacts the last stable version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #18 from Colin Campbell --- Bonus - fixes a failure to process renew requests I've just spotted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21400] Cronjobs: processes exited with return code 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21400 Claudio changed: What|Removed |Added Component|Command-line Utilities |Notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #59 from Jonathan Druart --- First patch does not longer apply Applying: Bug 14716: URI-encode URLs in MARC21 xsl templates. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl M koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl M koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 --- Comment #3 from Tomás Cohen Arazi --- The original bug is in: koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc it is not easy to 'reproduce', as the code that should generate credit return offsets is not working properly (bug 13098). This is my attempt: - View the following file: installer/data/mysql/account_offset_types.sql $ less installer/data/mysql/account_offset_types.sql - Notice there's 'Lost Item' in line 4 - View koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc $ less koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc - Notice it maps the values from the account_offset_types.sql file into english descriptions. => FAIL: There's no mapping for 'Lost Item', but there's a mapping for 'Lost Item Return', which doesn't really exist in account_offset_types.sql - Apply the patch => SUCCESS: The value <-> description mapping in account_offset_type.inc makes sense now. It respects the values that would be stored on the DB if the feature worked correctly. => BONUS: Koha/Account.pm gets fixed to generate the right value too. Notice there's a hash with mappings for some keywords into both account_offset_types and account types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Jonathan Druart changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21570] Switch two-column templates to Bootstrap grid: Various
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21570 Jonathan Druart changed: What|Removed |Added Attachment #80822|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 81030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81030=edit Bug 21570: Update two-column templates with Bootstrap grid: Various This patch modifies several assorted templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 21570] Switch two-column templates to Bootstrap grid: Various
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21570 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 --- Comment #13 from Jonathan Druart --- Created attachment 81029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81029=edit Bug 20970: Add preventDefault to avoid trailing # to be added to the url Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Jonathan Druart changed: What|Removed |Added Attachment #80954|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 81028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81028=edit Bug 20970: Reformat basket information on acquisitions basket page This patch reformats the display of information on the acquisitions basket page, hiding form controls until they are triggered. Some basket information is now in the second column in order to balance the two columns better. The "Library" label has been replaced with the more precise "Managing library." Unrelated change: Removed script type attributes. To test, apply the patch and view a basket in acquisitions. Test these processes: - Adding and removing managing users - Setting and changing managing library - Setting and changing basket group Signed-off-by: Caroline Cyr La Rose Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21625] Fix wording and typo in SMSSendDriver system preference description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625 Jonathan Druart changed: What|Removed |Added Attachment #80967|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 81027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81027=edit Bug 21625: Fix wording and typo in SMSSendDriver system preference description SMSSendDriver was missing an S. Koha is sending not receiving messages, so I think switching that will be a little more clear. To test: Verify that the system preference description reads correctly. Signed-off-by: Andreas Roussos Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
