https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614
Jonathan Druart changed:
What|Removed |Added
Attachment #80991|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098
Tomás Cohen Arazi changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098
Tomás Cohen Arazi changed:
What|Removed |Added
Severity|normal |major
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |In Discussion
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #34 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #31)
> This approach scares me I'm afraid.. it feels like we're hiding errors that
> really ought to be getting thrown up to the callers and for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #33 from Marcel de Rooy ---
Isn't the problem that we ignored too many warnings in the past that we cannot
let it explode on such things now ?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #172 from Joonas Kylmälä ---
Comment on attachment 78690
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690
Bug 19893 - Alternative optimized indexing for Elasticsearch
Review of attachment 78690:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242
Jonathan Druart changed:
What|Removed |Added
Depends on||21634
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634
Jonathan Druart changed:
What|Removed |Added
Blocks||21242
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18062
Caroline Cyr La Rose changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #32 from Martin Renvoize ---
Seems Tomas just expressed the same concern as me there really.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #31 from Martin Renvoize ---
This approach scares me I'm afraid.. it feels like we're hiding errors that
really ought to be getting thrown up to the callers and for developers to make
informed decisions.
Falling back to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #30 from Tomás Cohen Arazi ---
(In reply to Tomás Cohen Arazi from comment #29)
> (In reply to Jonathan Druart from comment #28)
> > (In reply to Tomás Cohen Arazi from comment #26)
> > > I feel like (overall) I don't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #29 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #28)
> (In reply to Tomás Cohen Arazi from comment #26)
> > I feel like (overall) I don't agree with the approach (the general one, or
> > the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #28 from Jonathan Druart
---
(In reply to Tomás Cohen Arazi from comment #26)
> I feel like (overall) I don't agree with the approach (the general one, or
> the various fixes on the Koha:: namespace that have been
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #27 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #16)
> Comment on attachment 80882 [details] [review]
> Bug 21610: Fix integers and dates values at Koha::Object->store level
>
> Review of attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #26 from Tomás Cohen Arazi ---
I feel like (overall) I don't agree with the approach (the general one, or the
various fixes on the Koha:: namespace that have been pushed to master). DBIC
should explode, we should catch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242
--- Comment #6 from Nick Clemens ---
(In reply to Jonathan Druart from comment #5)
> Nick, Owen, what about this alternative patch?
Hmm...this still allows for odd things - the borrowernumber is locked, but I
can change the moduel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #25 from Jonathan Druart
---
(In reply to Tomás Cohen Arazi from comment #24)
> What about things like this:
>
> https://metacpan.org/release/DBIx-Class-Validation
If I understand the goal of this module correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635
--- Comment #1 from Jonathan Druart
---
Created attachment 81025
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81025=edit
Bug 21635: [sql_modes] Remove GROUP BY clause in batchMod.pl
batchMod.pl: DBD::mysql::st
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
Jonathan Druart changed:
What|Removed |Added
Depends on||21635
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635
Bug ID: 21635
Summary: Incorrect GROUP BY clause in batchMod.pl
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635
Jonathan Druart changed:
What|Removed |Added
Blocks||17258
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #24 from Tomás Cohen Arazi ---
What about things like this:
https://metacpan.org/release/DBIx-Class-Validation
Also, it feels DBIX::Class should have some way to tell 'use the default when
undef is passed'. I'm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436
Kyle M Hall changed:
What|Removed |Added
Attachment #80984|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #23
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634
--- Comment #1 from Jonathan Druart
---
Created attachment 81023
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81023=edit
Bug 21634: Keep "circulation" module selected when viewing patron's logs
To recreate:
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511
--- Comment #5 from Nick Clemens ---
Created attachment 81022
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81022=edit
Bug 21511: (RM follow-up) Use orders.count instead of new variable
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #22 from Kyle M Hall ---
Created attachment 81021
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81021=edit
Bug 21610: Improve default values for dates
This patch fixes failures on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
Kyle M Hall changed:
What|Removed |Added
Attachment #80880|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #21 from Kyle M Hall ---
Created attachment 81020
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81020=edit
Bug 21610: (follow-up) Default value for dates
We have some dates with DEFAULT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #20 from Kyle M Hall ---
Created attachment 81019
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81019=edit
Bug 21610: (QA follow-up) Better use columns_info from DBIx
We should better use the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #19 from Kyle M Hall ---
Created attachment 81018
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81018=edit
Bug 21610: Fix integers and dates values at Koha::Object->store level
With strict SQL modes,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #18 from Kyle M Hall ---
Created attachment 81017
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81017=edit
Bug 21610: Remove specific changes we made previously
We handled integers and dates for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634
Bug ID: 21634
Summary: "Circulation" option is lost when viewing patron's
logs
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
--- Comment #16 from Kyle M Hall ---
Comment on attachment 80882
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80882
Bug 21610: Fix integers and dates values at Koha::Object->store level
Review of attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242
--- Comment #5 from Jonathan Druart
---
Nick, Owen, what about this alternative patch?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #171 from David Gustafsson ---
(In reply to Joonas Kylmälä from comment #168)
> Comment on attachment 80971 [details] [review]
> Bug 19893: Add pods, remove syspref, add tests for serialization format
>
> Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #81014|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
Ere Maijala changed:
What|Removed |Added
CC||ere.maij...@helsinki.fi
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #80971|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_18_11_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_18_11_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476
--- Comment #3 from Nick Clemens ---
Created attachment 81013
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81013=edit
Bug 21476: [alternate] Incorrect filter prevents HTML5 media from playing in
the OPAC
This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
--- Comment #120 from Ere Maijala ---
I took the liberty of fixing the md5sum of the schema file while signing off.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #78403|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #78401|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #80335|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #78400|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #78397|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #78402|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #78399|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #78396|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
Ere Maijala changed:
What|Removed |Added
Attachment #78398|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282
Jonathan Druart changed:
What|Removed |Added
Attachment #78293|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #168 from Joonas Kylmälä ---
Comment on attachment 80971
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80971
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21283
Alex Buckley changed:
What|Removed |Added
Resolution|--- |INVALID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954
Alex Buckley changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
Alex Buckley changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
Alex Buckley changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
--- Comment #17 from Alex Buckley ---
Created attachment 81002
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81002=edit
Bug 21486: Only fetch the items' barcodes
and avoid unecessary processing
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
--- Comment #16 from Alex Buckley ---
Created attachment 81001
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81001=edit
Bug 21486: Fix 'AU' for SIP
Signed-off-by: Colin Campbell
Signed-off-by: Alex Buckley
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
Alex Buckley changed:
What|Removed |Added
Attachment #80976|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
--- Comment #15 from Alex Buckley ---
(In response to Colin Campbell in comment 14):
Yes I can confirm Jonathan's patches do what I had envisaged and can replace my
patch.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
Alex Buckley changed:
What|Removed |Added
Attachment #80729|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
Alex Buckley changed:
What|Removed |Added
Attachment #80251|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465
Elanie changed:
What|Removed |Added
CC||dragoela...@gmail.com
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633
--- Comment #1 from Magnus Enger ---
Looking some more at this, it seems that finesMode = test really does not do
anything. In order to make fines.pl write output to a file, either the --log
command line option (for writing to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633
Bug ID: 21633
Summary: Did finesMode = test ever send email?
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282
--- Comment #3 from Katrin Fischer ---
Jonathan, could you have another look here?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #167 from Joonas Kylmälä ---
(In reply to David Gustafsson from comment #165)
> Regarding the other changes, to make review easier, they where mainly:
>
> Rename marc_records_to_documents to _marc_records_to_documents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #166 from Joonas Kylmälä ---
(In reply to David Gustafsson from comment #164)
> Created attachment 80983 [details] [review]
> Bug 19893: Fixed some typos
Please squash this to the previous patch as a new commit created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You
101 - 181 of 181 matches
Mail list logo