[Koha-bugs] [Bug 21487] Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Fridolin SOMERS changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17371] Add routes for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Johanna Räisä changed: What|Removed |Added CC||johanna.ra...@koha-suomi.fi --- Comment #20 from Johanna Räisä --- I have a suggestion to POST and PUT endpoints. At the moment the code doesn't validate or compare coming MARC record. On POST endpoint there should be some kind of validation at least checking that the control numbers exist. On PUT we should check matching rules so libraries can choose what they want to do with the fields. Matcher_id check could be added as an optional parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |BLOCKED --- Comment #13 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #12) > I am not sure I agree about 1): If you have it show up on the holds to pull > report, it should be made sure that the items you pull can trigger the hold > on return. Hiding the itemtypes that are not holdable makes sense to me. Changing status again. Still rethinking a bit about what you say. Thx for feedback. > But more important, as this is a bug fix, the page should behave the same as > it behaved before we broke it for now and changes should be discussed > separately. Hmm. A fix should not be a new bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 e.betemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 e.betemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 --- Comment #14 from Marcel de Rooy --- Forget my former QA comment. I tested biblio level hold and item level hold now. Probably misread the query ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 --- Comment #15 from Marcel de Rooy --- So, I will pass QA. The only thing raised about a hold that no longer should be a hold since it does no longer pass circ rules, should not block this report indeed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Marcel de Rooy changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Marcel de Rooy changed: What|Removed |Added Attachment #93728|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 93985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93985&action=edit Bug 23484: Update pendingreserves.pl to use circulation_rules Signed-off-by: Fridolin Somers Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Marcel de Rooy changed: What|Removed |Added Attachment #93731|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 93986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93986&action=edit Bug 23484: (follow-up) add parenthesis in JOIN Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl --- Comment #55 from Marcel de Rooy --- OK Trying to be brave, start QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #56 from Marcel de Rooy --- INSERT IGNORE INTO account_debit_types ( code, default_amount, description, can_be_added_manually, is_system ) SELECT SUBSTR(authorised_value, 1, 64), lib, authorised_value, 1, 0 This does not match somehow. Default amount filled by lib ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #57 from Marcel de Rooy --- NAME ac_debit_types_branches Names for databases, tables, columns, and indexes can be up to 64 characters long. Alias names can be up to 256 characters long. Why not account_debit_types_branches instead of some abbreviated form. Making developers look for a table a bit longer? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #58 from Marcel de Rooy --- Moving authorized values to new table: SUBSTR(authorised_value, 1, 64) This may be a source of trouble, at least theoretically. Why not switch from the 64 to 80 chars? `accounttype` varchar(80) default NULL, `debit_type_code` varchar(64) default NULL, `payment_type` varchar(80) default NULL, -- optional authorised value PAYMENT_TYPE This looks a bit inconsistent too? Why not give the table an autoincrement id as PK and do not duplicate the code everywhere? Accountlines could be large, less space? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19884] Improve performance of GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #57 from David Gustafsson --- (In reply to Tomás Cohen Arazi from comment #55) > Hi David, I haven't been following this thread in full, but I suggest you > take a look at this line of code: > > http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=opac/opac- > ISBDdetail.pl;h=c79167cd31274cf115e99293bdd7fa7716c3d88d;hb=HEAD#l63 > > You will notice that there's actually a prefetch of the related metadata row > and the (maybe multiple) items rows in the same query (through a LEFT JOIN). > > The same approach can be used for a resultset (i.e. not just a ->find > returning a single Koha::Biblio). > > You can then acccess (without further queries to the DB) the MARC record > through: > > $biblio->metadata->record > > I think the only missing thing here, would be a Koha::RecordProcessor filter > (EmbedItems) that would take this resultset (so no new queries) and does the > same thing your original code did. > > In short: heavy use of prefetch, and abandon the C4::Biblio and C4::Items > routines. If you agree I could write the RecordProcessor filter. Hi! This sounds good if I'm understanding correctly. The big win is to be able to fetch multiple biblios in batches and this resulting in only one or a few constant number of queries. If prefetch on a biblio resultset manages to do this you would probably get the same speedup. (Worth noticing is that the overhead is not on the sql-server, but almost completely in the perl-code initializing each call to Koha::Objects->find/search, so more efficient database-queries is not the primary target for improving performance, but making fewer calls to DBIx methods through batching.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #59 from Marcel de Rooy --- FAIL Koha/Account/DebitType.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Account::DebitType': Koha::Account::DebitType, current merge results [ ] merging failed on 'Koha::Object' FAIL Koha/Account/DebitTypes.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' SKIP spelling OK valid Not sure what exactly triggered the first one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #60 from Martin Renvoize --- Thanks for taking a look Marcel, I'll get onto the feedback today... all of it seems sane to me so far. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andreas Hedström Mace changed: What|Removed |Added CC||andreas.hedstrom.mace@sub.s ||u.se --- Comment #26 from Andreas Hedström Mace --- I don't understand Nick's third point. Any attempted renewal should base that renewal on today's date and calculate the new due date based on the circulation rule for the item from that? Not the original due date. (At least that is what happens if I renew in our version of Koha, 18.11.) So it could never happen that the item is not "current" after a renewal? Or am I reading that wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19884] Improve performance of GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #58 from David Gustafsson --- It would need a larger refactoring though, even though I know we want to get rid of the C4 namespace. GetBiblioMarc would be replaced by a call to Biblio->find with a Koha::RecordProcessor for embedding items (I would suggest keeping but deprecating GetBiblioMarc and replacing the subroutine body with the Koha-namespace equivalent code. Perhaps it would be a mistake to make things a bit messy making this refactoring part of this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #27 from Andrew Isherwood --- Hi Andreas I believe this is determined by the "RenewalPeriodBase" syspref, if set to "the old due date of the checkout" then the scenario Nick describes could happpen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #28 from Andreas Hedström Mace --- Ah, thanks! I had forgotten about that one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23800] New: Batch modification tool orders items by barcode incremental by default (different behavior than 17.11)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Bug ID: 23800 Summary: Batch modification tool orders items by barcode incremental by default (different behavior than 17.11) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suz...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 93987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93987&action=edit Screen capture When using the batch modification tool and entering barcodes in a list, the screen which shows the different items matched is sorted by barcode ordered incrementally. It's quite inconvenient for a librarian who have a pile of book on his desk with a different order (which was just scanned). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #61 from Marcel de Rooy --- This is a quite fundamental one: UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types) Hmm. I do not really like this at first glance (and second too ;). I would prefer one account type and not a separate debit code. If I would be scrolling through account lines, I think it is weird to have to look at two columns to determine the type of this transaction. But might understand this choice from the perspective to keep this patch set a bit smaller and narrow it down to the old MANUAL_INV stuff. So, my problem actually goes a bit beyond this report too and is also about the design of accounts. We should have added an accounts type table in the first place. Now we are doing it for a subset of our account types. And I am wondering if this step will bring us closer to that goal of integrating these types or will just hinder us along the way. I am inclined to think that we should not separate the two now. And I understand that this creates new problems. The account types would be partially controlled by the debit codes list. So we could not (yet) put a FK on it. But it might be a better starting point for controlling the other account types? Since this is an important design choice, I would suggest to discuss this on the dev list or within the QA team, or dev meeting? We need some more consensus on that decision. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23801] New: Connectivity with other systems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23801 Bug ID: 23801 Summary: Connectivity with other systems Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: roland.vandervel...@bruynzeel.org QA Contact: testo...@bugs.koha-community.org I'm looking for possibilities to automate or make the retrieval & return process more efficient between Koha and intelligent mobile shelving systems. I have several questions on this matter: - Does Koha provide a picking lists option based on the most efficient order / sequence? - Is there a possibility to communicate between Koha and intelligent mobile shelving systems via an interface? - In which way is this communication possible? Ofcourse ther are much more questions, but this should give a start to get in contact with somebody that can help me on this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #10 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #11 from Marcel de Rooy --- From Patron/Category: =head3 override_hidden_items if ( $patron->category->override_hidden_items ) { ... } Returns a boolean that if patrons of this category are exempt from the OPACHiddenItems policies TODO: Remove on bug 22547 => Looks like we did not on 22547 ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #47 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 --- Comment #18 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #12 from Marcel de Rooy --- Does this report obsolete the borcat parameter of GetMarcBiblio btw? If so, please provide a follow-up to get rid of it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #13 from Marcel de Rooy --- If I have nothing in OPACHiddenItems or just itype: [CF], I do not see my two items on a record with itype BK or BKS. Just: No available items. Without your patch, they come up again. Nice. So there is still something wrong ;) Can you find it ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Severine: Please describe how you got the encoding issue. I see a title field on your image. Where does it come from ? Nick: At first glance it seems to me that you should encode/decode unicode stuff when saving and fetching from CGI cookies. I had a quick look in CGI on cpan but the docs are very quiet about it. Cannot see if -utf8 should handle cookie values too. Please check. Changing status for feedback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23801] Connectivity with other systems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23801 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- (In reply to roland.vandervelden from comment #0) > I'm looking for possibilities to automate or make the retrieval & return > process more efficient between Koha and intelligent mobile shelving systems. > I have several questions on this matter: > - Does Koha provide a picking lists option based on the most efficient order > / sequence? > - Is there a possibility to communicate between Koha and intelligent mobile > shelving systems via an interface? > - In which way is this communication possible? > Ofcourse ther are much more questions, but this should give a start to get > in contact with somebody that can help me on this. Hi Roland, the changes on the bug tracker are only read by few people (like me). As this is not a bug or feature request (yet), please bring your question up on the mailing list, where you will reach a much wider audience. https://koha-community.org/support/koha-mailing-lists/ Koha general list or koha-dev for more technical topics. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14319 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14319] Support for DuoSecurity 2FA Authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20476 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #62 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #58) > Moving authorized values to new table: > SUBSTR(authorised_value, 1, 64) > This may be a source of trouble, at least theoretically. Why not switch from > the 64 to 80 chars? > > `accounttype` varchar(80) default NULL, > `debit_type_code` varchar(64) default NULL, > `payment_type` varchar(80) default NULL, -- optional authorised value > PAYMENT_TYPE > This looks a bit inconsistent too? > > Why not give the table an autoincrement id as PK and do not duplicate the > code everywhere? Accountlines could be large, less space? I stuck to codes here to continue the pattern for simple reporting and also to allow for simple translations of the core system defaults where a code is significantly simpler to remember for translators. (Discussed with Katrin at hackfest regarding the translation comment, she was very pleased that we could keep the existing translations in the form of the include files). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23801] Connectivity with other systems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23801 roland.vandervel...@bruynzeel.org changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #2 from roland.vandervel...@bruynzeel.org --- Thanks for your help! Appreciate it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #63 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #59) > FAIL Koha/Account/DebitType.pm >OK critic >OK forbidden patterns >OK git manipulation >OK pod >OK pod coverage >SKIP spelling >FAIL valid > Inconsistent hierarchy during C3 merge of class > 'Koha::Account::DebitType': > Koha::Account::DebitType, > current merge results [ > ] > merging failed on 'Koha::Object' > > FAIL Koha/Account/DebitTypes.pm >OK critic >OK forbidden patterns >OK git manipulation >OK pod >FAIL pod coverage > POD is missing for 'object_class' >SKIP spelling >OK valid > > Not sure what exactly triggered the first one. The first one is the use of Koha::Objects::Limit::Library as a base class. Tomas has been looking into how to quiet this warning as we believe it's just noise at the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #64 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #61) > This is a quite fundamental one: > > UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL > WHERE accounttype IN (SELECT code from account_debit_types) > > Hmm. I do not really like this at first glance (and second too ;). I would > prefer one account type and not a separate debit code. If I would be > scrolling through account lines, I think it is weird to have to look at two > columns to determine the type of this transaction. Actually, as it currently stands you already have to look at two columns to ascertain whether the accountline is a debit or credit, so having these two fields next to each other is clearer in my opinion. I would like to rename accounttype to credit_type but didn't want to do that here and make the bug even bigger. > But might understand this choice from the perspective to keep this patch set > a bit smaller and narrow it down to the old MANUAL_INV stuff. Correct, I was trying to make this patch a bit more manageable. Bug 17702 became inpenetrably large by doing it all in one hit. > > So, my problem actually goes a bit beyond this report too and is also about > the design of accounts. We should have added an accounts type table in the > first place. Now we are doing it for a subset of our account types. And I am > wondering if this step will bring us closer to that goal of integrating > these types or will just hinder us along the way. I am inclined to think > that we should not separate the two now. > And I understand that this creates new problems. The account types would be > partially controlled by the debit codes list. So we could not (yet) put a FK > on it. But it might be a better starting point for controlling the other > account types? The aim was to have a similar treatment for credit_types in a second bug.. although presently I see no use case for user-definable credit_types at this time. I strongly believe one of the major strengths of this bug is that we're introducing better DB design including FK constraints. One cannot point a single field at multiple tables for such constraints at this time and I don't believe there is any plan for such support in SQL. > > Since this is an important design choice, I would suggest to discuss this on > the dev list or within the QA team, or dev meeting? We need some more > consensus on that decision. I'm happy to attempt something else if you can come up with any suggestions, but I don't really want this to go back to discussion again (this is just a reimplementation of bug 17702 which I believe has already been discussed). I've already saught support for this from those most closely in touch with accounts and thats how I arrived at this design (Tomas, Kyle, Josef). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #8 from Séverine Queune --- Hi Marcel, I know I used a Biblibre's sandbox in Unimarc, but I can't remember if it was http://pro.es5-koha.sandbox.biblibre.eu (login with test/test) which uses ES5 or http://pro.es6-koha.sandbox.biblibre.eu with ES6. I tried with several title and everything worked fine, except for the title "Mademoiselle liberté" with this little issue. This is something quite usual with some letter with diacritics in French (see for example bug 23542), so as I said, I'm not sure it comes from the patch, nor if the patch could solve this problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23802] New: In intranet Renew tab does not work properly in main search box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23802 Bug ID: 23802 Summary: In intranet Renew tab does not work properly in main search box Change sponsored?: --- Product: Koha Version: 19.05 Hardware: Other OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: moz...@tedankara.k12.tr QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 93988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93988&action=edit Screenshot of bug When we try to renew item from search panel in intranet, system automatically set return date as today. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93960|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23802] In intranet Renew tab does not work properly in main search box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23802 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi, I think this is a possible duplicate of bug 23551. *** This bug has been marked as a duplicate of bug 23551 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93961|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer changed: What|Removed |Added CC||moz...@tedankara.k12.tr --- Comment #10 from Katrin Fischer --- *** Bug 23802 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93962|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93963|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93964|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93965|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93966|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93969|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93967|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93970|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93968|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93973|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93974|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93972|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93975|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93976|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93977|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93979|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93978|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #65 from Martin Renvoize --- Created attachment 93989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93989&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #67 from Martin Renvoize --- Created attachment 93991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93991&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #66 from Martin Renvoize --- Created attachment 93990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93990&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #68 from Martin Renvoize --- Created attachment 93992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93992&action=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #69 from Martin Renvoize --- Created attachment 93993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93993&action=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #70 from Martin Renvoize --- Created attachment 93994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93994&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #71 from Martin Renvoize --- Created attachment 93995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93995&action=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #72 from Martin Renvoize --- Created attachment 93996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93996&action=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE Capitalise reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #74 from Martin Renvoize --- Created attachment 93998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93998&action=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23327] Optionally add column headings to emailed reports generated by the runreport.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23327 SiobhanC changed: What|Removed |Added CC||siobhancot...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #75 from Martin Renvoize --- Created attachment 93999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93999&action=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #73 from Martin Renvoize --- Created attachment 93997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93997&action=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #77 from Martin Renvoize --- Created attachment 94001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94001&action=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #78 from Martin Renvoize --- Created attachment 94002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94002&action=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #80 from Martin Renvoize --- Created attachment 94004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94004&action=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #76 from Martin Renvoize --- Created attachment 94000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94000&action=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #79 from Martin Renvoize --- Created attachment 94003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94003&action=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #83 from Martin Renvoize --- Created attachment 94007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94007&action=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #84 from Martin Renvoize --- Created attachment 94008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94008&action=edit Bug 23064: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #81 from Martin Renvoize --- Created attachment 94005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94005&action=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #82 from Martin Renvoize --- Created attachment 94006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94006&action=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23803] New: Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Bug ID: 23803 Summary: Add Font Awesome icon to cart in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: claire_grav...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The cart icon should be a font awesome icon to match the other icons used in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23803] Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Claire Gravely changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |claire_grav...@hotmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23803] Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 --- Comment #1 from Claire Gravely --- Created attachment 94009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94009&action=edit Bug 23803: Add Font Awesome icon to cart in staff interface This patch adds the font awesome icon to the cart in the staff interface. To test: 1. Apply patch and run yarn build (see: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 2. Check that the old cart icon no longer displays and the new font awesome icon is positioned correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23803] Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Claire Gravely changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23803] Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Owen Leonard changed: What|Removed |Added Attachment #94009|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 94010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94010&action=edit Bug 23803: Add Font Awesome icon to cart in staff interface This patch adds the font awesome icon to the cart in the staff interface. To test: 1. Apply patch and run yarn build (see: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 2. Check that the old cart icon no longer displays and the new font awesome icon is positioned correctly Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23803] Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23772] Itemtype icons not showing in table and not checked when editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 --- Comment #3 from Martin Renvoize --- Created attachment 94011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94011&action=edit Bug 23772: Revert to passing itemtype objects to the template This patch restores the methodology prior to bug 23602 of passing the full Koha::ItemType objects to the template and thus giving us the ability to use all the methods present within them. Test plan: 1) Ensure you have at least one itemtype with an assigned icon and the images enabled. 2) View the itemtypes admin page and note the icons display again 3) Ensure you have at least one itemtype with library limitations defined. 4) View the itemtypes admin page and note the library limitations still display. 5) Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23803] Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23803] Add Font Awesome icon to cart in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23803 Nick Clemens changed: What|Removed |Added Attachment #94010|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 94012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94012&action=edit Bug 23803: Add Font Awesome icon to cart in staff interface This patch adds the font awesome icon to the cart in the staff interface. To test: 1. Apply patch and run yarn build (see: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 2. Check that the old cart icon no longer displays and the new font awesome icon is positioned correctly Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23804] New: Itemtype not checked when editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Bug ID: 23804 Summary: Itemtype not checked when editing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: agustinmoy...@theke.io, gmcha...@gmail.com, katrin.fisc...@bsz-bw.de, koha-bugs@lists.koha-community.org, n...@bywatersolutions.com, testo...@bugs.koha-community.org Depends on: 23772, 20216, 23602 +++ This bug was initially created as a clone of Bug #23772 +++ When looking at the new datatable for itemtypes, the itemtype icons are no longer displayed. The same happens, when editing an itemtype - the icon is no longer 'checked'. When you take a look at the db, the file names are there. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 [Bug 20216] Editing itemtypes does not pull existing values correctly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 [Bug 23602] Library limitations should display in the item types table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 [Bug 23772] Itemtype icons not showing in table and not checked when editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing values correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 Martin Renvoize changed: What|Removed |Added Blocks||23804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 [Bug 23804] Itemtype not checked when editing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23772] Itemtype icons not showing in table and not checked when editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Martin Renvoize changed: What|Removed |Added Blocks||23804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 [Bug 23804] Itemtype not checked when editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize changed: What|Removed |Added Blocks||23804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 [Bug 23804] Itemtype not checked when editing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/