[Koha-bugs] [Bug 25411] Plugin routes cannot have annonymous access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #104968|0 |1 is obsolete|| --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 104978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104978=edit Bug 25411: Regression tests This patch adds tests the new RESTPublicAnonymousRequests syspref doesn't apply to routes added by plugins. It is up to the plugin developer to handle those conditions. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t => FAIL: Notice the tests fail Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25483] Url item field no longer accepts html tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25483 --- Comment #10 from Marcel de Rooy --- Apart from that, I think we should not allow html in a field called uri. A uri is what it is. And it is not html. We can render it as an html link and that would fail if we put html in this field. So the question should probably be: Where do you expect this uri to be presented as a link while it does not? The reference to bug 23194 is about public notes, a field with completely different content. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25483] Url item field no longer accepts html tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25483 --- Comment #12 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #11) > I think the issue here is not that you don't want it to appear as link some > cases or that it doesn't, but that we have no way to configure a link text > (see comment#5) or shorten very long URLs. Which you could say, is actually a limitation of the MARC standard. Since our 952$u comes from 852$u. MARC does not allow you to define link text here. The solution too provide a generic text (as in 856$u) is imo rather poor. Especially when we add multiple URIs in one field. What you could do, is: add an item field urllinktext and provide a way to enter that field in the item editor somehow. It would live in items and not in MARC. But it could be used whenever we want to render an item URI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509 --- Comment #2 from David Cook --- Looking back at 97232eee15e, the original "koha" package by Lars had "libjs-jquery", "tinymce2", and "libjs-yui". You can see there that he was overriding the bundled jquery, tinymce, and yui with the Debian package versions. But we don't do that anymore. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #133 from Marcel de Rooy --- -$periodicity, $firstacquidate, $irregularity, $numberpattern, $locale, -$numberlength, $weeklength, $monthlength, $lastvalue1, $innerloop1, -$lastvalue2, $innerloop2, $lastvalue3, $innerloop3, $status, -$biblionumber, $callnumber, $notes, $letter, $manualhistory, -$internalnotes, $serialsadditems, $staffdisplaycount, $opacdisplaycount, -$graceperiod, $location, $enddate, $subscriptionid, $skip_serialseq, -$itemtype, $previousitemtype, $mana_id +$periodicity, $firstacquidate, $irregularity, $permanent_irregularity, +$numberpattern, $locale, $numberlength, $weeklength, $monthlength, +$lastvalue1, $innerloop1, $lastvalue2, $innerloop2, $lastvalue3, +$innerloop3, $status, $biblionumber, $callnumber, $notes, $letter, +$manualhistory, $internalnotes, $serialsadditems, $staffdisplaycount, +$opacdisplaycount, $graceperiod, $location, $enddate, $subscriptionid, +$skip_serialseq, $itemtype, $previousitemtype, $mana_id Doing things like this does not life make easier for QA. Do I now have to check if every parameter is still there? You could have added the permanent_irregularity without touching all the other lines. And you can still fix it too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #134 from Marcel de Rooy --- Same remark for this: -librarian => $auser, -branchcode=> $branchcode, -aqbooksellerid=> $aqbooksellerid, -cost => $cost, -aqbudgetid=> $aqbudgetid, -biblionumber => $biblionumber, -startdate => $startdate, -periodicity => $periodicity, -numberlength => $numberlength, -weeklength=> $weeklength, -monthlength => $monthlength, -lastvalue1=> $lastvalue1, -innerloop1=> $innerloop1, -lastvalue2=> $lastvalue2, -innerloop2=> $innerloop2, -lastvalue3=> $lastvalue3, -innerloop3=> $innerloop3, -status=> $status, -notes => $notes, -letter=> $letter, -firstacquidate=> $firstacquidate, -irregularity => $irregularity, -numberpattern => $numberpattern, -locale=> $locale, -callnumber=> $callnumber, -manualhistory => $manualhistory, -internalnotes => $internalnotes, -serialsadditems => $serialsadditems, -staffdisplaycount => $staffdisplaycount, -opacdisplaycount => $opacdisplaycount, -graceperiod => $graceperiod, -location => $location, -enddate => $enddate, -skip_serialseq=> $skip_serialseq, -itemtype => $itemtype, -previousitemtype => $previousitemtype, -mana_id => $mana_id, +librarian => $auser, +branchcode => $branchcode, +aqbooksellerid => $aqbooksellerid, +cost=> $cost, +aqbudgetid => $aqbudgetid, +biblionumber=> $biblionumber, +startdate => $startdate, +periodicity => $periodicity, +numberlength=> $numberlength, etc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #482 from Aleisha Amohia --- == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104910|0 |1 is obsolete|| --- Comment #481 from Aleisha Amohia --- Created attachment 104920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104920=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Katrin Fischer changed: What|Removed |Added Blocks||25508 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 [Bug 25508] Confusing renewal message when paying accruing fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25483] Url item field no longer accepts html tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25483 --- Comment #9 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #8) > I've tested in 17.11 and it works, but only 'by accident' because the > browser ignores the very invalid HTML it creates: > > Link to > the resource"> href='https://cve-grics-ca.proxy.collanaud.qc.ca/fr/1133/33191'>Link to the > resource > > The change on master is: > > href="%3Ca%20href='https://cve-grics-ca.proxy.collanaud.qc.ca/fr/1133/ > 33191'%3ELink%20to%20the%20resource%3C/a%3E">Link to resource > > We are now escaping the content entered in $u. > > I feel we need a better, different way than adding HTML to this field to be > able to specify a link text. Is there a separator we could use? > > url | linktext ? The one character you should absolutely NOT use is the pipe ! In item fields the pipe is the split character for repeatable subfields and this field is repeatable too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25483] Url item field no longer accepts html tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25483 --- Comment #11 from Katrin Fischer --- I think the other bug is relevant in that the 'fix' here would be to remove the filter again, but we'd still end up with wrong HTML and that is not a good solution, especially since not all browsers might be so lenient in parsing it. It was not intended to carry HTML. Good point about the |. My general feeling is that markup should be avoided whenever possible in favor of structured data entry. Make entry easy as possible and use the software to do the formatting. I think the issue here is not that you don't want it to appear as link some cases or that it doesn't, but that we have no way to configure a link text (see comment#5) or shorten very long URLs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104909|0 |1 is obsolete|| --- Comment #480 from Aleisha Amohia --- Created attachment 104919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104919=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104907|0 |1 is obsolete|| --- Comment #478 from Aleisha Amohia --- Created attachment 104917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104917=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104906|0 |1 is obsolete|| --- Comment #477 from Aleisha Amohia --- Created attachment 104916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104916=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Katrin Fischer changed: What|Removed |Added Depends on||23051 --- Comment #1 from Katrin Fischer --- Adding the original bug introducing the feature in depends on - this will also help to get the developers and original testers informed :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104905|0 |1 is obsolete|| --- Comment #476 from Aleisha Amohia --- Created attachment 104915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104915=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104903|0 |1 is obsolete|| --- Comment #474 from Aleisha Amohia --- Created attachment 104913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104913=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104904|0 |1 is obsolete|| --- Comment #475 from Aleisha Amohia --- Created attachment 104914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104914=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104908|0 |1 is obsolete|| --- Comment #479 from Aleisha Amohia --- Created attachment 104918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104918=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #132 from Marcel de Rooy --- FAIL installer/data/mysql/atomicupdate/Bug_17656-add-permanent-irregularities.sql FAIL git manipulation The file has been added and deleted in the same patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #135 from Marcel de Rooy ---
+=head2 GessEnddate
+
+my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength,
$weeklength, $monthlength);
+
+=cut
+
+sub GuessEnddate {
The routine name should obviously be the same in POD and code.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #13 from David Cook --- Ok when I removed everything tiny_mce related from debian/rules, it installed the bundled tinymce overtop of /usr/share/tinymce/www through the existing symlink for my already existing Koha installation. Yikes. I should've tested with Kyle's original patch, but it's overtime on Friday night, so will have to leave that to someone else, or I can revisit on Monday... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25473] Can't add order from MARC file, save button does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #5 from Katrin Fischer --- > > Item information tab: Cataloging plugins for fields like > date acquired, barcode > > - date acquired ok > - barcode: nothing happens, no error. Does it depends on other data/config? This one depends on the AutoBarcode system preference. You possible need to activate the feature first - it's off by default. > > Default accounting details tab: Show inactive control > > I couldn't find how to make a fund inactive ^^" Go to: Acquisition > Budets Edit the budget to set it not active (first checkbox, not the locked one) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Large patch Priority|P3 |P1 - high Text to go in the|This new feature introduces |This new feature introduces release notes|the ability for borrowers |the ability for borrowers |to place a recall on an |to place a recall on an |item from the OPAC detail. |item from the OPAC detail. |Borrowers can see details |Borrowers can see details |of their requested recalls |of their requested recalls |in the OPAC and can cancel |in the OPAC and can cancel |the recall before it is |the recall before it is |returned. |returned. | | |Librarians can |Librarians can |view and administer the |view and administer the |recalls in the Circulation |recalls in the Circulation |interface of the staff |interface of the staff |client which displays a |client which displays a |list of recalls, overdue|list of recalls, overdue |recalls and recalls |recalls, recalls awaiting |awaiting pickup. |pickup, recalls to pull, | |and old recalls. |The | |amount of time the recalled |The |item has to be returned and |amount of time the recalled |the amount of time it will |item has to be returned and |wait for pickup can be set |the amount of time it will |in circulation and fine |wait for pickup can be set |rules in the unit of hours |in circulation and fine |or days. |rules in the unit of days. | | |After an item is|After an item is recalled |recalled it cannot be |it cannot be renewed. When |renewed. When the item is |the item is returned the |returned the recall can be |recall can be confirmed or |confirmed or cancelled. |cancelled. || |Recalls are marked as |Recalls are |overdue by the |marked as overdue by the |overdue_notices.pl cronjob. |overdue_recalls.pl cronjob ||or expired by the ||expired_recalls.pl cronjob. Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy changed: What|Removed |Added Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #131 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #12 from David Cook --- I think this one needs more testing, but on my initial tests it doesn't work when upgrading Koha. I imagine it would work for installing Koha initially though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #136 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #135)
> +=head2 GessEnddate
> +
> +my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength,
> $weeklength, $monthlength);
> +
> +=cut
> +
> +sub GuessEnddate {
>
> The routine name should obviously be the same in POD and code.
Seeing a correction now. Reason for some squashing ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24854] Remove IDreamBooks integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 --- Comment #13 from Jonathan Druart --- Maybe we should just turn it off and display a message during the upgrade process? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for the z39.50 server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Jonathan Druart changed: What|Removed |Added Blocks||25510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Depends on||24905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 [Bug 24905] log4perl-site.conf.in missing entries for the z39.50 server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #138 from Marcel de Rooy ---
+my $subscription_o =
Koha::Subscriptions->find($subscription->{subscriptionid});
+my @irreg = $subscription_o->irregularities;
+is($irreg[0], 2, 'First element of irregularities is 2');
+is($irreg[1], 4, 'Second element of irregularities is 4');
+is($irreg[2], 7, 'Third element of irregularities is 7');
+
+my @permanent_irreg = $subscription_o->permanent_irregularities;
+is($permanent_irreg[0], 1, 'First element of permanent_irregularities is 1');
+is($permanent_irreg[1], 2, 'Second element of permanent_irregularities is 2');
Do we really need this?
You add a separate script here to test if split /;/ works ?
I appreciate your willingness to test, but I have the impression that we should
focus here on complex exceptions with various frequencies, different months,
leap years, etc. Think of various date peculiarities.
Elaborating on that, t/db_dependent/Koha/Subscription/Irregularities.t contains
a lot of code, but actually only one test.
+ is($irregularities, '10;11', 'Irregularities have been updated');
Since this looks like the most important test, I would really expect more
testing here. Maybe you should think of some intelligent mocks here to reduce a
lot of building calls?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25480] koha-create may hide useful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25480 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25468] Preserve line breaks in hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25480] koha-create may hide useful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25480 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 --- Comment #7 from Jonathan Druart --- It means that the improvement speed bug 24700 was supposed to bring, never actually worked? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 Jonathan Druart changed: What|Removed |Added Depends on||24700 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 [Bug 24700] Improve Mojo startup speed for REST APIs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284 --- Comment #10 from Jonathan Druart --- Any news from this, Tomasito? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25278] Search fields cache must be separate for different indexes under Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25278 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart --- Nick, 4 occurrences, please move that to a method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #137 from Marcel de Rooy ---
You add a routine to DateUtils called issue_number:
+my $week_number = issue_number('2017-01-01', 'week');
What you actually want is a day-of-week, week number or month.
The name is confusing. I do not expect an issue_number in DateUtils.
The POD is wrong since you expect a dt and raise an exception on a string.
+ return Day_of_Week(split /-/, $date->ymd);
Please consider using a DateTime function here:
$dt->day_of_week()
$dt->wday() and $dt->dow().
$dt->local_day_of_week()
Actually $dt->dow is shorter than issue_number($dt, 'week')
+ return $date->month;
In this case it is more work to call issue_number($dt, 'month') than to say
$dt->month.
+my $dow = issue_number( dt_from_string($date), $frequency->unit );
This is a bit confusing. If we do not know the unit, how could we save it into
dow (day of week) ? Rename ?
I recommend to remove issue_number from DateUtils. We could move it to Serials?
It is a thin wrapper to three DateTime methods. If you want to keep it in
DateUtils, we should come up with a convincing name.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #182 from Ere Maijala --- Thanks Josef, I'll address your comments when I'm done rebasing. It proved to be a bit more work than before since the MARC 21 default framework was changed to YAML. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #4 from Jonathan Druart --- Created attachment 104921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104921=edit Bug 25510: Fix syntax error in koha-common.postinst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510
--- Comment #3 from Jonathan Druart
---
If I execute:
log4perl_component()
{
local config=$1
local component=$2
if [ grep -q -x "log4perl.logger.$component" $config ]; then
return 0
else
return 1
fi
}
for site in $(koha-list); do
log4perl_config="/etc/koha/sites/$site/log4perl.conf"
if ! log4perl_component $log4perl_config "sip"; then
echo $site
fi
done
I get
xxx.pl: line 67: [: too many arguments
Looks like we need another change
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Blocks||25510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Depends on||15253, 25032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 [Bug 15253] Add Koha::Logger based logging for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25468] Preserve line breaks in hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25468] Preserve line breaks in hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Marcel de Rooy changed: What|Removed |Added Attachment #104854|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 104923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104923=edit Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #15 from Katrin Fischer --- Thx for all the work here everyone. Just a thought: Why not keep it simple for now? We could keep the SQL files for any additional changes needed after the default installer files are loaded. At the moment it's very easy to customize the installer, as you just need to add your own directory (optional) and a text and sql file. If we could keep that ability at the same time, it would be a nice benefit. I have to admit, we run some changes on the frameworks and other standard settings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25468] Preserve line breaks in hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25416] Add information about anonymous session for XSLT use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25416 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 --- Comment #31 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25416] Add information about anonymous session for XSLT use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25416 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
--- Comment #181 from Josef Moravec ---
Comment on attachment 99235
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99235
Bug 20447: MARC Holdings support
Review of attachment 99235:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20447=99235)
-
Hi Ere, I read through the code and have some notes/questions
Overall, I think it's great enhancement and I really like this to be part of
Koha.
::: C4/Search.pm
@@ +2242,5 @@
> }
>
> +# Fetch summary holdings
> +if (C4::Context->preference('SummaryHoldings')) {
> +$summary_holdings = Koha::Holdings->search({ biblionumber =>
> $oldbiblio->{biblionumber}, deleted_on => undef });
Maybe something like $biblio->holdings?
::: Koha/Biblio.pm
@@ +520,5 @@
> +
> +sub holdings {
> +my ($self) = @_;
> +
> +$self->{_holdings} ||= Koha::Holdings->search( { biblionumber =>
> $self->biblionumber } );
use relation and new_from_dbic?
::: Koha/Holding.pm
@@ +23,5 @@
> +use Carp;
> +
> +use C4::Charset;
> +use C4::Log;
> +
are all imports needed?
@@ +138,5 @@
> +
> +return
> +wantarray
> +? Koha::Items->_new_from_dbic($items_rs)->as_list
> +: Koha::Items->_new_from_dbic($items_rs);
do we really need this duality?
@@ +166,5 @@
> +my $guard = C4::Context->dbh->{AutoCommit} ? $schema->txn_scope_guard()
> : undef;
> +
> +my $result = $self->SUPER::store();
> +
> +return $result unless $result;
Should it be just 'return unless $result'?
::: Koha/Holdings.pm
@@ +25,5 @@
> +use C4::Biblio;
> +use C4::Charset;
> +use C4::Context;
> +use Koha::Database;
> +use Koha::Holding;
Are all imports needed?
::: Koha/Holdings/Metadata.pm
@@ +34,5 @@
> +=cut
> +
> +=head3 record
> +
> +my @record = $metadata->record($params);
there are no params handled in method 'record'
::: catalogue/detail.pl
@@ +432,3 @@
> C4::Search::enabled_staff_search_views,
> +materials => $materials_flag,
> +show_summary_holdings => C4::Context->preference('SummaryHoldings') ? 1
> : 0,
You could use template plugin for getting value of a syspref and then you don't
need to pass this variable to template
::: cataloguing/addholding.pl
@@ +151,5 @@
> +=cut
> +
> +sub CreateKey {
> +return int(rand(100));
> +}
Maybe Koha::Token would be better to use instead of this sub, but could be
leaved to other bug report, as this pattern is in more files now.
::: cataloguing/value_builder/marc21_field_008_holdings.pl
@@ +22,5 @@
> +use C4::Auth;
> +use CGI qw ( -utf8 );
> +use C4::Context;
> +
> +use C4::Search;
Do you need C4::Search ?
@@ +39,5 @@
> +my $function_name = $params->{id};
> +my $dateentered = date_entered();
> +my $res = "
>
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|enhancement |critical Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #2 from Jonathan Druart --- So Koha install is broken using the Debian package? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Attachment #104912|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Comment on attachment 104912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104912 Bug 25510: Fix shell syntax for updating log4perl.conf for instances This patch is not sufficient for master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 Jonathan Druart changed: What|Removed |Added Blocks||25510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Assignee|dc...@prosentient.com.au|jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #139 from Marcel de Rooy --- Since we already got into string freeze, I leave it for now. Please resubmit your work in some squashed way. Perhaps divide the module changes, tests, script and template changes, and db revisions over separate patches. Thanks ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25481] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481 --- Comment #9 from Jonathan Druart --- Erk, I attached the wrong patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25481] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481 Jonathan Druart changed: What|Removed |Added Attachment #104887|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 104922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104922=edit Bug 25481: Pass --user to start-stop-daemon when a pidfile is used Since D10, the behaviour of start-stop-daemon changed, see from its manual: """ Warning: using this match option with a world-writable pidfile or using it alone with a daemon that writes the pidfile as an unprivileged (non-root) user will be refused with an error (since version 1.19.3) as this is a security risk, because either any user can write to it, or if the daemon gets compromised, the contents of the pidfile cannot be trusted, and then a privileged runner (such as an init script executed as root) would end up acting on any system process. Using /dev/null is exempt from these checks. """ Test plan: koha-plack --restart kohadev should success with this patch. Without this patch you get: start-stop-daemon: matching only on non-root pidfile /var/run/koha/kohadev/plack.pid is insecure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25481] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25468] Preserve line breaks in hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- @RM: Touches a template but should not result in translation changes. Just a %s ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25483] Url item field no longer accepts html tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25483 --- Comment #13 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #12) > (In reply to Katrin Fischer from comment #11) > > I think the issue here is not that you don't want it to appear as link some > > cases or that it doesn't, but that we have no way to configure a link text > > (see comment#5) or shorten very long URLs. > > Which you could say, is actually a limitation of the MARC standard. Since > our 952$u comes from 852$u. MARC does not allow you to define link text here. > > The solution too provide a generic text (as in 856$u) is imo rather poor. > Especially when we add multiple URIs in one field. > > What you could do, is: add an item field urllinktext and provide a way to > enter that field in the item editor somehow. It would live in items and not > in MARC. But it could be used whenever we want to render an item URI. I think we go way beyond 852 in a lot of areas - which is also the problem: There are no more free subfields in Koha to use for this. And if you have repated $u you also get the issue of sequence. Btw - if we used MFHD (MARC for Holdings Data, we could have a full 856 there, so it's not really a limitation of the standard). The item editor is not made to resort the item subfields and I also feel like that would not be a good solution and more error prone / harder to handle for catalogers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24700] Improve Mojo startup speed for REST APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Jonathan Druart changed: What|Removed |Added Blocks||25504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 [Bug 25504] Wrong API spec breaks plack without meaningful error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy changed: What|Removed |Added Attachment #103886|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 104924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104924=edit Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin While adding the data from the existing field to the auth_finder URI, we're using encodeURI(), which is meant for an entire URI and thus doesn't escape &. Things that are going into a querystring need encodeURIComponent() instead. Test plan: 1. Enable the system preference EnableAdvancedCatalogingEditor 2. Clear your browser cache, even a shift+reload won't get you a fresh marc-editor.js for the advanced editor 3. Create a Topical Term authority with 150 $aThis & That$xStuff & Junk 4. In the Basic editor, use the authority plugin on the 650 field to select that authority. 5. Click the authority plugin again, verify that the popup contains This & That and Stuff & Junk rather than just This and Stuff 6. From the Cataloging home page choose Advanced editor 7. In a new line paste 650 _ _ ‡aThis & That‡xStuff & Junk 8. Type ctrl+shift+L and verify the popup shows both words in both fields 9. When you remember the plugin exists there too, edit your Stuff & Junk authority, and in a 550 tag type One & Two in $a and Three & Four in $x and click the plugin link, verify that the search window has your search terms not cut off. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled from record, content after & is cut off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Marcel de Rooy changed: What|Removed |Added Summary|When cataloguing search |When cataloguing search |fields are prefilled form |fields are prefilled from |record, content after & is |record, content after & is |cut off |cut off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled from record, content after & is cut off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled from record, content after & is cut off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Marcel de Rooy changed: What|Removed |Added Attachment #104240|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 104925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104925=edit Bug 25308: Escape querystring for Z39.50 popup from cataloging Test plan: 1. For bonus fun, Administration -> MARC Frameworks -> New framework, with the code A and description Ants & Bees 2. In the A Actions menu, choose MARC structure since Import won't work 3. Accept the offer to copy in structure from default 4. Cataloging -> New record -> Ants & Bees 5. Type This & That in the 245$a (and for extra credit, in 020$a, and create an author authority with an & in it so you can put it in the 100/110) 6. Click Z39.50/SRU search, make sure everything you typed is prefilled including the parts after & 7. Search for anything that will retrieve a record (the ISBN This & That probably won't), choose Import 8. Check that the record came back, and verify in the Settings menu that it's still in the Ants & Bees framework. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled from record, content after & is cut off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #7 from Marcel de Rooy --- We could indeed find some more bugs in this area. Just looking at e.g. git grep Z3950Terms. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 --- Comment #2 from Jonathan Druart --- 75 $t->get_ok( "//$userid:$password@/api/v1/items" ) 76 ->status_is( 200, 'SWAGGER3.2.2' ); This test is the slower when I run it locally, and You got "Inactivity timeout" when it failed. It there any kinds of timeout value we could extend? That would explain why it fails randomly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25511] New: Add --force option to update_dbix_class_files.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Bug ID: 25511 Summary: Add --force option to update_dbix_class_files.pl Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Sometimes, if you know what you are doing, you may want to force a schema overwrite regardless of whether the hashes report there are changes above the fold. In these cases, we should expose said functionality via a --force option on the script. WARNING: Use this at your own risk.. it's helpful if you are maintaining a fork or in other such cases. You should always attempt to run the script without force first and only resort to using force if that fails. It is also very much worthwhile checking the diff after running with force to ensure you have not resulted in any unexpected changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25511] Add --force option to update_dbix_class_files.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25511] Add --force option to update_dbix_class_files.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 --- Comment #1 from Martin Renvoize --- Created attachment 104926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104926=edit Bug 25511: Add --force option to update_dbix_class_files.pl This adds a --force option to the aforementioned script allowing those in the know to overwrite the schema when changes above the found are detected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- +$biblionumber = int($biblionumber); I think we have a few places where we do that. And it is really ugly imo. If you dont pass a valid biblionumber, you should not get a valid response. Furthermore int does not like strings. We will have warnings like: Argument "3abc" isn't numeric in int I would rather get rid of the other places.. Changing status: ID or FQA ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25511] Add --force option to update_dbix_class_files.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Ere Maijala changed: What|Removed |Added Attachment #104926|0 |1 is obsolete|| --- Comment #2 from Ere Maijala --- Created attachment 104927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104927=edit Bug 25511: Add --force option to update_dbix_class_files.pl This adds a --force option to the aforementioned script allowing those in the know to overwrite the schema when changes above the found are detected. Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25511] Add --force option to update_dbix_class_files.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Ere Maijala changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #7) > It means that the improvement speed bug 24700 was supposed to bring, never > actually worked? It means not in stretch. Unless you cpan some libs to buster version -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229
--- Comment #3 from Jonathan Druart
---
I do recreate the issue with running several time the tests:
for i in {1..6}; do timeout 60 prove -v t/db_dependent/api/v1/items.t& done
Make sure you have the timeout, or the whole thing will freeze!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Sally changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #5 from Sally --- This fails on step 3 - neither WYSIWYG or CodeMirror loads after applying the patch. Instead, it's a plain textbox rather than the numbered lines you see with CodeMirror. If you're editing an existing news item, the plain textbox contains HTML. When you check NewsToolEditor, it has defaulted to CodeMirror rather than staying as WYSIWYG after the patch has applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
