[Koha-bugs] [Bug 11403] renew page missing help file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11403] renew page missing help file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23847|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23854 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23854action=edit [PASSED QA] Bug 11403: Add missing help file to new Renew page This patch adds a help file to the Renew page found under Circulation. To test: * Go to Circulation Renew * Click the help link * Confirm text and manual link are correct. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #23849|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 23855
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23855action=edit
[PASSED QA] Bug 11188 - Make gather_print_notices.pl die on failed open()
Problem:
If you tell gather_print_notices.pl to write output to a location
you do not have write access to, it will silently fail to write the
data, but still mark unsent messages as sent.
Solution:
This patch adds two lines of defense:
1. Check that the location given for the output is writable
2. use open() or die instead of just open() when writing the
output
The first measure should catch most of the potential errors, but
I guess a directory can be writable, but the open() still can fail
because the disk is full or something similar.
To test:
- Make sure you have some unsent messages in the message_queue table,
that do not have an email adress
- Apply the patch
- Run the script, pointing at a location you do not have access to
write to. Check that the script exits with an appropriate error
message, and that the unsent messages are still unsent. Do this
both with and without the -s option.
- To fake passing the first line of defence, comment out line 62
and put this in instead:
if ( !$output_directory || !-d $output_directory ) {
- Run the script again as above, check you get an appropriate
error and that the message queue is not touched
- Reset line 62 to how it was
- Run the script against a directory you do have access to write to
and check that output is produced as expected and that messages
are marked as sent
- Sign off
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.
Works as described.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23850|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23856 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23856action=edit [PASSED QA] Bug 11075 - 'select all' export clears renew checkboxes If circulation exports are enabled (by turning on ExportWithCsvProfile), the table on the checkout page includes three columns of checkboxes -- 'renew', 'checkin', and 'export'. For each loan, the renew and checkout links should behave like radio buttons, but the state of the export checkbox is meant to be independent of the renew and checkin checkboxes. However, if the 'select all' link in the export column is clicked, active renew checkboxes are toggled off. The desired behavior is that clicking the select all link in the export column should only affect checkboxes in that column. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script - one line JavaScript change. Works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23848|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23857 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23857action=edit [PASSED QA] Bug 11402: Labels::_guide_box should return undef if undefned data is passed That's it. A guide box cannot be created if invalid data is passed. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script, includes new unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23840|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23858 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23858action=edit [PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). To test: 1/ go to authorities/authorities-home.pl 2/ search something by authtype personal name 3/ results are displayed with summary 4/ now select the default entry and search again the results display but without the summary 5/ apply the patch 6/ search default again, now summary shows Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tested with a UNIMARC database, works as described. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23851|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23859 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23859action=edit [PASSED QA] Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron-daemon' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de No entry in debian/control yet, but according to comments in the file this file is generated from control.in - so this should be ok. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #34 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23861 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23861action=edit [PASSED QA] Bug 10277: Add UT for C4::Context::IsSuperLibrarian Note that I modify the return value. Before this patch, it returned an empty string or 1. Now it returns 0 or 1. Test plan: - same as the original patch - verify that unit tests pass: prove t/Context.t Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script, including new tests. Checked the code and tested superlibrarian behaviour in some places: moremember.pl: With IndyBranches only superlibrarian can delete borrowers from other branches. Accessing the borrower with a direct link. OK C4/Members.pm With IndyBranches only superlibrarian can search for borrowres from other branches. OK tools/holidays.pl With IndyBranches only superlibrarian can edit holidays for other branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #23523|0 |1
is obsolete||
Attachment #23635|0 |1
is obsolete||
--- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 23860
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23860action=edit
[PASSED QA] Bug 10277 - Add C4::Context-IsSuperLibrarian()
The method of checking the logged in user for superlibrarian privileges
is obtuse ( $userenv $userenv-{flags} % 2 != 1 ) to say the least.
The codebase is littered with these lines, with no explanation given. It
would be much better if we had one subroutine that returned a boolean
value to tell us if the logged in user is a superlibrarian or not.
Test Plan:
1) Apply this patch
2) Verify superlibrarian behavior remains unchanged
Signed-off-by: Joel Sasse jsa...@plumcreeklibrary.net
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Comments on second patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I retested this and think I spotted a problem: Order: 2 orders Cancel one order, delete bibliographic record Item cound is correct, but biblio count doesn't show the cancelled biblio. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
--- Comment #36 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 23526
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23526
Bug 9303 [1/2] - relative's checkouts in the opac - Schema Updates
Review of attachment 23526:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9303attachment=23526)
-
Hi Kyle, starting with a code review:
::: Koha/Schema/Result/Borrower.pm
@@ -191,4 @@
=head2 dateofbirth
data_type: 'date'
- datetime_undef_if_invalid: 1
Can you explain why those lines have been removed by your patch? I know that
those files are generated automatically, but I have difficulty to see how those
changes are related to the canges done in kohastructure.sql.
@@ +1020,2 @@
+# Created by DBIx::Class::Schema::Loader v0.07000 @ 2013-11-07 08:15:21
I notice, that your version is a bit older than the one used before, could that
explain some of the differences?
::: installer/data/mysql/updatedatabase.pl
@@ +7826,5 @@
+$DBversion = 3.15.00.XXX;
+if(CheckVersion($DBversion)) {
+$dbh-do(q{
+ALTER TABLE borrowers ADD privacy_relative_checkouts BOOLEAN NOT
NULL DEFAULT '0'
I'd feel a bit better about this line and the next, if there was an
AFTER/BEFORE making sure that the sequence of rows is the same for old and new
installations.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #37 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 23527 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23527 Bug 9303 [2/2] - relative's checkouts in the opac Review of attachment 23527: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9303attachment=23527) - No major findings - mostly noting a few things: I think maybe it would be better to separate the Schema and kohastructure/updatedatabase changes into 2 separate patches. Also adding a new PK to issues and old_issues could have been a separate bug/patch. ::: C4/Reserves.pm @@ +270,5 @@ +$sth-execute($reserve_id); +$res = $sth-fetchrow_hashref(); +} + +carp(No hold for for reserve_id $reserve_id) unless $res; Hm, this change seems unrelated to the bug description? ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +1168,5 @@ +option value=1Yes/option +[% END %] +/select +div class=hintAllow linked patron accounts to view this patron's checkouts from the OPAC/div +/li This is different to how we handle the other privacy seetings in that we don't allow staff to change those for a patron. I see why staff will want to change that setting for a parent requesting it, but at the same time it bothers me a bit. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ +1,3 @@ [% USE Koha %] [% USE KohaDates %] +[% USE EncodeUTF8 %] The only script using this so far is renew.pl - can you explain a bit? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Ok, found a major problem: New PK for issues and old_issues: - Sequential numbering done by updatedatabase worked correctly in my test database. - Returning checked out items moves them correctly to old_issues, issue_id is kept. - Checking out a new item after the updates generates an issue_id that was already used in old_issues! In my database, afer update: old_issues - 1-18 issues - 19-20 - returned 19, 20 old_issues 1-20 issues empty - checked out 2 items old_issues 1-20 issues 3,4 Please consider splitting the introduction of a new PK into a separate bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Working on this now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 23831 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23831 Bug 11336: Priority is not updated on deleting holds Review of attachment 23831: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11336attachment=23831) - ::: C4/Reserves.pm @@ +252,4 @@ $res = GetReserve( $reserve_id ); +Return the current reserve or the old reserve. This POD change no longer applies - please fix in a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23831|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23862 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23862action=edit [PASSED QA] Bug 11336: Priority is not updated on deleting holds There are a lot of places where a hold deletion is possible. But I just found 1 place where it works! To reproduce: - select or create 2 users U1 and U2 - select or create an holdable item - place on hold for both U1 and U2. U1 has priority 1 and U2 has priority 2. - delete the hold for U1 - go on circ/circulation.pl?borrowernumber= for U2 (or in the DB directly) and verify the priority has not been set to 1 The issue is repeatable (at least) on these 2 pages: * circ/circulation.pl?borrowernumber= (tab 'Holds', select yes in the dropdown list and submit the form) * reserve/request.pl?biblionumber= (click on the red cross) Signed-off-by: Christopher Brannon cbran...@cdalibrary.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Reran my tests: Preparations: - Create holds for different patrons on a record: * 1st - title level hold * 2nd - item level hold * 3rd - title level hold * 4th - title level hold - AllowOnShelfHolds = On/Allow (items were not checked out) Tests: Deleted holds from various pages, confirming bugs first, then testing with applied patches. Reloading database after each test. 1) Cancel holds from OPAC patron account /cgi-bin/koha/opac-user.pl#opac-user-holds - Cancel 4th - ok, before and after applying the patch - Cancel 2nd - ok, after applying the patch 2) Cancel hold from holds tab on staff detail page /cgi-bin/koha/reserve/request.pl?biblionumber=7 a) Setting priority to 'del', submitting with 'Update holds' - Cancel first (1st) - ok, before and after - Cancel hold in the middle (was 3rd) - ok, before and after - Cancel last (was 4th) -ok, before and after b) Using red X - Repeating tests from a) - before the patch is applied holds get totally 'out of order' - after applying the patch, it works correctly Additional tests done on this page: - Change priority using up, down, to top, to bottom icons - Change priority with 'toggle to lowest' 3) Cancel hold from the patron's account a) Check out tab - Delete? Yes, 'Cancel marked holds' /cgi-bin/koha/circ/circulation.pl?borrowernumber=X - Cancel first (1st) - ok, after applying the patch - Cancel hold in the middle (was 3rd) - ok, after applying the patch - Cancel last (was 4th) - ok, after applying the patch b) Details tab - Delete? yes, 'Cancel marked holds' /cgi-bin/koha/members/moremember.pl?borrowernumber=X - Cancel first (1st) - ok, after applying the patch - Cancel hold in the middle (was 3rd) - ok, after applying the patch - Cancel last (was 4th) - ok, after applying the patch Without the patch, holds priorities get out of order. Additional tests done: - Check in one item to trigger first hold - Check in one item to trigger second hold - Check out first item Priorities are kept while the item is waiting, when it's checked out, priorities of remaining holds get reset correctly. Conclusion: Big improvement, no regressions found. Passes all tests in t, xt and QA script. Also: t/db_dependent/Holds.t t/db_dependent/HoldsQueue.t t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #29 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23863 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23863action=edit Bug 11336: Follow-up - fixing capitalization in templates Fixes capitalization on the holds and check in page. Changes are easy to spot using: git diff HEAD^ --color-words=. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10952] Store anonymous search history in session
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Ok, giving this another go... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10952] Store anonymous search history in session
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Tested again in Chromium and Bootstrap theme: - Logged out. - Closed browser. - Reopened browser. - Did 2 simple searches. - Logged in using the link on top. - Doubled up entries in search history. - Logged out. - Did another serach. - Logged back in. - Doubled up entries in search history. I can't pass this :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10429] branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10429] branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19748|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23864 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23864action=edit [PASSED QA] Bug 10429 - branch filter not working in serial claims In serial claims page, the branch code is displayed in table instead of branch name and branch filter does not work. This patch adds the display of branch name by using branches template plugin. It changes javascript branch filter to make it work. Also sets all filter in template (like status filter) to allow translation and sets all as selected by default. Librairian branch was selected by default, but the table was not filtered with it. Test plan : - Go to serials claim of a vendor with serials of multiple branches = You see branch filter with (All) and table shows libraries names - Check that branch filter does its work Signed-off-by: David Cook dc...@prosentient.com.au Works as described. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Table now shows the branch name instead of the branchcode. First option was named (All), matching the status pull down. When opening the claims page, (All) is preselected and the result list matches with the selection. Before the patch the library was preselected, but the result list did show late issues from all branches. This patch is an improvement, but there is still more work to do. - Filters are not cumulative, but when another filter is selected the first filter is not reset. - It's not possible to combine 2 or more filters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5441] SSO CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5441 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|katrin.fisc...@bsz-bw.de| Assignee|gmcha...@gmail.com |paul.poul...@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11048] Fix logout redirection for CAS authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11048] Fix logout redirection for CAS authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23768|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23865 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23865action=edit [PASSED QA] Bug 11048: Fix logout redirection for CAS authentication The logout redirection function after a CAS authentication was misused. This patch fixes it, and allows the CAS server to redirect the user back to the opac after logout. Signed-off-by: Chris Cormack chr...@catalyst.net.nz From the Authen::Cas::Client documentation logout_url [%args] logout_url() returns the CAS server's logout URL which can be used to redirect users to end authenticated sessions. %args may contain the following optional parameter: * url = $url If present, the CAS server will present the user with a link to the given URL once the user has logged out. Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Change only affects CAS authentication and is correct according to the module documentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10277 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7002 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Patch currently doesn't apply. I tried applying it directly on master and on top of bug 10277: Signed-off-by: Joel Sasse jsa...@plumcreeklibrary.net -- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 10276 - Extend IndependentBranches to support groups of libraries fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10276 - Extend IndependentBranches to support groups of libraries The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem, run git am --resolved. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
--- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 23641
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23641
Bug 10276 - Extend IndependentBranches to support groups of libraries
Review of attachment 23641:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10276attachment=23641)
-
Patch doesn't apply, but doing a quick code review:
1) Commit message could be updated, dependencies noted are resolved and example
is slightly wrong (should be group 1 and 3).
2) Patch touches a lot of routines in different modules, but none of this is
backed up by unit tests.
This is a big feature with a lot of possible consequences if we break
something, I think unit tests
are a requirement, at least for the new routine. (UT)
3) Patch has bug 10277 notes as dependency, but is not using the new function
consequently (C4::Context-IsSuperLibrarian())
4) Patch seems to remove 'properties' from the interface. Currently libraries
can add properties library groups.
I think we need to discuss this before removing the feature. Also we need to
think about databases with property groups
defined and how to migrate them. Or keep the option. (properties)
::: C4/Branch.pm
@@ +43,4 @@
GetBranchCategories
GetBranchesInCategory
ModBranchCategoryInfo
+GetIndependentGroupModificationRights
UT
@@ +376,4 @@
#TODO manage category types. rename possibly to 'agency domains' ? as
borrowergroups are called categories.
sub GetCategoryTypes {
+ return ( 'searchdomain','independent_groups');
properties
@@ +446,5 @@
+
+If 'branch' is not provided, it will be looked up via
+C4::Context-userenv-{branch}.
+
+If 'for' is provided, the lookup is limited to that branch.
Could you explain the behaviour/use of 'for' a bit more?
@@ +452,5 @@
+If called in a list context, returns a list of
+branchcodes ( including $this_branch ).
+
+If called in a scalar context, it returns
+a count of matching branchcodes. Returns 1 if
...? :)
::: C4/Serials.pm
@@ +238,5 @@
+ subscription.subscriptionid as subsid
+|;
+if ( C4::Context-preference('IndependentBranches')
+ C4::Context-userenv
+ C4::Context-userenv-{'flags'} % 2 != 1
C4::Context-IsSuperLibrarian()
@@ +355,5 @@
+|;
+
+if ( C4::Context-preference('IndependentBranches')
+ C4::Context-userenv
+ C4::Context-userenv-{'flags'} % 2 != 1
C4::Context-IsSuperLibrarian()
@@ +413,5 @@
+|;
+
+if ( C4::Context-preference('IndependentBranches')
+ C4::Context-userenv
+ C4::Context-userenv-{'flags'} % 2 != 1
C4::Context-IsSuperLibrarian()
@@ +594,5 @@
+|;
+
+if ( C4::Context-preference('IndependentBranches')
+ C4::Context-userenv
+ C4::Context-userenv-{'flags'} != 1
C4::Context-IsSuperLibrarian()
::: catalogue/moredetail.pl
@@ +177,3 @@
my $userenv = C4::Context-userenv();
+unless (
+$userenv-{'flags'} % 2 != 1
C4::Context-IsSuperLibrarian()
::: cataloguing/additem.pl
@@ +702,4 @@
#verifying rights
my $userenv = C4::Context-userenv();
+unless (
+$userenv-{'flags'} % 2 == 1
C4::Context-IsSuperLibrarian()f
::: circ/circulation-home.pl
@@ +39,5 @@
$template-param( fast_cataloging = 1 ) if (defined $fa);
# Checking if the transfer page needs to be displayed
+$template-param( display_transfer = 1 )
+ if ( $flags-{'superlibrarian'} == 1
C4::Context-IsSuperLibrarian()
::: installer/data/mysql/kohastructure.sql
@@ +365,4 @@
`categorycode` varchar(10) NOT NULL default '', -- unique identifier for
the library/branch group
`categoryname` varchar(32), -- name of the library/branch group
`codedescription` mediumtext, -- longer description of the library/branch
group
+ `categorytype` ENUM( 'searchdomain', 'independent_group' ) NULL DEFAULT
NULL, -- says whether this is a search group or an independent group
properties
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9686] Sorting with independent branches returns results from all branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9686 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||k...@bywatersolutions.com --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Kyle, could you check this bug report? I am not sure I understand the problem described. We don't filter bibliographic searches yet I think, but you can't search for patrons in the OPAC... so I am confused. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, I found bug 7002 - it looks like there could be some more occurences to fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7002] Inaccurate checks for borrower flags == 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, I did a quick search and found some occurences of the problematic syntax in
the current code:
catalogue/moredetail.pl
178 unless (($userenv-{'flags'} == 1) or ($userenv-{'branch'} eq
$item-{'homebranch'})) {
cataloguing/additem.pl
695 unless (($userenv-{'flags'} == 1) or (($userenv-{'branch'} eq
$subfieldvalue))){
tools/batchMod.pl
498 unless
(($userenv-{'flags'} == 1) or (($userenv-{'branch'} eq $itembranchcode))){
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 23638 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23638 Bug 10278 - Add ability to hide items and records from search results for Independent Branches Review of attachment 23638: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10278attachment=23638) - Can't apply this patch, as the dependency doesn't apply, but starting with a code review: 1) We need some unit tests for the new routine GetCategoriesForBranch (UT). Also regression tests, additional tests, any tests for some of the other routines would be nice. Failed QA for the missing unit tests. ::: C4/Branch.pm @@ +42,4 @@ GetCategoryTypes GetBranchCategories GetBranchesInCategory +GetCategoriesForBranch UT ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref @@ +75,5 @@ + default: 0 + choices: + yes: Prevent + no: Don't prevent +- staff from seeing items owned by other libraries, and records without any items the library. I think there is a word missing in the last bit. I wonder a bit about the consequences - it will be required to always add at least one 'fake' item to every record, that you want to show up in the OPAC. Thinking about serials and electronic resources, but also set and traced serial record as used in Germany. ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt @@ +32,2 @@ strQuery += + [% z3950_search_param.name %] + = + [% z3950_search_param.encvalue %]; +*/ Why are you commenting this bit out? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263
--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 23639
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23639
Bug 10263 - Add ability to limit which branch can edit a bibliographic record
(IndependentBranchesMarcEditing)
Review of attachment 23639:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10263attachment=23639)
-
Doing some code review here too...
1) I think instead of using a new separate authorised value entry to have an
empty option, this could work like the item form. If you mark the subfield
mandatory, it will not offer an empty option. If it's not mandatory, it will.
But it looks like the rule does not apply to the cataloguing form yet, as 942$c
(itemtype) offers an
empty option and is mandatory. Hm.
2) HasIndependentGroupModificationRightsFor needs some unit tests and
documentation. Why is $self ignored?
Why not use GetIndependentGroupModificationRights( { for = $branchcode } );?
3) Spotted another 'old' superlibrarian permission check.
Failing for 2), 3) might be resolved by one of the other dependent patches.
::: C4/Auth.pm
@@ +197,3 @@
# to create the template's parameters that will indicate
# which menus the user can access.
if ( $flags $flags-{superlibrarian}==1 ) {
Old check for superlibrarian permission.
::: Koha/Template/Plugin/Koha.pm
@@ +44,4 @@
return C4::Context-preference( $pref );
}
+sub HasIndependentGroupModificationRightsFor {
POD, UT
::: admin/marc_subfields_structure.pl
@@ +133,4 @@
push @authorised_values, $category;
}
push( @authorised_values, branches );
+push( @authorised_values, branches_optional );
See 1) for an idea to handle this a bit differently.
::: installer/data/mysql/kohastructure.sql
@@ +127,4 @@
`timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update
CURRENT_TIMESTAMP, -- date and time this record was last touched
`datecreated` DATE NOT NULL, -- the date this record was added to Koha
`abstract` mediumtext, -- summary from the MARC record (520$a in MARC21)
+ `branchcode` VARCHAR( 10 ) NULL DEFAULT NULL, -- branchcode for the
opationl 'owner' of this record.
Small documentation typo.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10502] Add independent branches option for sql reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |BLOCKED CC||katrin.fisc...@bsz-bw.de --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Couldn't spot any problems reviewing the code :) I am marking this BLOCKED, because of the dependencies. As soon as those have moved forward, this can go back to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Robin, I am a bit worried about the dependency on bug 10611 as we were planning on adding some kind of Postgres support to 3.16. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #11 from Robin Sheat ro...@catalyst.net.nz --- (In reply to Katrin Fischer from comment #10) Hi Robin, I am a bit worried about the dependency on bug 10611 as we were planning on adding some kind of Postgres support to 3.16. It's not a hard depends, it's just that bug 10611 solves a problem that I identified that (significantly) improves performance. I think that we should apply that, and then work out how to make it work with pgsql, but that's a discussion for that bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3445] action_logs table needs some thought
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Not sure if that's too many indexes, but it works as expected :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3445] action_logs table needs some thought
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3445] action_logs table needs some thought
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23222|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23866 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23866action=edit [PASSED QA] Bug 3445 - action_logs table needs indexes This patch adds database indexes for action_logs table to speed up log viewer page. Removes the existing index on timestamp+user to add an indexe on each column since earch colums is separately defined in log viewer form. Test plan: - Update database - Play with log viewer : /cgi-bin/koha/tools/viewlog.pl - Perform searches with only one filter defined - Also check you see indexes with SQL query : SHOW CREATE TABLE action_logs Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr Signed-off-by: Katrin Fischer katrin.fischer...@web.de Rephrased the updatedatabase message a bit: Add indexes to action_logs table Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- So these patches can be tested without 10611 as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #13 from Robin Sheat ro...@catalyst.net.nz --- (In reply to Katrin Fischer from comment #12) So these patches can be tested without 10611 as well? Yep. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11457] New: t/db_dependent/Bookseller.t can fail when subscription table is not empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Bug ID: 11457 Summary: t/db_dependent/Bookseller.t can fail when subscription table is not empty Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: katrin.fisc...@bsz-bw.de QA Contact: gmcha...@gmail.com Tests 22 and 23 failed on my database because I had a few subscriptions in my database. After setting the subscription.enddate far into the future the tests passed again. ok 22 - search for subscriptions by expiration date ok 23 - search for subscriptions by expiration date Maybe cleaning the subscription table within the transaction before running the test would fix this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23826|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23867 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23867action=edit [SIGNED OFF] Bug 7965 : Silence warns in staff log Silence warns in C4::Bookseller to test 1/ run prove t/db_dependent/Bookseller.t Notice lots of Use of uninitialized value $delay in numeric lt () at /var/lib/jenkins/jobs/Koha_master/workspace/C4/Bookseller.pm line 134 type lines 2/ apply patch 3/ run prove t/db_dependent/Bookseller.t Notice warns are gone Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tiny change, positive consequences. Passes QA script and all tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7965] Silence warns in staff error log (koha-error_log)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7965 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11425] Search form for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9218] intranet cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2546] Description of charges: string hardcoded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11387 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11387] Hold waiting too long is untranslatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11387 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=2546 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #32 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, I reran the test, the result is the same: testing 4 commit(s) (applied to e815131 'Bug 10138: (follow-up) FIX sql errors') FAILmisc/sip_cli_emulator.pl OK pod OK forbidden patterns OK valid FAIL critic Subroutine prototypes used at line 115, column 1. See page 194 of PBP. Maybe someone else can test - did you check line 115? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Patches apply for me, for the second patch I think the subject should be a sponsor line :) (http://wiki.koha-community.org/wiki/Commit_messages#Sponsor_line) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #22007|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Blou, could you take a look and provide a follow-up for the bootstrap theme? It's the default theme now and we shouldn't add a new feature that doesn't work with it. Also, both patches seem almost identical - I am obsoleting the older patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11366] Acq basket group No group untranslatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|unspecified |master --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I can confirm this bug, the string is hardcoded into basket.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, could you take a look at Srdjan's comment? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11261] Sample frequencies and numbering patterns should better be mandatory on install
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11261 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||11309 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Depends on||11261 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11320] Ambiguous message when a duplicate record is detected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11320 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I have problems triggering the duplicate message on master right now. I tried matching title, biblio level itemtype and ISBN, but no success so far. Probably missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Failing QA to get attention for comment 26 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11458] New: Confusing description for syspref gist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11458 Bug ID: 11458 Summary: Confusing description for syspref gist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathsaby...@gmail.com QA Contact: testo...@bugs.koha-community.org The description of gist is: Default tax rates are .. (enter in numeric form, 0.12 for 12%. First is the default. If you want more than 1 value, please separate with |) The use of default is confusing here. It should be Authorized (Possible ?) tax rates are M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11459] New: OrderPdfFormat pref description could be more verbose
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Bug ID: 11459 Summary: OrderPdfFormat pref description could be more verbose Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathsaby...@gmail.com QA Contact: testo...@bugs.koha-community.org The description is: Use when printing basket groups. The list of possible templates should be precised. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11284] Package related updates for the new release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11284 --- Comment #7 from Robin Sheat ro...@catalyst.net.nz --- Thanks Fridolin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Samuel Crosby scrosby...@gmail.com changed: What|Removed |Added CC||scrosby...@gmail.com --- Comment #1 from Samuel Crosby scrosby...@gmail.com --- Created attachment 23868 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23868action=edit Proposed bug fix for 9654 Here we go, my first bug fix :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|NEW |Needs Signoff CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #23868|0 |1 is obsolete|| --- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 23869 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23869action=edit Bug 9654: Missing space between amount and currency symbol in basket group Formatting fix. To test 1) Create some orders, don't automatically add them to a basket group 2) Open a new basket group from the basket group page of the vendor 3) Check display of currencies for the orders shown 4/ Apply patch 5/ Recheck display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Working on I've never used basket groups before test plan, but this works as advertised. It even passes the qa test tool. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
However, I did further thinking, and there's a problem. :(
--- BEGIN SAMPLE CODE ---
#!/usr/bin/perl -Tw
my $val = undef;
my $total = 'q';
$total .= . ($val // 0);
print $total\n;
$total = 'q';
$total .= . $val // 0;
print $total\n;
--- END SAMPLE CODE ---
Before the space was added, a precedent issue wasn't as big an issue. I think
the patch should be:
$total .= . ($bookseller-{invoiceprice} // 0);
This will avoid an noisy warning, and better reflect the intent of the original
code, since I don't think ( . $val) // 0; is the thing being aimed for.
Here is my revised test plan:
1) Log into staff client
2) Acquisitions
3) Click 'Search' in the 'Manage orders' box.
4) Click '+ New basket' beside a vendor name.
5) Type 'Bug 9654 Test 1' into basket name.
6) Click 'Save'
7) Click 'Add to basket'
8) Click 'From an external source'
9) Type 'Green Eggs and Ham' into the Title text box.
10) Click 'Search'
11) Click 'Order' on any one of the results.
12) Click 'Add Item' in the 'Item' box.
13) Select a Fund from the dropdown in the 'Accounting details' box.
14) Click 'Save'
15) Click 'Close this basket'
16) Click 'Yes, close (Y)' without checking the attach to a basket group.
17) Click the 'Basket groups' tab.
18) Click '+ New basket group'
19) Notice the listing in 'Ungrouped baskets' lacks a space between the number
and the currency. (e.g. Total: 0USD)
20) Apply patch (git bz apply 9654)
21) Refresh the page
22) Notice there is now a space. (e.g. Total: 0 USD)
23) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 --- Comment #5 from Samuel Crosby scrosby...@gmail.com --- Created attachment 23870 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23870action=edit Fixed again Here we go -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 Samuel Crosby scrosby...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23869|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654
--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 23871
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23871action=edit
[SIGNED OFF] Bug 9654: Missing space between amount and currency symbol in
basket group
Changed:
$total .= $bookseller-{invoiceprice} // 0;
Into:
$total .= . ($bookseller-{invoiceprice} // 0);
in order to add a space between the total and currency in
the basket group.
Revised test plan:
1) Log into staff client
2) Acquisitions
3) Click 'Search' in the 'Manage orders' box.
4) Click '+ New basket' beside a vendor name.
5) Type 'Bug 9654 Test 1' into basket name.
6) Click 'Save'
7) Click 'Add to basket'
8) Click 'From an external source'
9) Type 'Green Eggs and Ham' into the Title text box.
10) Click 'Search'
11) Click 'Order' on any one of the results.
12) Click 'Add Item' in the 'Item' box.
13) Select a Fund from the dropdown in the
'Accounting details' box.
14) Click 'Save'
15) Click 'Close this basket'
16) Click 'Yes, close (Y)' without checking the attach to a
basket group.
17) Click the 'Basket groups' tab.
18) Click '+ New basket group'
19) Notice the listing in 'Ungrouped baskets' lacks a space
between the number and the currency. (e.g. Total: 0USD)
20) Apply patch (git bz apply 9654)
21) Refresh the page
22) Notice there is now a space. (e.g. Total: 0 USD)
23) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1)
Signed-off-by: Mark Tompsett mtomp...@hotmail.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23870|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9654] Missing space between amount and currency symbol in basket groups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9654 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- Congratulations on your first signed off bug fix. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
