[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Rémi Mayrand-Provencher remi.mayrand-provenc...@inlibro.com changed:

   What|Removed |Added

  Attachment #37010|0   |1
is obsolete||

--- Comment #20 from Rémi Mayrand-Provencher 
remi.mayrand-provenc...@inlibro.com ---
Created attachment 41463
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41463action=edit
Add a new report : Orders by budget

This patch adds the Orders by budget report to the reports page.

This report can generate the list of all orders on a specific budget. The All
budgets and All active budgets options are also available to have different
views of all your orders.

A [i] is also added before the names of inactive budgets in the budget
selection box.

How to test:
Go to Home  Reports  Orders by budget
Select one or all budgets
Output to Scrren or CSV file
Set a budget to inactive
Verify that this budget is marked wit [i] in drop down list (Filters)

Sponsored-by: ccsr

http://bugs.koha-community.org/show_bug.cgi?id=11371

Signed-off-by: Nicole Engard neng...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Rémi Mayrand-Provencher remi.mayrand-provenc...@inlibro.com changed:

   What|Removed |Added

  Attachment #37011|0   |1
is obsolete||

--- Comment #21 from Rémi Mayrand-Provencher 
remi.mayrand-provenc...@inlibro.com ---
Created attachment 41464
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41464action=edit
Bug11371 - QA fix

http://bugs.koha-community.org/show_bug.cgi?id=11371

Signed-off-by: Nicole Engard neng...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

Christopher Davis mr.catalo...@gmail.com changed:

   What|Removed |Added

 CC||mr.catalo...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

--- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Joonas Kylmälä from comment #3)
 Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com

Thx Joonas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Rémi Mayrand-Provencher remi.mayrand-provenc...@inlibro.com changed:

   What|Removed |Added

 CC||remi.mayrand-provencher@inL
   ||ibro.com
 Status|Failed QA   |Needs Signoff

--- Comment #22 from Rémi Mayrand-Provencher 
remi.mayrand-provenc...@inlibro.com ---
Fixed Conflicts in first patch and updated QA fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Christopher Davis mr.catalo...@gmail.com changed:

   What|Removed |Added

 CC||mr.catalo...@gmail.com

--- Comment #129 from Christopher Davis mr.catalo...@gmail.com ---
Dear Colleagues,

I am new to Bugzilla, so I hope that this comment will not overstep my bounds.
In my opinion, this bug is a slippery slope on the mountain of professional
ethics. I would rather error on the side of patron privacy and confidentiality
than I would on the side of trying to recuperate lost or damaged items. If we
say that we anonymize patron data, then we should go all the way without
exception.

FWIW,

Christopher Davis

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #135 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Christopher Brannon from comment #134)

 
 It should not be Koha's job to enforce privacy rules.  Rules come and go,
 and vary from place to place.  It should be a system preference, not
 something forced by the system.  Koha needs to be able to handle multiple
 scenarios.
 

I'm saying the default should be privacy, and you have to opt in to not
respecting privacy as a conscious choice. Which I think the suggestion of
having a cron to delete it after x days, is a workable compromise.

The system does of course have to enforce it, but I agree with you that if a
library wants to opt out of respecting privacy, they can do that by turning on
the system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14667] Label creator UI/UX revamp

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667

--- Comment #5 from Heather Braum hbr...@nekls.org ---
I'll be taking a look at this -- because this area definitely needed some love.
And +1 on overhauling the patron card creator, including taking on bug 12804,
please! 

Looking forward to looking at it, Liz.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562

--- Comment #5 from Jesse Weaver jwea...@bywatersolutions.com ---
This error only occurs when you don't click on a first letter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14676] New: UI/UX enhancements for the patron card creator

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676

Bug ID: 14676
   Summary: UI/UX enhancements for the patron card creator
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

This interface could use the same kind of love that the label creator is
getting, as it has a similar UI structure to the label creator tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7627] Editing of invoice number

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7627

Suzanne Fayle sfa...@roseman.edu changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #134 from Christopher Brannon cbran...@cdalibrary.org ---
(In reply to Chris Cormack from comment #133)
 (In reply to Christopher Davis from comment #129)
  Dear Colleagues,
  
  I am new to Bugzilla, so I hope that this comment will not overstep my
  bounds. In my opinion, this bug is a slippery slope on the mountain of
  professional ethics. I would rather error on the side of patron privacy and
  confidentiality than I would on the side of trying to recuperate lost or
  damaged items. If we say that we anonymize patron data, then we should go
  all the way without exception.
  
 I agree with this, I think we should be aiming to have Koha being the most
 privacy respecting system that exists.  And that we should treat privacy
 issues like we treat security ones. They are the same thing.

It should not be Koha's job to enforce privacy rules.  Rules come and go, and
vary from place to place.  It should be a system preference, not something
forced by the system.  Koha needs to be able to handle multiple scenarios.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
I just noticed that our To plugin, we just use to do JSON .. In future we could
maybe use this? But this is a just a comment. No reason to hold the bug

http://search.cpan.org/~nuffin/Template-Plugin-JSON-0.06/lib/Template/Plugin/JSON.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14667] Label creator UI/UX revamp

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667

--- Comment #4 from Liz Rea l...@catalyst.net.nz ---
Hi Chris,

That is a good point, I'll put it on my list of pet projects, because yeah,
that part needs updating too. There are lots of places that need love. :)

I wonder, could you help out with one thing though - the table headers are
untranslatable at the moment, if you have some time could you have a look at
that, or give me some hints as to how that could be done in a translatable way?

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5153] Patron Import tool does not show progress of upload

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5153

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |wizzy...@gmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #132 from Chris Rohde cro...@roseville.ca.us ---
Another point to make is that if a library is using RFID/AMH (Automated
Materials Handling), the materials are checked in before anyone has a chance to
catch damages.  We don't charge for damages, unless an item is completely
unusable.  However, when items such as a storytime kit go in, it jams the
sorter.  In our case, we offer the anonymization option to our patrons, to
honor their privacy choice.  I'd be fine with using a timestamp on the
lastpatron table, and a chron job which slides along datewise, deleting returns
older than 'x' days.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #131 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Thx you all for sharing your opinions and commenting!

Chris D. - you didn't overstep at all - please keep commenting on bugzila :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #133 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Christopher Davis from comment #129)
 Dear Colleagues,
 
 I am new to Bugzilla, so I hope that this comment will not overstep my
 bounds. In my opinion, this bug is a slippery slope on the mountain of
 professional ethics. I would rather error on the side of patron privacy and
 confidentiality than I would on the side of trying to recuperate lost or
 damaged items. If we say that we anonymize patron data, then we should go
 all the way without exception.
 
I agree with this, I think we should be aiming to have Koha being the most
privacy respecting system that exists.  And that we should treat privacy issues
like we treat security ones. They are the same thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022

jdem...@roseville.ca.us jdem...@roseville.ca.us changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14667] Label creator UI/UX revamp

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #40994|0   |1
is obsolete||

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 41467
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41467action=edit
Bug 14517: List shelves list is broken for translated interfaces

The translation script adds quotes () around translated string (Edit
for instance).
Which breaks the json structure.

Example:
dt_action: a style=\cursor:pointer\form action='shelves.pl'
method='get'input class=editshelf value=Editar type=submit
//form/a

Test plan:
1/ On the staff interface create a private list
2/ Go to More  Lists ('Your lists' tab)
3/ Translate the templates to any language like:
  $ cd misc/translator/
  $ perl translate install es-ES
4/ Enable the translated templates on the sysprefs
5/ Switch to the translated language
6/ Go to the lists page (Mas  Listas in es-ES)
The list should be displayed correctly.

Note: There is a limitation. If a translated string contains a simple
quote ('), it will also break the json.

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12804] Patron card creator search should have a branch dropdown option

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12804

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8291] patron import should show error names

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8291

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

--- Comment #1 from Heather Braum hbr...@nekls.org ---
+1 for this bug. 

I ran into this situation this evening: 

201 imported records (last was {last patron info})
1079 overwritten (last was {last patron info})
0 not imported because already in borrowers table and overwrite disabled
4 not imported because they are not in the expected format (last was {last
patron info})
1284 records parsed

What were the 4 that weren't overwritten/loaded?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Bob Birchall b...@calyx.net.au changed:

   What|Removed |Added

 CC||b...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] Attach files to bibliographic records

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #374 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Tomás Cohen Arazi from comment #373)
 Feature pushed to master.
 
 Congratulations to everyone involved!
 
 Note: this is an early push of a working feature. It needs testing
 and followup bugs will be filled (at least by me) that will be blockers
 for the release.

Patches for bug 14321 forthcoming !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12965] can create an item type that already exists

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

  Attachment #40942|0   |1
is obsolete||

--- Comment #4 from Joonas Kylmälä j.kylm...@gmail.com ---
Created attachment 41456
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41456action=edit
Bug 12965: Prevent to erase an existing item type

On creating an item type, if it already exists, it will replace the
existing one.
This patch prevent that and display a message to the interface.

Note: The fields are lost.

Test plan:
1/ Create an item type 'AAA', description 'AAA'
2/ Edit it, update the description with 'BBB'
3/ Create an item type 'AAA' with a description 'CCC' = you should get
a warning already exists.

Works well, no errors

Signed-off-by: Amit Gupta amit.gu...@informaticsglobal.com
Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #114 from Aleisha Amohia aleishaamo...@hotmail.com ---
Signing off! Works for me

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #41125|0   |1
is obsolete||

--- Comment #2 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41457
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41457action=edit
Bug 14589: Replace fetch CGI::Cookie calls

This patch is inspired by the change in bug 14588.
It replaces the indirect object syntax for CGI::Cookie.
Some trivial corrections are made to authorities/merge_ajax.pl just as
bug 14588 does for cataloguing.

Test plan:
Run the URL authorities/merge_ajax.pl in staff.
Upload a file with Stage MARC records for import.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

--- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Rebased on top of 6874.
I need this (trivial) patch for 14321.
Please add your (easy) signoff..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Blocks||14321


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
[Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Depends on||14588, 14589


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588
[Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589
[Bug 14589] Replace fetch CGI::Cookie calls
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Blocks||14321


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
[Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661

--- Comment #8 from Joonas Kylmälä j.kylm...@gmail.com ---
Created attachment 41458
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41458action=edit
Bug 14661 - space needed in added to staff side cart message, if items added
are already in cart

There is a missing space in the added to cart message on the staff side, when
you are adding 2 or more items to the cart, where 1+ is already in the cart and
1+ is not in the cart. I verified that this is not an issue in the OPAC cart
function.

Test:

1. Search for records in your system.
2. In search results, select the first two records and choose Add to Cart.
3. Message returned, 2 item(s) added to your cart, as expected.
4. Keep those 2 records selected, and select 2 additional records (so 4 total
records selected), and choose Add to Cart again.
5. Message returned, 2 item(s) added to your cart2 already in your cart.
6. Apply this patch
7. Repeat steps 1 through 4
8. Note the two phrases are on separate lines

Signed-off-by: Heather Braum hbr...@nekls.org
Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #120 from Kyle M Hall kyle.m.h...@gmail.com ---
*** Bug 2443 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2443] Acquisitions by EDIFACT

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2443

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||kyle.m.h...@gmail.com
 Status|NEW |RESOLVED

--- Comment #8 from Kyle M Hall kyle.m.h...@gmail.com ---


*** This bug has been marked as a duplicate of bug 7736 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14620] Contact information validations

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

--- Comment #2 from Lari Taskula la...@student.uef.fi ---
(In reply to Lari Taskula from comment #1)
 Created attachment 41461 [details] [review]
 Bug 14620 - Contact information validations
 
Centralizes email and phone number validations into Koha::Validation. Adds two
new system preferences, 'ValidateEmailAddress' and 'ValidatePhoneNumber', which
determine whether to use the validations or not.

Email address validation uses Email::Valid module introduced in Bug 5685. Email
can be verified via Koha::Validation::validate_email(em...@address.com).

Phone number validation uses regex to validate phone numbers. The system
preference, ValidatePhoneNumber, let's you define which regex you want to use.
In the patch there is two different phone number validators implemented,
(international and Finnish). Anyone can easily create their own regex for his
local use.

Validations are both client- and server-side.

The following test plan applies to memberentry.pl, opac-memberentry.pl and
opac-messaging.pl.

Test plan:
1. Apply the patch (and run updatedatabase.pl).
2. Set system preferences ValidateEmailAddress to Enable and
ValidatePhoneNumber to International Phone Numbers.
3. Navigate to edit user contact informations in Staff client and OPAC.
4. Make sure JavaScript is enabled.
5. Insert invalid email (e.g. invalid) and invalid phone number
(+123invalid) and send the form.
6. Confirm that form will not be submitted and errors will be given.
7. Disable JavaScript.
8. Try sending the form again.
9. Confirm that form will be submitted but errors will be given on top of the
form.
10. Observe that none of the changes are accepted.
11. Set system preferences ValidateEmailAddress to Disable and
ValidatePhoneNumber to none.
12. Repeat step 3-9 but observe that errors will not be given and changes will
be submitted and saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14584] Encoding broken with system preferences

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

--- Comment #11 from Lari Taskula la...@student.uef.fi ---
Created attachment 41459
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41459action=edit
Bug 13906 - (follow-up) Add SystemPreferenceFactory (TestObjectFactory)

This follow-up adds SystemPreferenceFactory into TestObject Factories.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14620] Contact information validations

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

--- Comment #1 from Lari Taskula la...@student.uef.fi ---
Created attachment 41461
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41461action=edit
Bug 14620 - Contact information validations

I'm thinking we should centralize all patron's contact information validators
into one module. Currently we only have validations for e-mail addresses, using
the Email::Valid module. In our local library we also want to validate phone
numbers with a regex that only recognizes phone numbers from my country. So I
suggest we create a phone number validation as well, with an option to easily
create custom regex for your local use.

If a library does not wish to use validations, we should give them an option to
turn them off. If more local validators are implemented, we should also give
the library an option to select which validator they wish to use.

With this method we could implement phone number validators from around the
world and add them into our module. Then we would make the validations simply
by calling our validator. The validator would know by system preference which
one of the implemented phone number validators it should use.

Validations should be both client and server side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14536] PageObject-pattern base implementation

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

--- Comment #7 from Lari Taskula la...@student.uef.fi ---
Created attachment 41460
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41460action=edit
Bug 14536: (follow-up) Add Memberentry PageObject and navigations

This follow-up adds Memberentry PageObject and adds navigations to memberentry
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14536] PageObject-pattern base implementation

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Lari Taskula la...@student.uef.fi changed:

   What|Removed |Added

 Blocks||14620


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620
[Bug 14620] Contact information validations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14620] Contact information validations

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Lari Taskula la...@student.uef.fi changed:

   What|Removed |Added

 Depends on||14536


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536
[Bug 14536] PageObject-pattern base implementation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Marcel de Rooy from comment #1)
 ... (Note that
 Class::-method is preferred above Class-method. See perlobj.)

http://perldoc.perl.org/perlobj.html#Invoking-Class-Methods
Interesting. I did not know this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14484] Warns when changing patron password

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #6 from Mirko Tietgen mi...@abunchofthings.net ---
Sorry, but the new attachment looks the same as the one before (and I get the
same error)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #4 from Mirko Tietgen mi...@abunchofthings.net ---
Can't reproduce on 3.18.9.

I do a search for 't', then filter the results by search type or category. One
of the patrons has an empty card number. Works for me.

Anything else I should try?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Alan aschr...@eunc.edu changed:

   What|Removed |Added

 CC||aschr...@eunc.edu

--- Comment #48 from Alan aschr...@eunc.edu ---
Hi All, 

When do you anticipate this being available for use? We had used the command
line tool in the past, so now are in a mode of manual uploads until this is
ready. 

Thanks for all of the work you are doing!

Alan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

  Attachment #41126|0   |1
is obsolete||

--- Comment #3 from Joonas Kylmälä j.kylm...@gmail.com ---
Created attachment 41462
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41462action=edit
Checked the code, looks good to me. I didn't notice any

changes in the behaviour of the merge functionality.

Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14592] Export data bad encoding

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #41129|0   |1
is obsolete||

--- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41465
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41465action=edit
[SIGNED OFF] Bug 14592: Export data bad encoding

Tools  Export data produces a file badly encoded, when marc/xml file
format is chosen. It works with CSV.

To test:

1. Tools  Export data
2. Choose a limited interval of biblionumber
3. Export in marc/xml/csv.
4. Check files exported at 3: csv file is ok. marc/xml files are
   corrupted, ie badly encoded.
5. Apply the patch
6. Repeat steps 34, and confirm that all file formats are valid.

Signed-off-by: Tomas Cohen Arazi tomasco...@unc.edu.ar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14592] Export data bad encoding

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

   Severity|trivial |major
 CC||tomasco...@gmail.com

--- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com ---
Good catch Frederic. Even if the patch is trivial, I find the problem a big
deal, libraries here are used to export their catalogs for sending to union
catalogs and this bug is really nasty for them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14667] Label creator UI/UX revamp

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 CC||cnighswon...@foundations.ed
   ||u

--- Comment #2 from Chris Nighswonger cnighswon...@foundations.edu ---
Nice improvements, Liz. I'd like to see these applied to the patron card tool
in conjunction with this to keep the interfaces similar in look and feel.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14295] Add creation time, size and owner for uploaded files

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14296] Introduce upload settings, add quota and translate alerts

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14667] Label creator UI/UX revamp

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10468] patron print summary should show more

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14592] Export data bad encoding

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14667] Label creator UI/UX revamp

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

  Attachment #41438|0   |1
is obsolete||

--- Comment #3 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 41466
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41466action=edit
[Signed off] Bug 14667 - UI/UX improvements for the Label creator

Note: It would be good to adopt these same changes in the Patron Card creator
for consistency and push
  them in conjunction with these changes. -Chris_n

Reasoning

Librarians will be doing label things in the following frequencies, from most
frequent to least frequent:
1. Creating new label batches - every day/every few days
2. Managing existing label batches - every day/every few days
3. Managing existing label layouts - as needed, infrequent
5. Managing existing label templates - as needed, infrequent
6. Creating new label layouts - as needed, infrequent
7. Creating new label templates - as needed, infrequent
8. Managing existing printer profiles - possibly once only!
9. Creating new printer profiles - possibly once only!

This change to the label creator aims to make the most frequently used items
easily accessible at the top of the main area,
reduces clutter on the page, and makes the label creator fall in line with UI
paradigms found elsewhere in Koha.

To test:

Open the label creator: More - Tools - Label creator
Note that the toolbar has changed. It should be consistent across all of the
label creator (it is an include).

+ New menu:

Label batch
1. make sure it looks ok - toolbar buttons are consistent at the top of the
main block.
2. add items both by barcode, and by search (note this patch does not touch the
pop up window. Another day.)
3. note that the usual buttons have moved below the textarea, and now have
icons.
4. delete and export single items using the buttons corresponding to each item
5. select multiple and use the buttons above the table to remove and export
selected items
6. export a full batch
7. deduplicate a batch
There should be no regressions in functionality.

Layout
1. This menu item should take you directly to the Edit layout screen.
2. no functional changes here.
3. note toolbar at top is consistent

Label template
1. this menu item should take you directly to the Edit label template page.
2. no functional changes here.
3. note toolbar at top is consistent.

Printer profile
1. this menu item should take you directly to the Edit printer profile page.
2. no functional changes here.
3. note toolbar at top is consistent.

+ Manage menu:

Label batches
1. This menu item should take you directly to the currently available batches
page.
2. select a batch to edit using the buttons
3. select a batch to delete using the buttons - it should ask for confirm.
4. select several batches using the tickboxes, and select Export selected.
Batches should be exported as normal.
5. note toolbar at top is consistent.

Layouts
1. This menu item should take you directly to the currently available layouts
page.
2. select a layout to edit using the buttons
3. select a layout to delete using the buttons
4. note toolbar at top is consistent.

Label templates
1. This menu item should take you directly to the currently available
templates page.
2. select a template to edit using the buttons
3. select a template to delete using the buttons
4. note toolbar at top is consistent.

Printer profiles
1. This menu item should take you directly to the currently available
profiles page.
2. select a profile to edit using the buttons
3. select a profile to delete using the buttons
4. note toolbar at top is consistent

+ General
* note that sidebar now only has labels home instead of the full manage
list. It seemed redundant with the toolbar tidied up.

Please note that I am happy to take suggestions/amendments to these changes.

Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #130 from Nick Clemens n...@quecheelibrary.org ---
My consortium sponsored this development, and it has taken some time to
progress it this far forward. If MySQL performance is the only blocker right
now I would really like to see a solution that addresses that and unsticks the
bug rather than requiring a rewrite of the feature.

I played around with the query and the below, while still containing a NOT IN,
eliminates the GROUP BY and improves speed significantly:
if ( C4::Context-preference('StoreLastBorrower') ) {
# Do not delete the newest old_issue for any itemnumber
$query .=  AND issue_id NOT IN ( SELECT issue_id FROM (Select
oi.issue_id from old_issues oi LEFT OUTER JOIN old_issues oi2 ON
oi.itemnumber=oi2.itemnumber AND oi2.issue_idoi.issue_id WHERE
oi.borrowernumber= ? AND oi2.borrowernumber IS NULL) AS oi ) ;
push @bind_params, $borrowernumber;

Another option is to just use the query labeleed as 'oi' above in a separate
update.  It effectively finds all the 'last returned' info for a borrower and
would allow you to mark those somehow (say invert borrower number to negative
of borrowernumber) then perform the regular anonymizing, and then update any
rows with a negative borrowrnumber to a positive borrowernumber (or whatever
marker was used)

I think Chris's comment #129 has been addressed, the feature is optional
(syspref) and gives a big warning to the patron when it is enabled for full
transparency. And I don't think sharing your opinion is overstepping :-) 

If the above queries don't work, a new table could work, though I do wonder
about the redundancy.  I wonder if it would be possible to use the 'return'
column in old_issues to mark 'lastreturned' or something similar to allow for
easy SQL selection.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface

2015-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Can I get a rebase please

Applying: Bug 14517: List shelves list is broken for translated interfaces
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 14517: List shelves list is broken for translated
interfaces

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/