[Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one column heading

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Marc Véron  changed:

   What|Removed |Added

  Attachment #42396|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 42460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42460=edit
CAM 2146 - Bug 13781 - Fix relatives's checkouts missing heading columns

There was two missing heading columns (location and fine) and one hidden
heading missing column (this hidden column is needing for sorting the table) it
was taking the due_date column for the hidden column, so I added them

Both patches tested together. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one column heading

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #143 from Julian Maurice  ---
Yes, we can, and we should, as we agreed on that during the previous dev
meeting.
It's better to have a tiny patch in master than a big, full-featured patch that
will never be pushed because of its complexity.
And the API key authentication system needs some discussion, as some people
disagree with it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one column heading

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Marc Véron  changed:

   What|Removed |Added

  Attachment #42459|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 42461
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42461=edit
CAM 2146 - Bug 13781 - Fix missing heading columns for relative's checkouts
table in check out patron page

Theres was two missing heading columns Location and Fines in the Check out
section of a Patron

Tested both patches together. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11390] DBIx::Class schema deployment script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #12 from Olli-Antti Kivilahti  ---
Hi there!
Can you share the code you have been working on here as commits?
I am not asking for anything "git bz apply":able, just something to read your
thoughts from.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5837] Change installer to use DBIx::Class::Schema::Versioned instead of updatedatabase.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5837

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #6 from Olli-Antti Kivilahti  ---
Hi there!
Can you share the code you have been working on here as commits?
I am not asking for anything "git bz apply":able, just something to read your
thoughts from.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14767] Message delivery notes from SMS Gateway provider reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

Lari Taskula  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14723

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42465|0   |1
is obsolete||

--- Comment #4 from Lari Taskula  ---
Created attachment 42467
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42467=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

 Depends on|13995   |14723


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

   What|Removed |Added

 Blocks||14791


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13995] Proper Exception handling

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Lari Taskula  changed:

   What|Removed |Added

 Blocks|14791   |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13995] Proper Exception handling

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Lari Taskula  changed:

   What|Removed |Added

 Blocks||14791


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

--- Comment #14 from Marc Véron  ---
Created attachment 42462
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42462=edit
[Signed-off] Bug 14620 - Contact information validations

I'm thinking we should centralize all patron's contact information validators
into one module. Currently we only have validations for e-mail addresses, using
the Email::Valid module. In our local library we also want to validate phone
numbers with a regex that only recognizes phone numbers from my country. So I
suggest we create a phone number validation as well, with an option to easily
create custom regex for your local use.

If a library does not wish to use validations, we should give them an option to
turn them off. If more local validators are implemented, we should also give
the library an option to select which validator they wish to use.

With this method we could implement phone number validators from around the
world and add them into our module. Then we would make the validations simply
by calling our validator. The validator would know by system preference which
one of the implemented phone number validators it should use.

Validations should be both client and server side.

Test plan:
1. Apply the patches (and run updatedatabase.pl).
2. Set system preferences ValidateEmailAddress to "Enable" and
ValidatePhoneNumber to "International Phone Numbers".
3. Make sure JavaScript is enabled.
4. Navigate to edit user contact informations in Staff client and OPAC.
5. Clear email and phone fields.
6. Insert whitespaces to email and phone fields and submit the form.
7. Edit patron.
8. Observe that there are no longer whitespaces in email and phone fields.
9. Insert invalid email (e.g. "invalid") and invalid phone number
("+123invalid") and send the form.
10. Confirm that form will not be submitted and errors will be given.
11. Disable JavaScript.
12. Insert invalid email and invalid phone number
13. Try sending the form again.
14. Confirm that form will be submitted but errors will be given on top of the
form.
15. Observe that none of the changes are accepted.
16. Set system preferences ValidateEmailAddress to "Disable" and
ValidatePhoneNumber to "none".
17. Repeat step 3-9 but observe that errors will not be given and changes will
be submitted and saved.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42467|0   |1
is obsolete||

--- Comment #5 from Lari Taskula  ---
Created attachment 42468
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42468=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

Added 1 more test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #42456|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Marc Véron  changed:

   What|Removed |Added

  Attachment #42457|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

--- Comment #2 from Lari Taskula  ---
Created attachment 42463
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42463=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

Sometimes notices keep failing due to various reasons. One common problem
is network connection failures. Because of this, the notices go into
'failed' status without another attempt for sending. This is very problematic,
because we have to not only monitor the failed messages but also resend
them manually. The purpose of this patch is to move us into more automated
way of handling delivery failures.

This patch enables us to handle exceptions in SMS messaging. The main idea
is to throw an exception from SMS::Send driver in case of a failure.
The exception will be caught by C4::SMS and from here it will be forwarded
to C4::Letters where instead of automatically setting the message into
'failed' status, we now can do as we wish with various exceptions.

As an example I have caught Koha::Exception::ConnectionFailed in
C4::Letters::_send_message_by_sms(). When we catch the said exception,
we simply leave the message in 'pending' status.  This way it will be resent
whenever process_message_queue.pl is executed again.

There are multiple other reasons of failure where Exceptions will come
in handy. For example the SMS Gateway provider may return some errors
at request, and with this patch we will be able to handle them better.

Below is a short example for making your SMS::Send driver throw an
exception in case of a connection failure in SMS/Send/MyDriver/Driver.pm.

___
use Koha::Exception::ConnectionFailed;

sub send_sms {
#.your implementation.

# Throw an exception in case of a connection error
# $connError can be for example: ($curl->{'retcode'} == 6)
# cURL code 6: CURLE_COULDNT_RESOLVE_HOST
if ($connError){
Koha::Exception::ConnectionFailed->throw(error => "Connection failed");
}

#.your implementation.
}
___

prerequisites:
-2. Set system preference SMSSendDriver to Example::ExceptionExample
-1. Enable system preference EnhancedMessagingPreferences

To test:
1. Have/create some pending sms messages into message_queue
2. Go to Patrons -> Notices
3. Observe that the your message is in pending status
4. Apply patch
5. Run misc/cronjob/process_message_queue.pl
6. Observe that your message is still in pending status

You can also test it with your own implementation of SMSSendDriver.
What you need to do is follow the example mentioned earlier to make
send_sms() subroutine throw Koha::Exception::ConnectionFailed
in case of a connection failure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

 Depends on||13995


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

--- Comment #11 from Marc Véron  ---
Created attachment 42464
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42464=edit
[Signed-off] Bug 14590 - Checkboxes should be disabled without valid contact
information in messaging preferences

This patch makes both client and server side validations, both in OPAC and
Staff client.

Followed test plan (comment #9), works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14767] Message delivery notes from SMS Gateway provider reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

Lari Taskula  changed:

   What|Removed |Added

 Depends on||14791

--- Comment #1 from Lari Taskula  ---
A more detailed explanation for the reports and delivery notes.

Our SMS Gateway provider has a two-step delivery success response. When sending
the HTTP request from our SMS::Send driver, our SMS Gateway provider will
immediately respond if the message is placed for delivery OR the following
error messages:
 - unknown error
 - invalid recipient (phone# syntax is invalid)
 - duplicate recipient (same phone# is given multiple times)
 - unallowed recipient (non-mobile/foreign phone#)

This is the first step to gather delivery notes from SMS Gateway provider. With
Bug 14791 we are able to throw Exceptions from SMS::Send driver. I propose we
throw an exception (e.g. Koha::Exception::SMSDeliveryFailure) with an accurate
description of the error. The exception will be forwarded all the way to
C4::Letters::_send_message_by_sms() where we can set the status of the message
to 'failed' and add the delivery note accordingly.

However, if the initial request was successful and the provider has accepted it
for delivery, we will move to the second phase of the delivery.

Second phase occurs after the delivery is complete on the provider's end. They
will send us a request with appropriate information of the state of the
delivery and an error message if the delivery was failed. For the second phase
we should use REST API.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

 Blocks||14767


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767
[Bug 14767] Message delivery notes from SMS Gateway provider reports
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42455|0   |1
is obsolete||

--- Comment #13 from Lari Taskula  ---
Created attachment 42466
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42466=edit
Bug 14723 - Additional delivery notes to messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

 Depends on||13995


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13995] Proper Exception handling

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Lari Taskula  changed:

   What|Removed |Added

 Blocks||14791


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42463|0   |1
is obsolete||

--- Comment #3 from Lari Taskula  ---
Created attachment 42465
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42465=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14791

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14723,
   ||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14767] Message delivery notes from SMS Gateway provider reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

Lari Taskula  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14791

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14796] zebra returns error code 114

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14796

philippe michel  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from philippe michel  ---
thanks for the tip, i found out that i had to switch from grs to dom indexing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14797] New: Cancelling orders with no alert to existing holds

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

Bug ID: 14797
   Summary: Cancelling orders with no alert to existing holds
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fiona.borthw...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

When AcqCreateItem is set to create an item when placing an order, this allows
holds to be placed on on-order items.  When an order is then cancelled, there
is no alert to existing holds.

When the order is cancelled, there is still a link to the hold against the bib
record but the Holds screen in the bib record states that you cannot place
holds as no item exists.  As a result, you cannot cancel the hold from this
screen nor can library staff see the patron details to inform them.

As a workaround, they can add a new temporary item to allow them to delete the
hold but it would be good to have an alert appearing on screen at the point of
cancelling the order (via the Delete Order link in the Basket) so that the link
to the hold record could be broken first.

Workflow to reproduce:

- Set AcqCreateItem to 'placing an order'.
- From the Acquisitions screen, select a vendor, create a new basket and add an
order to this basket.
- As the system preference is set to add the item, fill out all the relevant -
item information as well as other acq info.
- Once saved, create a hold for a patron
- Confirm that hold is present and can be seen from the bib record
- From the open basket (so reopen if already closed), select the 'Delete Order'
link against the correct orderline.
- Enter cancellation reason and click Yes.

Order is then cancelled but there was no alert about the hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing holds

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #16 from Jesse Weaver  ---
(In reply to Katrin Fischer from comment #15)
> This basically works, but 2 small glitches:
> 
> - When returning the item without the proper configuration, the warning
> message is shown, but the item still appears in the table below, even tho it
> was not checked in. It shows as: Not checked out. I think it should show an
> error and not appear in the table, as it has not been checked in.
> 

Agreed; this quirk was very confusing to us and our partners before we figured
out the issue.

> - The error message is not ideal - I think you can't say 'a privacy':
> Error: This patron has requested a privacy on returning item but the
> AnonymousPatron pref is not set correctly.
> 
> Suggestion:
> This patron has requested their circulation history be anonymized on
> check-in, but the AnonymousPatron system preference is not set correctly.
> 
> It's also showing on checkout, so would have to be changed in 2 places.

May I make the small suggestion of "... the AnonymousPatron system preference
is empty or incorrect."? Tiny quibble, but either is an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14642] Add logging of hold modifications

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Nicole C. Engard  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED
 CC||neng...@gmail.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7403] CataloguingLog warning incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14800] New: Adding Patrons to new Batch increments batchno instead of adding patron to list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14800

Bug ID: 14800
   Summary: Adding Patrons to new Batch increments batchno instead
of adding patron to list
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: heinrich.ha...@email.de
QA Contact: testo...@bugs.koha-community.org

Created attachment 42471
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42471=edit
manage batch - after once new batch and add items  adding three patrons

I observed the following malfunction in 3.20:

In pataron card creator after choosing new batch:
By Add Item(s) I am offered a pop up window to search for patrons. In each row
of all the patrons found for this search there is a button to add this patron
to the (new) batch. After pressing this button the patron is really added to
the new batch which now comprises just this one. If I want to add more patrons
to the list and therefore continue  e.g. with another search and pressing add
for further patrons to be included in the batch the chosen patrons are not
added to the just created batch but instead new batches are crated and I end
with several new batches each one with exactly one patron in it!


Apparently this is not so if  i chose to edit an existing batch. Add item(s)
and adding several patrons results correctly in extending the current batch.
This is also my bypass for the problem. I created a batch with the first patron
in it, returned to manage batches, chose again the just created batch for
editing an could complement it with the other wanted patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14798] New: Renew and checkin do not update parts of checkout page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14798

Bug ID: 14798
   Summary: Renew and checkin do not update parts of checkout page
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: a...@hanover.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When the checkout table is updated by renewing or checking in a selected item,
the page does not refresh. 
This leaves the message "Patron has ITEMS OVERDUE" in red at the top right of
the screen when actually no items are overdue.
If the item is checked in, it leave the item visible in the Checked Out items
table - with the message "checked in"

Some of this may be an intended feature, so - comments welcome!

My request is that a modification is made so that at least the ITEMS OVERDUE
message is removed once the renewals are completed.
I think in earlier versions the whole page was refreshed - checked in items
disappeared, and the Items Overdue message disappeared once the "Renew or check
in selected items" button was clicked.
Now that the table is Ajaxed, simply refreshing the entire page might have
possible unforeseen consequences that developers may need to address.

Note that you can see this effect also - if a barcode is typed into the "Enter
item barcode" box, but check out is not completed, and then you renew or
check-in an item in the checkout table, the barcode remains in the box.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

--- Comment #2 from Heather Braum  ---
I'm glad to see someone working on this; I was about to file a bug that records
with a 260 field returns with a Publisher: line but records with 264 fields do
not return with a Publisher: line in the staff xslt search results. 

It looks your work goes even further. Great, and good luck!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Genevieve Plantin  changed:

   What|Removed |Added

  Attachment #39744|0   |1
is obsolete||

--- Comment #13 from Genevieve Plantin  ---
Created attachment 42469
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42469=edit
bug 12446 - Enable adult patrons to have a guarantor

I have rebased Simith's patch.
This includes all the features from the previous patch.

On the patron category page, there is a new field to specify whether patrons
can be guarantee or not.
The atomic update SQL script adds this new field and sets it to true for
categories of type "C" and "P".

1) Apply the patch
2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and
canbeguarantee to categories.
3) Go to patron category administration, edit a category and change the value
of Can Be Guarantee to yes (for Child and Professional mostly to set it by
default)
4) See below to test various scenarios

- Enable an adult to have a guarantor:
0.0) Create or edit a patron category of type 'A'.
0.1) Set the "Can be guarantee" field to "Yes" and save.
1) Select an adult patron -> details tab;
2) Click edit button;
3) validate "guarantor information" fieldset;

- Shows guarantees' fines in the guarantor's page:
4) Click Set to patron button and select a guarantor;
5) Generate a fine;
6) Select guarantor patron -> details tab;
7) Validate guarantee's fine information.

- Transfer some guarantor's information to the guarantee while adding a
guarantiee:
0) Select an adult patron;
1) Insert all information;
2) Click Add guarantiee bouton;
3) Validade Garantor information/Main address/Contact fieldsets filled;

- Transfer some guarantor's information to the guarantee while creating a new
patron
0) Select an adult patron;
1) Insert all information;
2) Add a new adult patron;
3) Click "Set to patron" button;
4) Select the adult patron from 0);
5) Validade Garantor information/Main address/Contact fieldsets filled;

- Transfer some guarantor's information to the guarantee while adding a
guarantiee:
0) Select an adult patron;
1) Insert all information;
2) Click Add guarantiee bouton;
3) Validade Garantor information/Main address/Contact fieldsets filled;

- Transfer guarantor's alternate address/contact to the guarantee while
creating a new patron:
0) Search AdditionalGuarantorField preference;
1) Insert some additional database columns from alternate address/contact to be
transferred from guarantor;
2) Select an adult patron;
3) Insert all information;
4) Add a new adult patron;
5) Click "Set to patron" button;
6) Select the adult patron from 0);
7) Validade Garantor information/Main address/Contact fieldsets filled;
8) Validade Garantor additional alternate address/contact filled;

- Transfer guarantor's alternate address/contact to the guarantee while adding
a guarantiee:
0) Search AdditionalGuarantorField preference;
1) Insert some additional database columns from alternate address/contact to be
transferred from guarantor;
3) Select an adult patron;
4) Insert all information;
5) Click Add guarantiee bouton;
6) Validade Garantor information/Main address/Contact fieldsets filled;
7) Validade Garantor additional alternate address/contact filled;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14799] New: patron catalog security

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14799

Bug ID: 14799
   Summary: patron catalog security
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: je...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When a patron logs in to their account on the KOHA opac , then logs out, then
uses the back button to go back, their account information is still available.
This seems like a security issue. When a patron logs out, their information
should not be still available for anyone to see by using the back button (or
any other way).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14799] patron catalog security

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14799

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 5371 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371

Katrin Fischer  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com

--- Comment #10 from Katrin Fischer  ---
*** Bug 14799 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13466] Changing language does not work

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13466

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Mirko, are you still seeing this problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #14 from Genevieve Plantin  ---
Created attachment 42470
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42470=edit
Bug 12446 - Clean code according to Comment 12

For the first recommendation, I tried to be more explicit, I don't know if you
would prefer it because it is slower.

For the second point, I've got rid of the UPDATE line so we don't activate a
new functionnality.

For the third point, I was told that the coma was there in case of new
addition.

Fourth, I corrected the mistake.

For the fifth recommendation, I tried to separate the hardcode categories, but
it is simple for the display (it only changes a the choice in the select for
yes, but the user can still change it aftewards). However, I modified it so, if
someone wants to add a new category to be displayed as guarantee by default, he
only has to add the category code in the array instead of writting another
select == 'new category'.

For the sixth point, I replaced the space.

Lastly, I deleted these lines because, as you said it, it wasn't used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14800] Adding Patrons to new Batch increments batchno instead of adding patron to list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14800

--- Comment #1 from Heinrich Hartl  ---
Unfortunately I had created about 20 batches when trying to print patron cards
for 20 new patrons. Deleting these was no fun - After selecting these batches
for deletion I was told that I can delete only one batch at a time, SO what for
is the possibility to select more batches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14800] Adding Patrons to new Batch increments batchno instead of adding patron to list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14800

--- Comment #2 from Heinrich Hartl  ---
Created attachment 42472
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42472=edit
pop up message after trying  delete with several batches selected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/