[Koha-bugs] [Bug 15727] Add 385$a - Audience to MARC21 detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15727 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Marc Véron changed: What|Removed |Added Attachment #61626|0 |1 is obsolete|| --- Comment #3 from Marc Véron --- Created attachment 61636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61636&action=edit Bug 18332: Add the Koha::Objects->last method DBIx::Class does not provide such method, but it can be handy in some cases. Test plan: prove t/db_dependent/Koha/Objects.t should return green Test returned green. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 --- Comment #3 from Jonathan Druart --- Just wrote exactly the same patch, did not see yours! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329
Jonathan Druart changed:
What|Removed |Added
Attachment #61613|0 |1
is obsolete||
--- Comment #2 from Jonathan Druart
---
Created attachment 61635
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61635&action=edit
Bug 18329 - Batch record deletion broken
Hie, Tools > Batch record deletion seems broken.
Any deletion returns error :
Bibliographic record YYY was not deleted. An error occurred. (The error was:
{UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at
/home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more
information).
Looks like it is because of Bug 18242 which added a transaction in
C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
The script batch_delete_records created a transaction with $dbh->{AutoCommit} =
0;
This patch fixes by using also Koha::Schema in batch_delete_records to manage
transaction.
It also removes "$dbh->{RaiseError} = 1", this behavior is managed in
Koha::Database.
Test plan :
- Go to Staff interface : Tools > Batch record deletion
- Enter a few existing biblionumbers
- Click on "Continue"
- Click on "Delete selected records"
=> Without patch you get a DB error
=> With patch you get confirmation message
- Try to get the biblios to confirm they are deleted :
/cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx
- Test with and without Plack
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #128 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 --- Comment #8 from Jonathan Druart --- Created attachment 61634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61634&action=edit Bug 18314: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 --- Comment #7 from Jonathan Druart --- Created attachment 61633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61633&action=edit Bug 18314: Resetting the password removes the lock When a password is changed (updated by a staff member or using the "recover password via email" feature, the counter/flag needs to be reset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 --- Comment #6 from Jonathan Druart --- Created attachment 61632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61632&action=edit Bug 18314: Account lockout To prevent brute force attacks on Koha accounts, staff and opac, we need to implement an account lockout process to Koha. After a number of failed login attempts a users account would become locked. The user would then need to use the reset password functionality to send a reset token to their email account. After a successful password reset the lockout flag would be removed. The number of failed login attempts before lockout is configurable using a new system preference 'FailedLoginAttempts'. How does it work? When a patron enter an invalid password, the borrowers.login_attempts value for this patron is incremented. When this value reach the value of the pref FailedLoginAttempts, the password comparison is not done and the authentication is rejected. This login_attempts field is reset when a patron correctly logs in. When the account is locked the patron has to reset his/her password using the OpacResetPassword feature or ask a staff member to generate a new password. If the pref is not set (0, or '') the feature is considered as disabled, but the failed login attempts are stored anyway. Test plan: 0/ Apply patch and execute the update DB entry 1/ Switch on the feature by setting FailedLoginAttempts to 3 2/ Use an invalid password to login at the staff or OPAC interface 3/ After the third consecutive failures, you will be asked to reset your password if OpacResetPassword is set, or contact a staff member 4/ Switch on OpacResetPassword and reset your password 5/ Confirm that you are able to login 6/ Play with the different combinations QA details: The trick happens in C4::Auth::checkpw, to make things clear I had to create a return value (note the awesome name: @return) and replace the 3 successives if statements with elsif. Indeed if one of the condition is reached, it will return inside the given block. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 --- Comment #4 from Jonathan Druart --- Created attachment 61630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61630&action=edit Bug 18314: Add pref FailedLoginAttempts and columns borrowers.login_attempts And of course deletedborrowers.login_attempts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 --- Comment #5 from Jonathan Druart --- Created attachment 61631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61631&action=edit Bug 18314: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #22 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #31 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18314] Account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Jonathan Druart changed: What|Removed |Added Depends on||18174 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 [Bug 18174] Add the Koha::Object->update method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18174] Add the Koha::Object->update method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 Jonathan Druart changed: What|Removed |Added Blocks||18314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 [Bug 18314] Account lockout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15705] Notify the user on auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What|Removed |Added Attachment #61497|0 |1 is obsolete|| --- Comment #54 from Jonathan Druart --- Comment on attachment 61497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61497 Bug 15705: Add is_tt param to the new letter This column has been abandoned on bug 14757, we should not use it here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Jonathan Druart changed: What|Removed |Added CC||julian.maur...@biblibre.com ||, ||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com --- Comment #7 from Jonathan Druart --- I have rebased this branch, that was a nightmare, really... There are too many patches in the queue, please help me to move things toward master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #13 from Christopher Brannon --- Note to kohadevbox testers: disable plack. Kohadevbox is not pointing to all the files in the kohaclone environment with plack enabled. This is an issue with kohadevbox, not the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #12 from Christopher Brannon --- Created attachment 61629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61629&action=edit [SIGNED OFF] Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected Works as expected. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Jonathan Druart changed: What|Removed |Added Attachment #59451|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 61628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61628&action=edit Bug 17967: TT syntax for notices - Prove that ODUE is compatible Nothing new here, unless we are introducing a regression. The items.fine is a trick of our historical syntax. We need to provide a way to access this value from the a notice template using the TT syntax. A bug 17976 has been opened for discussion. Test plan: Define ODUE and OVERDUES_SLIP notice templates and use it to generate overdue notices from the cronjob script (misc/cronjobs/overdue_notices.pl) or the interface (members/print_overdues.pl). You should be able to generate the same notices with and without using the TT syntax -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17650] Create the option to save the cover with the uploaded files.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650
Eric changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
CC||eric.gosseli...@gmail.com
--- Comment #10 from Eric ---
Patch didn't apply in the sandbox.
Some problems occurred applying patches from bug 17650:
Something went wrong !Applying: Bug 17650 - Create the option to save
the cover with the uploaded files.
.git/rebase-apply/patch:69: trailing whitespace.
->png(), );
.git/rebase-apply/patch:73: trailing whitespace.
.git/rebase-apply/patch:97: trailing whitespace.
->{'imagefile'} = ;
.git/rebase-apply/patch:157: trailing whitespace.
ALTER TABLE
.git/rebase-apply/patch:159: trailing whitespace.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17969] Refactor the way <> is generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart changed: What|Removed |Added Blocks||17967 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 [Bug 17967] TT syntax for notices - Prove that ODUE is compatible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Jonathan Druart changed: What|Removed |Added Depends on||17969 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 [Bug 17969] Refactor the way <> is generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #19 from Jonathan Druart --- Created attachment 61627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61627&action=edit Bug 17964: Replace next with last We certainly always want to retrieve the last row of a given search. If it not sufficient we will need to rethink this code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #18 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #17) > (In reply to Jonathan Druart from comment #16) > > (In reply to Jonathan Druart from comment #15) > > > (In reply to Marcel de Rooy from comment #13) > > > > In the interface I used this checkin notice: > > > > > > > > The following items have been checked in: > > > > > > > > [% biblio.title %] [% old_issues.returndate %] > > > > [% old_issues.issue_id %] > > > > TT syntax uses old_checkouts. Take a look at unit tests. > > OK. Is that handy? Others might make the same mistake when converting a > notice? In any cases it's not introduced by this patchset. We discussed about that already and decided to use the "new" terminology. You should also take a look at bug 17981, I provide a very friendly way to automagically convert legacy syntax notices to the TT syntax. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Jonathan Druart changed: What|Removed |Added Blocks||17964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What|Removed |Added Depends on||18332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 [Bug 18332] Add the Koha::Objects->last method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Jonathan Druart changed: What|Removed |Added Attachment #61625|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 61626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61626&action=edit Bug 18332: Add the Koha::Objects->last method DBIx::Class does not provide such method, but it can be handy in some cases. Test plan: prove t/db_dependent/Koha/Objects.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 --- Comment #1 from Jonathan Druart --- Created attachment 61625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61625&action=edit Bug 18332: Add the Koha::Objects->last method DBIx::Class does not provide such method, but it can be handy in some cases. Test plan: prove t/db_dependent/Koha/Objects.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > (In reply to Jonathan Druart from comment #15) > > (In reply to Marcel de Rooy from comment #13) > > > In the interface I used this checkin notice: > > > > > > The following items have been checked in: > > > > > > [% biblio.title %] [% old_issues.returndate %] > > > [% old_issues.issue_id %] > > TT syntax uses old_checkouts. Take a look at unit tests. OK. Is that handy? Others might make the same mistake when converting a notice? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 --- Comment #12 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #10) > > (In reply to Marcel de Rooy from comment #8) > > > (In reply to Tomás Cohen Arazi from comment #4) > > > > I get an empty file no matter what I do. Tried with a 'biblios' file > > > > with > > > > valid biblionumbers, tried renaming to 'biblios.txt' and even tried > > > > without > > > > a file. The result is always an empty .mrc file. > > > > > > Problem reproduced. > > > > I do not understand, Tomas is saying that the patch is buggy, you confirmed, > > but PQA? > > No, I confirm that the problem can be reproduced. And the patch resolves it. Problem reproduced == Internal server error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18332] New: Add the Koha::Objects->last method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Bug ID: 18332 Summary: Add the Koha::Objects->last method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org This is not a DBIx::Class method, but we can provide it for Koha::Objects using slice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > (In reply to Marcel de Rooy from comment #8) > > (In reply to Tomás Cohen Arazi from comment #4) > > > I get an empty file no matter what I do. Tried with a 'biblios' file with > > > valid biblionumbers, tried renaming to 'biblios.txt' and even tried > > > without > > > a file. The result is always an empty .mrc file. > > > > Problem reproduced. > > I do not understand, Tomas is saying that the patch is buggy, you confirmed, > but PQA? No, I confirm that the problem can be reproduced. And the patch resolves it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #41 from Jonathan Druart --- Created attachment 61624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61624&action=edit Bug 17762: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #42 from Jonathan Druart --- Rebased and fixed a test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #40 from Jonathan Druart --- Created attachment 61623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61623&action=edit Bug 17762: Fix test for NewsChannels.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #39 from Jonathan Druart --- Created attachment 61622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61622&action=edit Bug 17762: Fix sql fields insertion The "Insert ->" buttons used to copy the sql field to the textarea was based on the id of the fieldset. This id has to be unique to work as expected. It is now composed of mtt + lang instead of mtt only Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #38 from Jonathan Druart --- Created attachment 61621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61621&action=edit Bug 17762: Add the lang parameter to C4::Letters::getletter Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #37 from Jonathan Druart --- Created attachment 61620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61620&action=edit Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #35 from Jonathan Druart --- Created attachment 61618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61618&action=edit Bug 17762: Add lang to the PK of letter We need to enlarge the PK of the letter table. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #36 from Jonathan Druart --- Created attachment 61619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61619&action=edit Bug 17762: Update the letter form interface If the pref is on, the notice template will be translatable in different languages Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #33 from Jonathan Druart --- Created attachment 61616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61616&action=edit Bug 17762: Add the lang attribute to the patron form Not the opac because we do not want the patron to modify it, they won't be necessary translated. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What|Removed |Added Attachment #59452|0 |1 is obsolete|| Attachment #59453|0 |1 is obsolete|| Attachment #59454|0 |1 is obsolete|| Attachment #59455|0 |1 is obsolete|| Attachment #59456|0 |1 is obsolete|| Attachment #59457|0 |1 is obsolete|| Attachment #59458|0 |1 is obsolete|| Attachment #59459|0 |1 is obsolete|| Attachment #59460|0 |1 is obsolete|| Attachment #59461|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart --- Created attachment 61614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61614&action=edit Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #32 from Jonathan Druart --- Created attachment 61615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61615&action=edit Bug 17762: Add the new TranslateNotices syspref This whole patch set adds the ability to translate notices in different languages. That way, if a library has patrons from different countries, they will not have to send the notices in only one language but they will be able to translate them. Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates => You should see different tabs, 1 tab per language translated at the opac (which sounds to make sense) - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17762] Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #34 from Jonathan Druart --- Created attachment 61617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61617&action=edit Bug 17762: Remove FK on message_transports I don't really understand where does come from this foreign key but at first glance it does not make sense. Note that it seems we could also remove message_transports.branchcode Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8266] remove location from pull down on search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #11 from Christopher Brannon --- Throwing stray text into the file you patched doesn't seem to effect anything. I know my test environment is working, as I can apply another patch and see the effects of it right away. We're missing something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329
--- Comment #1 from Fridolin SOMERS ---
Created attachment 61613
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61613&action=edit
Bug 18329 - Batch record deletion broken
Hie, Tools > Batch record deletion seems broken.
Any deletion returns error :
Bibliographic record YYY was not deleted. An error occurred. (The error was:
{UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at
/home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more
information).
Looks like it is because of Bug 18242 which added a transaction in
C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
The script batch_delete_records created a transaction with $dbh->{AutoCommit} =
0;
This patch fixes by using also Koha::Schema in batch_delete_records to manage
transaction.
It also removes "$dbh->{RaiseError} = 1", this behavior is managed in
Koha::Database.
Test plan :
- Go to Staff interface : Tools > Batch record deletion
- Enter a few existing biblionumbers
- Click on "Continue"
- Click on "Delete selected records"
=> Without patch you get a DB error
=> With patch you get confirmation message
- Try to get the biblios to confirm they are deleted :
/cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx
- Test with and without Plack
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15647] Allow selection of destination email address for print overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647 Eric changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||eric.gosseli...@gmail.com --- Comment #5 from Eric --- Patch doesn't apply Some problems occurred applying patches from bug 15647: Something went wrong !Applying: Bug 15647: Allow selection of destination email address for print overdue notices Using index info to reconstruct a base tree... Koha/Library.pm installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref misc/cronjobs/overdue_notices.pl Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/overdue_notices.pl CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging Koha/Library.pm Patch failed at 0001 Bug 15647: Allow selection of destination email address for print overdue notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #10 from Marc Véron --- Not kohadevbox. It's a VM with an install from packets that I gitified. Current version is 16.12.00.015 Just an idea because I remember a similar situation: What happens if you edit the patched C4/Patroncards/Patroncard.pm file and intentionally insert some errors in order to make it crash? - Can you provoke the crash or does export still behave as before? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #9 from Christopher Brannon --- Are you testing the patch on a dedicated test server, or are you using kohadevbox? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > (In reply to Marcel de Rooy from comment #13) > > In the interface I used this checkin notice: > > > > The following items have been checked in: > > > > [% biblio.title %] [% old_issues.returndate %] > > [% old_issues.issue_id %] TT syntax uses old_checkouts. Take a look at unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #11 from Tomás Cohen Arazi --- I expected to see something like: ccode:0 in biblio-koha-indexdefs.xml for MARC21 and NORMARC (and the corresponding field/subfield for UNIMARC). And then have the biblio-zebra-indexdefs.xsl file get re-generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964
--- Comment #15 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #13)
> In the interface I used this checkin notice:
>
> The following items have been checked in:
>
> [% biblio.title %] [% old_issues.returndate %]
> [% old_issues.issue_id %]
>
> Thank you.
>
> And it does not show me the old issues information. No date and no id.
I will take a look.
> If I look at sub _get_tt_params, I am having doubts if the correct old
> issues record would be found when just using itemnumber as a foreign key.
> Note that I repeatedly checked in and out the same item. Looking at the
> code, I would expect the wrong old issue record found. Should you not look
> at the last one instead of the first one? The "historical" code uses: ORDER
> BY timestamp DESC in _parseletter_sth..
Same.
> Another question: How do you use plural in _get_tt_params ? If we are not
> using it, why add it?
You should take a look at the whole enhancement, tree of dependencies.
If you take a look bug 17981, which is almost the top of the tree, you will see
all the deps. There is a remote branch to see all patches applied. I think it's
important to have this overview in mind before QAing separately the different
bug reports.
It is hard to make a such big tree and trying to reflect what you are trying to
do on all the different steps.
(In reply to Marcel de Rooy from comment #14)
> And as a side note: Is this code in get_tt_params really correct:
> else {# $ref eq 'ARRAY'
> my $object;
> if ( @{ $tables->{$table} } == 1 ) {# Param is a single
> key
> $object = $module->search( { $pk => $tables->{$table} }
> )->next();
> }
> else { # Params are
> mutliple foreign keys
> croak "Multiple foreign keys (table $table) should be
> passed using an hashref";
> }
> I was thinking that I could pass a few primary keys in an array (see
> historical code). But this code croaks on "multiple fk's". Plus a typo :)
That could be implement later, I just implemented what I used. During the whole
process I did not need it. Maybe later?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #10 from Martin Renvoize --- Created attachment 61612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61612&action=edit Furher UNIMarc Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17502] Add type check to output_pref and use exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502
--- Comment #27 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #25)
> (In reply to Jonathan Druart from comment #23)
> > The classes of the exceptions should not be named with the module they are
> > raised from.
>
> Hmm. Just following what we already did (and approved).
> Like:
>
> package Koha::Patron::Modification;
> use Koha::Exceptions::Patron::Modification;
> Koha::Exceptions::Patron::Modification::DuplicateVerificationToken->throw
> ===
> package Koha::Exceptions::Patron::Modification;
>
> 'Koha::Exceptions::Patron::Modification::DuplicateVerificationToken' => {
> isa => 'Koha::Exceptions::Patron::Modification',
> description => "The verification token given already exists"
> },
> ===
>
> Please explain.
> Should we formulate a coding guideline here?
We might need to.
I think the thing with the exceptions you add is:
- There's no need to have them tied to output_pref, they could jus tbe
top-level for the DateUtils namespace. Remember when you catch them, you have
the context in which it happened and can build the needed actions.
- The ones you add should be general exceptions: WrongParameters,
MissingParameters, InvalidParamType. Keep in mind that you can use them like
this:
Koha::Exceptions::InvalidParamType->throw('DateTime object expected');
Koha::Exceptions::WrongParameters->throw('Conflicting parameters dt and str
passed');
instead of baking a too specific exception.
Regarding the Patron modification ones, I found that patron modification tokens
were too specific, and they deserved its own exception. But it might be subject
to future changes if someone raises it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Owen Leonard changed: What|Removed |Added Component|Circulation |OPAC Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #8 from Christopher Brannon --- > I repeated with your settings, it works as expected (see screenshot > attached). After taking the screenshots, I tested with other B_-fields as > well, e.g. , they display as expected. > > It did not work immediately after applying the patch, I had to re-start > Plack and to reload the page for batch management. Tested with single export > and with export of entire batch. > > Hmm, where is the difference...? Don't know. I've tried everything I know. Don't know why loading a patch should be this difficult. I even tried another browser. If it is sticking anywhere, it is on the server side, not the browser, since the change is not reflected in a new browser. I'll keep beating up on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 --- Comment #10 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #8) > (In reply to Tomás Cohen Arazi from comment #4) > > I get an empty file no matter what I do. Tried with a 'biblios' file with > > valid biblionumbers, tried renaming to 'biblios.txt' and even tried without > > a file. The result is always an empty .mrc file. > > Problem reproduced. I do not understand, Tomas is saying that the patch is buggy, you confirmed, but PQA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #7 from Marc Véron --- Created attachment 61611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61611&action=edit Re-testing same settings as in screenshot comment #5 (In reply to Christopher Brannon from comment #4) > I've cleared cache, restarted apache2, restarted memcache, restarted all > (restart_all), no luck. > > I'm using the demo layout that installed with Koha, and just editing the 2nd > field to read "Address: " > > I go to manage Card batches and on my one patron I click Export. When I > open the pdf, I still see . > > I will attach my screen shots. I repeated with your settings, it works as expected (see screenshot attached). After taking the screenshots, I tested with other B_-fields as well, e.g. , they display as expected. It did not work immediately after applying the patch, I had to re-start Plack and to reload the page for batch management. Tested with single export and with export of entire batch. Hmm, where is the difference...? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021
Benjamin Rokseth changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #15 from Benjamin Rokseth ---
(In reply to Marcel de Rooy from comment #14)
> Please look at this:
>
> if ($messages->{NeedsTransfer}) {
> $self->{item}->destination_loc($messages->{NeedsTransfer});
> $self->alert_type('04');# send to other branch
> }
> if ($messages->{WasTransfered}) { # set into transit so tell unit
> $self->destination_loc($iteminformation->{homebranch});
> $self->alert_type('04');# send to other branch
> }
>
> You changed NeedsTransfer, but you did not touch WasTransfered here.
> That is the reason why I saw the CV04 without CT.
> Please change and set back to Needs Signoff. A fresh signoff would not be
> bad.
this must be a lost commit, will make a new patch and set back to Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Eric changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||eric.gosseli...@gmail.com --- Comment #36 from Eric --- Patch didn't apply, Some problems occurred applying patches from bug 14272: Something went wrong !Applying: Bug 14272: Show single news item (tests) Applying: Bug 14272: Show single news item (backend) Using index info to reconstruct a base tree... M C4/NewsChannels.pm Falling back to patching base and 3-way merge... Auto-merging C4/NewsChannels.pm CONFLICT (content): Merge conflict in C4/NewsChannels.pm Patch failed at 0001 Bug 14272: Show single news item (backend) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] Export csv in item search, exports all items in one line ( see Bug 16914)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Katrin Fischer changed: What|Removed |Added Depends on||16914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 [Bug 16914] Export csv in item search, exports all items in one line -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 Katrin Fischer changed: What|Removed |Added Blocks||18331 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 [Bug 18331] Export csv in item search, exports all items in one line (see Bug 16914) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 --- Comment #30 from Katrin Fischer --- Filed bug 18331 for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] New: Export csv in item search, exports all items in one line (see Bug 16914)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Bug ID: 18331 Summary: Export csv in item search, exports all items in one line (see Bug 16914) Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr CSV exports of late orders and item search are broken again if you are using them from a 'complete' translation. The theory is that if the strings are not translated, then the file is only copied (preserves line breaks) and not translated (kills line breaks). Both late orders and item search csv expots are effected. For item search there is one string in itemsearch_item.csv.inc: %s %s %s %s "%s %svon %s%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s" Easiest way to test: - Install German - Test CSV export - it should be broken. - Look for the strings in itemsearch_item.csv in the staff po file and "untranslate" them. This is easiest done by adding "fuzzy". - Reinstall German - CSV shoudl be fixed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #16 from Koha Team Lyon 3 --- I repeat tests proposed by Marc in Comment 5 : With syspref DigitSeparator : ",." CHF 1.45 -> 1.45 OK 12.50$ -> 12.50 OK 199 -> 199.00 OK 1'345.95 -> 1345.95 OK (Switzerland) With syspref DigitSeparator : "." 12,34,567.89 -> 1234567.89 OK (Pakistan, India) 12,34,567 -> 1234567.00 OK 1 234 567,89 -> 123456789.00 OK (Germany...) With syspref DigitSeparator : "," 1.234.567,89 -> 1234567.89 1.234.567 -> 1234567.00 Calculations are good but I don't want to sign-off this patch before the other pages are done (see comment 15) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 --- Comment #29 from Katrin Fischer --- Easiest way to test: Install German, look for the string (search for the file name), mark it as 'fuzzy' - Export works, remove 'fuzzy' - export is broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 --- Comment #28 from Katrin Fischer --- It appears that if you actually translate the file by having a translated version of the string %s %s %s %s "%s %svon %s%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s", "%s" then the csv export is broken again because the line breaks in itemsearch_item.csv.inc get destroyed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Baptiste changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #21 from Baptiste --- I corrected the display of streetnumber in this ticket, I don't think it's necessary to open a new ticket just for one code line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #20 from Baptiste --- Created attachment 61610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61610&action=edit BUG 18110: Corrected display address format - minor changes on address format - corrected member-password so that steetnumber is given to the template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 Marcel de Rooy changed: What|Removed |Added Attachment #61434|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 61609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61609&action=edit Bug 18312: Fix export unless a file is supplied Bug 18087 breaks export unless a file is supplied. Can't use an undefined value as a HASH reference at /home/vagrant/kohaclone/tools/export.pl line 75. Test plan: Export records using a file of id that is not a valid file (not txt or csv) Export records using a valid file Export records without supplying a file => The export should work or fail as expected. Signed-off-by: Jesse Maseto Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 --- Comment #8 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #4) > I get an empty file no matter what I do. Tried with a 'biblios' file with > valid biblionumbers, tried renaming to 'biblios.txt' and even tried without > a file. The result is always an empty .mrc file. Problem reproduced. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18312] Export is broken unless a file is supplied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #7 from Marcel de Rooy --- Last one :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16895] Allow writeoffs via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #8 from Marcel de Rooy ---
Question raised while testing:
Why does sub pay in C4/SIP/ILS/Transaction/FeePayment.pm contain this check:
if ( $fee && $fee->amountoutstanding == $amt ) {
If I am paying a partial amount in the interface, this is allowed too. But note
that it is not possible to writeoff a partial amount in the interface.
I tried a partial writeoff in testing this patch and I wondered why I got a N
in the response. But the cause is this test. I think we should print a message
why we refused the payment.
While I understand that you refuse it for a writeoff, I do not understand it
for another payment type. And thats where I can tie it to this report: Should
this check be applied only to the writeoffs ?
In summary I propose two changes:
[1] Send a message why you refuse a partial payment for writeoffs.
[2] Accept a partial payment for other types.
Changing status
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18330] New: REST API: Date-time handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 Bug ID: 18330 Summary: REST API: Date-time handling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: lari.task...@jns.fi QA Contact: testo...@bugs.koha-community.org Swagger2 wants dates and date-times as defined in RFC3339, https://xml2rfc.tools.ietf.org/public/rfc/html/rfc3339.html#anchor14 Make sure each object property has a format date or date-time defined where needed. We should include information on time zone and use an appropriate separator "T" between date and time, e.g.: 2017-03-24T14:00:00+02:00 2017-03-24T12:00:00Z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Fridolin SOMERS changed: What|Removed |Added Assignee|gmcha...@gmail.com |fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Fridolin SOMERS changed: What|Removed |Added Blocks||18329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 [Bug 18329] Batch record deletion broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] New: Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329
Bug ID: 18329
Summary: Batch record deletion broken
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Tools
Assignee: gmcha...@gmail.com
Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
Hie, Tools > Batch record deletion seems broken.
Any deletion returns error :
Bibliographic record YYY was not deleted. An error occurred. (The error was:
{UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at
/home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more
information).
Looks like it is because of Bug 18242 which added a transaction in
C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
The script batch_delete_records created a transaction with $dbh->{AutoCommit} =
0;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18329] Batch record deletion broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Fridolin SOMERS changed: What|Removed |Added Depends on||18242 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 [Bug 18242] Remove primary key on old_issues.issue_id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA Patch complexity|--- |Small patch --- Comment #13 from Marcel de Rooy --- QA Comment: Looks good to me. Tested fee paid with and without accountlines id. The cli emulator looks ok, but did not test it; rather run a test file like t/db_dependent/SIP/Message.t or so :) Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #15 from Koha Team Lyon 3 --- I'm testing now. Looks goog but I haven't finished yet. But It should be extended to this page : /cgi-bin/koha/admin/aqbudgets.pl /cgi-bin/koha/members/mancredit.pl and /cgi-bin/koha/members/maninvoice.pl? as well Perhaps in cgi-bin/koha/acqui/neworderempty.pl too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Marcel de Rooy changed: What|Removed |Added Attachment #61375|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 61607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61607&action=edit Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha Signed-off-by: Rhonda Kuiper Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Marcel de Rooy changed: What|Removed |Added Attachment #61376|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 61608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61608&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing Signed-off-by: Rhonda Kuiper Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Status|Needs Signoff |Signed Off --- Comment #2 from Séverine Queune --- The patch 13205 apply perfectly. There is no problem jumping from any page to first/last/next/previous page on OPAC or staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #6 from Colin Campbell --- Created attachment 61606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61606&action=edit proposed patch Add test for new method added to line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Attachment #61602|0 |1 is obsolete|| --- Comment #5 from Colin Campbell --- Created attachment 61605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61605&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste changed: What|Removed |Added Attachment #61603|0 |1 is obsolete|| --- Comment #14 from Baptiste --- Created attachment 61604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61604&action=edit BUG 12310: Modified the tooltips Modified the tooltips helping the users entering monrtary information in the right format. BUG 12310: Corrected the RegExp -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18328] New: There is no history for article request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18328 Bug ID: 18328 Summary: There is no history for article request Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: severine.que...@bulac.fr QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Il would be useful if the "Cancelled requests" and "Completed requests" of articles request were kept in different tabs, just like it exists for acquisition suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
