date:20170630

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #3 from Alex Buckley  ---
Created attachment 64763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64763=edit
Bug 18743 - Removed library filter in Acquisition suggestions when
IndependentBranches enabled

Also ensured that when a superlibrarian is logged in then suggestions from
all branches are displayed with IndependentBranches being either on or off, as
this
syspref does not affect what suggestions superlibrarians can see.

But when non-superlibrarian user with access to the acquisitions module
visits it when IndependentBranches is enabled then only suggestions of
the branch they are logged in with are displayed.

If non-superlibrarian users log in when IndependentBranches is not
enabled then suggestions from all branches are displayed.

Note: The library filter in the 'Organize by' area (which is displayed when
multiple branches suggestions are displayed according to the aforementioned
logic) successfully splits the suggestions into different tabs with the correct
number of suggestions for each branch
displayed in each tab.

Test plan:
1. Create 2 suggestions a library branch (which I will refer to in this
test plan as branch A)

2. Create 1 suggestion for a different branch (which I will refer to as
branch B)

3. Log into staff client as superlibrarian with either branch and ensure the
IndependentBranches syspref is set to 'yes'

4. Go to Acquisitions->Suggestions Management

5. Notice that suggestions from branch A and B are displayed

6. In the Organize by are click to filter by library and click go

7. Notice that one tab says  (2) whilst the other tab
says  (1) with each tab containing the relevant
suggestions to that branch

8. Now change the IndependentBranches syspref to 'no'

9. Repeat steps 4, 5, 6, 7 noticing the same outcome in step 7

10. Log out and log back into staff client in branch A as a non-superlibrarian
user
who has access to the Acquisitions module

11. Currently IndependentBranches is set to 'no' so go to
Acquisitions->Suggestions Management

12. Repeat steps 5, 6, 7 and notice the same outcome as step 7

13. Change IndependentBranches to 'yes'

14. Go to Acquisitions->Suggestions Management

15. Notice that only suggestions from branch A (the branch you are
logged in with) are displayed. This is because when IndependentBranches
is enabled non-superlibrarians do not need to see suggestions from other
branches

16. Also noticethat there is no 'library' option in the 'Organized by'
area. This is because only suggestions from the current branch are
displayed and so organizing by library is redundant.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9409] koha-create --request-db should be able to accept a dbhost option

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409

M. Tompsett  changed:

   What|Removed |Added

   Assignee|tomasco...@gmail.com|mtomp...@hotmail.com

--- Comment #4 from M. Tompsett  ---
Thanks for the sign off, LeeJ. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785

--- Comment #2 from M. Tompsett  ---
Comment on attachment 64197
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64197
Bug 18785: Add Koha::Subscription::biblio

Review of attachment 64197:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18785=64197)
-

::: Koha/Subscription.pm
@@ +44,5 @@
> +
> +sub biblio {
> +my ($self) = @_;
> +
> +return Koha::Biblios->find($self->biblionumber);

There are a bunch of other bugzilla issues related to ->find and a scalar
context.
Perhapts actually using ->find({ biblionumber => $self->biblionumber }); or
I think others get lazy ->find( scalar $self->biblionumber )... or was it
return scalar Koha::Biblios->find($self->biblionumber);
Hmmm... anyways, this isn't right, as far as I can tell.
Plus if it is singular, then why Biblios? This is the part I don't understand
in this and other code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64101|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 64762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64762=edit
Bug 18755 Allow empty passwords in Patron Info to return OK

With this patch a parameter 'allow_empty_passwords="1" can be added to a
login in the SIP configuration file to allow the behaviour as was normal
before the patch for bug 16610 was applied. Some sip clients rely on
this behaviour sending an empty password field when they wish to
validate to user but do not have the password.
If a password is supplied it will be validated

A test has been added to Message.t to confirm this behaviour

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
I figured the test added should fail under master, so:
git bz apply 18755
git checkout origin/master -- C4/SIP/Sip/MsgType.pm
prove t/db_dependent/SIP/Message.t
-- fails as expected
git reset --hard origin/master
git bz apply 18755
prove t/db_dependent/SIP/Message.t
-- passes as expected.

This change is fully tested by the test that is added, so I'm going to sign
off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798

--- Comment #7 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #6)
> > To my understanding, this is what happened :
> > 
> > Situation 1 (regular)
> > 
> > - Patron A put a hold on Book A
> > - Book A is returned. Hold is confirmed.
> > - Patron B checkout Book A
> > - Koha says "This book is on hold for Patron A, what do you want to do?"
> > - The button "Don't checkout and print" allows you to cancel the process and
> > print a slip.
> > - It keeps the book on hold for Patron A. It's actually already on hold so
> > there should be no reason to update it.
> 
> If the item is already on hold for the patron it will allow to reprint the
> hold slip. Sounds good.
> 
> 
> > BUT, here comes situation 2 (exception)
> > 
> > - Patron A put a hold on Book A
> > - Book A is returned. Hold is NOT confirmed (Library wants to confirm the
> > hold later to control when the confirmation email is sent, or library had
> > forgotten, etc.)
> > - Patron B checkout Book A
> > - Koha says "This book is on hold for Patron A, what do you want to do?"
> > - The button "Don't checkout and print" allows you to cancel the process and
> > print a slip.
> > - The hold is not confirmed and this button doesn’t update it.
> 
> I think that's wrong - you should not have a hold slip if no email is
> generated and the hold is not set to waiting. The slip should only happen if
> the hold is waiting or set to waiting - otherwise you end up with
> 'available' items on the hold shelf. 
> 
> I wonder if the message could be better as on hold sounds like it's already
> waiting, but it's not. We should have different messages for already waiting
> and having a hold on it that's not yet confirmed.
> 
> I think what Nick describes is a 3rd option: hold for A, don't confirm hold,
> try to checkout to A. In this case, the item was not waiting and should be
> set to waiting.

Yes, as I follow things this is correct - I was thinking of the situation
where:
A places a hold from home
B picks up the book off the shelf before a hold list is checked
Try to checkout to B, print slip, hold never confirmed

I think you are getting at language something like:
this item has a hold for Patron A
versus 
this item is on hold for Patron A

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #13 from Marc Véron  ---
(In reply to Marcel de Rooy from comment #12)
> Applying: Bug 18881: Remove dead code in circ/view_holdsqueue.pl
> fatal: sha1 information is lacking or useless (circ/view_holdsqueue.pl).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.

Re-tested, applies cleanly here (on top of Bug 18859).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Alex Buckley  changed:

   What|Removed |Added

  Attachment #64742|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #2 from Alex Buckley  ---
Hi Severine 

I am working through making a patch for this bug report and just to clarify the
issue I thought I would write this up:

When IndependentBranches is enabled then both the 'organise by', and
'Acquisition information' filters should not have a library option because only
suggestions from the currently logged in library branch should be displayed. 

An additional bug I have found on the current master is:

When the IndependentBranches syspref is set to 'no' then only suggestions from
the currently logged in branch are displayed.
For example if the staff member is logged into Fairfield branch then only
suggestions submitted to Fairfield branch are displayed. 

This is incorrect because with IndependentBranches not enabled then the user
should be able to see all suggestions from all library branches and this is
when the 'Organise by' and 'Acquisition information' filters should have a
library option.  

Whereas when IndependentBranches syspref is set to 'yes' then all suggestions
from all library branches are displayed which is not correct. When
IndependentBranches is set to true then only the suggestions from the currently
logged in branch should be displayed. 

Regards 
Alex Buckley

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811

Michael Cabus  changed:

   What|Removed |Added

 CC||mich...@bywatersolutions.co
   ||m

--- Comment #12 from Michael Cabus  ---
When I run perl misc/maintenance/auth_show_hidden_data.pl -c I get this error:

DBIx::Class::ResultSet::find(): find() expects either a column/value hashref,
or a list of values corresponding to the columns of the specified unique
constraint 'primary' at /home/vagrant/kohaclone/Koha/Objects.pm line 85

Checked Authorities schema and all seemed well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18888] New: Include the definition of currency in onboarding tool

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Bug ID: 1
   Summary: Include the definition of currency in onboarding tool
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

At present when installing Koha currencies are only defined if the user decides
to install them whilst going through the web installer.

Currencies are important because they are used in the acquisition and fines
module and so they should be set up in the onboarding tool with the creation of
the library, patron category, patron administrator, item type and circulation
rule

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850

Jacqueline  changed:

   What|Removed |Added

 CC||jacqueline@bywatersolutions
   ||.com

--- Comment #1 from Jacqueline  ---
This is also showing up when receiving items.

Example:
When receiving a new shipment the shipping funds display as an option ONLY
active funds. There is an option to show inactive funds as well.

In another screen at the invoice detail level---the pull down menu to shipping
costs shows ALL inactive and active funds. This can be a problem if you have to
edit shipping cost and you use the same duplicated fund structure year after
year. Would be nice to have only active funds shown here and then have the
option check box as the prior screen to show inactive funds IF you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #12 from Marcel de Rooy  ---
Applying: Bug 18881: Remove dead code in circ/view_holdsqueue.pl
fatal: sha1 information is lacking or useless (circ/view_holdsqueue.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #11 from Marc Véron  ---
Created attachment 64761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64761=edit
Bug 18881: Remove dead code in circ/view_holdsqueue.pl

Remove a line of dead code from circ/view_holdsqueue.pl

To test:
- Apply patch
- Go to Home > Circulation > Holds queue
- Verify that description in Item type column displays as before
- Create a translation for an item type:
  Home > Administration > Item types > Modify item type 'BK'
  There you have a link 'Translate into other languages' to create translations
  To test, you can even 'translate' for English to overwrite the original
  description.
- Verify that the translated descriptions displays when changing the language
  as appropriate
- For an explanation how translation of item types descriptions work and why
  it is not done with Pootle see comment #7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

  Attachment #64726|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED
Summary|Change comment about|Remove dead code in
   |translated itemtype |circ/view_holdsqueue.pl
   |description in  |
   |circ/view_holdsqueue.pl |

--- Comment #10 from Marc Véron  ---
(In reply to Marcel de Rooy from comment #9)
> If we remove this comment, some day somebody wonders again why we do not use
> the translated description.
> So instead of removing I would opt for adding a legitimate reason why we
> really do not want a translation.

The translation takes place by overlaying in the template, using the itemtype.
The whole line is dead code.

Changed bug title as appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Change comment about translated itemtype description in circ/ view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

Summary|Remove comment about|Change comment about
   |translated itemtype |translated itemtype
   |description in  |description in
   |circ/view_holdsqueue.pl |circ/view_holdsqueue.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Needs Signoff   |Failed QA

--- Comment #9 from Marcel de Rooy  ---
If we remove this comment, some day somebody wonders again why we do not use
the translated description.
So instead of removing I would opt for adding a legitimate reason why we really
do not want a translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18886] Restructure storage of circulation rules to reduce complexity and enable increased flexiblity

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||18887


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887
[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18887] New: Introduce new table 'circulation_rules', use for ' max_holds' rules

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Bug ID: 18887
   Summary: Introduce new table 'circulation_rules', use for
'max_holds' rules
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
Blocks: 18886


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886
[Bug 18886] Restructure storage of circulation rules to reduce complexity and
enable increased flexiblity
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9409] koha-create --request-db should be able to accept a dbhost option

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409

Lee Jamison  changed:

   What|Removed |Added

 CC||ldjami...@marywood.edu
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9409] koha-create --request-db should be able to accept a dbhost option

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409

Lee Jamison  changed:

   What|Removed |Added

  Attachment #64560|0   |1
is obsolete||

--- Comment #3 from Lee Jamison  ---
Created attachment 64760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64760=edit
Bug 9409: Add --dbhost parameter and dbhost field

This allows setting the remote db host correctly for
request-db either with a command-line or passwd file.

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

Lee Jamison  changed:

   What|Removed |Added

 CC||ldjami...@marywood.edu

--- Comment #10 from Lee Jamison  ---
The 18002 dependency applies cleanly (tested during this bug as well as tested
18002 independently as well). However, this bug does not apply. See merge
conflict message below.

Applying: Bug 18060 - Label onboarding tool to be displayed when no labels or
templates exist
Using index info to reconstruct a base tree...
M   C4/Budgets.pm
M   acqui/acqui-home.pl
M   admin/aqbudgetperiods.pl
M   admin/aqbudgets.pl
M   admin/currency.pl
M   koha-tmpl/intranet-tmpl/prog/css/staff-global.css
M   koha-tmpl/intranet-tmpl/prog/en/includes/budgets-active-currency.inc
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
:749: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc
CONFLICT (add/add): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude2.inc
CONFLICT (add/add): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude2.inc
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude1.inc
CONFLICT (add/add): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude1.inc
Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/css/staff-global.css
Failed to merge in the changes.
Patch failed at 0001 Bug 18060 - Label onboarding tool to be displayed when no
labels or templates exist
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-18060---Label-onboarding-tool-to-be-displayed--p4jDwr.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|15221   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221
[Bug 15221] SIP server always sets the alert flag
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15221] SIP server always sets the alert flag

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|15522   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
[Bug 15522] New interface for revamped circulation rules
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15521] Make circulation rules backend more granular

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||18886
 CC||k...@bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886
[Bug 18886] Restructure storage of circulation rules to reduce complexity and
enable increased flexiblity
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18886] Restructure storage of circulation rules to reduce complexity and enable increased flexiblity

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15521


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521
[Bug 15521] Make circulation rules backend more granular
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18886] Restructure storage of circulation rules to reduce complexity and enable increased flexiblity

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||15522


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
[Bug 15522] New interface for revamped circulation rules
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||18886


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886
[Bug 18886] Restructure storage of circulation rules to reduce complexity and
enable increased flexiblity
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18886] Restructure storage of circulation rules to reduce complexity and enable increased flexiblity

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||15524


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524
[Bug 15524] Set limit on maximum possible holds per patron by category
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||18886


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886
[Bug 18886] Restructure storage of circulation rules to reduce complexity and
enable increased flexiblity
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18886] New: Restructure storage of circulation rules to reduce complexity and enable increased flexiblity

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886

Bug ID: 18886
   Summary: Restructure storage of circulation rules to reduce
complexity and enable increased flexiblity
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

This report is an omnibus bug for the Circulation Rules Revamp as defined on
the wiki (
https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC
)

The rough outline to complete this is as follows:
1) Create new circ rules table that will eventually replace all existing rule
tables including but not limited to:
issuingrules
branch_borrower_circ_rules
branch_item_rules
default_borrower_circ_rules
default_branch_circ_rules
default_branch_item_rules
default_circ_rules
refund_lost_item_fee_rules

2) Transfer circ rules behavior over to the new table one rule at a time ( or
as groups of logically connected rules ) in separate bug reports / patch sets
to make testing and qa. The interface will remain unaltered at this point.

3) Update the rules editor interface to allow more flexibility in the way rules
are set, solve the issue of the "ever widening" rules table

4) Unleash the full power of the Koha's circulation rules by "decoupling" the
rule sets. At the moment, a full set of rules is tied to each
branch/borrower/item combo. Even if all the rules except a single column are
the same, a full set is currently created for each combination. We should be
able to set all the rules for */*/* *except* for that single rule ( e.g. loan
length ) thus greatly simplifying the rules needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #8 from M. Tompsett  ---
(In reply to Marc Véron from comment #7)
> Maybe there is a misunderstanding.

Perhaps. I'll just remove myself for the conversation. Please continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64756|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 64759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64759=edit
Bug 18882 [QA Followup] - Ensure stats with no or undef location are set to
NULL in db

Confirm that only NULL or a string are in the location field of the
statistics table. Test with two items, one with shelving location set,
and one without it set.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64727|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 64758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64758=edit
Bug 18882 - Add location code to statistics table for checkouts and renewals

Some libraries wish to track what the current location of items was at the time
they were checked out. This will help libraries track which physical locations
in the library patrons are more likely to check out a given book from.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Check out an item that has a location set
4) Renew that item
5) View the checkout and renewal in the statistics table,
   verify each has the location column populated correctly

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18735] Print Barcode as soon as adding an item

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735

DEVINIM  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Lee Jamison  changed:

   What|Removed |Added

  Attachment #64266|0   |1
is obsolete||

--- Comment #27 from Lee Jamison  ---
Created attachment 64757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64757=edit
Bug 15438 [Alternate Solution] - Checking out an on-hold item sends holder's
borrowernumber in AF (screen message) field.

Description: Let's say that 'Holding Patron' puts a hold on title 'ASDF'. If
'SIP  Patron' then tries to check out ASDF, Holding Patron's card number
appears in the AF (i.e. Screen Message) field. This only occurs if the hold has
*not* yet been finalized -- If ASDF is waiting for Holding Patron, the screen
message will read "Item is on hold shelf for another patron."

The screen message containing only the Holding Patron's borrowernumber is
confusing because a) It contains no context as to the nature of the number
showing on the screen b) SIP devices work with borrower card numbers, so the
number being returned has the wrong context. Furthermore, we're leaking patron
information in a place where we probably would never check.

Replicating the problem:

Set up instance with two patrons, as well as a bib/item to put on hold/check
out.
Make sure that circ rules allow holds.
Set up SIPconfig.xml to allow checkouts on the IP/port of your choice.
Start SIP2. Make sure that authentication, checkin and check out work for the
'SIP Patron'.
Ensure that AllowItemsOnHoldCheckout is set to "Don't Allow".

In the steps to replicate, the Title/barcode of the item on hold/being checked
out will be 'asdf'. The Holding Patron will be referred to as 'holder' and the
checkout patron will be referred to as 'sipper'. Let's say that sipper's
borrowernumber is 52.

1/ Place a biblio level hold for asdf, with holder as the holding patron.
2/ Start `sudo tail -f /var/log/syslog | grep sip`
3/ Attempt to check out asdf to sipper. You will see the sip checkout message
'11...' followed by a '120...|AF52|...' sip checkout response. This indicates
that the checkout has failed (which we would expect), and that the screen
message is '52'.

Example using ./misc/sip_cli_emulator.pl

$ ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su staff -sp staff -l CPL
--patron 23529001223636
--password 1234 --item 1234 -m checkout
Attempting socket connection to 127.0.0.1:6001...connected!
SEND: 9300CNstaff|COstaff|CPCPL|
READ: 941

Trying 'checkout'
SEND: 11YN2015122905321120151229   
053211AOCPL|AA23529001223636|AB1234|ACstaff|AD1234|BON|BIN|
READ: 120NUN20151229053211AOCPL|AA23529001223636|AB1234|AJTheories of human
development :|AH|AF52|BLY|BV5.00|BHUSD|BT06|

Works as directed based on the replication steps.
Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #20 from M. Tompsett  ---
The issue isn't the XSLT sysprefs per say.
The issue is the item-itype system preference.
Toggle that in your testing too!
And make sure to have 2 records one with a biblio level item type and another
with an item level item type.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #4 from Kyle M Hall  ---
(In reply to M. Tompsett from comment #2)
> The code puts '' if there is no location key. But if the location key is
> NULL, because I hadn't set my shelving location, there is NULL. Do we want
> NULL's? If so, I'll sign this off. If not, could you tweak that?

I think we should always use NULL is the location is not passed or is set to
undef. It seems like odd behavior to convert undef values to empty strings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

--- Comment #3 from Kyle M Hall  ---
Created attachment 64756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64756=edit
Bug 18882 [QA Followup] - Ensure stats with no or undef location are set to
NULL in db

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

--- Comment #13 from M. Tompsett  ---
Squashed and shortened commit message as per comment #10.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64753|0   |1
is obsolete||
  Attachment #64754|0   |1
is obsolete||

--- Comment #12 from M. Tompsett  ---
Created attachment 64755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64755=edit
Bug 18771: CGI.pm: Subroutine multi_param redefined

The commands in the test plan are examples, and may need varying
depending on your installation. This was created as a result
of attempting to clean the installation process up. However,
I believe the redefine might exist normally too. I just didn't
check. This is tested on a Debian 8 box sudo apt-get update'd
fully.

TEST PLAN
-
empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

drop and recreate and empty db
> drop database koha_library;
> create database koha_library;
> quit

run the web installer, but DO NOT LOG IN!
*opening chrome to Staff Client URL*

check the error log
$ less ~/koha-dev/var/log/koha-error_log
...
[Fri Jun 09 13:08:52.793627 2017] [cgi:error] [pid 5802] [client
192.168.71.101:58169] AH01215: [Fri Jun  9 13:08:52 2017] CGI.pm: Subroutine
multi_param redefined at /usr/share/perl5/CGI.pm line 419.
...

apply patch

empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

refresh the installation login page

recheck the error log
$ less ~/koha-dev/var/log/koha-error_log

notice no reference to "Subroutine multi_param redefined"

run koha qa test tools

Notice that it is just a require CGI; and comment added.

Signed-off-by: Lee Jamison 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

--- Comment #11 from M. Tompsett  ---
(In reply to Marcel de Rooy from comment #10)
> Would certainly not oppose to squash both patches and reduce the verbosity
> of the commit message now. The point has been made very clear. Thx Mark!

Sometimes during the course of doing a patch, you need to show the intermediate
work. Since this has passed QA, I concur that a squash is in order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

--- Comment #7 from Fiona Borthwick  ---
I definitely think a separate permission to manage suggestions would be very
welcome. We have a range of customers who make use of purchase suggestions but
want to have the ability to control which members of the staff can actually
manage the suggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

--- Comment #5 from Baptiste  ---
Sorry I changed them again after my last test to check icons where displayed
(only alternate test can be displayed on the sandbox).

However with all system preferences set to default, I can't see the icons. I
can't test the Marc21 outside this sandbox, so if it don't work I can't really
sign off your patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #19 from Fridolin SOMERS  ---
(In reply to Baptiste from comment #18)
> I don't see any difference between  DisplayIconsXSLT setted and not setted,
> in all case, all icons are displayed in intranet results and not in intranet
> details.
> 
> I tested on this sandbox because I have locally no Marc21:
> http://pro.user03-koha.sandbox.biblibre.eu/cgi-bin/koha/catalogue/detail.
> pl?biblionumber=73=scs_1498810298579
> 
> If you have an idea of what went wrong.. ;)

XSLT sysprefs are empty on this sandbox, use "default"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18852] Installation is inoperative even after fresh install

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18852

--- Comment #2 from C.J.S. Hayward  ---
>From a mailing list response, after things are working:

--

Tim Young 
8:56 PM (17 hours ago)

to koha 
Hi,

This sounds like it is because of an odd "feature" of mysql which is not always
present.

This page:
https://askubuntu.com/questions/766334/cant-login-as-mysql-user-root-from-normal-user-account-in-ubuntu-16-04

with the answer from "Todor", explains that mysql will change over to using an
auth_socket "plugin."  So, instead of using password authentication, part of
the permission is blocked by unix file-level permissions.

The simple solution:

   sudo mysql -u root
   update mysql.user set plugin = 'mysql_native_password' where User='root';
   FLUSH PRIVILEGES;

Then you should be able to connect up as root even if you are not a root user.

After that, you should be able to run the script.

- Tim

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18527] Add a system preference to exclude renewals from the quick slip

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Baptiste  changed:

   What|Removed |Added

 CC||baptiste.wojtkowski@biblibr
   ||e.com

--- Comment #2 from Baptiste  ---
This works as expected, but:
1 - Shouldn't be the syspref setted by default to 0 (old behaviour)
2 - I think the file installer/data/mysql/atomicupdate/ is missing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Baptiste  changed:

   What|Removed |Added

 CC||baptiste.wojtkowski@biblibr
   ||e.com

--- Comment #4 from Baptiste  ---
5) Set the new max holds rule to X for "All libraries"

Do you mean in the first array ? I don't find any other, but if it is this is
not really intuitive

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

--- Comment #10 from Marcel de Rooy  ---
Would certainly not oppose to squash both patches and reduce the verbosity of
the commit message now. The point has been made very clear. Thx Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

--- Comment #9 from Marcel de Rooy  ---
Created attachment 64754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64754=edit
Bug 18771: CGI.pm: Subroutine multi_param redefined

TEST PLAN
-
Follow the test plan on the first patch.

Notice that with both patches applied, it is just a require CGI;
and comment added.

Signed-off-by: Lee Jamison 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64729|0   |1
is obsolete||
  Attachment #64730|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 64753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64753=edit
Bug 18771: CGI.pm: Subroutine multi_param redefined

The commands in the test plan are examples, and may need varying
depending on your installation. This was created as a result
of attempting to clean the installation process up. However,
I believe the redefine might exist normally too. I just didn't
check. This is tested on a Debian 8 box sudo apt-get update'd
fully.

TEST PLAN
-
empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

drop and recreate and empty db
> drop database koha_library;
> create database koha_library;
> quit

run the web installer, but DO NOT LOG IN!
*opening chrome to Staff Client URL*

check the error log
$ less ~/koha-dev/var/log/koha-error_log
...
[Fri Jun 09 13:08:52.793627 2017] [cgi:error] [pid 5802] [client
192.168.71.101:58169] AH01215: [Fri Jun  9 13:08:52 2017] CGI.pm: Subroutine
multi_param redefined at /usr/share/perl5/CGI.pm line 419.
...

apply first patch

empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

refresh the installation login page

recheck the error log
$ less ~/koha-dev/var/log/koha-error_log

[Fri Jun 09 12:59:06.705954 2017] [cgi:error] [pid 5692] [client
192.168.71.101:57887] AH01215: Low version
[Fri Jun 09 12:59:06.723323 2017] [cgi:error] [pid 5692] [client
192.168.71.101:57887] AH01215: Is actually: 4.09
...

notice that 4.09 is bigger than the 4.08 condition, and that
the code was triggered because $CGI::VERSION is undefined,
since there was no require to set the VERSION value.

apply second patch

empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

refresh the installation login page

recheck the error log
$ less ~/koha-dev/var/log/koha-error_log

notice no reference to "Subroutine multi_param redefined"

run koha qa test tools

Signed-off-by: Lee Jamison 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #20 from Marcel de Rooy  ---
Created attachment 64752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64752=edit
Bug 17738: [QA Follow-up] Remove second find of same patron

We can just use the $patron from line 77 here.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64332|0   |1
is obsolete||

--- Comment #19 from Marcel de Rooy  ---
Created attachment 64751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64751=edit
Bug 17738: Remove warning about redeclaration of $patron

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64330|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 64749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64749=edit
Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds

This patch replace the different calls to GetReservesFromBorrowernumber
with a calls to Koha::Patron->get_holds.
In some places we need to get a restricted set of holds, that's why we
process a search on this holds returned by ->get_holds (on the found
status for instance).

The changes are quite trivial and reading the diff should be enough to
catch bugs.

Test plan:
I would suggest to test this patch with patches from bug 17736 and bug 17737,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

Tested both patches together, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #62188|0   |1
is obsolete||
  Attachment #62189|0   |1
is obsolete||
  Attachment #62219|0   |1
is obsolete||

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #14 from Kyle M Hall  ---
Created attachment 64330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64330=edit
Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds

This patch replace the different calls to GetReservesFromBorrowernumber
with a calls to Koha::Patron->get_holds.
In some places we need to get a restricted set of holds, that's why we
process a search on this holds returned by ->get_holds (on the found
status for instance).

The changes are quite trivial and reading the diff should be enough to
catch bugs.

Test plan:
I would suggest to test this patch with patches from bug 17736 and bug 17737,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

Tested both patches together, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

--- Comment #15 from Kyle M Hall  ---
Created attachment 64331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64331=edit
Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

At this point, there should not be any occurrences of
GetReservesFromBorrowernumber anymore.

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

--- Comment #16 from Kyle M Hall  ---
Created attachment 64332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64332=edit
Bug 17738: Remove warning about redeclaration of $patron

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64331|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy  ---
Created attachment 64750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64750=edit
Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

At this point, there should not be any occurrences of
GetReservesFromBorrowernumber anymore.

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18885] Onsite Checkout has a weird behaviour concerning sticky due date

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

Baptiste  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18885] Onsite Checkout has a weird behaviour concerning sticky due date

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

--- Comment #1 from Fridolin SOMERS  ---
Linked to Bug 10067 and Bug 16527

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18885] Onsite Checkout has a weird behaviour concerning sticky due date

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18885] Onsite Checkout has a weird behaviour concerning sticky due date

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

Baptiste  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |baptiste.wojtkowski@biblibr
   |ity.org |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18885] Onsite Checkout has a weird behaviour concerning sticky due date

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

Baptiste  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10067,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16527

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16527] Sticky due date calendar unexpected behaviour

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Baptiste  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18885

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #5 from Marcel de Rooy  ---
Koha/REST/V1/Hold.pm
Result of Koha::Biblios->find( $biblionumber ) is not tested, but result of
GetBiblio was not tested too before.
No blocker.

catalogue/imageviewer.pl
biblionumber is a CGI parameter here
find should be tested

Same for catalogue/issuehistory.pl
opac/opac-imageviewer.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Baptiste  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18885

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18885] New: Onsite Checkout has a weird behaviour concerning sticky due date

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

Bug ID: 18885
   Summary: Onsite Checkout has a weird behaviour concerning
sticky due date
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: baptiste.wojtkow...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When you perform an onsite checkout, the next checkout is pre-setted as
follows:
- Specify due date => today
- Onsite checkout => not checked

I don't think this is is a correct behaviour: according to me there are 3
solutions, but I don't know which is the best:
- Maintaining "onsite checkout" checked
- Don't change duedatespec in interface when onsite checout is clicked and
process it in the intranet part
- Remove the duedatespec on the new checkout page loading

This part of the code is really hard for me since it were patched and re
patched and I'm not sure of the expected behaviour of all lines, so I would
like some expert opinion before coding a solution

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #45 from Marc Véron  ---
(In reply to Alex Buckley from comment #44)
> Thanks for testing and the feedback Marc
> 
> At present the currency is not set in the onboarding process and will only
> be set if the user chooses to install currencies in the web installer.
> 
> However the creation of a currency in the onboarding too could be a good
> enhancement to the onboarding tool I will make a bug report for that if you
> like?

+1 :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16497] REST API: add routes to list libraries

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Assignee|koha-b...@lists.koha-commun |m...@jkozlovsky.cz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #49 from Marcel de Rooy  ---
Add checks for find please.

Can't call method "biblio" on an undefined value at circ/circulation.pl line
334.

Before this patch set you get a warning on an unknown barcode, now an Internal
server error..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #48 from Marcel de Rooy  ---
Created attachment 64748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64748=edit
Bug 18276: [QA Follow-up] Two newlines to make qa tools happy

FAIL pod Apparent command =cut not preceded by blank line in file
misc/cronjobs/advance_notices.pl
FAIL pod Apparent command =cut not preceded by blank line in file
C4/SIP/ILS/Item.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #44 from Alex Buckley  ---
Thanks for testing and the feedback Marc

At present the currency is not set in the onboarding process and will only be
set if the user chooses to install currencies in the web installer.

However the creation of a currency in the onboarding too could be a good
enhancement to the onboarding tool I will make a bug report for that if you
like?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #47 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18002

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=4078

--- Comment #43 from Marc Véron  ---
(In reply to Marc Véron from comment #42)
> The active currency must have an exchange rate of 1.
> However, the wizard allows to enter a different value.

I think 
- the checkbox "Active" should be checked and read-only (maybe hidden?)
- the exchange rate should be set to 1 and read-only (maybe hidden?)

BTW I'm not sure, should not the currency be already defined in the onboarding
process immediately after installing? - Since the active currency is important
not only for acquisition, but should / will be used for fines etc. as well (at
least the symbol), see Bug 4078.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61528|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 64747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64747=edit
Bug 18235: DBIx schema changes

Fresh changes for SearchField, facet_order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #10 from Marcel de Rooy  ---
If I select say Author and set them all to Facetable No in the Search fields
list on the Biblios tab, I would not expect Author to be still in the Facet
order list?

Changing status for feedback

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #42 from Marc Véron  ---
The active currency must have an exchange rate of 1.
However, the wizard allows to enter a different value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #71 from Marcel de Rooy  ---
Can we rearrange these patches too?
All patches that should not be pushed together? 0009?
All patches for modules and for scripts or so ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

2017-06-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Baptiste  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #18 from Baptiste  ---
I don't see any difference between  DisplayIconsXSLT setted and not setted, in
all case, all icons are displayed in intranet results and not in intranet
details.

I tested on this sandbox because I have locally no Marc21:
http://pro.user03-koha.sandbox.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?biblionumber=73=scs_1498810298579

If you have an idea of what went wrong.. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 118 matches

Mail list logo