[Koha-bugs] [Bug 19418] Patron search is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19418 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #7 from Marc Véron --- Created attachment 67864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67864&action=edit Screenshot with frozen patron search "Processing" Tested on current master with Plack. The problem seems to happen arbitrarily. See screenshot attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 Josef Moravec changed: What|Removed |Added Attachment #67857|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 67863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67863&action=edit Bug 19431: Fix error when checking out an unknown barcode It seems this has been caused by commit 1544f9a5d4a8acd47c97d7c6ac55dee8e759d3ff Bug 18276: Remove GetBiblioFromItemNumber - circulation pages To reproduce the problem you need switch on the two prefs - OnSiteCheckouts - OnSiteCheckoutsForce Test plan: Try to check an item out using an unknown barcode With the 2 prefs set to on and without this patch, you will get the following error in the log Can't call method "materials" on an undefined value at /home/vagrant/kohaclone/circ/circulation.pl line 387. With this patch applied you should not get this error and a correct behaviour for the different pref combinations. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766
--- Comment #21 from Aleisha Amohia ---
(In reply to Katrin Fischer from comment #19)
> There seems to be a bug in this patch set. I have run the database update
> and restart_all, but when I click on "Save description" there is no visual
> feedback and nothing happens.
>
> Also internal server error when I try to save my patron card batch:
> DBD::mysql::st execute failed: called with 4 bind variables when 5 are
> needed [for Statement "INSERT INTO creator_batches (batch_id, description,
> borrower_number, branch_code, creator) VALUES (?,?,?,?,?);" with
> ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
> Database returned the following error on attempted INSERT: called with 4
> bind variables when 5 are needed at
> /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73.
> Can't use string ("-2") as a HASH ref while "strict refs" in use at
> /home/vagrant/kohaclone/patroncards/edit-batch.pl line 124.
Hi Katrin,
Everything still works for me and I can't see this error when I test. Is
someone else please able to test and see if they can replicate this error?
On the other hand you did make me realise that I hadn't made the fix from
comment 18 on the patroncard side, so I've implemented that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #20 from Aleisha Amohia --- Created attachment 67862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67862&action=edit Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19429] No confirm message when deleting an invoice from invoice search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19429] No confirm message when deleting an invoice from invoice search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19429] No confirm message when deleting an invoice from invoice search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429 --- Comment #1 from Aleisha Amohia --- Created attachment 67861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67861&action=edit Bug 19429: Adding confirm message when deleting invoice from invoice search page To test: To test: 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Delete 5) Notice invoice is deleted instantly 6) Apply patch and repeat steps 3 and 4 7) Confirm the confirm message shows and works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #45 from Srdjan Jankovic --- I've added a patch with some limited value. And another seemingly unrelated, which you may choose to apply or drop depending on the policies/feelings. My position is that as is any proper automated testing would be difficult and expensive in terms of effort. Considering it is a niche area, I doubt it is worth it. If it is any comfort you can take my word that automated tests for WebService::ILS are passing. It is unfortunate that I started this work at the time when api was not established. The right thing would be to move svc code to api/v1, at which point it would be much easier and make sense to do Mojo tests. But again, would it be worth the effort. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #44 from Chris Cormack --- (In reply to Jonathan Druart from comment #41) > (In reply to Tomás Cohen Arazi from comment #39) > > Regarding the whole patchset, I'd say tests coverage is not good enough. And > > having the tests require valid credentials for the proprietary external > > system seems too much. There are two options IMHO: > > > > - If the provider does have a sandbox/testbed infrastructure, use it > > - If it doesn't, keep the tests (which skip if credentials are missing) but > > add new db-independent tests with mocked behaviour for WebService::ILS. > > Auth_with_ldap.t can be a good source of examples for completely mocking the > > tests. > > Chris, Srdjan, any ideas how we could improve that? > Can someone share the test credentials with me? We have no contractual relationship, or any clients who use it. It is probably best to talk to Bywater or someone who have clients that might have a test account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #43 from Srdjan Jankovic --- Created attachment 67860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67860&action=edit t/Koha_ExternalContent_OverDrive.t correction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #42 from Srdjan Jankovic --- Created attachment 67859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67859&action=edit Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18884] Advanced search on staff client, Availability limit not properly limiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884 --- Comment #4 from David Cook --- Note that the fix I've done isn't exactly the one that the OP asked for. "branch" is actually mapped to "homebranch" in ccl.properties, and the "Individual libraries" limit in the staff client advanced search has always used "branch:". If one wanted to differentiate between holding branch and home branch, I think that would be an enhancement, whilst my patch simply fixes a regression. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18884] Advanced search on staff client, Availability limit not properly limiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884 --- Comment #3 from David Cook --- Created attachment 67858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67858&action=edit Bug 18884 - Advanced search on staff client, Availability limit not properly limiting Bug 15758 accidentally removed the branch: prefix off the individual library limits on the advanced search in the staff client. This patch adds an optional prefix to the html_helpers.inc file, so that advsearch.tt can provide the required "branch:" prefix. _TEST PLAN_ Before applying: 0) Make sure you have branches in your Koha (e.g. select all sample data via web installer initially) 1) View the source on the staff client advanced search, and note that the "branch:" prefix is missing from the individual library limit: Centerville 3) Apply the patch 4) Refresh the advanced search page 5) View the source on the staff client advanced search, and note that the "branch:" prefix now appears for the individual library limit: Centerville -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18884] Advanced search on staff client, Availability limit not properly limiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18884] Advanced search on staff client, Availability limit not properly limiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15758 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18884 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18884] Advanced search on staff client, Availability limit not properly limiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- (In reply to Mark Alexander from comment #1) > I ran into this problem today on 17.05.01. > > The workaround I came up with was to create a library group, and add to this > group the specific library I wanted to search. Then in the search form, I > selected that library group. > > I'm not familiar with the code, but I did take a quick look, and couldn't > see a way to fix this just in advsearch.tt. The language limit is handled > correctly there through the use of a FOREACH loop that inserts "ln,rtrn:" in > front of the language name in the option value. But the branch limit is > handled by a call to options_for_libraries. That function, in > html_helpers.inc, doesn't seem to allow a prefix to be inserted in front of > the option value. > > So it looks like the branch selector in advsearch.tt should have a name > other than "limit", and in search.pl this param should be handled separately > from the other "limit" params, by inserting the prefix > "limit=holdingbranch:" in front of the branch name. > > Of course, due to my ignorance, I could be entirely wrong about all this :-) > . It's definitely a regression introduced by Bug 15758: -[% FOREACH branchloo IN branchloop %] -[% IF ( branchloo.selected ) %] -[% branchloo.branchname %] -[% ELSE %] -[% branchloo.branchname %] -[% END %] -[% END %] +[% PROCESS options_for_libraries libraries => Branches.all() %] I think I'll just write a patch to add an optional prefix to html_helpers.inc to restore the original syntax. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #134 from David Cook --- This patch introduces a regression to the branch limit in the staff client advanced search. (The OPAC masthead search is ok and I think OPAC advanced search is too, but need to double-check.) More details at Bug 18884... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 Jonathan Druart changed: What|Removed |Added Depends on||18276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What|Removed |Added Blocks||19431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 [Bug 19431] Error when trying to checkout an unknown barcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 --- Comment #2 from Jonathan Druart --- Created attachment 67857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67857&action=edit Bug 19431: Fix error when checking out an unknown barcode It seems this has been caused by commit 1544f9a5d4a8acd47c97d7c6ac55dee8e759d3ff Bug 18276: Remove GetBiblioFromItemNumber - circulation pages To reproduce the problem you need switch on the two prefs - OnSiteCheckouts - OnSiteCheckoutsForce Test plan: Try to check an item out using an unknown barcode With the 2 prefs set to on and without this patch, you will get the following error in the log Can't call method "materials" on an undefined value at /home/vagrant/kohaclone/circ/circulation.pl line 387. With this patch applied you should not get this error and a correct behaviour for the different pref combinations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Cheryl changed: What|Removed |Added CC||clack...@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19424] XISBN.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19424 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 19440 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 --- Comment #4 from Jonathan Druart --- *** Bug 19424 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Jonathan Druart changed: What|Removed |Added CC||m...@kohaaloha.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com --- Comment #6 from Jonathan Druart --- Mason, there are too much tests failing on 16.05.x, you really need to make sure the tests do not fail before you push stuffs. These patches should take care of most of the failures. After them, only ES-related tests will fail, I did not manage to find the cause of the problem (Nick maybe?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Jonathan Druart changed: What|Removed |Added Version|unspecified |16.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #4 from Jonathan Druart --- Created attachment 67855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67855&action=edit Bug 19441: Fix t/db_dependent/Biblio/Isbd.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #5 from Jonathan Druart --- Created attachment 67856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67856&action=edit Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t Koha::Caches and Koha::MarcSubfieldStructures do not exist in 16.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #3 from Jonathan Druart --- Created attachment 67854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67854&action=edit Bug 19441: Fix AutomaticItemModificationByAge.t Koha::Caches does not exist in 16.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #2 from Jonathan Druart --- Created attachment 67853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67853&action=edit Bug 19441: Fix AuthorisedValues.t Koha::AuthorisedValueCategor[y|ies] do not exist in 16.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #1 from Jonathan Druart --- Created attachment 67852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67852&action=edit Bug 19441: Fix xt/sample_notices.t fr-CA is not up-to-date: - RESERVESLIP have been renamed with HOLD_SLIP - PASSWORD_RESET and MEMBERSHIP_EXPIRY are not defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19441] New: Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Bug ID: 19441 Summary: Several tests are failing on 16.05.x Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org xt_sample_notices_t.No sample notice to add xt_sample_notices_t.No sample notice to delete t_db_dependent_XISBN_t.Gets correct biblionumber from a book with a similar isbn using XISBN t_db_dependent_Template_Plugin_AuthorisedValues_t t_db_dependent_Items_AutomaticItemModificationByAge_t t_db_dependent_Biblio_Isbd_t t_db_dependent_SIP_Message_t t_db_dependent_Koha_SearchEngine_Elasticsearch_Search_t t_db_dependent_Koha_SearchEngine_Elasticsearch_Search_t t_db_dependent_00_strict_t.Syntax check misc/search_tools/rebuild_elastic_search.pl t_db_dependent_Koha_Elasticsearch_Indexer_t t_db_dependent_Koha_Elasticsearch_Indexer_t t_db_dependent_Biblio_TransformKohaToMarc_t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #41 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #39) > Regarding the whole patchset, I'd say tests coverage is not good enough. And > having the tests require valid credentials for the proprietary external > system seems too much. There are two options IMHO: > > - If the provider does have a sandbox/testbed infrastructure, use it > - If it doesn't, keep the tests (which skip if credentials are missing) but > add new db-independent tests with mocked behaviour for WebService::ILS. > Auth_with_ldap.t can be a good source of examples for completely mocking the > tests. Chris, Srdjan, any ideas how we could improve that? Can someone share the test credentials with me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #65 from Jonathan Druart
---
Some adjustments are required:
1. Update DB entry must use column_exists()
2. t/db_dependent/Acquisition/CancelReceipt.t and
t/db_dependent/Acquisition/TransferOrder.t are failing with
Can't use string ("Koha::Acquisition::Order") as a HASH ref while "strict
refs" in use at /home/vagrant/kohaclone/Koha/Object.pm line 275.
3. Koha::EDI and circ/reserveratios.pl are still using AcqCreateItem from the
pref
4. On basketheader.pl?booksellerid=1&op=add_form, the values for the dropdown
"Create items when:" ended with a '.'
I'd say it should be removed or moved out the options.
5. This looks like a typo (basketheader.tt):
-
+
6. Koha::Acquisition::Order->basket must use DBIx::Class rs
7. Double check the code in addorderiso2709, it is buggy (GetBasket and
Koha::Baskets->find calls)
Can't call method "effective_create_items" on unblessed reference at
/home/vagrant/kohaclone/acqui/addorderiso2709.pl line 107.
8. Change in acqui/basket.pl is not needed (basket passed twice to the
template)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #112 from Jonathan Druart --- Please rebase Applying: Bug 14826: Add unit tests for _FixAccountForLostAndReturned and _FixOverduesOnReturn error: sha1 information is lacking or useless (t/db_dependent/Circulation.t). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Radek Šiman (R-Bit Technology, s.r.o.) changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 --- Comment #46 from Radek Šiman (R-Bit Technology, s.r.o.) --- Created attachment 67850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67850&action=edit Bug 17492: (followup) Fixed broken layout of the patron detail page Test plan: 1) apply this patch 2) open eg. /cgi-bin/koha/members/moremember.pl?borrowernumber=3 3) tabbed menu (checkout, details, fines, etc.) should be displayed on the left side of the page not at the bottom -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 --- Comment #47 from Radek Šiman (R-Bit Technology, s.r.o.) --- Created attachment 67851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67851&action=edit Bug 17492: (followup) Logic moved to Koha namespace Test plan: 1) Apply patch 2) Create a patron and assign him a category having age limits set 3) Change patron's age to be older/younger than category's limits 4) At "Check out" and "Details" tabs you should see a warning with a button allowing to change the category, eg.: - http://prntscr.com/cz7ch3 - http://prntscr.com/cz7em4 - http://prntscr.com/cz7dj1 5) Set a valid category according to patron's age 6) Warning should disappear 7) Perform similar test again, but instead of changing the age change the limits of a category 8) During tests verify "Change category" button everytime opens "Modify patron" page: http://prntscr.com/cz7g5q 9) Ensure that left-side panel is always on its expected place -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #47 from Tomás Cohen Arazi --- Ping Katrina, last followup is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 --- Comment #46 from Tomás Cohen Arazi --- Created attachment 67849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67849&action=edit Bug 18996: (followup) Fix tests count [16.11.x] This patch fixes a wrong tests count introduced on merging. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19437] Rearrange CancelExpiredReserves tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19437 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on biblioserver since 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19397] Release team 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19340] Transferred orders show incorrect basket in transferred from/ to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19371] Change template table column text from 'Delete?' to 'Cancel?' on the patron circulation page holds tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19367] $biblio variable redefined in same scope in ISBDdetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19367 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19196] Add pagination helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #31 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19190] Silly calculation of average time in touch_all scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18916] Add pagination to top of search results in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18916 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #36 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14039] Add patron title to checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart --- Patches pushed to master, Thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 --- Comment #2 from Jonathan Druart --- Created attachment 67848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67848&action=edit Bug 19440: Existing calls need to be done in scalar context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #1 from Josef Moravec --- (In reply to Katrin Fischer from comment #0) > When trying to checkout an unknown barcode, I receive an internal server > error: > > Can't call method "materials" on an undefined value at > /home/vagrant/kohaclone/circ/circulation.pl line 387. > > It should ask me to do a fast add instead. For me, it asks for fast cataloguing the item - I can't reproduce it on my devbox... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 67847
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67847&action=edit
Bug 19440: Identify overlimit problems in XISBN tests
This patch makes C4::XISBN::get_xisbns() return an errors hashref
including information of the failing fetches from xisbn services.
It tackles the situation of XISBN, which in some cases returns 'overlimit'
errors.
The patch makes the relevant functions check if the response->{stat} string
is 'ok' and returns the string in $errors otherwise.
This only happens when in list context. This allows to fix the randomly failing
tests while keeping the current behaviour.
All this code should be rewritten. It does the job bug doesn't have problems
handling
or reoprting. This is just a band aid.
To test:
- Make sure
k$ prove t/db_dependent/XISBN.t
=> SUCCESS :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] New: XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 Bug ID: 19440 Summary: XISBN tests should skip if XISBN returns overlimit error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19340] Transferred orders show incorrect basket in transferred from/ to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||15531 --- Comment #4 from Jonathan Druart --- Looks like it has been caused by commit 9501ac2feffa8aca965fd24156560870df4065c3 Bug 15531: Add support for standing orders Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 [Bug 15531] Add support for standing orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15531] Add support for standing orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jonathan Druart changed: What|Removed |Added Blocks||19340 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 [Bug 19340] Transferred orders show incorrect basket in transferred from/to -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 --- Comment #4 from Katrin Fischer --- My fault, I should have read further, the first test plan I looked at didn't include it, but the last version of the commit message had full instructions: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974#c8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 --- Comment #3 from Katrin Fischer --- I looked at them, but was not sure what to make of this: 4. Ensure you have your selenium service running -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 --- Comment #2 from Jonathan Druart --- Alex wrote a complete test plan in all the commit messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #25 from Katrin Fischer --- Hi Tomas, what I meant is that the table displays dail limit = 0 for all circulation conditions existing pre-update. If 0 means unlimited it should display as such. If 0 means 0 we should fix the existing rules on update so they still work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19418] Patron search is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19418 --- Comment #6 from Alex Arnaud --- Seems that some people can reproduce the bug. The patch is quite tiny and make sense (just add use C4::Members::Attributes qw(SearchIdMatchingAttribute)) This could be quickly QAed/Pushed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on biblioserver since 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67788|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 67846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67846&action=edit Bug 19415: FindDuplicateAuthority is searching on biblioserver since 16.05 Commit b4392018bc1f9bf6a2f7dfe70b488856ad3a3897 [Bug 12478: make things using SimpleSearch use the new version] changed sub FindDuplicateAuthority and replaced this call (from 3.22.x) in 16.05 (pushed April 2016): my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); The new call does unfortunately not include the authorityserver: my ($error, $results, $total_hits) = $searcher->simple_search_compat( $query, 0, 1 ); Simple_search_compat redirects to C4/Search/SimpleSearch and SimpleSearch assumes a biblioserver if no server is passed. This effectively makes FindDuplicateAuthority useless since we will no longer find duplicates and we could see an error like this in the log: 16:51:42-04/10 zebrasrv(51) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @and @attr 1=authtype PERSO_NAME @attr 1=Heading Moerenhout The fix is obviously trivial. Test plan: [1] Go to Authorities. [2] Add a new authority PERSO_NAME with 100a Moerenhout. [3] Repeat step 2. Verify that you get the duplicate authority warning. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on biblioserver since 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Tomás Cohen Arazi changed: What|Removed |Added Summary|Integrate support for |Integrate support for |ONeclickDigital/Recorded|OneClickdigital/Recorded |Books API |Books API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #40 from Tomás Cohen Arazi --- I'm not sure how to deal with this kind of patchsets. I'm passing it to the RM. The functionality is the expected one. The main problem is the fact that the vendor is not providing good testing tools. I think it deserves to go in. The users sponsoring it will for sure make us improve it if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #24 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #17) > 1) Translations in mind, I suggest to make the message a bit more specific: > Daily limit reached for patron > > Daily hold limit reached for patron Fixed, thanks! > 2) If nothing is entered, it appears to default to 0 (instead of unlimited). > So I think this will break existing installations. I'd suggest to copy the > max holds total into max holds daily. This is intended, on purpose! Its the same behaviour allowedreserves has. 0 and undef mean the same in the code. If no daily (or zero) limit is defined, then the global one is used > 3) The tests are giving me trouble: > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t > t/db_dependent/Holds.t .. 26/59 # Looks like you planned 59 tests but ran 56. > t/db_dependent/Holds.t .. Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 3/59 subtests Fixed it, I guess some recent changes in Holds.t made this. Tests should pass noW! Thanks for the feedback! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67207|0 |1 is obsolete|| --- Comment #23 from Tomás Cohen Arazi --- Created attachment 67845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67845&action=edit Bug 15486: Modify request.tt to handle the new error string This patch makes reserve/request.pl display a convenient error description when a hold cannot be placed due to the new daily limit configuration. To test: - Apply this patchset - Upgrade - Configure your circulation rules so there's a daily limit for holds - Place holds so the patron reaches the maximum - Place one more hold - Notice the hold cannot be placed and a convenient error message is displayed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67205|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 67843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67843&action=edit Bug 15486: Unit tests This patch introduces unit tests for the new circulation rules option that allows setting a max holds per day limit. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: CanItemBeReserved doesn't check the amount of holds per day and the introduced error code is not returned. OK is returned instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67206|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 67844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67844&action=edit Bug 15486: Extend CanItemBeReserved so it handles daily holds limits This patch implements the required changes in C4::Reserves::CanItemBeReserved so it implements a daily limit on holds. It returns the 'tooManyReservesToday' string if the policy doesn't allow placing the hold. It returns 'OK' (current behaviour) otherwise. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: Tests fail because the error condition is not making CanItemBeReserved return the desired error code. - Apply this patch - Run: k$ prove t/db_dependent/Holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67203|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 67841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67841&action=edit Bug 15486: DBIC update schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67204|0 |1 is obsolete|| --- Comment #20 from Tomás Cohen Arazi --- Created attachment 67842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67842&action=edit Bug 15486: Make circ rules UI handle holds_per_day This patch makes the staff UI correctly handle the holds_per_day configuration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67202|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 67840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67840&action=edit Bug 15486: DB structure change This patch adds a new column __max_holds_per_day__ to the issuingrules table. It's going to be used to set a daily limit for holds. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Jhon Merced changed: What|Removed |Added CC||jhonmerc...@gmx.com --- Comment #14 from Jhon Merced --- Thanks for the patch! We've been waiting for it on https://www.webtrafficgeeks.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19439] New: Some error response from unapi get lost in eval
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 Bug ID: 19439 Summary: Some error response from unapi get lost in eval Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293 Lari Taskula changed: What|Removed |Added Attachment #67625|0 |1 is obsolete|| --- Comment #8 from Lari Taskula --- Created attachment 67839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67839&action=edit Bug 19293: Prevent error when receiving shipment with order with deleted biblio This patch checks if the biblio exists when receiving a shipment, and will skip the order if the biblio does not exist. To test: 1) Find or create a basket 2) Add TWO items to it 3) Find the record for one item in a separate tab, delete the record 4) Notice the order in the basket for that item now says 'deleted bibliographic record' 5) close the basket and receive the shipment 6) After entering an invoice number and clicking next, you'll see the error: Can't call method "subscriptions" on an undefined value at /home/vagrant/kohaclone/acqui/parcel.pl line 245. 7) Apply the patch and go back to the basket to receive the shipment 8) Put in an invoice number and click next 9) This should now work as expected, skipping the deleted biblio, and the other item should show as ready to receive Sponsored-by: Catalyst IT Patch applies and works as described when test plan is followed. Signed-off-by: Dilan Johnpullé Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043 --- Comment #8 from Marcel de Rooy --- Created attachment 67837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67837&action=edit Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available Test plan: 0) Apply the patch 1) Install all affected languages: de-DE, es-ES, fr-CA and pl-PL 2) Remove and recreate Koha database 3) Go through web installer in English and don't forgot to load sample Z39.50 servers 4) Go to Administration -> Z39.50/SRU Servers and confirm the sample servers are here, but columbia.edu is not here 5) Repeat 2-4 for other languages: de-DE, es-ES, fr-CA and pl-PL Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043 Marcel de Rooy changed: What|Removed |Added Attachment #65692|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19043] Z39.50 target clio-db.cc.columbia.edu: 7090 is no longer publicly available.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19043 --- Comment #9 from Marcel de Rooy --- Created attachment 67838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67838&action=edit Bug 19043: (QA follow-up) Add dbrev and print warning This follow-up takes care of the requested warning at upgrade time. At the same time it removes the obsolete Columbia record when host and port are equal to the formerly used values. Note that the new host for on-campus use has been changed. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
