[Koha-bugs] [Bug 15679] Reset item level hold back to record level hold without deleting and readding the hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15679

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #1 from Hugh Rundle  ---
I agree, this is a major problem if a hold goes missing after it is allocated.
There doesn't seem to be a simple way to 'de-allocate' a hold and return it to
it's original state (i.e. a bib-level hold at the front of the queue).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

John DeLooper  changed:

   What|Removed |Added

 CC||jdeloo...@hccc.edu

--- Comment #12 from John DeLooper  ---
I too would love to see this kind of feature added, and am glad to see patches
in progress. I think a process for merging creates a smoother experience than
the current looking up duplicates and choosing which one to delete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC only appears / works if no other list already exists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19573] New: Link to make a new list in masthead in OPAC only appears / works if no other list already exists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Bug ID: 19573
   Summary: Link to make a new list in masthead in OPAC only
appears / works if no other list already exists
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The new enhancement from bug 17948 allows for a quick New List option in the
List function found in the masthead in OPAC.  This enhancement can only be seen
when the patron has no lists already created.  If a patron has a private list
created, the option for that New List will not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19572] opac-result item avaibility not the same as opac-detail shows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19572

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
The result page groups the different values, lost, not-for-loan (negative
values = on order, positive = reference). Fixing this to show the value from
the authorised values has been discussed on a different bug (can't locate it
right now)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19572] New: opac-result item avaibility not the same as opac-detail shows

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19572

Bug ID: 19572
   Summary: opac-result item avaibility not the same as
opac-detail shows
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: david.bourga...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

This is an issue two of our clients have encountered : the item avaibility in
the result page does not match the one in the detail page.

e.g.: The items have a notforloan value of -2, which is mapped through
Authorised_Values to "In Processing" (or equivalent) but on the OPAC result
page, it is displayed as "On Order". The detailed page show the correct value.

>From my analysis, this is because whereas the intranet results and the opac
details use the database to get items statuses, the opac result goes through
the XSLT processing, and doesn't have access to the Authorised_Values table.
This is worked around by some hardcoded values in the "item namespace" created
by XSLT.pm.

It's possible to fix this issue case-by-case for each client, but that's a very
ugly solution.

I don't plan to submit a patch to this bug, because I am not sure how to solve
the issue.

(If my explanations are unclear please tell me)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

--- Comment #18 from J Schmidt  ---
(In reply to Blou from comment #17)
> Hi Jen,
> 
> I'm curious, those things (calendar...) are put in with Bug 17015.  You've
> applied it first (I presume), have you tested it before applying 17983? 
> That could help us see where the issue is.

Hi,
I typically use ByWater's sandbox page and click "Apply" for a specific
sandbox. I think that action means it will apply any dependent patches
automatically.  Nick at ByWater relayed I should look into the syspref to set
it to SpecifyDueDate which I did not do. I'll test again and do that system
pref.  Thank you. jls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode hides email and breaks workflow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #8 from Katrin Fischer  ---
It's odd, I was testing in a 16.11.12. Will try to retest on master soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821
[Bug 18821] TrackLastPatronActivity is a performance killer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA
 Depends on||16276
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276
[Bug 16276] When automatically deleting expired borrowers, make sure they
didn't log in recently
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #27 from Jonathan Druart  
---
Patch rebased and rewritten, please test.

Srdjan's concern is not valid IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19567] New: Development

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19567

Bug ID: 19567
   Summary: Development
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: je...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

1. Add new “Merge selected” button to the patrons toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #19087|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  
---
Created attachment 68898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68898=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19566] New: Integrate multiple instance auto_increment fix from KohaAloha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19566

Bug ID: 19566
   Summary: Integrate  multiple instance auto_increment fix from
KohaAloha
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pongta...@punsarn.asia
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

In the Wiki https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix, there
is a link to a solution for auto_increment problem by KohaAloha:

https://github.com/KohaAloha/koha-mysql-init

This solution automatically work with multiple instances and if integrated into
Koha Debian package, does not require any work manual fix by the user at all.

So I would like to propose this solution to be integrate into Debian package by
default for all supported releases that target Debian 8/9 (with systemd).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17661] Differences in whitespace cause duplicate facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17661] Differences in whitespace cause duplicate facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #3 from Nick Clemens  ---
Should expand this patch to cover whitespace, also need ES coverage, also
better bug title

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17661] Differences in whitespace cause duplicate facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

--- Comment #2 from Nick Clemens  ---
Created attachment 68897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68897=edit
Bug 17661 - Ending punctuation causes duplicate facets

WIP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18357   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14045
 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
[Bug 14045] Add specific quotas to on-site checkout
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18357


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357
[Bug 18357] On-site checkouts issues with 'Unlimited'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18321   |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

--- Comment #4 from Jonathan Druart  
---
Created attachment 68896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68896=edit
Bug 18357: Handle unlimited on-site checkouts

If on-site checkouts are set to unlimited (i.e. NULL/undef), they are
currently blocked.

Test plan:
1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts
2/ Will be able to perform onsite checkout
3/ Edit rule to be 15/Unlimited normal/onsite
4/ Will be able to perform onsite checkout
=> Without this patch it was blocked
5/ Set rule to 15/15
6/ Onsite checkouts work again

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #6 from Jonathan Druart  
---
Created attachment 68895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68895=edit
Bug 16787: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52652|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 68894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68894=edit
Bug 16787: 'Too many holds' message appears inappropriately and is missing data

This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when
allowedreserves=0. This allows passing to the user an appropriate
message about the availability of items for holds

To test:
1 - Set an item type to allow no holds
2 - Attempt to place a hold for a patron
3 - Message should be "No holds allowed: [Firstname Surname] cannot
place holds on any of these items"
4 - Try placing a multihold with the record above and a holdable record,
  message should end "...cannot place holds on some of these titles'
  items"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

--- Comment #4 from David Gustafsson  ---
Would be nice if "." could as be included as a valid field characters, since it
is used for subfields in Elasticsearch. ("Control-number.raw" for example).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

David Gustafsson  changed:

   What|Removed |Added

 CC||glask...@gmail.com

--- Comment #3 from David Gustafsson  ---
*** Bug 19565 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19565] Fix regular expression in _truncate_terms so field names are not split up

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

David Gustafsson  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from David Gustafsson  ---


*** This bug has been marked as a duplicate of bug 19559 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19565] Fix regular expression in _truncate_terms so field names are not split up

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

--- Comment #2 from David Gustafsson  ---
Just saw this bug was recently reported in:
"https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559;, which also
contains a test case. Would be nice if "." could also be included as a valid
field name character though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect condition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19565] Fix regular expression in _truncate_terms so field names are not split up

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

--- Comment #1 from David Gustafsson  ---
Created attachment 68893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68893=edit
Bug 19565: Fix regular expression in _truncate_terms so field names are not
split up

The regular expression used for tokenizing search string does not allow for
field names containing "." or "-". Fix regular expression to allow for field
names containing "." or "-".

Test plan:
1. Make sure Elasticsearch is used as default search engine.
2. Select "Search the catalog" in the staff client front page.
3. Search for Control-number.raw="" where  is an existing control number. (The quotes around are value are needed
to prevent
Koha from appending "*" to control number).
4. The search should not yield any results.
5. Apply patch.
6. Search again using the same condition.
7. The biblio with the control number used in the search should appear as a
match.
8. Search for Control-number="".
9. The biblio with the control number used in the search should appear as a
match.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19565] Fix regular expression in _truncate_terms so field names are not split up

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19565] New: Fix regular expression in _truncate_terms so field names are not split up

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

Bug ID: 19565
   Summary: Fix regular expression in _truncate_terms so field
names are not split up
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: glask...@gmail.com

The regular expression used for extraction search terms does not allow for
field names containing "." or "-". For example Control-number.raw:"123", would
be split up into: "Control-number." and "raw\"123\"". "Control-number:"123"
into "Control-", "number:\"123\"". The regular expression needs to be adjusted
to allow for certain valid characters ("." and "-" most importantly) in field
names.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

--- Comment #2 from David Gustafsson  ---
I did not add a test-case since sorting does currently work anyway because of
other unrelated bugs (which I can link to once having created issues and
submitted fixes f). But this Perl code can be executed to illustrate the issue
(and fix):

my ( $f, $d ) = "call_number_asc" =~ /(.+)_(.+)/;
print "$f $d\n";
( $f, $d ) = split /_/, "call_number_asc";
print "$f $d\n";

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

--- Comment #1 from David Gustafsson  ---
Created attachment 68892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68892=edit
Bug 19564: Fix extraction of sort order from sort condition name

Currently sort order is extracted from sort condition by splitting the
field, instead use regular expression to extract the last part preceded
by underscore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19564] New: Fix extraction of sort order from sort condition name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

Bug ID: 19564
   Summary: Fix extraction of sort order from sort condition name
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: glask...@gmail.com

Currently sort order is extracted from sort condition with "my ( $f, $d ) =
split /_/;"
So for example with the value "call_number_asc", you get $f (field) "call", and
$d (order) "number", when expecting to get "call_number" and "asc". This should
be changes using a regular expression instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16787

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11160] Better message when placing hold at OPAC is blocked

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11160

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 19540 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19540
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540

Jonathan Druart  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #2 from Jonathan Druart  
---
*** Bug 11160 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #5 from Jonathan Druart  
---
Created attachment 68891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68891=edit
Bug 18712: Remove unecessary fixtures

2 fixtures are in a subroutine that is never called, it can be removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #115 from David Bourgault  ---
I've been told that isn't necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #4 from Jonathan Druart  
---
Created attachment 68890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68890=edit
Bug 18712: Fix t/Matcher.t if DB is empty

t/Matcher.t is failing with an empty DB, the data are not mocked
correctly

Test plan:
drop your DB and recreate it without any data and prove t/Matcher.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Summary|Run database_dependent test |make test is failing with
   |suite --No ignored  |an empty DB - t/Matcher.t
Version|17.05   |master
 Status|NEW |ASSIGNED

--- Comment #3 from Jonathan Druart  
---
We have 2 problems here:
1/ t/Matcher.t is failing with an empty DB, the data are not mocked correctly
(Prices.t has been fixed earlier, maybe with bug 18289)
2/ We access DB during compilation time, which is quite bad.
>From C4::Auth, we retrieve system preference values in the BEGIN block:
  62 $cas   = C4::Context->preference('casAuthentication');
  64 $caslogout = C4::Context->preference('casLogout');
This should be rewritten and fixed, but it does not prevent the tests to pass,
but raises the "DBI connect failed" warning.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect condition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

--- Comment #1 from David Gustafsson  ---
Created attachment 68889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68889=edit
Bug 19563: Generation of sort_fields uses incorrect condition

Fix incorrect condition for if clause for generating __sort mappings
for Elasticsearch. Also remove redundant check for same condition when
generating fixer rules.

Test plan:
1. Inspect current mappings for example by viewing:
http://:9200/koha__biblios/_mapping.
2. If using the default configuraion only "author" has a sort field
(author__sort).
4. Appy patch.
5. Reindex using rebuild_elastic_search.pl.
6. All fields except those with sort sort set to "0" should now have sort
fields, which in the default configuration is all but "author".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #8 from M. Tompsett  ---
Comment on attachment 66518
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518
Bug 18915: Fix checkout note email message

Review of attachment 66518:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18915=66518)
-

::: installer/data/mysql/updatedatabase.pl
@@ +14308,4 @@
>  
>  $dbh->do(q|
>  INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, 
> `is_html`, `title`, `content`, `message_transport_type`)
> +VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item 
> set by patron', '0', 'Checkout note', '<> 
> <> has added a note to the item <> - 
> <> (<>).','email');

I don't think updatedatabase should be modified like this. This is already
done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE, if
this is correct logic.

::: opac/svc/patron_notes
@@ +82,4 @@
>  my $biblionumber = $issue->item->biblionumber;
>  my $letter = C4::Letters::GetPreparedLetter (
>  module => 'circulation',
> +letter_code => 'CHECKOUT_NOTE',

Why even change the letter code, given that you aren't changing the svc name?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #114 from David Bourgault  ---
The signoff was done before a rebase, so I figured I'd ask for another signoff
in case I screwed up my rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19563] New: Generation of sort_fields uses incorrect condition

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Bug ID: 19563
   Summary: Generation of sort_fields uses incorrect condition
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: glask...@gmail.com

Incorrect condition for generation of sort field mappings etc, will post patch
shortly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes marked as problematic with no_barcode?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562

--- Comment #1 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #0)
> A simple custom solution is:
> $item->{problems}->{no_barcode} = 1 unless $item->{itemnotes} =~
> /convolute/i;

This actually is too simple, since GetItemsForInventory does not return
itemnotes. But you get the point.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19492] Field 'lowestPriority' doesn't have a default value (MariaDB)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17258

--- Comment #3 from Jonathan Druart  
---
The "doesn't have a default value" is related to the STRICT_TRANS_TABLES mode,
with NO_ENGINE_SUBSTITUTION you should not get this error.

Can you confirm you restarted the service and you still get this error?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19492


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492
[Bug 19492] Field 'lowestPriority' doesn't have a default value (MariaDB)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #113 from Andreas Hedström Mace  
---
Shouldn't this bug have status Signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19548] Search Result Second page not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Which version of Koha are you using?
Can you give us an example of title with quotation mark to search for?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19456] Some pages title tag contains html

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

--- Comment #11 from Jonathan Druart  
---
(In reply to David Bourgault from comment #9)
> Worked as planned, QA tool green across the board.

Do not forget to add your 'signed-off-by' line to the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_17_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19543] Koha does not reserve an item if there is one available in another library.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

--- Comment #6 from Cristian  ---
(In reply to Jonathan Druart from comment #4)
> Cristian, can you confirm that this is a duplicate of bug 18547?

Hi Jonathan, I'll confirm. It also appears to be a duplicate of bug 18366.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_17_11_candidate
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19496


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496
[Bug 19496] Patron notes about item does not get emailed as indicated
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19496] Patron notes about item does not get emailed as indicated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14224
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz
   Keywords||rel_17_11_candidate
 Status|NEW |ASSIGNED
Version|17.05   |master

--- Comment #1 from Jonathan Druart  
---
Aleisha, can you take care of this one please?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
[Bug 14224] patron notes about item shown at check in
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19543] Koha does not reserve an item if there is one available in another library.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

--- Comment #5 from Cristian  ---
(In reply to Katrin Fischer from comment #3)
> Hi Cristian, I think you might want to have a look at bug 18547.

Hi Katrin, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19456] Some pages title tag contains html

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Jonathan Druart  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

--- Comment #10 from Jonathan Druart  
---
*** Bug 19553 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19553] Patron page: HTML span tag visible in page title when patron has a title

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19553

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 19456 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|19456   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456
[Bug 19456] Some pages title tag contains html
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14039] Add patron title to checkout screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456
[Bug 19456] Some pages title tag contains html
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19456] Some pages title tag contains html

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|14919   |14039


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039
[Bug 14039] Add patron title to checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919
[Bug 14919] Holds history for patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode hides email and breaks workflow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #7 from Jonathan Druart  
---
I do not recreate, I have added "branchcode" to
PatronSelfRegistrationBorrowerUnwantedField, when I go to opac-memberentry.pl I
do not see the library entry and see "primary email" in the "contact
information" part.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19543] Koha does not reserve an item if there is one available in another library.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Cristian, can you confirm that this is a duplicate of bug 18547?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #7 from Magnus Enger  ---
My patch just adds timestamp columns to biblio_metadata and
deletedbiblio_metadata. This means the timestamps in those columns will be
-00-00 00:00:00. 

Possible things to do:

1. One thing we could do is copy over data from biblioitems.timestamp to
biblio_metadata.timestamp. That would give us non-zero values, but those values
would still be as wrong as the values in biblioitems.timestamp are. 

2. One step further, at least for MARC21, would be to extract the date from 005
and put that in biblio_metadata.timestamp. That should give pretty accurate
timestamps, as long as the value in 005 makes sense. 

3. The problem with both 1 and 2 is that some biblio_metadata.timestamps will
be way back in time. If a client does a harvest like
verb=ListRecords=marcxchange=2017-10-26=2017-11-02 to
pick up the most recent changes, those records with old timestamps will still
not be picked up. So the best solution is perhaps to set
biblio_metadata.timestamp to the value of 005, BUT when that timestamp is more
recent than biblioitems.timestamp, set biblio_metadata.timestamp to NOW(), so
that a harvest of "recent updates" will catch all these old changes. 

Should we put this in the databaseupdate, or is it too complex? Is it better to
have a note in the databaseupdate pointing to a page on the wiki that details
these options and lets the user/admin choose which one they want?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_17_11_candidate
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19562] New: Inventory: How can we skip convolutes marked as problematic with no_barcode?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562

Bug ID: 19562
   Summary: Inventory: How can we skip convolutes marked as
problematic with no_barcode?
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

We have two biblio records, but one item. It is a convolute, a bound set of
actually two items. We added one item to each biblio, added Convolute in the
item notes and gave the bound set one barcode recorded in one of the items.
When doing inventory and comparing with a barcode file, you can imagine that
the item without the barcode (having the same callnumber as the item with the
barcode) is reported as a problem (no_barcode).

A simple custom solution is:
$item->{problems}->{no_barcode} = 1 unless $item->{itemnotes} =~ /convolute/i;

Do you have any suggestions or ideas to resolve similar problems with
convolutes, if you have them ? How do you record this situation ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #6 from Magnus Enger  ---
Created attachment 6
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6=edit
Bug 19555: Some changes to records are not reflected in OAI-PMH

When we moved biblioitems.marcxml to biblio_metadata.metadata, this
meant that biblioteitems.timestamp was only updated when there
were changes to MARC fields that have corresponding columns in
the biblioitems table, like ISBN. This patch adds a timestamp
column to biblio_metadata and makes OAI-PMH use that to decide
if a record should be included in a response or not. This should
mean that any change to the records are reflected in OAI-PMH.

To test:
- Before applying the patch:
- Look at at the data in biblioitems for a record, e.g.:
  SELECT * FROM biblioitems WHERE biblionumber = x\G
- Edit the record, and verify that a change to e.g. ISBN updates
  the timestamp, and a change to e.g. a subject does not
- Apply the patch and make sure the atomicupdate is run
- Look at the data in biblio_metadata for the record. e.g.:
  SELECT * FROM biblio_metadata WHERE biblionumber = x\G
- Verify that any change to the record results in a change to
  the timestamp
- Enable OAI-PMH with the OAI-PMH syspref
- Visit this URL in your browser:
 
/cgi-bin/koha/oai.pl?verb=ListRecords=marcxml=2017-10-26=2017-11-02
- Change the from and until dates as well as the
  biblio_metadata.timestamp value (e.g.: UPDATE biblio_metadata
  SET timestamp = '2017-10-24' WHERE biblionumber = x), and verify
  that the record is included or not included in the OAI-PMH
  response as expected
- Run the tests: prove t/db_dependent/OAI/*.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Magnus Enger  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #26 from Marcel de Rooy  ---
Just a few (minor) comments from looking at t::lib::Dates

Test::More seems not to be used.
$description is not used either, and if I am not mistaken is never passed too.
POD says that date is truncated to minutes, but the code compares epoch times
(which are seconds) and than rather out of the blue ignores a difference of
less than 6 seconds (why 6) ? A comment in the code would be helpful too. The
POD is no longer true.

If I understood well, Julian asked to remove the floating timezones. It seems
to me that you'd better compare dates in floating however. (See similar problem
with DST boundaries on earlier pushed report.) And yes, you should clone the
dates when changing timezone and comparing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/