[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #38 from Josef Moravec ---
Comment on attachment 79810
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79810
Bug 11175: Show record component parts in the detail view
Review of attachment 79810:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11175=79810)
-
::: Koha/Biblio.pm
@@ +388,4 @@
> return $self->{_biblioitem};
> }
>
> +=head3 components
Please, provide tests for this method
@@ +399,5 @@
> +
> +sub components {
> +my ($self) = @_;
> +
> +return undef if (C4::Context->preference('marcflavour') ne 'MARC21');
Do not return explicit undef
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #109 from Alex Buckley --- Created attachment 79859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79859=edit Bug 8367: reserves.lastpickupdate calculation checks and uses ExcludeHolidaysFromMaxPickUpDelay syspref Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed changed: What|Removed |Added Attachment #73363|0 |1 is obsolete|| Attachment #73364|0 |1 is obsolete|| --- Comment #4 from paxed --- Created attachment 79858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79858=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Incorporated the QA fixes by M. Tompsett in this patch. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 M. Tompsett changed: What|Removed |Added Attachment #79852|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 79857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79857=edit Bug 21479: Fix remove from cart - OPAC This bug affects all stable releases and seems to have been there for a long time. To recreate: - Launch a search at the OPAC - Add 2 elements to the cart - Remove one => Cart is empty Note that it does not exist on the staff interface The code in opac-bottom is only for the detail page, where biblionumber is defined, but the event binding was done on the result search page as they have the same selector (.cartRemove) On the results page, the biblionumber is not defined and triggers the deletion of all the items as a result. Using a more specific selector (this solution is already used for "add to shelf") fixes the problem Test plan: Add and remove elements to/from your cart On both search and detail view Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #27 from Alex Buckley --- Can the additional patch removing unneccessary code related to the MSG_IN_YOUR_CODE message please be tested. Thanks :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #26 from Alex Buckley --- Created attachment 79856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79856=edit Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS The 'Items in your cart' message is obsolete with the cart dropdown box being removed. Therefore the assignment of this text into the MSG_IN_YOUR_CART variable (which is done in the opac-bottom.inc), and the use of the MSG_IN_YOUR_CART variable in the updateBasket() function (in the OPAC's basket.js) has been removed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #25 from Alex Buckley --- (In reply to Jonathan Druart in comment #22) Hi Jonathan Yes, that message is now obsolete with the cart dropdown option now being removed. I am attaching another commit which removes the assignment of the MSG_IN_YOUR_CART (in opac-bottom.inc) and the use of it in the updateBasket() in opac-tmpl/bootstrap/js/basket.js. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #108 from Alex Buckley --- Created attachment 79855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79855=edit Bug 8367: Fixed how expirationdate is calculated when ExcludeHolidaysFromMaxPickUpDelay syspref is enabled Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21452] Items available for hold or loan must have an item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21452 --- Comment #3 from Barton Chittenden --- Also, frameworks are editable, and I'd rather not have this be something that a user can disable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21452] Items available for hold or loan must have an item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21452 --- Comment #2 from Barton Chittenden --- (In reply to Katrin Fischer from comment #1) > If the problem is acq items, maybe setting the itemtype not-mandatory for > the ACQ framework but mandatory for every other would work? There is a lot > more things that influence if an item can be checked out, not only the > not-for-loan status. I'm not sure that will work: 1) If item-level_itypes is set to 'biblio record', items.itype may not be set at all, so we really need to test that one or the other is set. 2) Even if an item is in acquisitions, the library may want to the not-for-loan status to a negative number, making it available to be placed on hold... at that point, the item type needs to be set. That may well happen while the item is still in acquisitions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #107 from Alex Buckley --- Created attachment 79854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79854=edit Bug 8367: Altered expirationdate calc in Koha/Hold.pm and altered C4/Reserves/CancelExpiredReserves() Added check for holidays to expirationdate calculation in Koha/Hold.pm so the expirationdate respects holidays as the lastpickupdate does. Changed C4/Reserve/CancelExpiredReserves() to check the reserves.lastpickupdate rather than rserves.expirationdate. Therefore it will now automatically expire holds if they have not been picked up within the time period specified in the hold pickup delay defined in the issuing rules (which is added to reserves.waitingdate to calculate the reserves.lastpickupdate) AND the ExpireReservesMaxPickUpDelay syspref is enabled. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #106 from Alex Buckley --- Created attachment 79853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79853=edit Bug 8367: Moved database update out of updatedatabase.pl into atomicupdates dir -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #12 from Jonathan Druart --- (In reply to Alex Buckley from comment #11) > Rebased against master on 16th of sept 2018. - + Rebase is wrong, you removed the filters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #24 from Jonathan Druart --- (In reply to Jonathan Druart from comment #23) > Also found a bug: > From the search result page: > - "Add to cart" > - "Add to cart" (another one) > => Cart displays 2 elements - OK > - "(remove)" > => Cart displays nothing - KO must display 1 > > (maybe on master as well) I have opened bug 21479 (with a fix). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 --- Comment #1 from Jonathan Druart --- Created attachment 79852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79852=edit Bug 21479: Fix remove from cart - OPAC This bug affects all stable releases and seems to have been there for a long time. To recreate: - Launch a search at the OPAC - Add 2 elements to the cart - Remove one => Cart is empty Note that it does not exist on the staff interface The code in opac-bottom is only for the detail page, but the evenement binding was done on the result search page as they have the same selector (.cartRemove) Using a more specific selector (already used for "add to shelf") fixes the problem. Test plan: Add and remove elements to/from your cart On both search and detail view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] New: Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 Bug ID: 21479 Summary: Removing from cart removes 2 items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org This bug affects all stable releases and seems to have been there for a long time. To recreate: - Launch a search at the OPAC - Add 2 elements to the cart - Remove one => Cart is empty Note that it does not exist on the staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21471] Misspelled variable name in _get_outstanding_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Chris Cormack changed: What|Removed |Added Attachment #79817|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 79851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79851=edit Bug 21471: Misspelled variable in _get_outstanding_holds Misspelled variable causes _get_outstanding_holds to crash if patron is queued on biblio level Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21471] Misspelled variable name in _get_outstanding_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21471 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 --- Comment #2 from Nick Clemens --- Created attachment 79850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79850=edit Bug 21465: Don't throw duplicate userid error if userid belongs to the matched patron To test: 1 - Export your patrons a - Create a report 'SELECT * FROM borrowers' b - Run and save the report as csv (check your delimiter) c - Delete the borrowernumebr column 2 - Use the Patron Import tool to import the csv from above 3 - Set matching to 'cardnumber' 4 - Set 'If matching record is already in the borrowers table:' to Overwrite 5 - Import 6 - None are import because of matchign userid (their own) 7 - Apply patch 8 - Repeat 9 - Patrons are successfully overwritten 10 - prove -v t/db_dependent/Koha/Patrons/Import.t 11 - prove -v t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Nick Clemens changed: What|Removed |Added Summary|Overlaying with Patron |Cannot overlay patrons when |Imports cannot be done if |matching by cardnumber if |user id and cardnumber are |userid exists in file and |the same. |in Koha Version|18.05 |master CC||n...@bywatersolutions.com --- Comment #1 from Nick Clemens --- This appears to have been intentional according to tests, but I think the tests and assumption were wrong. Essentially if not matching by userid and a userid is inthe file we try to create a new user and see if the user id is valid. It isn't, of course, because the patron exists. has_valid_userid is supposed to ignore a duplicate for the existing borrower, but we avoid that check by creating a new borrower!?!? Patch coming -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21478] New: Koha::Hold->suspend_hold allows suspending in transit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Bug ID: 21478 Summary: Koha::Hold->suspend_hold allows suspending in transit holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org My understanding is that both 'waiting' and 'in transit' holds are 'found', and in both cases suspending them should be disallowed. I haven't looked at the places in which this could happen, but the code implementing the checks in Koha::Hold clearly misses the use case. The method should be renamed to the new guidelines (->suspend) and it should raise exceptions in both cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21472] Links in Additional Formats section of bib details do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Paul Hoffman changed: What|Removed |Added Version|18.05 |17.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21475] Error in the OPAC when viewing a record which has no biblio-level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21475
--- Comment #3 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #2)
> Also, from C4::Circulation::transferbook:
>
> 324 my $code = C4::Context->preference("BranchTransferLimitsType")
> eq 'ccode' ? $item->ccode : $item->biblio->biblioitem->itemtype; #
> BranchTransferLimitsType is 'ccode' or 'itemtype'
Scratch that, it should not explode.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21475] Error in the OPAC when viewing a record which has no biblio-level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21475
--- Comment #2 from Jonathan Druart
---
Also, from C4::Circulation::transferbook:
324 my $code = C4::Context->preference("BranchTransferLimitsType") eq
'ccode' ? $item->ccode : $item->biblio->biblioitem->itemtype; #
BranchTransferLimitsType is 'ccode' or 'itemtype'
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21470] Due date no longer shown in red when viewing checkouts for a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21470 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21474] Add the Koha::Subscription->frequency method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 Josef Moravec changed: What|Removed |Added Attachment #79827|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 79849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79849=edit Bug 21474: Add the Koha::Subscription->frequency method And the 2 modules for the subscriptions' frequencies Test plan: prove t/db_dependent/Koha/Subscription.t must return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21474] Add the Koha::Subscription->frequency method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21476] Markup error prevents HTML5 media from playing in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21466] Data inconsistencies - items.location values must have a corresponding authorised value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] ILL backends/plugins need hooks into checkin and checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17237] Stop koha-create from creating MySQL users without host restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17237 Josef Moravec changed: What|Removed |Added Attachment #79372|0 |1 is obsolete|| --- Comment #7 from Josef Moravec --- Created attachment 79848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79848=edit Bug 17237: Remove CREATE USER 'user'@'%' line Having a 'user'@'%' line decreases database security. Bug 16690 closes the need for such a line, and this bug removes the use of it. TEST PLAN - While this depends on 16690, it is not required for testing. On a kohadev box: sudo koha-create --create-db test_17237_a git bz apply 17237 sudo perl ~/misc4dev/cp_debian_files.pl restart_all sudo systemctl daemon-reload sudo koha-create --create_db test_17237_b sudo mysql -u root SELECT user,host from mysql.user; -- test_17237_a will have two entries, one being '%' -- test_17237_b will only have one entry, not '%' Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17237] Stop koha-create from creating MySQL users without host restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17237 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17237] Stop koha-create from creating MySQL users without host restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17237 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21322] process_message_queue.pl --type should take an argument
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21322 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21322] process_message_queue.pl --type should take an argument
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21322 Josef Moravec changed: What|Removed |Added Attachment #79406|0 |1 is obsolete|| --- Comment #6 from Josef Moravec --- Created attachment 79847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79847=edit Bug 21322: process_message_queue.pl --type should take an argument The help for this script says: -t --type: If supplied, only processes this type of message ( email, sms ) Currently, the type argument is set up wrong, so it does not look for an argument. This patch fixes that. To test, run this command (should work in kohadevbox) or something similar: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/process_message_queue.pl -v \ --type=sms" kohadev This should give the following error: "Option type does not take an argument". Apply the patch and run the same command again. This should not give an error. Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21322] process_message_queue.pl --type should take an argument
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21322 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard changed: What|Removed |Added Attachment #79843|0 |1 is obsolete|| Attachment #79844|0 |1 is obsolete|| --- Comment #47 from Owen Leonard --- Created attachment 79845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79845=edit Bug 15766: (follow-up) Correct merge errors This patch corrects some problems applying this on current master and removes an old merge conflict marker. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #48 from Owen Leonard --- Created attachment 79846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79846=edit Bug 15766: (follow-up) Fixing layout of description button This patch moves the 'Save' button to the toolbar as suggested. The description textbox and 'Save' button are hidden if the batch is new and appears when items are added. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #46 from Owen Leonard --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #45 from Owen Leonard --- Created attachment 79844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79844=edit Bug 15766: (follow-up) Fixing layout of description button This patch moves the 'Save' button to the toolbar as suggested. The description textbox and 'Save' button are hidden if the batch is new and appears when items are added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #44 from Owen Leonard --- Created attachment 79843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79843=edit Bug 15766: (follow-up) Correct merge errors This patch corrects some problems applying this on current master and removes an old merge conflict marker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #43 from Owen Leonard --- Created attachment 79842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79842=edit Bug 15766: (follow-up) Hide description field if the batch is empty Because if it's empty, it hasn't actually been created yet. Hiding the field prevents a lot of errors Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #42 from Owen Leonard --- Created attachment 79841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79841=edit Bug 15766: (follow-up) Save description link as button on patroncard side Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #41 from Owen Leonard --- Created attachment 79840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79840=edit Bug 15766: (follow-up) Making 'Save description' link a button For consistency's sake in response to Comment 17. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard changed: What|Removed |Added Attachment #75213|0 |1 is obsolete|| Attachment #75214|0 |1 is obsolete|| Attachment #75215|0 |1 is obsolete|| Attachment #75216|0 |1 is obsolete|| Attachment #75715|0 |1 is obsolete|| Attachment #75843|0 |1 is obsolete|| --- Comment #40 from Owen Leonard --- Created attachment 79839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79839=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. 7) Go to Tools -> Label Creator -> Manage labels 8) Repeat steps 3 to 6 Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21477] New: Use of REMOTE_ADDR causes problems when Koha is behind a proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21477 Bug ID: 21477 Summary: Use of REMOTE_ADDR causes problems when Koha is behind a proxy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org For sysprefs like: RestrictedPageLocalIP we check the REMOTE_ADDR to get the IP, for setups behind a proxy we have seen issues as the IP is not matching the users IP. We should have a support for checking X_FORWARDED_FOR in order to check the IP of the end user -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Overlaying with Patron Imports cannot be done if user id and cardnumber are the same.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 --- Comment #8 from Nick Clemens --- This is not quite true, you can view these suggestions, they just don't show up by default. If you click on 'Acquisition Information' on the left side of the screen it expands into filters for 'Book fund' and 'Library' Set 'Library' to 'Any' and these suggestions should show This is definitely not intuitive and should be addressed, perhaps if we indicate on the screen somewhere that we are already filtering by branch? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart changed: What|Removed |Added Attachment #79801|0 |1 is obsolete|| Attachment #79802|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 79834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79834=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #6 from Jonathan Druart --- Created attachment 79837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79837=edit Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #7 from Jonathan Druart --- Created attachment 79838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79838=edit Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #5 from Jonathan Druart --- Created attachment 79836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79836=edit Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #4 from Jonathan Druart --- Created attachment 79835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79835=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21474] Add the Koha::Subscription->frequency method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 Jonathan Druart changed: What|Removed |Added Blocks||21467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 [Bug 21467] Allow several receipts for a given subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart changed: What|Removed |Added Depends on||21474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 [Bug 21474] Add the Koha::Subscription->frequency method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 --- Comment #7 from Owen Leonard --- I rebased this patch and converted the CSS changes to SCSS. I also modified the commit message to include the test plan. It works well for me but I'm not sure about the explicit width and height for videos in the OPAC. Is it necessary? If so, shouldn't the same CSS change be added to the staff client? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 --- Comment #6 from Owen Leonard --- Created attachment 79833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79833=edit Bug 20783: Cannot embed some YouTube videos due to 403 errors YouTube videos are embeded instead of played with its videoplayback URL, that can throw a 403 error To test the patch you have to: * Install a new package: HTML::Video::Embed * Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) * Enable the syspref HTML5MediaEnabled to some interface, and HTML5MediaYouTube to embed videos. * Edit a biblio and put some youtube video in a 856u field. * Check it in OPAC or INTRANET. The video https://www.youtube.com/watch?v=haT8g7oKnns can not be played before the patch, but after it has no problems. Sponsored-by: UCA - Universidad de Cádiz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21418] Incorrectly filtered markup in staff client lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21418] Incorrectly filtered markup in staff client lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418 --- Comment #12 from Josef Moravec --- Created attachment 79832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79832=edit Bug 21418: Remove shelfoff which is not used No need to add a new line to escape this variable that is never used, better to remove it `git grep shelfoff` will prove that it is not used anywhere else. Signed-off-by: Jonathan Druart Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21418] Incorrectly filtered markup in staff client lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418 --- Comment #11 from Josef Moravec --- Created attachment 79831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79831=edit Bug 21418: Html escape the 2 variables We should be on the safe side without this patch because shelfnumber and type comes from the DB and are integer or varchar. It may be better to show good examples to start, and escape everything anyway. Signed-off-by: Jonathan Druart Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21418] Incorrectly filtered markup in staff client lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418 Josef Moravec changed: What|Removed |Added Attachment #79610|0 |1 is obsolete|| Attachment #79706|0 |1 is obsolete|| Attachment #79707|0 |1 is obsolete|| --- Comment #10 from Josef Moravec --- Created attachment 79830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79830=edit Bug 21418: Incorrectly filtered markup in staff client lists This patch removes the "|html" filter from some variable declarations in the template used to display the list of lists in the staff client. To test you should have at least one list. Apply the patch and go to Lists. In the table of lists, the "Edit" and "Delete" buttons should look correct and work correctly. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21418] Incorrectly filtered markup in staff client lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Owen Leonard changed: What|Removed |Added Attachment #79829|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Owen Leonard changed: What|Removed |Added Attachment #75443|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 79829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79829=edit Bug 20783: Cannot embed some YouTube videos due to 403 errors YouTube videos are embeded instead of played with its videoplayback URL, that can throw a 403 error To test the patch you have to: * Install a new package: HTML::Video::Embed * Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) * Enable the syspref HTML5MediaEnabled to some interface, and HTML5MediaYouTube to embed videos. * Edit a biblio and put some youtube video in a 856u field. * Check it in OPAC or INTRANET. The video https://www.youtube.com/watch?v=haT8g7oKnns can not be played before the patch, but after it has no problems. Sponsored-by: UCA - Universidad de Cádiz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Owen Leonard changed: What|Removed |Added Attachment #75442|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21352] Allow plugins to add CSS and Javascript to Staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21352 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Owen Leonard changed: What|Removed |Added Blocks||21476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 [Bug 21476] Markup error prevents HTML5 media from playing in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Owen Leonard changed: What|Removed |Added Depends on||21476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 [Bug 21476] Markup error prevents HTML5 media from playing in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21476] New: Markup error prevents HTML5 media from playing in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 Bug ID: 21476 Summary: Markup error prevents HTML5 media from playing in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 8377 Blocks: 20783 There is an extra set of quotes in the markup for HTML5 media embeds in the OPAC which prevents media from playing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 [Bug 20783] Cannot embed some YouTube videos due to 403 errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21432] Internal Server Error in Checkout History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 Josef Moravec changed: What|Removed |Added Attachment #79785|0 |1 is obsolete|| --- Comment #13 from Josef Moravec --- Created attachment 79828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79828=edit Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted patrons Template process failed: undef error - DBIC result _type isn't of the _type Borrower at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt line 54. Koha::Old::Checkout->patron should return undef if the patron record has been removed. Test plan: - Check 2 items out on the same bibliographic record - Check them in - Delete the patron's record of one of the issuer (Is this word really exist?) - View the checkout history for this bib record (Home › Catalog › Checkout history) => Without this patch you get the error => With this patch applied one of the "Patron" cells will be empty Signed-off-by: Claudio Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21432] Internal Server Error in Checkout History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Jonathan Druart changed: What|Removed |Added Blocks||21475 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21475 [Bug 21475] Error in the OPAC when viewing a record which has no biblio-level itemtype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21432] Internal Server Error in Checkout History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21475] Error in the OPAC when viewing a record which has no biblio-level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21475 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||17530 --- Comment #1 from Jonathan Druart --- Caused by: commit e85d6e12ea4dccd8fa08ec600864c2f985dcf886 Bug 17530: (QA follow-up) Move may_article_request to ItemType Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 [Bug 17530] Don't show 'article request' link when no article requests are permitted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21475] New: Error in the OPAC when viewing a record which has no biblio-level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21475 Bug ID: 21475 Summary: Error in the OPAC when viewing a record which has no biblio-level itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org When I view in the OPAC a record which has no biblio-level itemtype I get an error: Can't call method "may_article_request" on an undefined value at /home/vagrant/kohaclone/opac/opac-detail.pl line 761 My item-level_itypes system preference is set to "specific item." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20941] Displaying requests does not display request material type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact||josef.mora...@gmail.com CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20941] Displaying requests does not display request material type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941
--- Comment #4 from Josef Moravec ---
Comment on attachment 79577
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79577
Bug 20941: Add Illrequest->getType method
Review of attachment 79577:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20941=79577)
-
::: Koha/Illrequest.pm
@@ +724,4 @@
> || ""; # "the empty prefix"
> }
>
> +=head3 getType
should be get_type, or maybe better get_material_type, please rename the method
@@ +734,5 @@
> +
> +sub getType {
> +my ($self) = @_;
> +my $attr = $self->illrequestattributes->find({ type => 'type'});
> +return $attr ? $attr->value : 'N/A';
We should return implicit undef if no type is set and then handle it in
templates.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21474] Add the Koha::Subscription->frequency method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21474] Add the Koha::Subscription->frequency method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 --- Comment #1 from Jonathan Druart --- Created attachment 79827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79827=edit Bug 21474: Add the Koha::Subscription->frequency method And the 2 modules for the subscriptions' frequencies Test plan: prove t/db_dependent/Koha/Subscription.t must return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #28 from Magnus Enger --- *** Bug 21461 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21461] Add logging for ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21461 Magnus Enger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 20750 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21474] New: Add the Koha::Subscription->frequency method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21474 Bug ID: 21474 Summary: Add the Koha::Subscription->frequency method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m Status|Needs Signoff |Signed Off --- Comment #34 from Victor Grousset/tuxayo --- Signed off and updated test plan: - add "(manual restriction works)" - update text 'called "Suspension in days"' to match the UI Thanks Frido for guiding me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #77683|0 |1 is obsolete|| --- Comment #33 from Victor Grousset/tuxayo --- Created attachment 79826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79826=edit Bug 14784 - Fix checkin message for debarred patrons After thinking about it I changed the code's behavior to always display a reminder if the patron was previously debarred. This makes sense to me (it's only a reminder) and it correctly stacks with other messages. -- Test plan: Before 1) Select a user with active restrictions (manual restriction works) 2) Make sure finesday=0 for the user category. See [1] 3) Checkout and return an item (not overdue) A previous restriction reminder will appear 4) Checkout and return an overdue item (change the date at cehckout) No previous restriction reminder will appear After applying patch: Same steps, but a reminder should appear for step 4) I've also tested with finesday=1 with "no overdue", "grace period overdue" and "long overdue" test cases. The appropriate nessage appeared for each test. [1] The "finesday" setting is called "Suspension in days" in the web interface, if you're searching for it like I did... Signed-off-by: Katrin Fischer Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21473] New: Circulation make checkout when refresh the browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21473 Bug ID: 21473 Summary: Circulation make checkout when refresh the browser Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ah_samir...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hi if I open same page (check out) at the same time at different browser and different account the first browser make an checkout when refresh the second browser show the checkout and then make checkin Then go to first browser and make refresh browser koha make checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21472] New: Links in Additional Formats section of bib details do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Bug ID: 21472 Summary: Links in Additional Formats section of bib details do not work Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: p...@flo.org QA Contact: testo...@bugs.koha-community.org The links that appear under the heading Additional Formats, built using data from 776 fields, are hardcoded to be like this in the OPAC: /cgi-bin/koha/opac-search.pl?q=control-number:__ And like this in the staff interface: /cgi-bin/koha/catalogue/search.pl?q=control-number:__ The blanks are filled in with the contents of the 776 field, subfield $w, with any parenthesized organization code stripped. Thus, for example, a 776 field like this: 776 08 $i Online version: [...] $z 9781938168000 $w (OCoLC)895896190 Would yield a staff URL like this: /cgi-bin/koha/opac-search.pl?q=control-number:895896190 But that link won't work, at least not in our case; control numbers found in 035 $a are indexed as other-control-number, not control-number, and the organization code is not stripped when indexing. However, a link like this does retrieve the bib record with the 776 field given above: /cgi-bin/koha/catalogue/search.pl?idx=other-control-number,phr=(OCoLC)895896190 These links are built in /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl (lines 808 ff.) and /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl (lines 756 ff.); for example, the latter looks like this: Additional physical formats: No title i : /cgi-bin/koha/catalogue/search.pl?q=control-number: ; The template "extractControlNumber" extracts the control number (minus parenthesized prefix) from the value in 776 $w. Unfortunately, this template is used elsewhere so I'm not sure it's safe to change it so that it does *not* strip the parenthesized prefix. Perhaps we could add a second parameter to it that specifies whether or not to strip it, with the default set to true. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13484] Suggestions should have a foreign key constraint for branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13484 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 --- Comment #7 from Marjorie Barry-Vila --- Still valid. Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20452] Add HTML classes to search results availability data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20452 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- (In reply to Katrin Fischer from comment #7) > Maybe better to use 'results_'. Would this be ok for you? I agree with this suggestion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #10 from Jonathan Druart --- So maybe just a JS check for \d | \w ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #11 from Jonathan Druart --- *could* be done -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #10 from Jonathan Druart --- The things is that it would be done later, but will require more work (remove the code, update the DB, etc.) Not a big deal anyway. I will let the status as "Needs QA" to let another QAer give their opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20941] Displaying requests does not display request material type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #3 from Andrew Isherwood --- Created attachment 79825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79825=edit Bug 20941: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
