[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513
--- Comment #31 from Jonathan Druart
---
I confirm I can make it fail 100% of the time on U18, but only occasionally on
D10 (hum?)
On U18 it's failing on the tests we wrote for this specific problem
("Regression tests for bug 25513"), but on D10 it fails on another one:
t/db_dependent/api/v1/acquisitions_orders.t .. 1/5
# Failed test 'SWAGGER3.3.2'
# at t/db_dependent/api/v1/acquisitions_orders.t line 129.
# Structures begin differing at:
# $got->{ecost_tax_included} = '2.7621662673219e+21'
# $expected->{ecost_tax_included} = '2762166267321895092224.00'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24911] Exception holidays treated as unique holidays in calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 --- Comment #4 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #3) > Hm, I think there is no point to have an exception for a unique holiday = > you could just delete it. So maybe we should not allow exceptions in that > case and suggest to remove from the calendar instead? I agree. So we could just hide the option to generate exception when selected holiday is unique. Also seems like this was already reported in bug 9918. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25477] The responsive design in opac-main.tt should be correct
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #15 from Timothy Alexis Vass --- Options are nice, of course. But only when all available options are fully functional. I suggest we go forward with this. To replace the 3-column layout completely, since it is broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Timothy Alexis Vass --- (In reply to Katrin Fischer from comment #9) > I wanted to compare with the patch, but it currently doesn't apply. There was an old attachment that I had to obsolete. Please try it again now with the correct one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What|Removed |Added Attachment #105574|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What|Removed |Added Attachment #105577|0 |1 is obsolete|| --- Comment #11 from Timothy Alexis Vass --- Created attachment 105619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105619=edit Bug 25680 - When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. This patch will center the focused field at the golden section in the window. To test: 1) Begin to add a new patron. 2) Leave a required field empty, which is outside the screen view, and click Save. 3) Notice that the field is at the bottom, behind the language bar if there is one. 4) Apply patch 5) Add a new patron. 6) Leave the required field empty again and Save. 7) Notice that the required field is now clearly shown in view. 8) Sign off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 --- Comment #10 from Timothy Alexis Vass --- (In reply to Katrin Fischer from comment #9) > I was using Firefox, wonder if > the browser makes a difference? In this situation does. :) > I wanted to compare with the patch, but it currently doesn't apply. Is there an error? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] New: SIP allows to check out an item with hold in transfer to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Bug ID: 25690 Summary: SIP allows to check out an item with hold in transfer to another patron Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: minna.kivi...@hamk.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When system preference AllowItemsOnHoldCheckout is enabled, SIP allows another patron to check out an item with hold in transfer. After that the item is attached both to hold (reserves-table) and issue (issues table). The system should allow to check out an item to another patron than the one with hold, when item is attached to hold and is in transfer. This bug leads to unfortunate situations where patron with hold never gets the item. Borrower can't renew item since there is the hold, but the borrower can check in the item by self service station and check out again despite the hold in item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 --- Comment #18 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #17) > I am not sure I understand. > Make the tests pass using the default framework will be a good first step. The issue is that I wasn't getting the same record from LOC every time. And some have missing 040 and 245. Which doesn't comply with the default framework. I've fixed this by searching for an ISBN instead of a title + author. > tuxayo: > > # Idea from the current cleanup(): (whose code seems mostly not related to > > this test) > > # - name the record specifically like test_cataloging_workflow > > # - delete it and it's related items > > # - question: isn't it risky about data integrity? > > Data integrity? Why? Due to direct SQL DB modification. Actually it's not risky, that just means I need advice from someone who knows what do delete to cleanup a record + item creation. i.e. In which tables they span + eventual stuff that the Koha data layer does. > > # Another idea: > > # - pick a random number and replace the ISBN by it > > You can generate random data using TestBuilder is you like, then delete the > object and reuse the data, like: Thanks, that will be handy for other tests. For this one, the need is more low level right? (A random ISBN to replace the one that came from Z39.50 to avoid collisions). So, easy also. > In basic_workflow.t we use hardcoded values, that can work too. It won't help here because the issue is when the test is ran twice. But before going into this (cleaning up) or creating unique data that won't collide went test is ran twice: Should we rely on bug 19821 instead? That would block this patch and there other (less than a month, on maybe I'm too optimistic) but allow to not add and test code to handle cleanup. Including the case of the test that failed or was interrupted. We aim for the new tests to be backportable right? If so, do you think bug 19821 could be backported? I can spend time on that for each branch (especially since I would like to improve the coverage down to my branch ^^) but not matter how much, I don't know if it would be OK from a QA POV. If we aim to backport and depending on bug 19821 prevents that, then I would lean towards doing the current way of cleanup. And benefit from bug 19821 only in a future cycle. == Annex == Current state: diff: https://gitlab.com/tuxayo/Koha/-/commit/8935d1edc50156cea9dc16b56284c2994d941a0d whole test file: https://gitlab.com/tuxayo/Koha/-/blob/8935d1edc50156cea9dc16b56284c2994d941a0d/t/db_dependent/selenium/cataloging_workflow.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23349] Add batch operations to staff interface catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Katrin Fischer changed: What|Removed |Added Blocks||25659 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 [Bug 25659] Hide batch actions from reports results if no permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25659] Hide batch actions from reports results if no permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 Katrin Fischer changed: What|Removed |Added Depends on||23349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 [Bug 23349] Add batch operations to staff interface catalog search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #30 from Victor Grousset/tuxayo --- Hm, bug still happened on Ubuntu 18.04 for last 3 builds. https://jenkins.koha-community.org/job/Koha_Master_U18/813/ https://jenkins.koha-community.org/job/Koha_Master_U18/812/ https://jenkins.koha-community.org/job/Koha_Master_U18/811/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #7 from Katrin Fischer --- Hi Owen, is this ready for testing or are you still working on it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25673] Access logging of borrower's personal information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #1 from Katrin Fischer --- I think it really depends on the type of library, country, use cases etc. I think we'd definitely see some push back if we replaced the name by the cardnumber in general as this is seen as a feature. Libraries often know their patrons and want to see the names in a lot of cases. (think small company libraries, professors at universities etc.) But: we already have HidePatronName which makes this configurable in a lot of places that we could extend further. I think logging every page could get a lot pretty fast. Maybe we could start with viewing a patron record? (accessing the detail page) We should also make sure that patron batch edits are logged correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 Katrin Fischer changed: What|Removed |Added Blocks||25689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25689 [Bug 25689] Move 'Manage OPAC problem reports' permission into tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25689] New: Move 'Manage OPAC problem reports' permission into tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25689 Bug ID: 25689 Summary: Move 'Manage OPAC problem reports' permission into tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 25627 There is no reason for this permission to be a module level permission - it has no sub permission and as such currently is not set up quite right (compare to others like editauthorities). I propose that we move it to the tools permissions after bug 25627 has been resolved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 [Bug 25627] Move OPAC problem reports from administration to tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 --- Comment #2 from Katrin Fischer --- Hi Owen, thanks for taking this on! I was wondering if we should group it with patrons and circulation instead, as only logged in patrons can provide problem reports. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- Moving this straight to PQA (simple string change). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593 Katrin Fischer changed: What|Removed |Added Attachment #105550|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 105618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105618=edit Bug 25593: Terminology: Fix "There is no order for this biblio." on catalog detail page This patch changes the phrase "There is no order for this biblio" to "There is no order for this bibliographic record." on the catalog detail page. To test, apply the patch and view the bibliographic detail page for a record which has no order associated with it. The text in the "Acquisitions details" tab should be correct. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Add circulation process to inter-library loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #89 from Katrin Fischer --- (In reply to Jonathan Druart from comment #88) > +use Carp::Always; > > That should be removed, right? Should we file a new bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8371] Add global level issuing rules (number of checkouts over all libraries, etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25643 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #12 from Katrin Fischer --- I think a new page would probably be best. Don't mix up things on the first page - it's already confusing. Funnily, when adding bug 25688 for the terminology issue, I found another really old bug about this problem: Bug 8371 - Add global level issuing rules (number of checkouts over all libraries, etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8371 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25688] New: 'All libraries' terminology used on first page of circulation rules is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25688 Bug ID: 25688 Summary: 'All libraries' terminology used on first page of circulation rules is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: and...@bywatersolutions.com Our circulation rules page has undergone some terminology changes over the years, but at the moment, it seems quite confusing as discussions on some bugs (example: 25643) have shown. We say "default for all libraries" but actually, it's just "default for each libary" as the default rules page is used, when no library specific rule exists. Counts like 'number of holds' or 'number of checkouts' will not count for 'all libraries' but only for the 'individual library'. We should look for a way to make this more obvious in our wording. Would "default for a library" or "default for each library" work in English? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25688 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Katrin Fischer changed: What|Removed |Added Summary|Remove maxreserves syspref |Move maxreserves ||functionality into ||circulation rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 Katrin Fischer changed: What|Removed |Added Version|19.11 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676
--- Comment #3 from Katrin Fischer ---
I believe the issue is here:
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:
([% onloan_items_loo.count |
html %][% IF ( onloan_items_loo.longoverdue ) %], [%
onloan_items_loo.longoverdue | html %] long overdue[% END %]) date due: [%
onloan_items_loo.due_date | $KohaDates %]
And that leads us to Search.pm making wrong assumptions:
# if something's checked out and lost, mark it as 'long overdue'
if ( $item->{itemlost} ) {
$onloan_items->{$key}->{longoverdue}++;
$longoverdue_count++;
}
And now we have an issue: we can't guarantee which value is the long overdue
value lost value. If a library isn't using the long overdue prefs but using
command line parameters. So maybe we need to change this to just show the lost
description as is.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer --- I believe this is still not working right. The item is only returned when I check the 'charge lost fee' check box. Please explain, when adding a new patch. I think we are also going to need unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #5 from Andrew Nugged --- Here we need to have more filtering criteria for smart-rules. For Finnish libraries, we added "ccode" and "sleving_location", two extra smart rule filters (but by the way also later we propose this for the community version) so we had before: my $scope3 = [ 'branchcode', 'categorycode', 'itemtype' ]; but now we have in our case: my $scope3 = [ 'branchcode', 'categorycode', 'itemtype', 'ccode', 'shelving_location' ]; and because of having only a single variable, we don't need to change any variable names down in the file, nor copy-paste dozen times like it is now the same array copypasted everywhere. But now proposal from Jonathan to name it something like "$branch_category_itemtype" will make this: my $branch_category_itemtype = [ 'branchcode', 'categorycode', 'itemtype' ]; becoming this (???): my $branch_category_itemtype_ccode_shelving_location = [ 'branchcode', 'categorycode', 'itemtype', 'ccode', 'shelving_location' ]; so when we add two extra items, we should again change all the code down below to the new variable name $branch_category_itemtype_ccode_shelving_location? Yikes! That's why we voting for "$scope3", because we have three scope sections, even logically separated: small one, middle, and full. ... Oh, or let's name it "$scope_full" if you ok? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Katrin Fischer changed: What|Removed |Added Attachment #105560|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 105617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105617=edit Bug 25658: Print icon sometimes obscures patron barcode This patch alters the style of the patron name/cardnumber label on the checkout screen so that it has a maximum width. This will help avoid the label being obscured by the print/close buttons displayed when DisplayClearScreenButton is enabled. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the DisplayClearScreenButton system preference. - Check out to a patron. Resize the browser to confirm that at narrower browser widths the patron name in the checkout form isn't obscured by the print and clear screen buttons. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #8 from Iming Chan --- I suspect this problem only occurred after we upgraded to 19.11.06 as it was working fine last week. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #7 from Katrin Fischer --- Sorry, not sure what's going on then. I can't replicate the bug on a fresh 19.11 installation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 Katrin Fischer changed: What|Removed |Added Attachment #105562|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 105616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105616=edit Bug 25675: Reword and reorganize sysprefs related to patron self modification To Test: 1: apply patch 2: restart all 3: go to System Preferences > OPAC 4: confirm "Self registration" section is now labeled "Self registration and modification" 5: confirm OPACPatronDetails is now in the "Self registration and modification" section 6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC." 7: set OPACPatronDetails to Don't allow 8: set PatronSelfRegistration to Allow 9: log into the opac and verify you're not able to edit your patron details on an existing account Signed-off-by: DonnaB Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #6 from Iming Chan --- Created attachment 105615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105615=edit MARC screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #5 from Iming Chan --- We are using Marc21 and the default XSLT is used (admin preference never changed). We have always used 999 $c and $d for biblionumber (even though, we also copy the exact same number to 001). See screenshot attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 --- Comment #2 from Katrin Fischer --- Hi Owen, looking at the code I found a clue in Items.pm safe_to_delete: "not_same_branch" if the item is blocked by independent branches, I think you need to be: - not superlibrarian - IndependentBranches on - login branch != homebranch of the item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 --- Comment #3 from Katrin Fischer --- Created attachment 105614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105614=edit Bug 25677: Checkbox options for EDI accounts cannot be enabled Checking any of the checkboxes in the EDI Account editor does nothing. They always remain set to "off". Test Plan: 1) Browse to edi_accounts.pl 2) Create a new EDI account, check all the checkboxes 3) Edit the account, note none of the checkboxes are checked 4) Apply this patch 5) Repeat steps 1-2 6) Note the checkboxes remain checked Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25687] New: Switch Y/N in EDI accounts table for Yes and No for better translatability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 Bug ID: 25687 Summary: Switch Y/N in EDI accounts table for Yes and No for better translatability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org I think it would be easier to read and understand - and to translate, if we showed Yes and No instead of Y and N in the EDI accounts table for the checkboxes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25679] If no value is set in the system preference NoIssueCharge, odd yellow box appears
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25679 --- Comment #1 from Katrin Fischer --- I don't see this behaviour on master - can you confirm it's only on 19.11? For a change I think it would be nice if we allowed deactivating by leaving empty, as that would make it more consistent with the other fine limit related prefs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25679] If no value is set in the system preference NoIssueCharge, odd yellow box appears
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25679 Katrin Fischer changed: What|Removed |Added Summary|If no value is set in the |If no value is set in the |system preference |system preference |NoIssueCharge, Odd Yellow |NoIssueCharge, odd yellow |Box appears |box appears -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #56 from Katrin Fischer --- (In reply to David Cook from comment #55) > By the way, fontfaceobserver.min.js is getting flagged as the > Miner.Jswebcoin virus by Symantec Endpoint Protection. > > It says that Symantec have had it flagged for more than 1 year, and that the > file is untrustworthy. > > I have examined the Javascript, and it really appears to be a false > positive, but I'm noting it here anyway. > > I'm going to look at removing fontfaceobserver locally so that it can pass > security checks for the time being. Hi David, if we need to do something about this, please file a new bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25611] Changing the vendor when creating the basket does not keep that new vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611 Katrin Fischer changed: What|Removed |Added Summary|Changing the vendor when|Changing the vendor when |creating the Basket does|creating the basket does |not keep that new vendor. |not keep that new vendor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #4 from Katrin Fischer --- Which MARC format are you using? Have you chanced the XSLT files in any way? I believe this could also happen if your biblionumber is not stored in the expected MARC field. For MARC21 this would be 999. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25642] Technical notes are missing from the release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Katrin Fischer changed: What|Removed |Added Attachment #105584|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 105613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105613=edit Bug 25642: Fix description of new feature in update_dbix_class_files.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25642] Technical notes are missing from the release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Katrin Fischer changed: What|Removed |Added Attachment #105505|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 105612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105612=edit Bug 25642: Add technical notes Signed-off-by: Martin Renvoize Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25642] Technical notes are missing from the release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #3 from Iming Chan --- Created attachment 105611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105611=edit OPAC full catalogue record access error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686
--- Comment #2 from Iming Chan ---
After upgraded to 20.05 and fully reindex, the problem still exist.
However I just noticed that in the staff client, on the search result list, if
you click on the image column (whether there is a cover image or not), it will
take you to the normal display (full catalogue record).
Whereas, if you click on the title hyperlink, the "biblionumber" is missing and
thus cannot get to the normal (full record display).
In the OPAC, click on the cover image will take you to the full catalogue
record. However, when there is no cover image ("No cover image" hidden), then
you cannot get into the full catalogue record. You get an error message (see
screenshot attached).
Does this have anything to do with Bug # 24740 (implemented recently)?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #4 from Katrin Fischer --- Hi Peter, can you explain about your future needs? At the moment I am with Jonathan, I think readability is to be preferred, even if resulting in more code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25442] Release dates are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #12 from Katrin Fischer --- Is the alternative ready for testing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Katrin Fischer --- I've tried to test this. I've left off cardnumber and it didn't center, but only appeared at the bottom of the screen. I was using Firefox, wonder if the browser makes a difference? I wanted to compare with the patch, but it currently doesn't apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #14 from Katrin Fischer --- Hi Joe, thx for the patch! I noticed the attached patch file had a bit of a strange description - are you using git bz for attaching your patches? It makes interaction with Bugzilla very easy. I've done a follow-up, that I'd like to explain a bit: All course reserve items will be deleted from all courses to which they are attached. Will result in 3 separate strings to translate. - All course reserve items will be deleted from - all - courses to which they are attached I've seen there is a pre-existing occurence on the batch add feature, but we should fix that another time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Attachment #105607|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #13 from Katrin Fischer --- Created attachment 105610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105610=edit Bug 14648: (follow-up) Remove formatting from note for better translatability Removes to avoid that the sentence is split into separate parts in translation files. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #12 from Katrin Fischer --- Created attachment 105609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105609=edit Bug 14648: Batch remove reserve items Adds "Batch remove items" button to course-reserves.tt. Creates batch_rm_items.pl and batch_rm_items.tt. Allows user to enter a list of barcode numbers so that they will be removed from all course reserves to which they are attached. A dialog box will provide a warning before the final deletion is made. Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Log out 10. Log in as a user without permission to delete course reserves 11. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 12. You should not longer see the "- Batch remove items" button Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer --- Ok, I understand the problem with this patch now. borrowerRelationship: |father|mother With the patch: When you add an empty entry to the system preference, you end up with 2 empty entries in the list. None of them can be saved. Without the patch: The | has no effect - it shows an empty entry with |father|mother and with father|mother. You can save the empty entry, but it will result in father. I am leaning towards comment#25 now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 Katrin Fischer changed: What|Removed |Added Severity|critical|normal --- Comment #1 from Katrin Fischer --- Hi, I have tested in 19.11.06 and the links work ok for me from catalog and cataloguing search. Usually the error you see appears when your index is not up to date and you have records in the result list that have since been removed from Koha. Please try a full reindex. I am lowering the severity for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 --- Comment #6 from Jonathan Druart --- I am going to work on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|k...@bywatersolutions.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25638] API related tests failing on comparing floats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #13 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25638] API related tests failing on comparing floats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart --- Skipping QA, I want this one pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
